Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Generate compile information in build report

Thanks guys. I will create a new patch based on edk2-basetools next week. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100341): https://edk2.groups.io/g/devel/message/100341 Mute This Topic: https://groups.io/mt/96800354/21656 Group Own

[edk2-devel] [edk2 1/1] RiscVVirt: add SATA support

Tested with a PCIe pass-thru'd AHCI controller. Cc: Sunil V L Cc: Jiewen Yao Cc: Ard Biesheuvel Signed-off-by: Andrei Warkentin --- OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 7 +++ OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 7 +++ 2 files changed, 14 insertions(+) diff --git a/OvmfPkg/RiscVVi

[edk2-devel] [edk2 1/1] Dxe: add RISCV64 to mMachineTypeInfo

This fixes messages like: "Image type AARCH64 can't be loaded on UEFI system" Cc: Sunil V L Cc: Daniel Schaefer Cc: Liming Gao Cc: Jian J Wang Signed-off-by: Andrei Warkentin --- MdeModulePkg/Core/Dxe/Image/Image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeMod

[edk2-devel] [edk2 1/1] Dxe: add RISCV64 to mMachineTypeInfo

This fixes messages like: "Image type AARCH64 can't be loaded on UEFI system" Signed-off-by: Andrei Warkentin --- MdeModulePkg/Core/Dxe/Image/Image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Image/Image.c

[edk2-devel] [edk2 1/1] RiscV64 Timer: fix tick duration accounting

The TimerDxe implementation doesn't account for the physical time passed due to timer handler execution or (perhaps even more importantly) time spent with interrupts masked. Other implementations (e.g. like the Arm one) do. If the timer tick is always incremented at a fixed rate, then you can slow

[edk2-devel] [edk2 1/1] RISCV: Fix CpuSleep symbol name.

CpuSleep, not _CpuSleep. Cc: Sunil V L Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Andrei Warkentin --- MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/BaseCpuLib/RiscV/C

[edk2-devel] [edk2 1/1] BaseLib: don't log in InternalSwitchStack

InternalSwitchStack may be called with a TPL high enough for a DebugLib implementation to assert. Other arch implementations don't log either. Cc: Sunil V L Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Andrei Warkentin --- MdePkg/Library/BaseLib/R

[edk2-devel] [edk2 1/1] RISCV: clean up exception handling

RegisterCpuInterruptHandler did not allow setting exception handlers for anything beyond the timer IRQ. Beyond that, it didn't meet the spec around handling of inputs. RiscVSupervisorModeTrapHandler now will invoke set handlers for both exceptions and interrupts. Two arrays of handlers are maintai

[edk2-devel] [edk2 1/1] RISCV: Allow AArch64 and x64 images in BasePeCoffLib

ARM64 and X64 may allow such foreign images to be used when driver implementing EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL is present. Cc: Sunil V L Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Andrei Warkentin --- MdePkg/Library/BasePeCoffLib/RiscV/PeCo

[edk2-devel] [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()

There have been reports[1] of failures to boot due to unicode collation protocols not being available at Ext4Dxe load time. Therefore, attempt to initialize unicode collation at Start() time, like done previously in FatPkg/EnhancedFatDxe. By doing so, we move collation initialization to BDS, where

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink

On Fri, Feb 17, 2023 at 5:34 PM Pedro Falcato wrote: > > On Fri, Feb 17, 2023 at 8:56 AM Savva Mitrofanov wrote: > > > > The SymlinkTmp was deallocated unconditionally, so we shouldn't free it > > again on EFI_ERROR > > > > Cc: Marvin Häuser > > Cc: Pedro Falcato > > Cc: Vitaly Cheptsov > > Fi

Re: [edk2-devel] [Help] in Setting up EFI Shell in QEMU to allow for HTTP Requests

Are you sure you have the HttpDxe driver in your OVMF build?  Looks like you'd need to build with either -D NETWORK_HTTP_ENABLE or -D NETWORK_HTTP_BOOT_ENABLE. See https://github.com/tianocore/edk2/blob/master/OvmfPkg/README for details on HTTPS. *Brian J. Johnson *Hewlett Packard Enterprise

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

On Fri, 17 Feb 2023 at 18:31, Pedro Falcato wrote: > > On Fri, Feb 17, 2023 at 3:38 PM Marvin Häuser wrote: > > > > > > > On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote: > > > > > > So the FAT driver will happily load, but then fail in an obscure > > > manner when being started on a controller

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink

On Fri, Feb 17, 2023 at 8:56 AM Savva Mitrofanov wrote: > > The SymlinkTmp was deallocated unconditionally, so we shouldn't free it > again on EFI_ERROR > > Cc: Marvin Häuser > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") > Signed-off-by:

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

On Fri, Feb 17, 2023 at 3:38 PM Marvin Häuser wrote: > > > > On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote: > > > > So the FAT driver will happily load, but then fail in an obscure > > manner when being started on a controller handle, in a way that is > > indistinguishable (afict) from a partit

Re: [edk2-devel] BUG: tianocore does not honor the bootorder

On Fri, 2023-02-17 at 14:08 +0100, Gerd Hoffmann wrote: > On Wed, Feb 15, 2023 at 02:20:23PM -0600, Gregory Lee Bartholomew wrote: > > I have a script that uses Qemu to install a Linux OS to the supplied > > device. At > > the end of the install script, efibootmgr is called to create UEFI boot >

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

> On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote: > > So the FAT driver will happily load, but then fail in an obscure > manner when being started on a controller handle, in a way that is > indistinguishable (afict) from a partition that has not FAT file > system in the first place. > > So it

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

On Fri, 17 Feb 2023 at 15:55, Marvin Häuser wrote: > > > > On 17. Feb 2023, at 15:29, Ard Biesheuvel wrote: > > > > On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote: > >> > >> Hi Ard, > >> > >> Thank you! Is "1/4" a mistake or did I miss the other 3? :) > > > > Oops. > > > > It was part of som

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

> On 17. Feb 2023, at 15:29, Ard Biesheuvel wrote: > > On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote: >> >> Hi Ard, >> >> Thank you! Is "1/4" a mistake or did I miss the other 3? :) > > Oops. > > It was part of some RPi4 patches but I decided to send it out by itself. > > >> Comment

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote: > > Hi Ard, > > Thank you! Is "1/4" a mistake or did I miss the other 3? :) Oops. It was part of some RPi4 patches but I decided to send it out by itself. > Comments inline. > > On 17. Feb 2023, at 12:12, Ard Biesheuvel wrote: > > The Unicode

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

Hi Ard, Thank you! Is "1/4" a mistake or did I miss the other 3? :) Comments inline. > On 17. Feb 2023, at 12:12, Ard Biesheuvel wrote: > > The Unicode collation protocols, however, are different: loading the > driver will fail if neither of those are present. So they are not > TO_START protoco

Re: [edk2-devel] BUG: tianocore does not honor the bootorder

On Wed, Feb 15, 2023 at 02:20:23PM -0600, Gregory Lee Bartholomew wrote: > I have a script that uses Qemu to install a Linux OS to the supplied device. > At > the end of the install script, efibootmgr is called to create UEFI boot > entries > and set the boot order. However, every time I boot the

[edk2-devel] PATCH v3 3/3 OvmfPkg: take PcdResizeXterm from the QEMU command line

From: Laszlo Ersek This patch enables recognition of PcdResizeXterm config variable by the OvmfPkg. When enablet it will trigger passing xterm control sequences from the OvmfPkg to the client terminal (xterm, gnome-terminal etc.). This way client terminal window size will be alligned with numbers

[edk2-devel] PATCH v3 2/3 ArmVirtPkg: take PcdResizeXterm from the QEMU command line

From: Laszlo Ersek This patch enables recognition of PcdResizeXterm config variable. When enablet it will trigger passing xterm control sequences from the ArmVirtPkg to the client terminal (xterm, gnome-terminal etc.). This way client terminal window size will be alligned with numbers of rows and

[edk2-devel] PATCH v3 1/3 MdeModulePkg: TerminalDxe: set xterm resolution on mode change

From: Laszlo Ersek TerminalDxe driver can send xterm control sequences. Reference: This way it can trigger client window resize (xterm, gnome-terminal etc.) accordingly, to a specified number of rows and columns. It improves user experience when handling

[edk2-devel] PATCH v3 0/3 Add xterm resize support to OVMF

This set of patches adds xterm resize sequences support to OvmfPkg and ArmVirtPkg. This way firmware will be able to sent resize requests to user terminal (gnome-terminal, xterm, xfce4-terminal). To test this feature you can use a new configuration option: -fw_cfg name=opt/org.tianocore/PcdResizeX

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Hi all, Could you help to review this? thanks. Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial re

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

Hi, A kind reminder - has this been merged? Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered office: Bochum Commercial regis

[edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

The EXT4 driver implements the UEFI driver model, which means it can consume one protocol (marked with a TO_START comment in the .INF) and produce another (marked as BY_START). The TO_START protocols are not prerequisites for loading and starting the module, they are simply protocols the driver may

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

On 17/02/2023 04:27, Sunil V L wrote: On Thu, Feb 16, 2023 at 03:45:49PM -0700, dann frazier wrote: Thanks for your work getting this merged! In the above wiki, it notes that GCC 12+ is not supported. Is that still accurate? If so, can you clarify what is blocking that? Please see https://b

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink

Reviewed-by: Marvin Häuser > On 17. Feb 2023, at 09:56, Savva Mitrofanov wrote: > > The SymlinkTmp was deallocated unconditionally, so we shouldn't free it > again on EFI_ERROR > > Cc: Marvin Häuser > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic lin

[edk2-devel] [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink

The SymlinkTmp was deallocated unconditionally, so we shouldn't free it again on EFI_ERROR Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 - 1 file c

Re: [edk2-devel] [PATCH v6] Update CPUID Leaf 06H to follow latest SDM.

Reviewed-by: Ray Ni > -Original Message- > From: Wang, William2 > Sent: Friday, February 17, 2023 4:24 PM > To: devel@edk2.groups.io > Cc: Wang, William2 ; Kinney, Michael D > ; Gao, Liming ; > Ni, Ray ; Kuo, Donald ; Kumar, > Chandana C > Subject: [PATCH v6] Update CPUID Leaf 06H to fo

[edk2-devel] [PATCH v6] Update CPUID Leaf 06H to follow latest SDM.

From: William2 Wang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4262 Update CPUID Leaf 06H to follow latest SDM. Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni Cc: Donald Kuo Cc: Chandana C Kumar --- MdePkg/Include/Register/Intel/Cpuid.h | 65 ++-- 1 file changed,