Re: [edk2-devel] [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()

> On 20. Feb 2023, at 08:52, Ard Biesheuvel wrote: > > On Fri, 17 Feb 2023 at 21:14, Pedro Falcato wrote: >> >> There have been reports[1] of failures to boot due to unicode collation >> protocols not being available at Ext4Dxe load time. Therefore, attempt >> to initialize unicode collation

[edk2-devel] [RESEND] [PATCH v2 0/2] OvmfPkg: Enable measured direct boot on AMD SEV-SNP

[Resending due to missing Cc in actual patches emails.] (Note: This is a new version of this one-year-old patch series; the v1 series [1] got a few Acked-by but it's been so long that I don't consider them relevant anymore.) AMD SEV and SEV-ES support measured direct boot with kernel/initrd/cmdli

[edk2-devel] [RESEND] [PATCH v2 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf

Resize the MEMFD section of AmdSevX64.fdf and reorder its pages so that it matches the same size and order used in OvmfPkgX64.fdf. After this change, this is the difference in the MEMFD of the two targets: $ diff -u \ <(sed -ne '/FD.MEMFD/,/FV.SECFV/p' OvmfPkg/OvmfPkgX64.fdf) \ <(se

[edk2-devel] [RESEND] [PATCH v2 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

In order to allow the VMM (such as QEMU) to add a page with hashes of kernel/initrd/cmdline for measured direct boot on SNP, this page must not be part of the SNP metadata list reported to the VMM. Check if that page is defined; if it is, skip it in the metadata list. In such case, VMM should fill

Re: [edk2-devel] [edk2 1/1] BaseLib: don't log in InternalSwitchStack

Thanks for these fixes!, Andrei. Could you please use below format for the subject? PackageName: ModuleName: summary of changes Also, could you create single patch series with these patches? Otherwise, Reviewed-by: Sunil V L On Fri, Feb 17, 2023 at 10:29:21PM -0600, Andrei Warkentin wrote: >

Re: [edk2-devel] [edk2 1/1] RISCV: Fix CpuSleep symbol name.

Same feedback regarding the subject. Otherwise, Reviewed-by: Sunil V L On Fri, Feb 17, 2023 at 10:30:36PM -0600, Andrei Warkentin wrote: > CpuSleep, not _CpuSleep. > > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Andrei War

Re: [edk2-devel] [edk2 1/1] Dxe: add RISCV64 to mMachineTypeInfo

Please update the subject. Otherwise, Reviewed-by: Sunil V L Thanks! Sunil On Fri, Feb 17, 2023 at 10:36:26PM -0600, Andrei Warkentin wrote: > This fixes messages like: > "Image type AARCH64 can't be loaded on UEFI system" > > Cc: Sunil V L > Cc: Daniel Schaefer > Cc: Liming Gao > Cc: Jian

Re: [edk2-devel] [Patch V2 5/5] UefiCpuPkg: Put APs in 64 bit mode before handoff to OS.

On 2/19/23 23:20, Yuanhao Xie wrote: Update the address of the allocated memory, only keep 4GB limitation for the case that APs still need to be transferred to 32-bit mode before OS. Remove the unused arguments of AsmRelocateApLoopStart, update the stack offset. For the processors other than

回复: [edk2-devel] [IMPORTANT] February Release Reviews and Merges for this stable tag 202302

Hi, all There are the request to include several security fixes in this stable tag 202302. So, Hard feature freeze will be defer to the early of March. Now, we are still in soft feature freeze phase. If you have the patch set for this stable tag, please raise your request in this mail thread.

Re: [edk2-devel] [RESEND] [PATCH v2 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

On 2/20/23 02:49, Dov Murik wrote: In order to allow the VMM (such as QEMU) to add a page with hashes of kernel/initrd/cmdline for measured direct boot on SNP, this page must not be part of the SNP metadata list reported to the VMM. Check if that page is defined; if it is, skip it in the metadat

Re: [edk2-devel] BUG: tianocore does not honor the bootorder

On Mon, 2023-02-20 at 08:10 +0100, Gerd Hoffmann wrote: > On Fri, Feb 17, 2023 at 10:23:22AM -0600, Gregory Lee Bartholomew wrote: > > On Fri, 2023-02-17 at 14:08 +0100, Gerd Hoffmann wrote: > > > On Wed, Feb 15, 2023 at 02:20:23PM -0600, Gregory Lee Bartholomew wrote: > > > > I have a script that

Re: [edk2-devel] [Patch V2 5/5] UefiCpuPkg: Put APs in 64 bit mode before handoff to OS.

Hi Tom, This series is the same on the link that I sent to you last Wednesday with the latest update 5 days ago: https://github.com/tianocore/edk2/pull/4012. Last request email is on 17th, and a quick response on 18th, so I expect the testing is on the update version. Let's test it again. Ple

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

Quoting Sunil V L (2023-02-17 05:27:15) > On Thu, Feb 16, 2023 at 03:45:49PM -0700, dann frazier wrote: > > On Fri, Feb 10, 2023 at 5:30 AM Sunil V L wrote: > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > > > Add support for RISC-V qemu virt machine. Most of the change

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Tuesday, February 21, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Tuesday, February 21, 2023 10:00am to 11:00am (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753759 ) *Description:*

Re: [edk2-devel] [Patch V2 5/5] UefiCpuPkg: Put APs in 64 bit mode before handoff to OS.

On 2/20/23 11:43, Xie, Yuanhao wrote: Hi Tom, This series is the same on the link that I sent to you last Wednesday with the latest update 5 days ago: https://github.com/tianocore/edk2/pull/4012. Last request email is on 17th, and a quick response on 18th, so I expect the testing is on the upd

Re: [edk2-devel] [PATCH v4 1/1] MdePkg: Use ANSI colors to indicate debug message severity

On 11/10/22 12:11, Kinney, Michael D wrote: In the edk2 repo, I see the following instances of the DebugPrintMarker() API where you are currently adding he ANSI color sequences. Should all of these be updated? I did not review the edk2-platforms repo. And there may be downstream custom DebugL

Re: [edk2-devel] [PATCH v4 1/1] MdePkg: Use ANSI colors to indicate debug message severity

Hi Mike, Sorry, I only just saw this message. Your implementation looks better since as you say it doesn't require updates to the DebugLib instances. Since you're more familiar with the gotchas around adding this, I'll leave it to you to decide if this can be committed or not. -- Rebecca Cr

[edk2-devel] [PATCH 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

Replace rv64imafdc with rv64gc so that it works for gcc 12. "g" means imafd in gcc < 12 and imafd_zifencei_zicsr. So, replacing rv64imafdc with rv64gc will work for both gcc <12 and gcc >=12. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Andrei Warkentin Cc: Heinrich Schuchardt Signed-off-b

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

On Mon, Feb 20, 2023 at 09:44:22AM -0800, Oliver Steffen wrote: > Quoting Sunil V L (2023-02-17 05:27:15) > > On Thu, Feb 16, 2023 at 03:45:49PM -0700, dann frazier wrote: > > > On Fri, Feb 10, 2023 at 5:30 AM Sunil V L > > > wrote: > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi

[edk2-devel] [PATCH 1/1] OvmfPkg/RiscVVirt: Fix for SCT memory allocation test case failure.

The stack doesn't grow downwards but upwards for RISC-V. Hence, fix the UEFI memory range calculation by including the correct stack memory range. Without this fix, SCT hangs in MemoryAllocation test cases which call AllocateAddress(). Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Ger

Re: 回复: [edk2-devel] [IMPORTANT] February Release Reviews and Merges for this stable tag 202302

On Mon, Feb 20, 2023 at 10:28:58PM +0800, gaoliming via groups.io wrote: > Hi, all > > There are the request to include several security fixes in this stable tag > 202302. So, Hard feature freeze will be defer to the early of March. Now, we > are still in soft feature freeze phase. If you have th

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time

Could someone commit this please? On 12/5/22 19:17, Gao, Zhichao wrote: Reviewed-by: Zhichao Gao Thanks, Zhichao -Original Message- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Friday, December 2, 2022 5:50 AM To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao Cc: Rebec

[edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of warning DEBUG in UsbSelectConfig

Improve the formatting of a warning in UsbSelectConfig by adding parentheses around the EFI_STATUS value. Signed-off-by: Rebecca Cran --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/M

[edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes

The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems with drivers that use gBS->Stall, since it takes 10x longer than requested. For example requesting a timeout of 1 ms when doing a USB bulk transfer results in it taking 100 ms. Switching to the MdeModulePkg/Universal/Metrono

[edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver

The MetronomeDxe driver uses the PCD PcdMetronomeTickPeriod to calculate how many ticks to wait in MicroSecondDelay. Given that the timer clock on Juno runs at 50 MHz, it ticks every 20 ns; therefore, a setting of 1000 is wrong: for example it causes a call to gBS->Stall (1) to take 10 us. The dri

[edk2-devel] [PATCH edk2-platforms v2 2/2] Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from CNTFRQ_EL0

If PcdArmArchTimerFreqInHz is zero, the value of the timer frequency will be read from CNTFRQ_EL0. Avoid hard-coding the value in ArmJuno.dsc and instead let the ArmArchTimerLib driver read it from the SoC. Signed-off-by: Rebecca Cran --- Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++- 1 file changed,

[edk2-devel] [PATCH edk2-platforms 1/2] Silicon/Qemu: Convert DSDT ASL from legacy to ASL 2.0 syntax

From: Rebecca Cran ACPI 6.0 introduced support for ASL 2.0 includes standard operators. Convert the DSDT from legacy to ASL 2.0 syntax. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[edk2-devel] [PATCH edk2-platforms 0/2] Silicon/Qemu: SbsaQemu ACPI formatting improvements

Improve the readability of the SbsaQemu SPCR and DSDT. Rebecca Cran (2): Silicon/Qemu: Convert DSDT ASL from legacy to ASL 2.0 syntax Silicon/Qemu: Use the symbolic value for the SPCR table revision. Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 18 +- Silicon/Qemu/SbsaQemu/Ac

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/Qemu: Use the symbolic value for the SPCR table revision.

From: Rebecca Cran The current SPCR table revision is 2. Instead of using a hard-coded value, use the symbolic constant EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc | 3 ++- 1 file changed, 2 insertions(+),

[edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/VariablePolicyLib: Remove status checking

Main Changes : 1.Removing status checking as the status is always EFI_SUCCESS. Wenyi Xie (1): MdeModulePkg/VariablePolicyLib: Remove status checking MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.20.1.windows.1

[edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/VariablePolicyLib: Remove status checking

Removing status checking as the status is always EFI_SUCCESS. No functional change. Cc: Jian J Wang Cc: Liming Gao Cc: Hao A Wu Signed-off-by: Wenyi Xie --- MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/M

Re: [edk2-devel] [PATCH 1/1] MdePkg: Remove whitespace in doxygen param passing direction [in,out]

On 2/21/2023 1:45 AM, Rebecca Cran via groups.io wrote: > There isn't supposed to be whitespace for "@param [in,out]" between "in" > and "out". clang generates the following warning: > > test.c:8:9: warning: whitespace is not allowed in parameter passing direction > [-Wdocumentation-pedantic] >

Re: [edk2-devel] [PATCH 1/1] MdePkg: Remove whitespace in doxygen param passing direction [in,out]

On 2/20/23 18:58, Tinh Nguyen OS wrote: On 2/21/2023 1:45 AM, Rebecca Cran via groups.io wrote: There isn't supposed to be whitespace for "@param [in,out]" between "in" and "out". clang generates the following warning: test.c:8:9: warning: whitespace is not allowed in parameter passing directio

Re: [edk2-devel] [PATCH v4 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

On 18/02/2023 16:47, RichardHo [何明忠] via groups.io wrote: + PrintRndisMsg (RndisMsg); + + Status = UsbIo->UsbControlTransfer ( +UsbIo, +&DevReq, +EfiUsbDataOut, +USB_ETHERNET_TRANSFER_TIMEOUT, +

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, February 21, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, February 21, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

Re: [edk2-devel] [PATCH v4 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

Hi Tinh, Our last RNDIS driver’s code has add that. To see https://learn.microsoft.com/en-us/windows-hardware/drivers/network/control-channel-characteristics

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, February 21, 2023 #cal-reminder

There is no new issue. The meeting will be cancelled. Thanks Liming 发件人: devel@edk2.groups.io 代表 Group Notification 发送时间: 2023年2月21日 10:30 收件人: devel@edk2.groups.io 主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, February 21, 2023 #cal-reminder Reminder: TianoCore

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

On 2/17/23 10:16, Michael Brown wrote: On 17/02/2023 04:27, Sunil V L wrote: On Thu, Feb 16, 2023 at 03:45:49PM -0700, dann frazier wrote:    Thanks for your work getting this merged! In the above wiki, it notes that GCC 12+ is not supported. Is that still accurate? If so, can you clarify wh

[edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

Hi Usually PciBus scan is from low bus num to high bus num. So, does it support scan from end bus num to start bus num? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100400): https://edk2.groups.io/g/devel/message/100400 Mute T

Re: [edk2-devel] [edk2 1/1] RiscV64 Timer: fix tick duration accounting

Hi Andrei, Thank you very much for fixing this! On Fri, Feb 17, 2023 at 10:31:49PM -0600, Andrei Warkentin wrote: > The TimerDxe implementation doesn't account for the physical > time passed due to timer handler execution or (perhaps even > more importantly) time spent with interrupts masked. >

Re: [edk2-devel] [edk2 1/1] RISCV: clean up exception handling

Hi Andrei, Happy to see this patch! On Fri, Feb 17, 2023 at 10:28:09PM -0600, Andrei Warkentin wrote: > RegisterCpuInterruptHandler did not allow setting > exception handlers for anything beyond the timer IRQ. > Beyond that, it didn't meet the spec around handling > of inputs. > > RiscVSuperviso