Re: [edk2-devel] [edk2 1/1] RISCV: clean up exception handling

2023-02-21 Thread Andrei Warkentin
Hi Sunil, Thank you for the thorough review! - Thanks for catching EXCEPT_RISCV_STORE_ACCESS_PAGE_FAULT not being 15 - The EXCEPT_RISCV_XXX defines are needed for other drivers to pass as EFI_EXCEPTION_TYPE to RegisterCpuInterruptHandler. For example, this is used by our (soon to be made

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

2023-02-21 Thread Andrei Warkentin
Reviewed-by: Andrei Warkentin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100435): https://edk2.groups.io/g/devel/message/100435 Mute This Topic: https://groups.io/mt/97094195/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/RiscVVirt: Fix SCT memory allocation test case failure

2023-02-21 Thread Andrei Warkentin
Reviewed-by: Andrei Warkentin -Original Message- From: Sunil V L Sent: Tuesday, February 21, 2023 8:37 PM To: devel@edk2.groups.io Cc: Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann ; Warkentin, Andrei ; Heinrich Schuchardt Subject: [PATCH V2 1/1]

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of warning DEBUG in UsbSelectConfig

2023-02-21 Thread Wu, Hao A
Sorry, may I know why only this specific debug message requests format improving while others do not? Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Tuesday, February 21, 2023 8:52 AM > To: devel@edk2.groups.io; Wang, Jian J ;

Re: [edk2-devel] [PATCH v1 0/2] Enable LoongArch64 in uefi-sct

2023-02-21 Thread Chao Li
Hi Maintainers, This patch set has been committed several months ago, could you please review this patch set? Thanks, Chao 在 2023/1/5 11:27, Chao Li 写道: Hi Maintainers, Could you help review this patch set? 在 2022/12/14 16:36, Chao Li 写道: LoongArch64 support was merged into edk2 and

回复: [edk2-devel] [IMPORTANT] February Release Reviews and Merges for this stable tag 202302

2023-02-21 Thread gaoliming via groups.io
Hi, all The requester has confirmed that those security fixes will not be required to catch this stable tag 202302. So, we will start hard feature freeze now until Mar 3th (202302 stable tag will be created). I will send the announce mail soon. Thanks Liming 发件人: devel@edk2.groups.io 代表

回复: 回复: [edk2-devel] [IMPORTANT] February Release Reviews and Merges for this stable tag 202302

2023-02-21 Thread gaoliming via groups.io
Sunil: I am OK to merge them for this stable tag once they pass code review. Thanks Liming > -邮件原件- > 发件人: Sunil V L > 发送时间: 2023年2月21日 4:15 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: miki.deme...@intel.com; 'Andrew Fish' ; 'Michael > D Kinney' ; 'Leif Lindholm' > ;

[edk2-devel] [PATCH V2 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

2023-02-21 Thread Sunil V L
Replace rv64imafdc with rv64gc so that it works for gcc 12. "g" means imafd in gcc < 12 and imafd_zifencei_zicsr in gcc >= 12. So, replacing rv64imafdc with rv64gc will work for both gcc <12 and gcc >=12. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Andrei Warkentin Cc: Heinrich Schuchardt

[edk2-devel] [PATCH V2 1/1] OvmfPkg/RiscVVirt: Fix SCT memory allocation test case failure

2023-02-21 Thread Sunil V L
Fix the UEFI memory range calculation by including the correct stack memory range. Without this fix, SCT hangs in MemoryAllocation test cases which call AllocateAddress(). Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin Reported-by: Heinrich

Re: [edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-21 Thread Pedro Falcato
On Wed, Feb 22, 2023 at 1:10 AM Tiger Liu(BJ-RD) wrote: > > Hi, Pedro: > Thanks for your reply! > > For example: > There are 4 root bridges in a server motherboard, named them as : RP-A / RP-B > / RP-C / RP-D > RP-A : PCI Bus num range is 0 ~0x40 (hardware pre-configured) > RP-B : PCI Bus num

撤回: [edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-21 Thread Tiger Liu(BJ-RD)
Tiger Liu(BJ-RD) 将撤回邮件“[edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?”。 保密声明: 本邮件含有保密或专有信息,仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。 CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended

Re: [edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-21 Thread Tiger Liu(BJ-RD)
Hi, Pedro: Thanks for your reply! For example: There are 4 root bridges in a server motherboard, named them as : RP-A / RP-B / RP-C / RP-D RP-A : PCI Bus num range is 0 ~0x40 (hardware pre-configured) RP-B : PCI Bus num range is 0x40 ~0x80 (hardware pre-configured) RP-C : PCI Bus num range is

Re: [edk2-devel] [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()

2023-02-21 Thread Marvin Häuser
> On 21. Feb 2023, at 20:25, Pedro Falcato wrote: > > Marvin, > > Do you want me to spin up a quick v2 without the > Ext4IsCollationInitialized? Just doing the check internally in > Ext4InitialiseUnicodeCollation. It'd be my preferred solution, but it's just a detail. Reviewed-by: Marvin

Re: [edk2-devel] [PATCH 1/1] Ext4Pkg: Move unicode collation initialization to Start()

2023-02-21 Thread Pedro Falcato
?On Mon, Feb 20, 2023 at 8:00 AM Marvin Häuser wrote: > > > On 20. Feb 2023, at 08:52, Ard Biesheuvel wrote: > > On Fri, 17 Feb 2023 at 21:14, Pedro Falcato wrote: > > > There have been reports[1] of failures to boot due to unicode collation > > protocols not being available at Ext4Dxe load

Re: [edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-21 Thread Pedro Falcato
On Tue, Feb 21, 2023 at 3:08 AM Yoshinoya wrote: > > Hi > Usually PciBus scan is from low bus num to high bus num. > > So, does it support scan from end bus num to start bus num? > > Thanks Hi, What do you mean? Why do you want this? Do you want to number buses in reverse? That is technically

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time

2023-02-21 Thread Michael D Kinney
Hi Ard, There have been some communication issues on status with Liming. Miki and I think those are resolved now. We are wanting to move to hard freeze ASAP to keep as close as possible to the original planned release date. We will discuss with Liming when he is back online later today. I

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Tuesday, February 21, 2023 #cal-notice

2023-02-21 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Tuesday, February 21, 2023 10:00am to 11:00am (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753759 ) *Description:* TianoCore

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Tuesday, February 21, 2023 #cal-reminder

2023-02-21 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Tuesday, February 21, 2023 10:00am to 11:00am (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753759 ) *Description:*

Re: [edk2-devel] [PATCH v2 1/1] DynamicTablesPkg: Add SMBIOS table generation

2023-02-21 Thread Girish Mahadevan via groups.io
Hello Sami, Mind taking a quick look whenever you have some bandwidth. Thanks Girish On 1/27/2023 4:58 PM, Girish Mahadevan via groups.io wrote: External email: Use caution opening links or attachments Add the SMBIOS Table generator code to the DynamicTablesPkg. This change includes adding

Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: update path to edk2-test-parser, check for repo

2023-02-21 Thread G Edhaya Chandran
On Wed, Feb 15, 2023 at 06:21 AM, Gao Jie wrote: > > Reviewed-by: Barton Gao < gaojie@... > Upstreamed by the commit id:  https://github.com/tianocore/edk2-test/commit/8713740892bdb857e970a2841de9800b2c6b5552 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time

2023-02-21 Thread Ard Biesheuvel
On Tue, 21 Feb 2023 at 14:58, Gao, Zhichao wrote: > > Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create > the PR after edk2 202302 release. > The hard freeze has been deferred until early march, so you can go ahead and merge this patch. -- Ard. > > -Original

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SemihostFs: replace SetMem with ZeroMem

2023-02-21 Thread Sami Mujawar
Hi Gerd, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/02/2023, 14:37, "Gerd Hoffmann" mailto:kra...@redhat.com>> wrote: SetMem arguments 2+3 are in the wrong order, resulting in the call having no effect because Length is zero. Fix this by using

Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time

2023-02-21 Thread Gao, Zhichao
Sorry, I forgot this patch. Now it is the hard freeze for edk2. Would create the PR after edk2 202302 release. Thanks, Zhichao > -Original Message- > From: Rebecca Cran > Sent: Tuesday, February 21, 2023 8:45 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > > Subject: Re:

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

2023-02-21 Thread Gerd Hoffmann
On Tue, Feb 21, 2023 at 01:26:55AM +0530, Sunil V L wrote: > Replace rv64imafdc with rv64gc so that it works for gcc 12. > > "g" means imafd in gcc < 12 and imafd_zifencei_zicsr. So, > replacing rv64imafdc with rv64gc will work for both gcc <12 > and gcc >=12. > > Cc: Bob Feng > Cc: Liming Gao

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-21 Thread Gerd Hoffmann
On Tue, Feb 21, 2023 at 09:12:20AM +, Ni, Ray wrote: > Gerd, > I also don't think some Pentium processors still use the latest edk2 code. > Can you create a bugzilla for the request? > > If @Kinney, Michael D doesn't have concern, we can follow up on that old code > removal.

Re: [edk2-devel] [RESEND] [PATCH v2 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation

2023-02-21 Thread Gerd Hoffmann
On Mon, Feb 20, 2023 at 08:44:23AM -0600, Tom Lendacky wrote: > On 2/20/23 02:49, Dov Murik wrote: > > In order to allow the VMM (such as QEMU) to add a page with hashes of > > kernel/initrd/cmdline for measured direct boot on SNP, this page must > > not be part of the SNP metadata list reported

Re: [edk2-devel] [Patch V2 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

2023-02-21 Thread Gerd Hoffmann
Hi, > + Address= BASE_4GB - 1; Why do you set Address here ... > + Status = gBS->AllocatePages ( > + AllocateMaxAddress, > + EfiReservedMemoryType, > + StackPages+FuncPages, > + > + ); ... when it is

Re: [edk2-devel] [Patch V2 1/5] UefiCpuPkg: Duplicate RelocateApLoop for the processors with SEV-ES.

2023-02-21 Thread Gerd Hoffmann
Hi, >if (CpuMpData->UseSevEsAPMethod) { > -StackStart = CpuMpData->SevEsAPResetStackStart; > +StackStart = CpuMpData->SevEsAPResetStackStart; > +AsmRelocateApLoopFuncAmdSev = > (ASM_RELOCATE_AP_LOOP)(UINTN)mReservedApLoopFunc; > +AsmRelocateApLoopFuncAmdSev

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-21 Thread Ni, Ray
Gerd, I also don't think some Pentium processors still use the latest edk2 code. Can you create a bugzilla for the request? If @Kinney, Michael D doesn't have concern, we can follow up on that old code removal. Thanks, Ray > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday,

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Silicon/Qemu: SbsaQemu ACPI formatting improvements

2023-02-21 Thread Ard Biesheuvel
On Tue, 21 Feb 2023 at 02:09, Rebecca Cran wrote: > > Improve the readability of the SbsaQemu SPCR and DSDT. > > Rebecca Cran (2): > Silicon/Qemu: Convert DSDT ASL from legacy to ASL 2.0 syntax > Silicon/Qemu: Use the symbolic value for the SPCR table revision. > Reviewed-by: Ard Biesheuvel

Re: [edk2-devel] [PATCH edk2-platforms v2 0/2] Platform/ARM/JunoPkg: Timer fixes

2023-02-21 Thread Ard Biesheuvel
On Tue, 21 Feb 2023 at 02:03, Rebecca Cran wrote: > > The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems > with drivers that use gBS->Stall, since it takes 10x longer than > requested. For example requesting a timeout of 1 ms when doing a USB > bulk transfer results in it

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-02-21 Thread Gerd Hoffmann
On Mon, Feb 20, 2023 at 01:14:33AM +, Ni, Ray wrote: > I expect Gerd at least acknowledges all patches for UefiCpuPkg. Following > three haven't got: > * [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data > * [PATCH v9 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for

Re: [edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver

2023-02-21 Thread Ard Biesheuvel
Hi Rebecca, Thanks for the effort to fix this. On Tue, 21 Feb 2023 at 02:03, Rebecca Cran wrote: > > The MetronomeDxe driver uses the PCD PcdMetronomeTickPeriod to calculate > how many ticks to wait in MicroSecondDelay. Given that the timer clock > on Juno runs at 50 MHz, it ticks every 20 ns;