Re: [edk2-devel] [Patch V2 1/5] UefiCpuPkg: Duplicate RelocateApLoop for the processors with SEV-ES.

2023-02-22 Thread Yuanhao Xie
I'd suggest to move the code instead of copying it, i.e. have one patch moving (and renaming) the AmdSev AP loop. Have another patch adding the new code for the generic AP loop. That should result in patches which are easier to read, especially the new generic AP loop code is not mixed with Am

Re: [edk2-devel] [Patch V2 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

2023-02-22 Thread Yuanhao Xie
Hi, Set "Address= BASE_4GB - 1" first is to ensure the maximum address value is 4GB, since APs will be switched to 32 bit before OS, I mean in the original implementation. By the way, in patch 5, only SEV-ES processor keep this limitation, since for the generic processors they keep in 64 bi

回复: 回复: 回复: [edk2-devel] [IMPORTANT] February Release Reviews and Merges for this stable tag 202302

2023-02-22 Thread gaoliming via groups.io
I create two PRs for them. https://github.com/tianocore/edk2/pull/4064 https://github.com/tianocore/edk2/pull/4065 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sunil V L > 发送时间: 2023年2月22日 17:51 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: miki.deme...@intel.com;

[edk2-devel] 回复: [PATCH V2 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

2023-02-22 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Heinrich Schuchardt > 发送时间: 2023年2月22日 10:39 > 收件人: Sunil V L ; devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen ; Andrei > Warkentin ; Gerd Hoffmann > > 主题: Re: [PATCH V2 1/1] BaseTools/tools_def.template: Update -march > parameter

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of warning DEBUG in UsbSelectConfig

2023-02-22 Thread Wu, Hao A
If you think the format modification is valuable, please at least keep it aligned within the driver level. A search of the keyword '%r' in UsbBusDxe shows: edk2\MdeModulePkg\Bus\Usb\UsbBusDxe\UsbBus.c (8 hits) Line 841: "UsbIoPortReset: failed to reset hub port %d@hub %d, %r \n

Re: [edk2-devel] DSC nightmare

2023-02-22 Thread Andrew Fish via groups.io
Ben, I’d say the tools are optimized to be general purpose. So they are not really designed to be the easy button. In terms of things like SEC/PEI or DXE it is very common for this code on x86 to be compiled for different architectures. SEC/PEI is usually i386 and DXE is x86_64. Crazy I know b

[edk2-devel] DSC nightmare

2023-02-22 Thread Benjamin Mordaunt
Hi, I am working on implementing a new Arm platform in edk2-platforms, and have reached the stage of tackling writing a DSC to describe it, along with a "dsc.inc" which contains defines etc. common to platforms sharing the same SoC. I'm using, as reference the platforms currently present in the

[edk2-devel] regarding Android bootloader uefi pkg

2023-02-22 Thread ritul guru
Hi, I am looking for uefi android boot pkg, though do not find it in edk2 source code, any idea from where it can be cloned? *Thanks & RegardsRitul Guru+91-9916513186* -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100447): https://ed

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/RISC-V: Fix a build failure in RiscVCpuLib

2023-02-22 Thread Chai, Evan
From: "Chai, Evan" RiscVSetSupervisorAddressTranslationRegister() should be moved out from RiscVCpuLib since it had been merged to MdePkg/Include/Library/BaseLib.h, to avoid a multiple definition problem in building. Signed-off-by: Evan Chai --- .../RISC-V/ProcessorPkg/Include/Library/RiscVCpu

Re: [edk2-devel] [PATCH V2 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

2023-02-22 Thread Heinrich Schuchardt
On 2/22/23 03:37, Sunil V L wrote: Replace rv64imafdc with rv64gc so that it works for gcc 12. "g" means imafd in gcc < 12 and imafd_zifencei_zicsr in gcc >= 12. So, replacing rv64imafdc with rv64gc will work for both gcc <12 and gcc >=12. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: An

[edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-22 Thread Yoshinoya
Hi Usually PciBus scan is from low bus num to high bus num. So, does it support scan from end bus num to start bus num? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100442): https://edk2.groups.io/g/devel/message/100442 Mute T

[edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-22 Thread Yoshinoya
Hi Usually PciBus scan is from low bus num to high bus num. So, does it support scan from end bus num to start bus num? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100443): https://edk2.groups.io/g/devel/message/100443 Mu

[edk2-devel] [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp into MultiFv BdsFv

2023-02-22 Thread marsx . lin
From: MarsX Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4347 To put UiApp.inf and BootManagerMenuApp.inf to proper FV(BDSFV) Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: MarsX Lin --- UefiPayloadPkg/UefiPayloadPkg.fdf | 4 ++-- 1 file chang

[edk2-devel] PciBus scan: Does it support scan from EndBusNum to StartBusNum?

2023-02-22 Thread Yoshinoya
Hi Usually PciBus scan is from low bus num to high bus num. So, does it support scan from end bus num to start bus num? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100441): https://edk2.groups.io/g/devel/message/100441 Mute T

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Improve formatting of warning DEBUG in UsbSelectConfig

2023-02-22 Thread Rebecca Cran
That's the only USB debug message I noticed that seemed unclear. Looking through the code I see a few others that could also be improved: MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c 764:  "UsbGetOneConfig: failed to get descript length(%d) %r\n", 790:    DEBUG ((DEBUG_ERROR, "UsbGetOneConfig:

Re: [edk2-devel] [edk2 1/1] RiscV64 Timer: fix tick duration accounting

2023-02-22 Thread Sunil V L
On Tue, Feb 21, 2023 at 10:37:23AM +0530, Sunil V L via groups.io wrote: > Hi Andrei, > > Thank you very much for fixing this! > > On Fri, Feb 17, 2023 at 10:31:49PM -0600, Andrei Warkentin wrote: > > The TimerDxe implementation doesn't account for the physical > > time passed due to timer handle

Re: 回复: 回复: [edk2-devel] [IMPORTANT] February Release Reviews and Merges for this stable tag 202302

2023-02-22 Thread Sunil V L
On Wed, Feb 22, 2023 at 11:08:00AM +0800, gaoliming via groups.io wrote: > Sunil: > I am OK to merge them for this stable tag once they pass code review. Hi Liming, Andrei has helped to review the V2 versions of these patches. Please review and let me know if I need to update something. Thanks