Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

2023-03-12 Thread Wu, Jiaxin
I can reproduce the issue and root cause to below code. GetFirstGuidHob() can't be used after exit boot service, that's the reason why I didn't catch the issue during the S3 test in shell. I will remove those check directly, and add debug message for the mSmmRelocated value. ASSERT

Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions

2023-03-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Maintainers @michael.d.kin...@intel.com, @Liming Gao and @Zhiguang Liu, Please review and merge it if there is no problems with this patch, this helps the follow up development works. Please note that Isaac has his Acked-by: Isaac Oram to this patch. Thanks

Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add DMTF MCTP definitions

2023-03-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Maintainers @michael.d.kin...@intel.com, @Liming Gao and @Zhiguang Liu, Please review and merge it if there is no problems with this patch, this helps the follow up development works. Please note that Isaac has his Acked-by: Isaac Oram to this patch. One

Re: [edk2-devel] [PATCH v2 3/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

2023-03-12 Thread Ni, Ray
The instance should follow the SmmSmramSaveStateLib header to only have two functions with "EFIAPI". But I saw more than 2. Can you check and remove those unnecessary ones? Thanks, Ray > -Original Message- > From: Chang, Abner > Sent: Sunday, January 15, 2023 12:26 PM > To:

Re: [edk2-devel] [Patch 1/1] ShellPkg/Library: Fix 32-bit truncation of pointer values

2023-03-12 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Sunday, March 12, 2023 4:12 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: [Patch 1/1] ShellPkg/Library: Fix 32-bit truncation of pointer values > > REF:

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

2023-03-12 Thread Igor Kulchytskyy via groups.io
Thank you, Nickle. -Original Message- From: Nickle Wang Sent: Sunday, March 12, 2023 8:05 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation Hi Igor, Thank you

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, March 13, 2023 #cal-reminder

2023-03-12 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, March 13, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753769 ) *Description:*

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

2023-03-12 Thread Nickle Wang via groups.io
Hi Igor, Thank you for your review. I will incorporate your comments in version 2 patch files. Regards, Nickle -Original Message- From: Igor Kulchytskyy Sent: Saturday, March 11, 2023 2:49 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE: