[edk2-devel] [PATCH 3/3] RedfishPkg: fix config handler driver issues

Bug fix: - function stack fault - config handler driver requires the dependency of Redfish Credential Protocol - incorrect caller id installation when failed to perform init() - fix typo Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [PATCH 2/3] RedfishPkg: Redfish discover driver improvement

Bug fix: - function stack fault - properly handle "SubnetAddrInfoIPv6" when there is no IPv6 support - copy-n-paste error in RedfishGetHostInterfaceProtocolData() - fix typo Enhancement: - Redfish discover driver now can configure host IP address based on the information from SMBIOS type 42

[edk2-devel] [PATCH 1/3] RedfishPkg/JsonLib: address coverity issue

Fix implicit conversion issue in JsonLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Library/JsonLib/JsonLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c

[edk2-devel] [PATCH 0/3] Fix variety issues in RedfishPkg

Fix variety issues in RedfishPkg, including coverity issue, typo, coding bugs and improve driver binding code flow in RedfishDiscoverDxe driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (3): RedfishPkg/JsonLib: address coverity issue

回复: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Patrick > Rudolph > 发送时间: 2023年3月17日 22:06 > 抄送: devel@edk2.groups.io; guo.d...@intel.com; gua@intel.com; > james...@intel.com; ray...@intel.com; mhaeu...@posteo.de; > a...@kernel.org > 主题: [edk2-devel] [PATCH 1/3]

回复: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Patrick: I prefer to override this option in DSC instead of the change in tools_def.txt. Normal EFI image needs to set its page size for the smaller image size. You can see GCC DLINK option. It also sets page-size as 0x40. DEFINE GCC49_IA32_X64_DLINK_COMMON = -nostdlib

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote: > Add Ard Biesheuvel and Sunil V L > to cc list. > > > -Original Message- > > From: Jianyong Wu > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io; Sami Mujawar > > Cc: Jianyong Wu > > Subject: [PATCH] CloudHv: can't

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote: > Add Ard Biesheuvel and Sunil V L > to cc list. > > > -Original Message- > > From: Jianyong Wu > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io; Sami Mujawar > > Cc: Jianyong Wu > > Subject: [PATCH] CloudHv: can't

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Add Ard Biesheuvel and Sunil V L to cc list. > -Original Message- > From: Jianyong Wu > Sent: 2023年2月17日 14:48 > To: devel@edk2.groups.io; Sami Mujawar > Cc: Jianyong Wu > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > commit f13264b34 introduces a bug for

Re: [edk2-devel] [PATCH 3/9] IntelFsp2Pkg: Add CpuPageTableLib required by DxeIpl in DSC

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Dun > Sent: Monday, March 27, 2023 7:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Ni, Ray > > Subject: [PATCH 3/9] IntelFsp2Pkg: Add CpuPageTableLib required

[edk2-devel] [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO

Code refinement to the code to set page table as RO in DxeIpl module. Set all page table pools as ReadOnly by calling PageTableMap() in CpuPageTableLib multiple times instead of searching each page table pool address in page table layer by layer. Also, this commit solve the issue that original

[edk2-devel] [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX

In IA32 code, remove the duplicated code to enable NX. In the previous patch, IA32 code also uses the new CreateIdentityMappingPageTables() to create PAE page table. This function calls EnableExecuteDisableBit if needed. Signed-off-by: Dun Tan Cc: Dandan Bi Cc: Liming Gao Cc: Ray Ni Cc: Jian

[edk2-devel] [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib

Modify CreateIdentityMappingPageTables() to create page table based on CpuPageTableLib in DxeIpl module. This function can be used to create both IA32 PAE paging and long mode 4-level, 5-level paging structure. With the PageTableMap() API in the CpuPageTableLib, we can remove the complicated page

[edk2-devel] [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

Add UefiCpuPkg/UefiCpuPkg.dec in MdeModulePkg.ci.yaml to pass DependencyCheck since DxeIpl in MdeModulePkg needs to consume CpuPageTableLib in UefiCpuPkg. Signed-off-by: Dun Tan Cc: Liming Gao Cc: Ray Ni Cc: Jian J Wang --- MdeModulePkg/MdeModulePkg.ci.yaml | 5 +++-- 1 file changed, 3

[edk2-devel] [PATCH 2/9] EmulatorPkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in EmulatorPkg.dsc. Signed-off-by: Dun Tan Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index

[edk2-devel] [PATCH 5/9] OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file

Add CpuPageTableLib instance required by DxeIpl in corresponding DSC files of OvmfPkg. Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Ray Ni --- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- OvmfPkg/Bhyve/BhyveX64.dsc | 3 ++-

[edk2-devel] [PATCH 3/9] IntelFsp2Pkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in QemuFspPkg.dsc of IntelFsp2Pkg. Signed-off-by: Dun Tan Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ray Ni --- IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in the corresponding DSC files of ArmVirtPkg. Signed-off-by: Dun Tan Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: Ray Ni --- ArmVirtPkg/ArmVirtCloudHv.dsc | 2 ++ ArmVirtPkg/ArmVirtQemu.dsc| 3 ++- 2 files

[edk2-devel] [PATCH 0/9] Create page table by CpuPageTableLib in DxeIpl

This patch set is to create page table by CpuPageTableLib in DxeIpl. With the CpuPageTableLib, we can create or update page table by calling PageTableMap() in CpuPageTableLib multiple times. Then the original page table manipulating code can be removed. Dun Tan (9): ArmVirtPkg: Add

[edk2-devel] [PATCH 4/9] MdeModulePkg: Add CpuPageTableLib required by DxeIpl in DSC

Add CpuPageTableLib instance required by DxeIpl in MdeModulePkg.dsc. Signed-off-by: Dun Tan Cc: Jian J Wang Cc: Liming Gao Cc: Ray Ni --- MdeModulePkg/MdeModulePkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc

Re: [edk2-devel] [PATCHv2 1/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other reviewers. Best Regards, Hao Wu > -Original Message- > From: Albecki, Mateusz > Sent: Tuesday, March 28, 2023 5:38 AM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz ; Wu, Hao A > ; Ni, Ray

[edk2-devel] [PATCH v3] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Signed-off-by: Nickle Wang Cc: Abner Chang

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, March 28, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, March 28, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v1 1/2] MdePkg/BaseCacheMaintenanceLib: Enable RISCV CMO

On Mon, Mar 27, 2023 at 11:29:07PM +0530, Dhaval Sharma wrote: > My comments inline: > > On Mon, Mar 27, 2023 at 9:12 PM Sunil V L wrote: > > > Hi Dhaval, > > > > Thank you for looking at CMO support! > > > > General comments first: > > 1) Please have a cover letter patch and move some part of

Re: [edk2-devel] [PATCH v1 0/1] Define security policy in SECURITY.md file for repository

Ack Need to get this acked by others in infosec too -- Miki Demeter (she/her/Miki) Security Researcher / FW Developer FST Intel Corporation Co-Chair, Network of Intel African-Ancestry(NIA) - Oregon NIA-Oregon Portland Women in Tech Best Speaker

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

Hi Mike, Thank you for taking care of this. Also thanks to everyone involved in the discussion on how to address this issue. Best regards, Pawel On Sun, Mar 26, 2023 at 4:04 AM Michael D Kinney wrote: > Merged: https://github.com/tianocore/edk2/pull/4181 > > Commit: >

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, March 27, 2023 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* Monday, March 27, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753771 ) *Description:* TianoCore

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, March 27, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, March 27, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753771 ) *Description:*

Re: [edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38

I'm not able to reproduce the failure you're seeing. The error message, "clang: error: unable to execute command: program not executable" looks like it would be a temporary failure. Could you try again? Also, you said to install LLVM 11.0.0, but you apparently have 12.0.1 installed? --

[edk2-devel] [PATCHv2 1/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Currently AHCI driver will try to retry all failed packets regardless of the failure cause. This is a problem in password unlock flow where number of password retries is tracked by the device. If user passes a wrong password Ahci driver will try to send the wrong password multiple times which will

[edk2-devel] [PATCHv2 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Fix for the recovery logic which causes hdd unlock to fail if user supplies incorrect password. Every failed packet used to be recovered which is causing the incorrect password to be tried multiple times. This patch series fixes the logic to only retry commands that failed due to CRC error. BZ:

Re: [edk2-devel] [PATCH v1 1/2] MdePkg/BaseCacheMaintenanceLib: Enable RISCV CMO

My comments inline: On Mon, Mar 27, 2023 at 9:12 PM Sunil V L wrote: > Hi Dhaval, > > Thank you for looking at CMO support! > > General comments first: > 1) Please have a cover letter patch and move some part of the commit message to cover letter. Please CC all maintainers in the cover letter

Re: [edk2-devel] [PATCH v2 14/17] BaseTools/GenFw: Add DllCharacteristicsEx field to debug data

On Mon, 27 Mar 2023 at 17:46, Marvin Häuser wrote: > > Hi Ard, > > On 27. Mar 2023, at 13:01, Ard Biesheuvel wrote: > > The PE/COFF spec describes an additional DllCharacteristics field > implemented as a debug directory entry, which carries flags related to > which control flow integrity (CFI)

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

I think that would still be called Sec. Are there any issues with using Sec prefix? Mike > -Original Message- > From: Warkentin, Andrei > Sent: Thursday, March 16, 2023 10:45 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > > Subject: RE: [PATCH

Re: [edk2-devel] [Patch 0/2] Add and use FirmwareVolumeShadowPpi

Merged PR: https://github.com/tianocore/edk2/pull/4159 Commit: https://github.com/tianocore/edk2/commit/c8e631588b9591489d0219db1d14664e10367ecd Commit: https://github.com/tianocore/edk2/commit/144028626e0072c2c4fdfcc0fe1b72de319bdd2f Mike > -Original Message- > From: Wang, Jian J >

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

Hi folks, If there aren't any remaining concerns, can I get a reviewed-by on the MdePkg changes? A -Original Message- From: devel@edk2.groups.io On Behalf Of Andrei Warkentin Sent: Friday, March 17, 2023 12:45 AM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Gao, Liming ; Liu,

Re: [edk2-devel] [PATCH v2 14/17] BaseTools/GenFw: Add DllCharacteristicsEx field to debug data

Hi Ard, > On 27. Mar 2023, at 13:01, Ard Biesheuvel wrote: > > The PE/COFF spec describes an additional DllCharacteristics field > implemented as a debug directory entry, which carries flags related to > which control flow integrity (CFI) features are supported by the binary. Out of mere

Re: [edk2-devel] [PATCH v1 2/2] OvmfPkg/RiscVVirt: Enable CMO support

On Fri, Mar 24, 2023 at 09:13:42PM +0530, Dhaval Sharma wrote: > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Daniel Schaefer > Signed-off-by: Dhaval Sharma > > Add support for Cache Management Operations > --- > OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 9 + > 1 file changed, 9

Re: [edk2-devel] [PATCH v1 1/2] MdePkg/BaseCacheMaintenanceLib: Enable RISCV CMO

Hi Dhaval, Thank you for looking at CMO support! General comments first: 1) Please have a cover letter patch and move some part of the commit message to cover letter. Please CC all maintainers in the cover letter also. 2) Please run BaseTools/Scripts/GetMaintainer.py and CC all maintainers. 3)

Re: [edk2-devel] [Patch 2/2] SecurityPkg/FvReportPei: Use FirmwareVolumeShadowPpi

I agree with your comment. Can you please enter a new BZ to address it? Thanks, Mike > -Original Message- > From: Oliver Smith-Denny > Sent: Wednesday, March 22, 2023 9:05 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Patel, Umang ; Yao, Jiewen ; > Wang, Jian J > Subject:

Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/PlatformInitLib: simplify mtrr setup

On Tue, Mar 07, 2023 at 07:54:54AM +0100, Gerd Hoffmann wrote: > With the new mmconfig location at 0xe000 above the 32-bit PCI MMIO > window we don't have to special-case the mmconfig xbar any more. We'll > just add a mtrr uncachable entry starting at MMIO window base and ending > at 4GB. >

Re: [edk2-devel] [PATCH v2 2/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000

On Tue, Mar 07, 2023 at 07:54:53AM +0100, Gerd Hoffmann wrote: > Also swap the ordering of 32bit PCI MMIO window on q35, i.e. use the > room between end of low memory and the start of the mmconfig bar. > > With a typical configuration on modern qemu with gigabyte-aligned memory > the MMIO window

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Update Maintainer.txt file

Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Sunday, March 26, 2023 10:00 PM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch 1/1] edk2-libc: Update Maintainer.txt file > > REF :

Re: [edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

Reviewed-by: Michael D Kinney > -Original Message- > From: Rohit Mathew > Sent: Monday, March 27, 2023 7:33 AM > To: devel@edk2.groups.io; Rohit Mathew > Cc: Kinney, Michael D ; Sami Mujawar > ; 'Zhiguang Liu' ; > Thomas Abraham ; 'Swatisri Kantamsetti' > ; nd ; Gao, Liming > >

[edk2-devel] [PATCH 1/1] OvmfPkg/CI: Boot OVMF in SMP mode.

Increase the chance that CI finds bugs in MP changes. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py index

Re: [edk2-devel] [PATCH v2 1/3] OvmfPkg/PlatformInitLib: update address space layout comment

On Tue, Mar 07, 2023 at 07:54:52AM +0100, Gerd Hoffmann wrote: > Move the commment up so it is placed just before the address space > calculations start. Also add q35 memory layout. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [edk2-devel] [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

Hi all, Gentle reminder on the patch. Regards, Rohit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rohit > Mathew via groups.io > Sent: Monday, February 13, 2023 9:01 PM > To: devel@edk2.groups.io > Cc: 'Michael D Kinney' ; Sami Mujawar > ; 'Zhiguang Liu' ; Thomas >

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, Mar 27, 2023 at 15:12:29 +0100, Pedro Falcato wrote: > On Mon, Mar 27, 2023 at 12:01 PM Ard Biesheuvel wrote: > > > > Implement a CPP macro that can be called from .S files to emit the .note > > section carrying the annotation that informs the linker that the object > > file is compatible

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, Mar 27, 2023 at 12:01 PM Ard Biesheuvel wrote: > > Implement a CPP macro that can be called from .S files to emit the .note > section carrying the annotation that informs the linker that the object > file is compatible with BTI control flow integrity checks. > > Signed-off-by: Ard

[edk2-devel] [edk2-staging/Nvme-Fabrics-Boot] Introduction of new branch

Hello EDK2 community, The "Nvme-Fabrics-Boot" branch was created in edk2-staging repository. Role of this branch is to upstream our NVMe-over-Fabrics boot prototype created under Timberland SIG's umbrella to EDK2. Link to branch:

Re: [edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table

Hi, > > I know you point out to use CLANG38, but the set is also tagged PATCH > > rather than RFC. > > I believe this option was added to GCC in version 9, meaning this is a > > breaking change for GCC8. Now, GCC8 is ancient, but I expect it's > > still what's available in RHEL8 for example. So

[edk2-devel] [PATCH v2] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Signed-off-by: Nickle Wang Cc: Abner Chang

Re: [edk2-devel] [PATCH v2 15/17] MdePkg: Update MemoryAttributesTable to v2.10

On Mon, Mar 27, 2023 at 13:01:10 +0200, Ard Biesheuvel wrote: > UEFI v2.10 introduces a new flag to the memory attributes table to > inform the OS whether or not runtime services code regions were emitted > by the compiler with guard instructions for forward edge control flow > integrity

Re: [edk2-devel] [PATCH v2 11/17] ArmPkg, BaseTools AARCH64: Add BTI ELF note to .hii objects

On Mon, 27 Mar 2023 at 15:10, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 13:01:06 +0200, Ard Biesheuvel wrote: > > The ELF based toolchains use objcopy to create HII object files, which > > contain only a single .hii section. This means no GNU note is inserted > > that describes the object

Re: [edk2-devel] [PATCH v2 11/17] ArmPkg, BaseTools AARCH64: Add BTI ELF note to .hii objects

On Mon, Mar 27, 2023 at 13:01:06 +0200, Ard Biesheuvel wrote: > The ELF based toolchains use objcopy to create HII object files, which > contain only a single .hii section. This means no GNU note is inserted > that describes the object as compatible with BTI, even though the lack > of executable

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, Mar 27, 2023 at 14:15:09 +0200, Ard Biesheuvel wrote: > On Mon, 27 Mar 2023 at 13:53, Leif Lindholm wrote: > > > > On Mon, Mar 27, 2023 at 13:00:56 +0200, Ard Biesheuvel wrote: > > > Implement a CPP macro that can be called from .S files to emit the .note > > > section carrying the

Re: [edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table

(update Rebecca's email) On Mon, 27 Mar 2023 at 13:43, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 13:00:55 +0200, Ard Biesheuvel wrote: > > Implement version 2 of the memory attributes table, which now contains a > > flag informing the OS whether or not code regions may be mapped with CFI

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, Mar 27, 2023 at 14:46:49 +0200, Ard Biesheuvel wrote: > On Mon, 27 Mar 2023 at 14:45, Leif Lindholm wrote: > > > > On Mon, Mar 27, 2023 at 13:00:56 +0200, Ard Biesheuvel wrote: > > > Implement a CPP macro that can be called from .S files to emit the .note > > > section carrying the

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, 27 Mar 2023 at 14:45, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 13:00:56 +0200, Ard Biesheuvel wrote: > > Implement a CPP macro that can be called from .S files to emit the .note > > section carrying the annotation that informs the linker that the object > > file is compatible with

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, Mar 27, 2023 at 13:00:56 +0200, Ard Biesheuvel wrote: > Implement a CPP macro that can be called from .S files to emit the .note > section carrying the annotation that informs the linker that the object > file is compatible with BTI control flow integrity checks. > > Signed-off-by: Ard

[edk2-devel] [PATCH v2 1/1] OvmfPkg/RiscVVirt: Support multiple reserved memory ranges

M-mode firmware ranges should not be used by EDK2/OS. Currently, we search for mmode_resv0 node in FDT and mark it as the reserved memory in EFI memory map. However, if there are multiple M-mode firmware ranges, then this will miss those extra ranges allowing the OS to access the memory and hit a

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, 27 Mar 2023 at 13:53, Leif Lindholm wrote: > > On Mon, Mar 27, 2023 at 13:00:56 +0200, Ard Biesheuvel wrote: > > Implement a CPP macro that can be called from .S files to emit the .note > > section carrying the annotation that informs the linker that the object > > file is compatible with

Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

On Mon, Mar 27, 2023 at 13:00:56 +0200, Ard Biesheuvel wrote: > Implement a CPP macro that can be called from .S files to emit the .note > section carrying the annotation that informs the linker that the object > file is compatible with BTI control flow integrity checks. > > Signed-off-by: Ard

Re: [edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table

On Mon, Mar 27, 2023 at 13:00:55 +0200, Ard Biesheuvel wrote: > Implement version 2 of the memory attributes table, which now contains a > flag informing the OS whether or not code regions may be mapped with CFI > mitigations such as IBT or BTI enabled. > > This series covers roughly the

[edk2-devel] [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82

Subject: [edk2-platfoms][PATCH V2] Update PcdBoardID of JunctionCity and Aowanda platform to 0x81 and 0x82 Fix to resolve the boot error - Change the enum constants values TypeBoardPortTemplate, TypeJunctionCity and TypeAowanda in PlatformInfoTypes.h. Changed PcdBoardId as 0x81 and 0x82 for

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: After reset, wake up APs by SIPI.

On Mon, Mar 27, 2023 at 11:17:11AM +0800, Yuanhao Xie wrote: > Following a power-up or RESET, since all APs are already in the > “wait-for-SIPI state,” the BSP can broadcast just a single SIPI IPI to > the APs to wake them up and initialize them. > > Cc: Guo Dong > Cc: Ray Ni > Cc: Sean Rhodes

[edk2-devel] [PATCH v2 17/17] MdeModulePkg: Enable forward edge CFI in mem attributes table

The memory attributes table has been extended with a flag that indicates whether or not the OS is permitted to map the EFI runtime code regions with strict enforcement for IBT/BTI landing pad instructions. Given that the PE/COFF spec now defines a DllCharacteristicsEx flag that indicates whether

[edk2-devel] [PATCH v2 16/17] MdePkg/PeCoffLib: Capture DLL characteristics fieldis in image context

When loading a PE/COFF image, capture the DLL characteristics fields of the header into our image context structure so we can refer to them when mapping the image. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/IndustryStandard/PeImage.h | 13 +- MdePkg/Include/Library/PeCoffLib.h

[edk2-devel] [PATCH v2 15/17] MdePkg: Update MemoryAttributesTable to v2.10

UEFI v2.10 introduces a new flag to the memory attributes table to inform the OS whether or not runtime services code regions were emitted by the compiler with guard instructions for forward edge control flow integrity enforcement. So update our definition accordingly. Link:

[edk2-devel] [PATCH v2 14/17] BaseTools/GenFw: Add DllCharacteristicsEx field to debug data

The PE/COFF spec describes an additional DllCharacteristics field implemented as a debug directory entry, which carries flags related to which control flow integrity (CFI) features are supported by the binary. So let's add this entry when doing ELF to PE/COFF conversion - we will add support for

[edk2-devel] [PATCH v2 13/17] BaseTools/GenFw: Parse IBT/BTI support status from ELF note

When performing ELF to PE/COFF conversion, parse any notes sections to decide whether the image supports forward CFI landing pads. This will be used to set the associated DllCharacteristicsEx flag in a subsequent patch. Signed-off-by: Ard Biesheuvel --- BaseTools/Source/C/GenFw/Elf64Convert.c |

[edk2-devel] [PATCH v2 12/17] ArmPlatformPkg/PrePeiCore: Make vector table object BTI compatible

The object file containing the vector table does not contain any callable functions, so it will not be implicitly annotated as BTI compatible on BTI builds. So add the annotation by hand, and use the 'empty' type so we get the GNU ELF note but not the actual BTI opcode. Signed-off-by: Ard

[edk2-devel] [PATCH v2 11/17] ArmPkg, BaseTools AARCH64: Add BTI ELF note to .hii objects

The ELF based toolchains use objcopy to create HII object files, which contain only a single .hii section. This means no GNU note is inserted that describes the object as compatible with BTI, even though the lack of executable code in such an object makes the distinction irrelevant. However, the

[edk2-devel] [PATCH v2 10/17] ArmPkg/GccLto AARCH64: Add BTI note to LTO helper library

The GccLto helper library does not contain any code, as its only purpose is to pull in other libraries that implement intrinsics to which the linker's codegen pass may emit calls. So mark it as BTI compatible, so that the linker does not complain about unannotated objects. Signed-off-by: Ard

[edk2-devel] [PATCH v2 09/17] ArmPkg: Emit BTI opcodes when BTI codegen is enabled

When building with -mbranch-protection=bti, which affects the compiler codegen only, ensure that the assembler based codegen is aligned with this, by emitting the BTI C opcode at the start of each exported function. While most exported functions are not in fact ever called indirectly, whether or

[edk2-devel] [PATCH v2 08/17] MdePkg/BaseRngLib AARCH64: Make asm files BTI compatible

Add the BTI instructions and the associated note to make the AArch64 asm objects compatible with BTI enforcement. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseRngLib/AArch64/ArmReadIdIsar0.S | 3 +-- MdePkg/Library/BaseRngLib/AArch64/ArmRng.S | 1 + 2 files changed, 2

[edk2-devel] [PATCH v2 06/17] MdePkg/BaseMemoryLibOptDxe AARCH64: Make asm files BTI compatible

Add the BTI instructions and the associated note to make the AArch64 asm objects compatible with BTI enforcement. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareGuid.S | 1 + MdePkg/Library/BaseMemoryLibOptDxe/AArch64/CompareMem.S | 1 +

[edk2-devel] [PATCH v2 07/17] MdePkg/BaseSynchronizationLib AARCH64: Make asm files BTI compatible

Add the BTI instructions and the associated note to make the AArch64 asm objects compatible with BTI enforcement. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseSynchronizationLib/AArch64/Synchronization.S | 5 + 1 file changed, 5 insertions(+) diff --git

[edk2-devel] [PATCH v2 05/17] MdePkg/BaseLib AARCH64: Make asm files BTI compatible

Add the BTI instructions and the associated note to make the AArch64 asm objects compatible with BTI enforcement. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseLib/AArch64/CpuBreakpoint.S | 1 + MdePkg/Library/BaseLib/AArch64/DisableInterrupts.S | 1 +

[edk2-devel] [PATCH v2 04/17] MdePkg/BaseLib AARCH64: Make LongJump() BTI compatible

Currently, the AArch64 implementation of LongJump() avoids using the RET instruction to perform the jump, even though the target address is held in the link register X30, as the nature of a long jump implies that the ordinary return address prediction machinery will not be able to make a correct

[edk2-devel] [PATCH v2 03/17] MdePkg/BaseIoLibIntrinsic AARCH64: Make asm files BTI compatible

Add the BTI instructions and the associated note to make the AArch64 asm objects compatible with BTI enforcement. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/Library/ArmPlatformLibQemu/IdMap.S | 2 ++ MdePkg/Library/BaseIoLibIntrinsic/AArch64/ArmVirtMmio.S | 8 2 files

[edk2-devel] [PATCH v2 02/17] MdePkg/BaseCpuLib AARCH64: Make asm files BTI compatible

Add the BTI instructions and the associated note to make the AArch64 asm objects compatible with BTI enforcement. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BaseCpuLib/AArch64/CpuFlushTlb.S | 1 + MdePkg/Library/BaseCpuLib/AArch64/CpuSleep.S| 1 + 2 files changed, 2 insertions(+)

[edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note

Implement a CPP macro that can be called from .S files to emit the .note section carrying the annotation that informs the linker that the object file is compatible with BTI control flow integrity checks. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/AArch64/ProcessorBind.h | 31

[edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table

Implement version 2 of the memory attributes table, which now contains a flag informing the OS whether or not code regions may be mapped with CFI mitigations such as IBT or BTI enabled. This series covers roughly the following parts: - (AARCH64) Annotate ELF objects generated from asm as BTI

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string

Reviewed-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Monday, March 27, 2023 4:02 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann ; Dong, Eric ; > Kumar, Rahul R ; Oliver Steffen > ; Pawel Polawski ; Ni, Ray > ; Laszlo Ersek > Subject: [PATCH v2 1/1]

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string

On 3/27/23 10:02, Gerd Hoffmann wrote: > BufferPages is UINTN, so we need "%Lu" when printing it to avoid > it being truncated. Also cast to UINT64 to make sure it works > for 32bit builds too. > > Fixes: 4f441d024bee ("UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling") > Reported-by: Laszlo Ersek

[edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: migration of edk2module from chipsec repo

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access platform registers. These enhancements providing a set of APIs

[edk2-devel] [edk2-libc Patch 0/1] Python/Python3.6.8: migration of edk2module from chipsec repo

Python/Python3.6.8: migration of edk2module from chipsec repo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string

BufferPages is UINTN, so we need "%Lu" when printing it to avoid it being truncated. Also cast to UINT64 to make sure it works for 32bit builds too. Fixes: 4f441d024bee ("UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling") Reported-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann ---