Remove SmmLockBox.inf to fix a build issue, because it is already
been included from MinPlatform dsc/fdf file
Cc: Nate DeSimone
Cc: Ray Ni
Signed-off-by: Zhiguang Liu
---
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platfor
[AMD Official Use Only - General]
Hi all,
This is the RFC to occupy BIT23 of debug error level for Manageability
messages. This debug print error level covers below packages and purposes,
* edk2 RedfishPkg
* JSON plain text payload
* HTTP Header/Request/Response/body
* R
The error message says the below file can’t be found. Can you confirm it?
/home/luming/01_work/01_project/8295/rse/sa8295p-hqx-4-5-5-1_amss_standard_oem.git/boot/boot_images/Build/MakenaAU/Core/RELEASE_CLANG100LINUX/FV/Ffs/5E0EAE60-EAED-4D75-B8BF-EDBBAABC3F09SecurityDxe/5E0EAE60-EAED-4D75-B8BF-
[AMD Official Use Only - General]
Forget to CC Sean.
Hi Sean,
The package naming AmdMinBoardPkg looks good to you?
Thanks
Abner
> -Original Message-
> From: Chang, Abner
> Sent: Tuesday, April 11, 2023 7:05 PM
> To: Abdul Lateef Attar ; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Ab
[AMD Official Use Only - General]
Hi Richard and Pedro,
Understand that is the standard USB communication class device, that is why I
think put it under MdeModulePkg/Bus/Usb/UsbNetwork makes more sense because it
is similar to the USB mass storage or HID classes.
USB RNDIS driver and EDKII USB E
This change implements the blob transfer protocol used in OpenBmc
documented here: https://github.com/openbmc/phosphor-ipmi-blobs
Signed-off-by: Nick Ramirez
Cc: Abner Chang
Cc: Isaac Oram
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Tinh Nguyen
---
.../ManageabilityPkg/ManageabilityPkg.dec
Hi Pedro/Abner,
UsbNetworkPkg provide the RNDIS/ECM/NCM device support that are implement form
USB specification(we have other USB network device's driver to upstream).
It is not specific USB device. The driver could work on any platform. So, we
create UsbNetworkPkg same as NetworkPkg in edk2 re
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, April 11, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4e
I agree C related source files and scripts that generate C code would be
included.
Some of BaseTools python scripts generate .c/.h files too, so don't want to
exclude all .py.
Perhaps just exclude __file__?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca C
On 4/11/23 2:21 PM, Michael D Kinney wrote:
Should use we os.path services to get the file extension?
There are may other file types that this check should be excluded
(e.g. .sh, .gitignore, .gitmodules, .uni). Should this check only
apply to .c, .h. What about .C and .H and also the addition
> -Original Message-
> From: Rebecca Cran
> Sent: Tuesday, April 11, 2023 11:06 AM
> To: devel@edk2.groups.io; Gao, Liming ; Feng, Bob C
> ; Chen, Christine
> ; Kinney, Michael D
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to
> check for __FUNCTION__
>
> C
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Rebecca Cran
> Sent: Tuesday, April 11, 2023 11:06 AM
> To: devel@edk2.groups.io; Gao, Liming ; Feng, Bob C
> ; Chen, Christine
> ; Kinney, Michael D
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add
I agree. This is proper use of the term "Smram".
Mike
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, April 11, 2023 12:38 AM
> To: devel@edk2.groups.io; abdat...@amd.com; Kinney, Michael D
>
> Cc: Paul Grimes ; Garrett Kirkendall
> ; Abner Chang ;
> Gao, Liming ; Liu, Zhiguang
Thanks for the feedback Abdul. We usually do not see this in the history for a
new lib instance.
I know we recommend developers start from a template of a lib instance if it is
available
and then fill in the specific implementation, but those 2 steps do not go into
commit
history.
Mike
> ---
Looks like obvious syntax fix.
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Monday, April 10, 2023 7:53 PM
> To: Desimone, Nathaniel L
> Cc: devel@edk2.groups.io; Guenzel, Robert
> Subject: Re: [edk2-devel] [PATCH 1/2] Si
For the final version of this patch series, wouldn't only the full
implementation commit be required in the git history?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang, Abner
> via groups.io
> Sent: Monday, April 10, 2023 6:08 PM
> To: Kinney, Michael D ; Att
Could I get some reviews on this please?
--
Rebecca Cran
On 4/6/23 7:28 PM, Rebecca Cran wrote:
To help people format patches with the correct options, add an alias
named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
--stat-graph-width=20'.
Signed-off-by: Rebecca Cran
--
Could I get some reviews on this please?
--
Rebecca Cran
On 4/6/23 7:30 PM, Rebecca Cran wrote:
New code should use the C99 macro __func__ instead of the pre-Standard
macro __FUNCTION__. Update PatchCheck.py to reject patches with the
latter.
Signed-off-by: Rebecca Cran
---
BaseTools/Scr
From: Rebecca Cran
Add a new library, JedecJep106Lib which provides a service to return the
JEDEC JEP106 manufacturer string given the code and continuation bytes
values.
Signed-off-by: Rebecca Cran
---
MdePkg/MdePkg.dec|3 +
MdePkg/MdePkg.dsc
On 4/11/23 05:04, Gerd Hoffmann wrote:
On Fri, Apr 07, 2023 at 12:00:46PM -0500, Tom Lendacky wrote:
Thanks for the quick turn-around, but that patch didn't work for me. I've
update the bugzilla.
Can you try the patch below?
That doesn't work either.
Specifying both OVMF_CODE.fd and OVMF_V
BaseTools fails to build on my system (Ubuntu 22.04.2 with g++ 11.3.0)
after applying the patches.
g++ -o ../bin/VfrCompile AParser.o DLexerBase.o ATokenBuffer.o
EfiVfrParser.o VfrLexer.o VfrSyntax.o VfrFormPkg.o VfrError.o
VfrUtilityLib.o VfrCompiler.o -L../libs -lCommon
/usr/bin/ld: VfrFor
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro Falcato
> Sent: Tuesday, April 11, 2023 9:07 AM
> To: Tan, Lean Sheng
> Cc: Kinney, Michael D ; Warkentin, Andrei
> ; devel@edk2.groups.io;
> Lin, Benny ; Gao, Liming ;
> Liu, Zhiguang ; Sean
> Brogan ; Michael Kubac
On Tue, Apr 11, 2023 at 2:20 PM Lean Sheng Tan wrote:
>
> Thanks Mike for the proposal layout!
> It sounds good to me :)
>
> Hi Pedro,
> I went through the email chain again, basically these are 2 of your main
> concerns (correct me if I'm wrong):
> 1. a good idea to at least ditch that specific
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
.../C/Include/IndustryStandard/PeImage.h | 790 --
1 file changed, 790 deletions(-)
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeIma
Use the MdePkg versions instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/EfiRom/EfiRom.h| 4 +-
.../C/Include/IndustryStandard/Bluetooth.h| 56 --
.../C/Include/IndustryStandard/EfiPci.h | 51 --
...emoryMappedConfiguration
The BaseTools and MdePkg versions of PeImage.h diverged over time,
add some missing bits to the MdePkg header file in preparation for
removing the BaseTools version.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Include/IndustryStandard/PeImage.h | 31 +++
1 file changed, 31 insert
The #define for IMAGE_FILE_MACHINE_ARM is not present in MdePkg,
this looks like a relic not used any more. Remove.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Common/BasePeCoff.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/BaseTools/Sour
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
.../Source/C/Include/AArch64/ProcessorBind.h | 148 --
.../Source/C/Include/Arm/ProcessorBind.h | 147 --
.../Source/C/Include/Ia32/ProcessorBin
Use the newer versions of the machine #defines.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++---
.../C/Include/IndustryStandard/PeImage.h | 1 +
BaseTools/Source/C/Common/BasePeCoff.c| 28 ++---
BaseTools/Sourc
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Acked-by: Sunil V L
---
.../Source/C/Include/IndustryStandard/Acpi.h | 117 ---
.../C/Include/IndustryStandard/Acpi1_0.h | 285
.../C/Include/IndustryStandard/Acpi2_0.h | 520
Appears to be a relic for ancient windows / compiler versions,
windows builds in CI work just fine without it.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Common/WinNtInclude.h| 66 -
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 1 -
BaseTools/Source/C/GenFw/Elf
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over to use the include files in
MdePkg instead. It also cleans up some (apparently) obsolete code and
adapts BaseT
I've pushed the patches to a branch at
https://github.com/bcran/edk2/tree/usbnetworkpkg-202304
--
Rebecca Cran
On 4/7/23 5:27 AM, Richard Ho (何明忠) wrote:
This driver provides UEFI driver for USB RNDIS device
Signed-off-by: Richard Ho
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinne
Enable the NOOPT build for the Juno platform. This is useful for
source-level debugging.
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
index
Increase the FV size from 996KB to 2MB. This allows more features to be
accommodated in the firmware image, such as HTTPS boot. It also allows a
NOOPT build to be added, which is useful for source-level debugging.
Add a comment explaining that the size chosen doesn't reflect the actual
size of the
The current FV size of 996KB for the Juno platform is rather restrictive
nowadays: a NOOPT build can be made to fit, but when enabling HTTPS boot
the firmware size becomes far too large even with an optimized DEBUG build.
Since the size value is rather arbitrary, bump it to 2MB: a build with
HTTPS
Hi Abner,
It seems to me that some of protocol GUIDs are defined in [Guids] section
instead of [Protocol] section in Features/ManageabilityPkg/ManageabilityPkg.dec
file. Could you please address this together?
Thanks,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Mon
Thanks Mike for the proposal layout!
It sounds good to me :)
*Hi Pedro,*
I went through the email chain again, basically these are 2 of your main
concerns (correct me if I'm wrong):
1. a good idea to at least ditch that specific copy (current FDT in
Embedded Pkg) for a git submodule.
2. Rework to
yes
thanks,
ray
From: Attar, AbdulLateef (Abdul Lateef)
Sent: Tuesday, April 11, 2023 7:17:03 PM
To: Ni, Ray ; devel@edk2.groups.io ;
kra...@redhat.com
Cc: Grimes, Paul ; Kirkendall, Garrett
; Chang, Abner ; Dong, Eric
; Kumar, Rahul R ; Ard Biesheuvel
; Yao,
On Tue, Apr 11, 2023 at 1:31 PM Rebecca Cran wrote:
> Given this is adding a new top-level package, I'd like to see a
> review/feedback from the TianoCore Stewards.
I would personally love to understand why this is being pushed as a
top level package in edk2 when "supposedly" edk2-platforms/Featu
[AMD Official Use Only - General]
Is any one has additional comments on the V4 patch set? Otherwise I will push
it to edk2-platforms.
Thanks
Abner
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Monday, April 3, 2023 7:23 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (
On Tue, Apr 11, 2023 at 10:09:59AM +, Ni, Ray wrote:
> Gerd,
> I am asking Abdul to directly call SaveStateLib from CpuSmm driver.
> I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver and
> SaveStateLib
> regarding the save state access.
Yes, sure. The SmmCpuFeatures{Re
On Tue, Apr 11, 2023 at 02:49:05PM +0800, duntan wrote:
> This patch set is to use CpuPageTableLib to create and update smm page table.
> With the CpuPageTableLib, we can create or update page table by calling
> PageTableMap() in CpuPageTableLib multiple times. Then the original page table
> manipu
Gerd,
I am asking Abdul to directly call SaveStateLib from CpuSmm driver.
I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver and
SaveStateLib
regarding the save state access.
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
On Fri, Apr 07, 2023 at 12:00:46PM -0500, Tom Lendacky wrote:
>
> Thanks for the quick turn-around, but that patch didn't work for me. I've
> update the bugzilla.
Can you try the patch below?
thanks,
Gerd
>From a9179864523d12c3dcc137f36f6ed1a2832ed22c Mon Sep 17 00:00:00 2001
From: Gerd Hoffm
The change is only for the coding style: make sure there is a white space
between the function name and '('.
I think you can keep the previous R-B.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sam
> Kaynor
> Sent: Wednesday, April 5, 2023 4:11 AM
> To:
Merge at 51734dfc48466eddfb0f8acdb24518266c36c905
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao,
> Zhichao
> Sent: Monday, April 10, 2023 1:53 PM
> To: Lin, MillerX ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] ShellPkg: Up
> Uses new SmmSmramSaveStateLib library,
> which fix the CI failure.
What is the exact failure you are seeing?
> +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSmmSmramSaveStateLib.inf
This should be the AMD version. KVM uses the AMD smram state.
Also: OvmfPkg/Library/
On Thu, Apr 06, 2023 at 04:23:01PM -0600, Rebecca Cran wrote:
> Following on from commit b17a3a133b18fb41493fba7d86e9b5804ea6a8cf which
> updated MdePkg to be more C11 compliant by replacing the pre-standard
> __FUNCTION__ with __func__ which was introduced in C99, this patch
> series updates the r
>Status = SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register,
> Width, Buffer);
>if (Status == EFI_UNSUPPORTED) {
> -Status = ReadSaveStateRegister (CpuIndex, Register, Width, Buffer);
> +Status = SmramSaveStateReadRegister (CpuIndex, Register, Width,
> Buffer);
>}
>
I
On Tue, Apr 11, 2023 at 06:51:25AM +, Tan, Dun wrote:
> Hi all,
> Could you please help review this patch?
Acked-by: Gerd Hoffmann
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102816): https://edk2.groups.io/g/devel/message/1028
> +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel
> SmmSmramSaveStateLib.inf
1. Can you rename it to "IntelMmSaveStateLib"?
> + INF_VERSION= 1.29
> + BASE_NAME = IntelSmmSmramSaveStateLib
> + FILE_GUID = 37E8
Acked-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abdul
> Lateef Attar via groups.io
> Sent: Monday, April 10, 2023 7:10 PM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar ; Paul Grimes
> ; Garrett Kirkendall ;
> Abner Chang ; Dong, Eric ;
> Ni, Ray ; Ku
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abdul
> Lateef Attar via groups.io
> Sent: Monday, April 10, 2023 7:10 PM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar ; Paul Grimes
> ; Garrett Kirkendall ;
> Abner Chang ; Dong, Eric ;
> Ni, Ray ;
> +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Am
> dSmmSmramSaveStateLib.inf
1. The lib instance name can be AmdMmSaveStateLib inside X86MmSaveStateLib
folder.
> +[Defines]
> + INF_VERSION= 1.29
> + BASE_NAME = AmdSmmSmramSaveStateL
> + ## @libraryclass Provides functions for manipulating Smram savestate
> registers.
> + SmmSmramSaveSateLib|Include/Library/SmmSmramSaveStateLib.h
1. Can you please rename the lib class to MmSaveStateLib? So the lib can be
potentially linked with standalone MM CPU driver.
2. Also the lib he
The patch looks good in general.
@Kinney, Michael D, I think it's ok to use "SmramSaveStateMap.h" instead of
"MmramSaveStateMap.h" because it matches to the CPU spec.
Do you agree?
"MM" is more like a general term that applies to all archs, X86, ARM, etc.
Abdul, just curious why do you add prefi
57 matches
Mail list logo
