Hi,
Ping for reviewing.
Let me know if I need anything for this patch.
Thanks,
Nhi
On 4/12/2023 4:21 PM, Nhi Pham wrote:
Add the AUTH_SIG_NOT_FOUND Action to the Image Execution Info Table
when the Image is signed but signature is not allowed by DB and the
hash of image is not found in DB/DB
> -Original Message-
> From: Tom Lendacky
> Sent: Friday, April 14, 2023 12:19 AM
> To: Tan, Dun ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [Patch V2 0/8] Use CpuPageTableLib to create and
> update smm page table
>
> On 4/13/23 04:14, Tan, Dun wrote:
> > Hi Tom,
>
Hi Mike,
Thanks for your help!
Regards,
Nickle
From: Kinney, Michael D
Sent: Friday, April 14, 2023 2:23 AM
To: devel@edk2.groups.io; Nickle Wang
Cc: Kinney, Michael D
Subject: RE: [edk2-devel] [PATCH V3] MdeModulePkg/RegularExpressionDxe: Fix GCC
build error
External email: Use caution ope
On 4/13/23 07:14, PierreGondois wrote:
diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
index 0755dc155616..583efd0efb16 100644
--- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
+++
+CC edk2-devel, It seems that you dropped it accidentally.
On Thu, Apr 13, 2023 at 7:30 PM Pedro Falcato wrote:
>
> On Thu, Apr 13, 2023 at 5:53 PM Kinney, Michael D
> wrote:
> >
> > Hi Pedro,
> >
> > Any comments in this new version? Have your concerns been addressed,
> > especially libc conf
Merged
PR: https://github.com/tianocore/edk2/pull/4270
Commit:
https://github.com/tianocore/edk2/commit/55b67b6950e648338adfe8ec54aeb26ed89d2c97
Mike
From: devel@edk2.groups.io On Behalf Of Nickle Wang via
groups.io
Sent: Wednesday, April 12, 2023 9:44 PM
To: Kinney, Michael D ; devel@edk2.g
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Thursday, April 13, 2023 8:16 AM
> To: devel@edk2.groups.io; Kinney, Michael D ;
> Gao, Liming ; Feng, Bob C
> ; Chen, Christine
> Cc: Rebecca Cran
> Subject: [edk2-devel
Working link to Bugzilla Ticket: 4410 – TcgMorLockSmm: Key Mismatch doesn't
update the MorLock Variable Value. (tianocore.org) (
https://bugzilla.tianocore.org/show_bug.cgi?id=4410 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102958
On 4/13/23 04:14, Tan, Dun wrote:
Hi Tom,
Thank you for your help with testing.
For the build failure, it's because that the CpuPageTableLib instance is added
into OvmfPkg DSC in the last pacth ' OvmfPkg: Add CpuPageTableLib required by
PiSmmCpuDxe'. I have moved this patch to the head of the
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/04/2023 02:14 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
processing the library constructors of:
MdeModulePkg/Bus/Pci/PciHost
Sorry for the incredible delay!
I only recently realized I'm allowed to commit edk2 changes.
I've queued this up, so it'll be pushed when CI passes.
For future commits, you don't need to add "devel@edk2.groups.io" to the
Cc line since it's Cc'd automatically (PatchCheck.py complains if it's
ArmVirtXen.dsc initializes
gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString with with the
value of the variable "FIRMWARE_VER".
Move that functionality to ArmVirt.dsc.inc to make it available to all
ArmVirt packages, and make it conditional: only set the PCD string if
FIRMWARE_VER is actual
Initialize gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString with
with the value of the variable "FIRMWARE_VER", if is is defined. Applies
to all flavors of OvmfPkg.
This behavior is already implemented in ArmVirtXen.dsc. It allows
specifying the firmware version string on the build command
ArmVirtXen.dsc allows setting the firmware version
string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
via FIRMWARE_VER variable conveniently on the build command line.
These two patches add this behavior to all .dsc files in ArmVirtPkg
and OvmfPkg.
PR: https://github.com/tianocore/
New code should use the C99 macro __func__ instead of the pre-Standard
macro __FUNCTION__. Update PatchCheck.py to reject patches with the
latter.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/BaseTools/Scripts/PatchChec
On 4/13/23 01:05, Gerd Hoffmann wrote:
Hi,
Specifying both OVMF_CODE.fd and OVMF_VARS.fd generates an ASSERT.
Both as pflash I assume? Which assert?
Yes, both as pflash. I've never attempted to run an SEV guest using the
-bios option.
The assert is:
ASSERT [PlatformPei]
/root/kernels/
From: Pierre Gondois
Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
processing the library constructors of:
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
JunoPciHostBridgeLib.inf::HWPciRbInit() returns an error code
as Juno-r0 doesn't support PCIe.
Check Juno's revisi
Building with clang 14 on Ubuntu 22.04 fails.
"make CC=clang CXX=clang++ -C BaseTools" causes the following errors:
...
clang++ -o ../bin/VfrCompile AParser.o DLexerBase.o ATokenBuffer.o
EfiVfrParser.o VfrLexer.o VfrSyntax.o VfrFormPkg.o VfrError.o
VfrUtilityLib.o VfrCompiler.o -L../libs -l
On Thu, Apr 13, 2023 at 1:27 PM Oliver Steffen wrote:
> Switch to the new Fedora-37 CI docker image, and with it to gcc12, for
> Linux jobs.
>
> v2:
> Use latest image (no relevant functional changes).
>
> v1:
> Initial version.
>
> Oliver Steffen (1):
> CI: Use Fedora-37 (gcc12) image for Li
Switch to the new Fedora-37 CI docker image, and with it to gcc12, for
Linux jobs.
Signed-off-by: Oliver Steffen
Reviewed-by: Sunil V L
Reviewed-by: Michael Kubacki
Reviewed-by: Rebecca Cran
---
.azurepipelines/templates/defaults.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Switch to the new Fedora-37 CI docker image, and with it to gcc12, for
Linux jobs.
v2:
Use latest image (no relevant functional changes).
v1:
Initial version.
Oliver Steffen (1):
CI: Use Fedora-37 (gcc12) image for Linux jobs
.azurepipelines/templates/defaults.yml | 2 +-
1 file changed, 1
W dniu 7.04.2023 o 17:29, Marcin Juszkiewicz pisze:
Changes since v4:
- functions to read system registers are renamed and moved to ArmLib
Marcin Juszkiewicz (2):
ArmLib: add functions to read system registers
add ArmCpuInfo EFI application
ArmPkg/ArmPkg.dsc
Hi Tom,
Thank you for your help with testing.
For the build failure, it's because that the CpuPageTableLib instance is added
into OvmfPkg DSC in the last pacth ' OvmfPkg: Add CpuPageTableLib required by
PiSmmCpuDxe'. I have moved this patch to the head of the patch set.
For the boot failure, I
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
.../Source/C/Include/AArch64/ProcessorBind.h | 148 --
.../Source/C/Include/Arm/ProcessorBind.h | 147 --
.../Source/C/Include/Ia32/ProcessorBin
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
.../C/Include/IndustryStandard/PeImage.h | 790 --
1 file changed, 790 deletions(-)
delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeIma
Use the MdePkg version instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
Acked-by: Sunil V L
---
.../Source/C/Include/IndustryStandard/Acpi.h | 117 ---
.../C/Include/IndustryStandard/Acpi1_0.h | 285
.../C/Include/IndustryStandard/Acpi2_0.h | 520
Use the MdePkg versions instead of maintaining a copy in BaseTools.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/EfiRom/EfiRom.h| 4 +-
.../C/Include/IndustryStandard/Bluetooth.h| 56 --
.../C/Include/IndustryStandard/EfiPci.h | 51 --
...emoryMappedConfiguration
The #define for IMAGE_FILE_MACHINE_ARM is not present in MdePkg,
this looks like a relic not used any more. Remove.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Common/BasePeCoff.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/BaseTools/Sour
Use the newer versions of the machine #defines.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Chao Li
---
BaseTools/Source/C/EfiRom/EfiRom.h| 10 ++---
.../C/Include/IndustryStandard/PeImage.h | 1 +
BaseTools/Source/C/Common/BasePeCoff.c| 28 ++---
BaseTools/Sourc
There is alot of code duplication between BaseTools and MdePkg (and also
MdeModulePkg). This patch series starts reducing this by removing some
header files. BaseTools are switched over to use the include files in
MdePkg instead. It also cleans up some (apparently) obsolete code and
adapts BaseT
Appears to be a relic for ancient windows / compiler versions,
windows builds in CI work just fine without it.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Common/WinNtInclude.h| 66 -
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 1 -
BaseTools/Source/C/GenFw/Elf
The BaseTools and MdePkg versions of PeImage.h diverged over time,
add some missing bits to the MdePkg header file in preparation for
removing the BaseTools version.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Include/IndustryStandard/PeImage.h | 31 +++
1 file changed, 31 insert
Setting visibility to hidden can cause linker errors when BaseTools are
linked against standard libraries.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Include/X64/ProcessorBind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/X64/ProcessorBind.h
b/MdePkg/Include/
Allows for BaseTools-specific tweaks in include files.
Signed-off-by: Gerd Hoffmann
---
BaseTools/Source/C/Makefiles/header.makefile | 3 +++
BaseTools/Source/C/Makefiles/ms.common | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/Makefiles/header.
Hi Sunil,
Sorry to remind, do we need one more reviewer for it? Or you can help to
merge it now?
BR,
Evan
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sunil V L
Sent: Thursday, April 6, 2023 1:32 PM
To: devel@edk2.groups.io; Chai, Evan
Subject: Re: [edk2-devel] [PATC
35 matches
Mail list logo
