From: Minh Nguyen
In FailSafe context, there's one field to indicate which setting is using
to boot (BOOT_LAST_KNOWN_SETTINGS, BOOT_DEFAULT_SETTINGS, BOOT_NORMAL).
At SCP and ATF side, they will check their NVPARAM for Failsafe
(NV_SI_PMPRO_FAILURE_FAILSAFE - NV_SI_ATF_FAILURE_FAILSAFE) to decid
All,
Can you check if the meeting time is ok for you?
It will be in this week:
* PDT Wednesday 07:00
* Paris Wednesday 16:00
* Shanghai Wednesday 22:00
From: devel@edk2.groups.io on behalf of Taylor Beebe
Sent: Thursday, May 11, 2023 0:10
To: devel@edk2
On Tue, May 16, 2023 at 2:46 AM gaoliming via groups.io
wrote:
>
> Pedro:
>
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Pedro Falcato
> > 发送时间: 2023年5月15日 23:15
> > 收件人: devel@edk2.groups.io
> > 抄送: Pedro Falcato ; Michael D Kinney
> > ; Liming Gao ;
> > Zhiguang Liu ; Marvin Häuser
> >
Simplify ALIGN_VALUE and ALIGN_VALUE_ADDEND into simpler expressions.
ALIGN_VALUE can simply be a (value + (align - 1)) & ~align
expression, which works for any power of 2 alignment and generates
smaller code sequences. For instance:
ALIGN_VALUE(15, 16) = (15 + 15) & ~16 = 16
ALIGN
Few issues are submitted this week. I will cancel the meeting.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Group Notification
发送时间: 2023年5月16日 9:30
收件人: devel@edk2.groups.io
主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, May 16,
2023 #cal-reminder
Reminder: TianoC
Pedro:
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Pedro Falcato
> 发送时间: 2023年5月15日 23:15
> 收件人: devel@edk2.groups.io
> 抄送: Pedro Falcato ; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu ; Marvin Häuser
>
> 主题: [edk2-devel] [PATCH v2 1/1] MdePkg/Base.h: Simply alignment
> expressions
>
>
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, May 16, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4
Wendy:
I agree this is bug fix in PeiCore to support more than one FV images those
all have apriori list.
If no other comments, I will merge it for this stable tag 202305.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wendy Liao
> via groups.io
> 发送时间: 2023年5月15日 13:18
> 收件
Giri:
Edk2 CI enables SpellCheck. Seemly, those typos are not detected by CI. So, I
want to confirm which tool do you use.
This patch is good. But, the first changes the existing MACRO name. I am not
sure whether there is any code impact.
Thanks
Liming
> -邮件原件-
> 发件人: Giri Mudusuru
I've been starting to use the build_bios.py script in Platform\Intel in
edk2-platforms to build images for my UpXtreme board.
In my Windows installation, it's complaining that PYTHON_HOME /
PYTHONHOME isn't set - but I'm not sure why it expects that because
python.exe is in my %PATH% and so co
Add PCD to control if modules with start addresses in PE/COFF > 0x10
attempt to load at specified address.
If a module has an address in this range and there is untested memory
DxeCore will attempt to promote all memory to tested which bypasses any
memory testing that would occur later in boot.
*Tools, CI, Code base construction meeting series*
*When:*
Monday, May 15, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890534 )
*Description:*
TianoCore communit
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, May 15, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890534 )
*Description:*
TianoCor
Thank you Aryeh.
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, May 10, 2023 8:58 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Yao, Jiewen ;
> Sinha, Ankit
Reviewed-by: Isaac Oram
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Sunday, May 14, 2023 10:54 PM
To: devel@edk2.groups.io; Dong, Eric ; Oram, Isaac W
; Gao, Liming ; Chaganty,
Rangasai V ; Desimone, Nathaniel L
Cc: Rebecca Cran
Subject: [edk2-devel
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Ke, VincentX
> Sent: Thursday, May 11, 2023 3:00 AM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Sinha, Ankit
> Subject: [PATCH v7] MinPlatfo
Update the TF-A binaries to have FEAT_FGT support.
This support was merged into TF-A:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/19459
This allows SBSA Reference Platform to boot Linux on "max" cpu.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/Sbsa/Readme.md | 31 +
Thanks Liming!
> -Original Message-
> From: gaoliming
> Sent: Sunday, May 14, 2023 6:01 PM
> To: devel@edk2.groups.io; Chiu, Chasel ; Guo, Gua
>
> Cc: 'Andrew Fish' ; 'Leif Lindholm'
> ; Kinney, Michael D
> Subject: 回复: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewers
> an
Update the list of submodules used in EDK II, since several have been
added in recent years.
Signed-off-by: Rebecca Cran
---
ReadMe.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ReadMe.rst b/ReadMe.rst
index 56bf928cdf1b..cad7d5c5a314 100644
--- a/ReadMe.rst
+++ b/ReadMe.rst
@@ -
The Python-2.0 license is now at
https://opensource.org/license/pythonsoftfoundation-php/ .
Update ReadMe.rst to fix the link.
Signed-off-by: Rebecca Cran
---
ReadMe.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ReadMe.rst b/ReadMe.rst
index c1010b38ccd3..9ef1d432eca6
Improve some of the grammar in ReadMe.rst.
Signed-off-by: Rebecca Cran
---
ReadMe.rst | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ReadMe.rst b/ReadMe.rst
index 9ef1d432eca6..56bf928cdf1b 100644
--- a/ReadMe.rst
+++ b/ReadMe.rst
@@ -243,8 +243,8 @@ Definitions f
Make some improvements to ReadMe.rst:
- Avoid a potential redirect from http to https.
- Fix Python-2.0 license link.
- Improve grammar in a couple of paragraphs.
- Update the list of submodules.
Rebecca Cran (4):
ReadMe.rst: Update link to tianocore.org to use https
ReadMe.rst: Fix link to P
Update the link to tianocore.org to use https and avoid a potential
redirect from http to https.
Signed-off-by: Rebecca Cran
---
ReadMe.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ReadMe.rst b/ReadMe.rst
index ed1d4822459b..c1010b38ccd3 100644
--- a/ReadMe.rst
+++ b/R
I wasn’t aware of the history, so I agree with keeping it.
—
Rebecca Cran
On Mon, May 15, 2023, at 9:29 AM, Pedro Falcato wrote:
> On Mon, May 15, 2023 at 4:20 PM Marvin Häuser wrote:
>>
>> Well, I explicitly added this macro as a prerequisite to code used in our
>> new PE library (remember th
On Mon, May 15, 2023 at 4:20 PM Marvin Häuser wrote:
>
> Well, I explicitly added this macro as a prerequisite to code used in our new
> PE library (remember this patch was initially sent in 2021). We still require
> it downstream, but obviously upstream is not interested in the related
> contr
+CC Mike Kinney
Please use BaseTools/Scripts/GetMaintainers.py in the future to get
the correct CC's for your patches!
On Mon, May 15, 2023 at 3:34 PM Marcin Juszkiewicz
wrote:
>
> At Linaro I work on sbsa-ref, know direction it goes.
>
> May not get code details each time.
>
> Signed-off-by: Mar
Well, I explicitly added this macro as a prerequisite to code used in our new
PE library (remember this patch was initially sent in 2021). We still require
it downstream, but obviously upstream is not interested in the related
contributions that were to follow at the time.
Gerd picked it up bec
On 5/15/23 08:45, Pedro Falcato wrote:
-#define ALIGN_VALUE_ADDEND(Value, Alignment) (((Alignment) - (Value)) &
((Alignment) - 1U))
+#define ALIGN_VALUE_ADDEND(Value, Alignment) ((~(Value)) & ((Alignment) - 1U))
/**
Rounds a value up to the next boundary using a specified alignment.
Simplify ALIGN_VALUE and ALIGN_VALUE_ADDEND into simpler expressions.
ALIGN_VALUE can simply be a (value + (align - 1)) & ~align
expression, which works for any power of 2 alignment and generates
smaller code sequences. For instance:
ALIGN_VALUE(15, 16) = (15 + 15) & ~16 = 16
ALIGN
Simplify ALIGN_VALUE and ALIGN_VALUE_ADDEND into simpler expressions.
ALIGN_VALUE can simply be a (value + (align - 1)) & ~align
expression, which works for any power of 2 alignment and generates
smaller code sequences. For instance:
ALIGN_VALUE(15, 16) = (15 + 15) & ~16 = 16
ALIGN
At Linaro I work on sbsa-ref, know direction it goes.
May not get code details each time.
Signed-off-by: Marcin Juszkiewicz
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 24918d1c6ede..d1d75fe6c940 100644
--- a/Maintainers.txt
+++
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: Nickle Wang
Sent: Monday, May 15, 2023 12:25 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: Fix string
assert issue
**CAUTION: The e-mail below is f
On 5/15/23 07:22, Pedro Falcato wrote:
As I mentioned on Discord, ALIGN16 should not need a branch like this.
I propose switching ALIGN16 to use ALIGN_VALUE, or if you need compat
with older edk2s, even:
#define ALIGN16(size) (((size) + 15) & -16)
Which is a common enough pattern that
The IS_ALIGNED macro defined in PlatformBoardConfig.h conflicts with the
definition from MdePkg/Include/Base.h.
Since the definitions in CometlakeOpenBoardPkg and
WhiskeylakeOpenBoardPkg aren't used, delete them.
Signed-off-by: Rebecca Cran
---
Platform/Intel/CometlakeOpenBoardPkg/CometlakeURv
The following include files appear to be unused, since the build system
uses the corresponding files under WhiskeylakeOpenBoardPkg/Include
instead:
WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformHookLib.h
WhiskeylakeOpenBoardPkg/UpXtreme/Include/Library/PeiPlatformLib.h
WhiskeylakeOpe
Delete the ALIGN16 macro definitions in
Platform/Intel/{WhiskeylakeOpenBoardPkg,CometlakeOpenBoardPkg} since
they were causing a build breakage since March, and aren't used anymore.
Delete include files in WhiskeylakeOpenBoardPkg which appear to be unused.
Changes from v1 to v2
=
Thanks. For the series:
Reviewed-by: Rebecca Cran
On 5/15/23 07:47, Marcin Juszkiewicz wrote:
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
Version 0.0 (QEMU 8.0) provides platform version information.
Version 0.1 (in review) provides
Qemu has versioning for sbsa-ref platform. TF-A reads data from provided
DeviceTree and provides as SMC.
This change adds reading GIC base addresses into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 30 +++
.../SbsaQemuPlatformDxe.i
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 ++
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
Version 0.0 (QEMU 8.0) provides platform version information.
Version 0.1 (in review) provides GIC information.
Next versions will bring more changes to make use of development done
during last
W dniu 15.05.2023 o 15:14, Rebecca Cran pisze:
On 5/15/23 04:24, Marcin Juszkiewicz wrote:
+ /* If we are on platform version 0.0 then there is no more data for
us in DeviceTree */
+ if ((Arg0 == 0) & (Arg1 == 0))
+ {
+ return EFI_SUCCESS;
+ }
Should that be "&&" instead of "&"?
Ops
On Mon, May 15, 2023 at 6:43 AM Rebecca Cran wrote:
>
> The IS_ALIGNED macro defined in PlatformBoardConfig.h conflicts with the
> definition from MdePkg/Include/Base.h. Delete it, and switch to
> ADDRESS_IS_ALIGNED.
>
> Signed-off-by: Rebecca Cran
> ---
>
> Platform/Intel/WhiskeylakeOpenBoardP
On 5/15/23 04:24, Marcin Juszkiewicz wrote:
+ /* If we are on platform version 0.0 then there is no more data for us in
DeviceTree */
+ if ((Arg0 == 0) & (Arg1 == 0))
+ {
+return EFI_SUCCESS;
+ }
Should that be "&&" instead of "&"?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.
On 5/15/23 04:24, Marcin Juszkiewicz wrote:
+ Result = ArmCallSmc0 (SIP_SVC_VERSION, &Arg0, &Arg1, NULL);
+ if (Result == SMC_ARCH_CALL_SUCCESS)
+ {
+Result = PcdSet32S (PcdPlatformVersionMajor, Arg0);
+ASSERT_EFI_ERROR (Result);
+Result = PcdSet32S (PcdPlatformVersionM
Hi Liming,
Merged https://github.com/tianocore/edk2/pull/4397
Thank you.
Best Regards,
Wendy Liao
Insyde Software Corp.
Phone: +886-2-6608-3688 Ext.8731
gaoliming 於 2023/05/11 上午 10:53 寫道:
Wendy:
I understand the problem now. Your fix is correct. Reviewed-by: Liming Gao
This is a bug
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 13 May 2023 18:03
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 1/2] ManageabilityPk
[AMD Official Use Only - General]
Reviewed-by: Abdul Lateef Attar
-Original Message-
From: Chang, Abner
Sent: 12 May 2023 15:28
To: devel@edk2.groups.io
Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang ; Tinh Nguyen
Subject: [edk2-platforms][PATCH 1/2] ManageabilityPk
Hi Ard,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/05/2023, 13:09, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
On Tue, 25 Apr 2023 at 18:05, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
>
> Add ArmCcaDxe for early DXE phas
Hi Ard,
Thank you for the feedback.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/05/2023, 12:39, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
>
> The monitor call conduit is fixed
Hi Ard,
Thank you for the feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/05/2023, 12:33, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
>
> Although Kvmtool supports a CFI f
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c
Qemu has versioning for sbsa-ref platform. TF-A reads data from provided
DeviceTree and provides as SMC.
This change adds reading GIC base addresses into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 30 +++
.../SbsaQemuPlatformDxe.i
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
Version 0.0 (QEMU 8.0) provides platform version information.
Version 0.1 (in review) provides GIC information.
Next versions will bring more changes to make use of development done
during last
[AMD Official Use Only - General]
Thanks for addressing my concerns.
Reviewed-by: Abner Chang with below issues addressed.
1. "__FUNCTION__" to "__func__" in debug macro.
2. The description of parameter JsonWithAddendum may confuse user.
>+/**
>+ This function calls EDKII_REDFISH_RESOURCE_ADD
Thanks for your review comments, Abner! Updated in version 2 patch-set.
Regards,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Monday, May 15, 2023 11:20 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
> Subject: RE: [edk2-redfish-client][PATCH 2/3] Redfis
Bios feature driver utilizes RedfishAddendumLib and get additional data
before sending BIOS attributes to Redfish service.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 2 +
.../Include/RedfishResourceCommon.h |
Implement RedfishAddendumLib to support Redfish Resource Addendum Protocol.
Feature driver calls this library to get addendum data before providing
data to Redfish service
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 +-
Introduce Redfish Resource Addendum Protocol to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data that is required by BMC to manage Redfish BIOS service.
Signed-off
v2:
Update protocol and library function description.
v1:
Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data th
59 matches
Mail list logo
