Re: [edk2-devel] [Patch V4 07/15] UefiCpuPkg/PiSmmCpuDxeSmm: Add 2 function to disable/enable CR0.WP

2023-05-19 Thread Kun Qin
Hi Dun, Thanks for the notice on the other thread (v4 04/15). I have a few more questions on this specific patch (and a few associated commits related to it): Why would we allow page table manipulation after `mIsReadOnlyPageTable` is evaluated to TRUE? As far as I can tell, `mIsReadOnlyPag

Re: 回复: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update edk2 pip modules

2023-05-19 Thread Michael D Kinney
Hi Liming, The subject line is not tagged edk2-stable202305, but I think that is the intent. I have no objections to merging this into edk2-stable202305. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, May 19, 2023 5:50 PM > To: de

Re: 回复: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update edk2 pip modules

2023-05-19 Thread Michael Kubacki
I rebased the commit and added Mike's R-b in the PR. https://github.com/tianocore/edk2/pull/4401 On 5/17/2023 9:01 PM, Michael D Kinney wrote: Reviewed-by: Michael D Kinney -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, May 17, 2023 5:50

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-05-19 Thread Ard Biesheuvel
On Fri, 19 May 2023 at 18:32, Oliver Steffen wrote: > > > Hi all, > > I had another look at this and I can now reproduce the issue consistently, > with a quite minimal setup, on recent Linux kernel, Qemu, and EDK2. > It requires rebooting the guest in a tight loop. It happens in silent > and verbo

Re: [edk2-devel] Now: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 - Wednesday, May 17, 2023 #cal-notice

2023-05-19 Thread Taylor Beebe
A summary email containing the presentation, supplementary files, and next steps will go out on Monday to avoid the thread getting buried over the weekend. Thanks for your patience :) On 5/19/2023 1:10 PM, Sheng Lean Tan wrote: This was a good sharing! May I know where can I get the presentat

Re: [edk2-devel] Now: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 - Wednesday, May 17, 2023 #cal-notice

2023-05-19 Thread Sheng Lean Tan
This was a good sharing! May I know where can I get the presentation slides? Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105085): https://edk2.groups.io/g/devel/message/105085 Mute This Topic: https://groups.io/mt/98948349/2165

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-05-19 Thread Oliver Steffen
Quoting Oliver Steffen (2023-03-02 14:29:43) > On Thu, Mar 2, 2023 at 11:50 AM Ard Biesheuvel <[1]a...@kernel.org> wrote: > > On Thu, 9 Feb 2023 at 16:15, Ard Biesheuvel <[2]a...@kernel.org> wrote: > > > > On Tue, 7 Feb 2023 at 13:58, Oliver Steffen <[3]ostef...@redhat.com> > wrote:

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-19 Thread Andrew Fish via groups.io
I don’t think the atomic is going to help. The compiler honored the volatile by doing a read, but assumed it would never change due to scoping. As you can see in my example if the compiler thinks DeadLoopCount can be changed it will put the check back in and assume the function can return. So an

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-19 Thread Rebecca Cran
I've submitted a bug report at https://developercommunity.visualstudio.com/t/x64-codegen-with-optimizations-wrong-for/10369557 . -- Rebecca Cran On 5/19/23 09:31, Rebecca Cran wrote: Just to add more data, I also tried with "volatile sig_atomic_t" as someone suggested and both "/volatile:i

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-19 Thread Rebecca Cran
Just to add more data, I also tried with "volatile sig_atomic_t" as someone suggested and both "/volatile:iso" and "/volatile:ms" with no change in results. -- Rebecca Cran On 5/18/23 20:53, Ni, Ray wrote: I think all the options we considered are workarounds. These might break again if

[edk2-devel] [PATCH v2 2/5] ArmVirtPkg: Define variables for emulating runtime variables

2023-05-19 Thread Sami Mujawar
Kvmtool allows guest VMs to be launched with or without a CFI flash device. When the kvmtool option '--flash ' is used to launch a guest VM a CFI flash device maps the flash file that was specified at the command line. The NorFlash driver uses this flash as the variable storage backend. However,

[edk2-devel] [PATCH v2 4/5] ArmVirtPkg: Dispatch variable service if variable emulation is enabled

2023-05-19 Thread Sami Mujawar
The VariableRuntimeDxe links with NvVarStoreFormattedLib which is required to establish the dependency on OvmfPkg\VirtNorFlashDxe. The VirtNorFlashDxe installs the gEdkiiNvVarStoreFormattedGuid to indicate it has finished initialising the flash variable storage and that the variable service can be

[edk2-devel] [PATCH v2 1/5] ArmPkg: Configure PcdEmuVariableNvModeEnable as a dynamic PCD

2023-05-19 Thread Sami Mujawar
The PCD gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable indicates if a variable driver will emulate the variable NV mode. This PCD is defined as [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]. Some firmware builds may define this PCD as a dynamic PCD and initialise

[edk2-devel] [PATCH v2 5/5] ArmVirtPkg/PrePi: Allocate separate stack for Dxe phase

2023-05-19 Thread Sami Mujawar
The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard" enabled stack overflow detection for ArmVirtPkg. Following this patch, running UEFI shell command 'dmpstore' resulted in a crash indicating a stack overflow. Invoking 'dmpstore' results in recursive calls to CascadeProcessVariables () which ap

[edk2-devel] [PATCH v2 0/5] ArmVirtPkg: Add dynamic CFI flash detection for Kvmtool guests

2023-05-19 Thread Sami Mujawar
Kvmtool allows guest VMs to be launched with or without a CFI flash device. The guest hardware configuration can be seen in the device tree that Kvmtool hands off to the guest firmware. Therefore, add support to dynamically detect if a CFI flash device is present. If CFI is present use the NorFlas

[edk2-devel] [PATCH v2 3/5] ArmVirtPkg: Fallback to variable emulation if no CFI is found

2023-05-19 Thread Sami Mujawar
The kvmtool option '--flash ' is used to launch a guests VM with a CFI flash device that maps the flash file specified at the command line. However, kvmtool allows guest VMs to be launched without a CFI flash device. In such scenarios the firmware can utilize the emulated variable storage for UEFI

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

2023-05-19 Thread Pedro Falcato
On Thu, May 18, 2023 at 4:16 PM Ranbir Singh wrote: > > FspData->PerfIdx is getting increased for every call unconditionally > in the function SetFspMeasurePoint and hence memory access can happen > for out of bound FspData->PerfData[] array entries also. > > Example - >FspData->PerfData is an

[edk2-devel] [PATCH v8] MinPlatformPkg: Update HWSignature filed in FACS

2023-05-19 Thread VincentX Ke
From: VincentX Ke REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428 Calculating CRC based on each ACPI table. Update HWSignature filed in FACS based on CRC while ACPI table changed. Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c Signed-off-by: VincentX Ke Cc: Chasel Chiu Cc: Nate

[edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/VariableSmm.c: add Ap rendezvous check before SmmSetVariable.

2023-05-19 Thread gaoliming via groups.io
Ray and Gerd: Can you give the comments for this change? Thanks Liming > -邮件原件- > 发件人: Li, Zhihao > 发送时间: 2023年5月19日 16:11 > 收件人: Gao, Liming ; devel@edk2.groups.io; Ni, > Ray ; kra...@redhat.com > 抄送: Wang, Jian J > 主题: RE: [PATCH v1 1/1] MdeModulePkg/VariableSmm.c: add Ap rendezvous

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/VariableSmm.c: add Ap rendezvous check before SmmSetVariable.

2023-05-19 Thread Li, Zhihao
Hi Liming In Ap-Relaxed mode, Bsp will not wait for all ap arrive and call the SMI handlers. But some SMI handlers need all Aps arrive in smm mode such as SmmSetVariable. As the design, SetVariable need to let all aps arrive because it will write flash. Half year ago, I send the patch that call