Re: [edk2-devel] [PATCH 1/1] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: refine flash detection

On Thu, May 25, 2023 at 05:53:27PM +0200, Ard Biesheuvel wrote: > On Tue, 2 May 2023 at 07:59, Gerd Hoffmann wrote: > > > > Check whenever flash is actually writable. > > > > This is a bit too terse. Could you explain why this is needed, and why > this approach is suitable? Flash can be write-pr

Re: [edk2-devel] [PATCH v10] MinPlatformPkg: Update HWSignature field in FACS

Thanks for review and merge. -Original Message- From: Chiu, Chasel Sent: Wednesday, May 31, 2023 1:38 PM To: Ke, VincentX ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric ; Sinha, Ankit ; Ni, Ray Subject: RE: [PATCH v10] MinPlatformPkg: Upda

Re: [edk2-devel] [PATCH v10] MinPlatformPkg: Update HWSignature field in FACS

Patch merged: https://github.com/tianocore/edk2-platforms/commit/1a7bd150d39007bfb72c4727feda3184c23efe96 Thanks, Chasel > -Original Message- > From: Ke, VincentX > Sent: Tuesday, May 30, 2023 7:48 PM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Chiu, Chasel > ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH v10] MinPlatformPkg: Update HWSignature field in FACS

Reviewed-by: Ray Ni thanks, ray From: devel@edk2.groups.io on behalf of VincentX Ke Sent: Wednesday, May 31, 2023 10:48:06 AM To: devel@edk2.groups.io Cc: Ke, VincentX ; Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Gao, Liming ; Dong, Eric ; Sinha

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

Thanks, the code changes look good to me. May I know what tests have been performed for the patch? Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Neo > Hsueh via groups.io > Sent: Wednesday, May 24, 2023 1:07 AM > To: devel@edk2.groups.io > Cc: jianga

[edk2-devel] [PATCH v10] MinPlatformPkg: Update HWSignature field in FACS

From: VincentX Ke REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428 Calculating CRC based on each ACPI table. Update HWSignature field in FACS based on CRC while ACPI table changed. Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c Signed-off-by: VincentX Ke Cc: Chasel Chiu Cc: Nate

Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

4 minor comments. > +if (FadtPtr->XFirmwareCtrl) { 1. you should use "if (FadtPtr->XFirmwareCtrl != 0)" to align with edk2 coding style. > > + CallbackFunction ((EFI_ACPI_COMMON_HEADER > *)(UINTN)FadtPtr->XFirmwareCtrl, TableIndex++, Context); > > +} else { > > +

Re: [edk2-devel] [RFC PATCH 09/10] MdeModulePkg/DxeIpl: Use memory attribute PPI to remap the stack NX

+@Abner Chang and @Tom Lendacky > -Original Message- > From: Tan, Dun > Sent: Tuesday, May 30, 2023 6:25 PM > To: Ni, Ray ; Ard Biesheuvel ; > devel@edk2.groups.io > Cc: Yao, Jiewen ; Gerd Hoffmann > ; Taylor Beebe ; Oliver Smith- > Denny ; Bi, Dandan ; Gao, > Liming ; Kinney, Michael D >

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, May 30, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, May 30, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4

Re: [edk2-devel] [Patch v2 0/3] Address C++ keyword collisions

Reviewed-by: Jiewen Yao Hi Mike Do you think if we can enhance CI to catch such keyword? I don't mean to need it in this patch, but something we could consider later. Thank you Yao, Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Wednes

Re: [edk2-devel] [RFC PATCH 07/10] MdeModulePkg/PeiCore: Apply restricted permissions in image loader

On Tue, 30 May 2023 at 18:51, Oliver Smith-Denny wrote: > > On 5/25/2023 2:29 PM, Ard Biesheuvel wrote: > > On Thu, 25 May 2023 at 19:21, Oliver Smith-Denny > > wrote: > >> > >> On 5/25/2023 7:30 AM, Ard Biesheuvel wrote: > >>> + if (Private->MemoryAttributePpi == NULL) { > >>> > >>> +return

Re: [edk2-devel] [Patch 0/2] Address C++ keyword collisions

Hi Pedro, Great point on bisect. It is also important to provide patches that allow downstream usage of these fields to be able to use a subset of the patches that support both field names so they can update and test their code before using the full patch series that removes the old field name.

[edk2-devel] [Patch v2 0/3] Address C++ keyword collisions

New in v2 == Changes from 2 patches to 3 patches to support bisect. This temporarily uses an anonymous union to allow use of both field name styles. It also allows downstream usage of these fields to sync with the first 2 patches, update their field names, and then sync with last patch.

[edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

Update Tpm12.h and Tpm20.h and not use c++ reserved keywords operator and xor in C structures to support use of these include files when building with a C++ compiler. This patch temporarily introduces an anonymous union to add Operator and Xor fields to support migration from the current field nam

[edk2-devel] [Patch v2 2/3] SecurityPkg/Library/TpmCommandLib: Change xor to Xor

Change xor to Xor to avoid C++ reserved work name collisions when building with C++ compilers. Cc: Jiewen Yao Cc: Jian J Wang Cc: Oliver Smith-Denny Cc: Pedro Falcato Cc: Aaron Pop Signed-off-by: Michael D Kinney --- SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 6 +++--- SecurityPk

[edk2-devel] [Patch v2 3/3] MdePkg/Include/IndustryStandard: Address C++ keyword collisions

Update Tpm12.h and Tpm20.h and not use c++ reserved keywords operator and xor in C structures to support use of these include files when building with a C++ compiler. This patch removes the temporary use of anonymous unions and warning 4201 disable for VS20xx tool chains to complete the following

Re: [edk2-devel] [PATCH v3 7/7] OvmfPkg/RiscVVirt: SEC: Add IO memory resource hob for platform devices

On Mon, May 29, 2023 at 7:07 AM Ard Biesheuvel wrote: > On Sat, 27 May 2023 at 01:18, Tuan Phan wrote: > > > > Normally, DXE driver would add device resource to GCD before start using. > > But some key resources such as uart, flash base address are being > accessing > > directly in some core mod

Re: [edk2-devel] failed Pr

> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, May 30, 2023 8:45 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Sean Brogan ; Rebecca Cran > ; Kubacki, Michael ; Gao, > Liming > Subject: Re: [edk2-devel] failed Pr > > On Tue, 30 May 2023 at 17:36, Kinney, Michael D

Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

Thanks for the reviewing Ankit! It looks to me current version is good enough for merging, if no other feedbacks I will help to merge it tomorrow. Thanks, Chasel > -Original Message- > From: Sinha, Ankit > Sent: Tuesday, May 30, 2023 8:53 AM > To: Ke, VincentX ; devel@edk2.groups.io

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: make GIC base address Pcds dynamic

W dniu 12.05.2023 o 19:57, Leif Lindholm pisze: Currently, the GIC and redistributors base addresses are defined using FixedPcds. In order to enable the QEMU platform to evolve to provide ITS frames, as well as newer versions of the GIC, convert these accesses to Dynamic. Firtsly, this requires

Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

Reviewed-by: Ankit Sinha Thank you, Ankit > -Original Message- > From: Ke, VincentX > Sent: Wednesday, May 24, 2023 1:39 AM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric ; Sinha, Ankit > Subject:

Re: [edk2-devel] failed Pr

On Tue, 30 May 2023 at 17:36, Kinney, Michael D wrote: > > After looking at GitHub Action features the best approach is likely > a PR comment that provides a request to rerun all failed jobs. > > We can define a comment format to indicate a command to a tianocore bot. > Sounds reasonable, althoug

Re: [edk2-devel] [PATCH 1/1] IntelFsp2Pkg/Library/BaseFspCommonLib: Fix OVERRUN Coverity issue

Yes Chasel - please do so while merging, thanks! On Tue, May 30, 2023 at 8:58 AM Chiu, Chasel wrote: > > That’s good suggestion Pedro! > Ranbir, would you like me to modify your patch to "return 0" during > merging? > > Thanks, > Chasel > > > > -Original Message- > > From: devel@edk2.gro

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__ with __func__

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Tuesday, May 30, 2023 12:03 PM To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Tinh Nguyen Subject: [edk2-platforms][PATCH 1/2] Ma

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg: Use DEBUG_MANAGEABILITY

[AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Tuesday, May 30, 2023 12:03 PM To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Tinh Nguyen Subject: [edk2-platforms][PATCH 2/2] Ma

Re: [edk2-devel] failed Pr

After looking at GitHub Action features the best approach is likely a PR comment that provides a request to rerun all failed jobs. We can define a comment format to indicate a command to a tianocore bot. Mike > -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, May 30, 2023 7

Re: [edk2-devel] BaseTools: how to generate PcdValueInit without VS?

Please enter a Tianocore BZ and work with the BaseTools maintainers to evaluate this request. Thanks, Mike From: Yeping Song Sent: Tuesday, May 30, 2023 1:39 AM To: devel@edk2.groups.io; Kinney, Michael D Subject: RE: [edk2-devel] BaseTools: how to generate PcdValueInit without VS? Hi Mike,

Re: [edk2-devel] failed Pr

On Mon, 29 May 2023 at 18:45, Michael D Kinney wrote: > > Hi Sean, > > > > I see the “rerun” button on the “checks” page of GitHub from my login. > > > > We have a mix of both Azure Pipelines and GitHub Actions today, so I think it > is important to see the “rerun” from GitHub view for Maintainer

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue.

Reviewed-by: Igor Kulchytskyy -Original Message- From: Nickle Wang Sent: Monday, May 29, 2023 2:24 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. **CAUTION: The e-mail below is from

Re: [edk2-devel] [RFC PATCH 09/10] MdeModulePkg/DxeIpl: Use memory attribute PPI to remap the stack NX

On Tue, 30 May 2023 at 12:25, Tan, Dun wrote: > > Ray, > I think using MemoryAttribute PPI also looks good for X64 DxeIpl. > The only question that comes to my mind is the AMD sev feature. Since the > MemoryAttribute can't handle the AMD sev feature requirements(remapping ghcb > range from non-1

Re: [edk2-devel] [Patch 0/2] Address C++ keyword collisions

On Mon, May 29, 2023 at 6:06 PM Michael D Kinney wrote: > > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords > operator and xor in C structures to support use of these > include files when building with a C++ compiler. > > Update SecurityPkg Tpm2CommandLib to use updated field names. >

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

> On 30. May 2023, at 12:02, Ard Biesheuvel wrote: > > On Tue, 30 May 2023 at 11:53, Marvin Häuser > wrote: >> >> >> >> On 30. May 2023, at 11:48, Ard Biesheuvel wrote: >> >> On Tue, 30 May 2023 at 11:47, Ard Biesheuvel wrote: >> >> >> On Tue, 30 May 2023 at 1

Re: [edk2-devel] [RFC PATCH 09/10] MdeModulePkg/DxeIpl: Use memory attribute PPI to remap the stack NX

Ray, I think using MemoryAttribute PPI also looks good for X64 DxeIpl. The only question that comes to my mind is the AMD sev feature. Since the MemoryAttribute can't handle the AMD sev feature requirements(remapping ghcb range from non-1:1 mapping to 1:1-mapping), we may need to find an approp

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

On Tue, 30 May 2023 at 11:53, Marvin Häuser wrote: > > > > On 30. May 2023, at 11:48, Ard Biesheuvel wrote: > > On Tue, 30 May 2023 at 11:47, Ard Biesheuvel wrote: > > > On Tue, 30 May 2023 at 11:42, Marvin Häuser wrote: > > > I took a *very brief* look at the entire series now. Is this just to

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

> On 30. May 2023, at 11:48, Ard Biesheuvel wrote: > > On Tue, 30 May 2023 at 11:47, Ard Biesheuvel > wrote: >> >> On Tue, 30 May 2023 at 11:42, Marvin Häuser wrote: >>> >>> On 30. May 2023, at 11:38, Ard Biesheuvel wrote: On Tue, 30 May 2023 at 11:

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

On Tue, 30 May 2023 at 11:47, Ard Biesheuvel wrote: > > On Tue, 30 May 2023 at 11:42, Marvin Häuser wrote: > > > > > > > On 30. May 2023, at 11:38, Ard Biesheuvel wrote: > > > > > > On Tue, 30 May 2023 at 11:07, Marvin Häuser wrote: > > >> > > >> Hi Ard, > > >> > > >> Native PE toolchains *gene

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

On Tue, 30 May 2023 at 11:42, Marvin Häuser wrote: > > > > On 30. May 2023, at 11:38, Ard Biesheuvel wrote: > > > > On Tue, 30 May 2023 at 11:07, Marvin Häuser wrote: > >> > >> Hi Ard, > >> > >> Native PE toolchains *generally* also generate XIP images (/ALIGN = > >> /FILEALIGN, but with 32 Byt

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Platform/Qemu/Sbsa: Update TF-A binaries to enable FEAT_FGT

On Mon, 29 May 2023 at 17:13, Marcin Juszkiewicz wrote: > > W dniu 16.05.2023 o 12:21, Graeme Gregory pisze: > > On Mon, May 15, 2023 at 06:23:30PM +0200, Marcin Juszkiewicz via groups.io > > wrote: > >> Update the TF-A binaries to have FEAT_FGT support. > >> > >> This support was merged into TF-

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

> On 30. May 2023, at 11:38, Ard Biesheuvel wrote: > > On Tue, 30 May 2023 at 11:07, Marvin Häuser wrote: >> >> Hi Ard, >> >> Native PE toolchains *generally* also generate XIP images (/ALIGN = >> /FILEALIGN, but with 32 Byte rather than 64 Byte alignment compared to >> GCC49+ / CLANGDWARF

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

On Tue, 30 May 2023 at 11:07, Marvin Häuser wrote: > > Hi Ard, > > Native PE toolchains *generally* also generate XIP images (/ALIGN = > /FILEALIGN, but with 32 Byte rather than 64 Byte alignment compared to GCC49+ > / CLANGDWARF) [1]. However, because they are underaligned by default (even > f

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

> On 30. May 2023, at 11:06, Marvin Häuser wrote: > > Hi Ard, > > Native PE toolchains *generally* also generate XIP images (/ALIGN = > /FILEALIGN, but with 32 Byte rather than 64 Byte alignment compared to GCC49+ > / CLANGDWARF) [1]. However, because they are underaligned by default (even

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

Hi Ard, Native PE toolchains *generally* also generate XIP images (/ALIGN = /FILEALIGN, but with 32 Byte rather than 64 Byte alignment compared to GCC49+ / CLANGDWARF) [1]. However, because they are underaligned by default (even for RT images that run in an OS context and MM drivers... sigh...)

Re: [edk2-devel] [RFC PATCH 05/11] MdeModulePkg/DxeCore: Use memory mapped FV protocol to avoid image copy

On Tue, 30 May 2023 at 10:41, Ni, Ray wrote: > > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Tuesday, May 30, 2023 3:52 PM > > To: devel@edk2.groups.io; Ni, Ray > > Cc: Yao, Jiewen ; Gerd Hoffmann ; > > Taylor Beebe ; Oliver Smith-Denny > denny.com>; Bi, Dandan ; Gao, Li

Re: [edk2-devel] [RFC PATCH 05/11] MdeModulePkg/DxeCore: Use memory mapped FV protocol to avoid image copy

> -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, May 30, 2023 3:52 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Yao, Jiewen ; Gerd Hoffmann ; > Taylor Beebe ; Oliver Smith-Denny denny.com>; Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Leif Lindholm ; Michael Kubacki >

Re: [edk2-devel] BaseTools: how to generate PcdValueInit without VS?

Hi Mike, Thanks for your comments. According to DscBuildData.py , it only supports VS on windows OS. How can we support Cygwin to compile Pcdvalueinit on windows OS? Thanks Yepings From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: Thursday, May 25, 2023 12:10 AM To: devel@edk2.group

Re: [edk2-devel] [RFC PATCH 09/11] MdeModulePkg/DxeCore: Add PCD NX policy bit for default NX state

On Tue, 30 May 2023 at 08:54, Ni, Ray wrote: > > 1. Do we want to catch a case that platform wrongly sets BIT61 but drivers > run before CpuDxe are not XIP? > 2. Why BIT61 set is the "Default state"? > > The setting of BIT61 is a bit confusing. Is there a way to avoid adding BIT61 > through code

[edk2-devel] [PATCH] SimicsOpenBoard: Use default 10ms as delay between INIT and SIPI

Today the delay is 10us but the QSP simulates the multiprocessor by dividing time into segments and serializing processors within a segment. The length of the segment is configurable and Simics open board is configured using 100us. But the firmware configures the delay between INIT and SIPI is 10u

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

On Tue, 30 May 2023 at 10:02, Ni, Ray wrote: > > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Tuesday, May 30, 2023 3:58 PM > > To: devel@edk2.groups.io; Ni, Ray > > Cc: Yao, Jiewen ; Gerd Hoffmann ; > > Taylor Beebe ; Oliver Smith-Den

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Tuesday, May 30, 2023 3:58 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Yao, Jiewen ; Gerd Hoffmann ; > Taylor Beebe ; Oliver Smith-Denny denny.com>; Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ;

Re: [edk2-devel] [RFC PATCH 08/11] MdeModulePkg/DxeIpl: Relocate and remap XIP capable DXE drivers

On Tue, 30 May 2023 at 08:45, Ni, Ray wrote: > > 1. is it possible that a PE image sits in the right location but the > SectionAlignment is larger than FileAlignment so each section still needs to > be copied to the aligned memory location? > That is a good question. Currently, the ELF toolchai

Re: [edk2-devel] [RFC PATCH 07/11] MdeModulePkg/DxeCore: Execute loaded images in place if possible

On Tue, 30 May 2023 at 08:32, Ni, Ray wrote: > > I didn't review the existing logic carefully. Several comments: > 1. Assignments of several fields are skipped when executing in place. Do they > matter? > a). Image->NumberOfPages > b). Image->ImageBasePage > These are used when freeing t

Re: [edk2-devel] [RFC PATCH 05/11] MdeModulePkg/DxeCore: Use memory mapped FV protocol to avoid image copy

On Tue, 30 May 2023 at 08:21, Ni, Ray wrote: > > GetFileBufferByFilePath() always returns a copy of file buffer even when the > file > is in a memory-mapped device. > So, your patch adds a new implementation (abstracted through the new MM FV > protocol) that can directly return the file location

Re: [edk2-devel] [RFC PATCH 04/11] MdeModulePkg/DxeCore: Avoid caching memory mapped FFS files

On Tue, 30 May 2023 at 08:03, Ni, Ray wrote: > > I don't know why the FFS file is cached. Without knowing the reason of > caching, I cannot say it's good to remove the caching logic. > I will let @Gao, Liming, @Kinney, Michael D to comment. > Fair enought. I found this commit by Start commit e

[edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: Use DEBUG_MANAGEABILITY

From: Abner Chang Use debug print level DEBUG_MANAGEABILITY in RedfishClientPkg. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Include/RedfishBase.h| 2 +- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 10 .../Features/Bios/v1_0_9/Dx

Re: [edk2-devel] [RFC PATCH 01/11] MdeModulePkg/DxeCore: Remove unused 'EntryPoint' argument to LoadImage

On Tue, 30 May 2023 at 07:54, Ni, Ray wrote: > > I really like the code simplification! Just 2 comments below: > > 1. Can you describe the calling flow explicitly in commit message: > CoreLoadImage (public api) -> CoreLoadImageCommon -> CoreLoadPeImage > Ok > 2. You added "static" to CoreLoadI

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

On Tue, 30 May 2023 at 09:15, Ni, Ray wrote: > > 1. > The PPI interface supports to set and clear any attributes with single > invocation. > That's much better than the existing UEFI protocol prototype which requires > caller to call the interfaces > twice to set and clear some attributes. > Ag

Re: [edk2-devel] [RFC PATCH 09/10] MdeModulePkg/DxeIpl: Use memory attribute PPI to remap the stack NX

Looks good. @Tan, Dun, can you please evaluate if using MemoryAttribute PPI, what opens will there be for X64 DxeIpl? > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, May 25, 2023 10:31 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Ni, Ray ; Yao, Jiewen > ; Gerd Hoff

Re: [edk2-devel] [RFC PATCH 05/10] MdeModulePkg: Define memory attribute PPI

1. The PPI interface supports to set and clear any attributes with single invocation. That's much better than the existing UEFI protocol prototype which requires caller to call the interfaces twice to set and clear some attributes. So far I see two patterns for attributes setting: *. The patten

Re: [edk2-devel] [PATCH] RedfishPkg: Use DEBUG_MANAGEABILITY

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, May 30, 2023 3:09 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH] RedfishPkg: Use DEBUG_MANAGEABILITY > > External email: Use caution openin

[edk2-devel] [PATCH] RedfishPkg: Use DEBUG_MANAGEABILITY

From: Abner Chang Use debug print level DEBUG_MANAGEABILITY in RedfishPkg. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/Include/Library/RedfishDebugLib.h | 4 +- .../PlatformHostInterfaceBmcUsbNicLib.c | 22 +- .../RedfishPlatformCredentialIp