[edk2-devel] [PATCH] Maintainers.txt: Remove me from maintainers of UefiPayloadPkg,ShellPkg

Signed-off-by: Ray Ni Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Cc: Zhichao Gao --- Maintainers.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 5209e21449..e40361a0ae 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -592,7

[edk2-devel] [PATCH] Maintainers.txt: Remove UEFI Shell Binaries section

The Shell binaries are not generated anymore in each stable tag release. So, remove the section. Cc: Zhichao Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Ray Ni --- Maintainers.txt | 8 1 file changed, 8 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2-devel] [edk2-rfc] [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg

Hi Vincent, Thanks for your suggestion. I will follow the code-first-process to submit a change request to PI specification. Regards, Nickle > -Original Message- > From: Zimmer, Vincent > Sent: Tuesday, June 6, 2023 11:27 PM > To: r...@edk2.groups.io; Oram, Isaac W ; >

Re: [edk2-devel] [PATCH] Maintainers.txt: Update maintainers for StandaloneMmPkg

Reviewed by: jiewen@intel.com 发件人: Ni, Ray 发送时间: Wednesday, June 7, 2023 11:20:16 AM 收件人: devel@edk2.groups.io 抄送: Ard Biesheuvel ; Sami Mujawar ; Yao, Jiewen ; Supreeth Venkatesh 主题: [PATCH] Maintainers.txt: Update maintainers for StandaloneMmPkg

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

Merged via: PR - https://github.com/tianocore/edk2/pull/4478 Commit - https://github.com/tianocore/edk2/commit/67fc78d026490ea4c375eeb19724abb40e7be8f2 Best Regards, Hao Wu > -Original Message- > From: Wu, Hao A > Sent: Friday, June 2, 2023 11:14 AM > To: He, Jiangang ;

[edk2-devel] [PATCH] Maintainers.txt: Update maintainers for StandaloneMmPkg

Signed-off-by: Ray Ni Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 09d04af27a..9c54800f2f 100644 --- a/Maintainers.txt +++

Re: [edk2-devel] failed pr

Thanks. Below approach works for me: > From Conversation tab, scroll down to the "Some checks were not > successful" > area and scroll down to a check that failed. The select "Details". > that will take you to the specific area of the Checks tab that contains > a failure and the drop down for

Re: [edk2-devel] failed pr

There seems to be multiple views in the checks tab. From Conversation tab, scroll down to the "Some checks were not successful" area and scroll down to a check that failed. The select "Details". that will take you to the specific area of the Checks tab that contains a failure and the drop down

Re: [edk2-devel] [PATCH v1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

> 5th patch register ReadyToBoot callback. But is it too late from security > perspective? Why not lock after SMM core exit? @Yao, Jiewen Agree with Ray. ReadyToBoot is too late. > -Original Message- > From: Zhang, Hongbin1 > Sent: Wednesday, June 7, 2023 10:29 AM > To: Ni, Ray ;

Re: [edk2-devel] [PATCH v1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

Hongbin, The patch is so big. Can you please split the patch to small patches? For example: 1st patch only implements the Ipl entrypoint to find the correct SMRAM range and dump it 2nd patch loads SMM CORE without mode switch if sizeof (UINTN) matches SMM core module type. 3rd patch loads SMM

Re: [edk2-devel] failed pr

Hello Mike, I do not see the "re-run failed jobs" under "Checks" tab for cancelled CI tests: https://github.com/tianocore/edk2/pull/4478 (Only "Re-run all checks" is found) What should be done to handle such case? Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors

[AMD Official Use Only - General] To the entire series: Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, June 6, 2023 8:32 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH v2 0/9] Fix

Re: [edk2-devel] [PATCH] RedfishPkg: update Readme.md

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, June 5, 2023 10:41 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [PATCH] RedfishPkg: update Readme.md > > Caution: This message

Re: [edk2-devel] 回复: [PATCH v1 0/3] Adding Statuc Code Definitions from PI Spec v1.8

Hi Liming/Jiewen, Do you mind helping merging this patch series? It has collected necessary reviewed-by tags already: https://edk2.groups.io/g/devel/message/105602 https://edk2.groups.io/g/devel/message/105609 Please let me know if it is preferable for me to add the garner and send a v2.

Re: [edk2-devel] [PATCH v1 1/1] UnitTestFrameworkPkg: UnitTestPersistenceLib: Save Unit Test Cache to Drive

Hi Mike, I reworked the patch and sent a v2 here: https://edk2.groups.io/g/devel/message/105827 Note that I did not end up putting the shell based argument checks in UnitTestLib.inf because that library has multi-phase support. Adding Shell argument checks will break it unless we add more

[edk2-devel] [PATCH v2 1/1] UnitTestFrameworkPkg: UnitTestPersistenceLib: Save Unit Test Cache Option

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467 Current implementation of UnitTestFrameworkPkg for shell-based unit test will save the unit test cache to the same volume as the test application itself. This works as long as the test application is on a writable volume, such as USB or EFI

[edk2-devel] [PATCH v2 0/1] Add support for running shell test application in an immutable volume

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4467 This is a follow-up of a previously submitted patch series based on top of master branch: https://edk2.groups.io/g/devel/message/105514. The main changes between v1 and v2 patch are: - Added input argument support at library entrypoint.

[edk2-devel] Using Depex for Standalone MM drivers on ARM

Hi all, We found an issue a while back on ARM systems, where the Standalone MM drivers with Depex specified will run into a hang when TFA hands off to Standalone MM core. (https://bugzilla.tianocore.org/show_bug.cgi?id=3883) After some debugging, the logic in the ticket still seems to be true

[edk2-devel] [PATCH] OvmfPkg: RiscVVirt: Fix network drivers not be built

Only need to include Network.dsc.inc to have all network drivers/components be built. Otherwise, there were missing definition that prevent them from be built for RiscVVirt platform. Signed-off-by: Tuan Phan --- OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 15 +-- 1 file changed, 1

Re: [edk2-devel] [PATCH v2 2/7] MdeModulePkg/DxeIpl: Merge EBC, RISCV64 and LOONGARCH code

On Tue, 6 Jun 2023 at 20:48, Michael Kubacki wrote: > > On 6/2/2023 11:17 AM, Ard Biesheuvel wrote: > > The Risc-V and LoongArch specific versions of the DXE core handoff code > > in DxeIpl are essentially copies of the EBC version (modulo the > > copyright in the header and some debug prints in

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: RISC-V: TimerLib: Fix delay function to use 64-bit

On Tue, Jun 6, 2023 at 10:10 AM Sunil V L wrote: > On Tue, Jun 06, 2023 at 10:02:08AM -0700, Tuan Phan wrote: > > On Tue, Jun 6, 2023 at 3:27 AM Sunil V L > wrote: > > > > > On Fri, May 26, 2023 at 04:25:18PM -0700, Tuan Phan wrote: > > > > The timer compare register is 64-bit so simplifying

Re: [edk2-devel] failed pr

On Tue, 6 Jun 2023 at 21:55, Kinney, Michael D wrote: > > All EDK II Maintainers should now have permissions to "re-run failed jobs". > > If you see a PR with failed jobs that are not related to the code change, > then try rerunning the specific failed job or select "re-run failed jobs" > from

Re: [edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

Hi Pedro, Yes, this is. I will be sending more patches over the next few days to add support for Intel Alderlake platform in edk2-platforms. Thanks, Saloni -Original Message- From: Pedro Falcato Sent: Tuesday, June 6, 2023 1:59 PM To: devel@edk2.groups.io; Kasbekar, Saloni Cc:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Add SpeculationBarrier implementation for RiscV64

Merged Mike > -Original Message- > From: Li, Yong > Sent: Monday, June 5, 2023 12:45 AM > To: devel@edk2.groups.io; suni...@ventanamicro.com; Kinney, Michael D > ; Gao, Liming > Cc: Warkentin, Andrei ; Chai, Evan > ; Tuan Phan > Subject: Re: [edk2-devel] [PATCH v2 1/1]

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

On Tue, Jun 6, 2023 at 6:57 PM Michael D Kinney wrote: > > Hi Pedro, > > Based on this info, would you prefer we use xor_ style instead of Xor? > > I can update the PR with that change. > > Mike Hi Mike, Sorry, I didn't know you were waiting for my input. Yes, I would prefer xor_ style, but I'll

Re: [edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

On Tue, Jun 6, 2023 at 8:41 PM Saloni Kasbekar wrote: > > Adds the following library instances: > AlderlakePRvp/Library/BoardAcpiLib > AlderlakePRvp/Library/BoardInitLib Hi Saloni, Thanks for the patch. Is this part of a larger series? There's no AlderlakeOpenBoardPkg in-tree, and this patch

Re: [edk2-devel] failed pr

All EDK II Maintainers should now have permissions to "re-run failed jobs". If you see a PR with failed jobs that are not related to the code change, then try rerunning the specific failed job or select "re-run failed jobs" from the drop down in top right of "Checks" tab. Please let me know if

Re: [edk2-devel] [PATCH v2] MdePkg ACPI65: Update MADT Revision pre ACPI Spec 6.5

Merged https://github.com/tianocore/edk2/pull/4522 Mike > -Original Message- > From: Kinney, Michael D > Sent: Friday, June 2, 2023 11:10 AM > To: Chen, Aryeh ; devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Yao, Jiewen ; Kinney, > Michael D > Subject: RE: [PATCH v2]

[edk2-devel] [edk2-platforms] AlderlakeOpenBoardPkg/AlderlakePRvp: Add library instances

Adds the following library instances: AlderlakePRvp/Library/BoardAcpiLib AlderlakePRvp/Library/BoardInitLib Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../Library/BoardAcpiLib/BaseAcpiTableLib.c | 30 ++

Re: [edk2-devel] [PATCH v2 2/7] MdeModulePkg/DxeIpl: Merge EBC, RISCV64 and LOONGARCH code

On 6/2/2023 11:17 AM, Ard Biesheuvel wrote: The Risc-V and LoongArch specific versions of the DXE core handoff code in DxeIpl are essentially copies of the EBC version (modulo the copyright in the header and some debug prints in the code). In preparation for introducing a generic PPI based

Re: [edk2-devel] [Patch v2 1/3] MdePkg/Include/IndustryStandard: Add Operator and Xor field names

Hi Pedro, Based on this info, would you prefer we use xor_ style instead of Xor? I can update the PR with that change. Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, June 1, 2023 8:02 AM > To: Pedro Falcato > Cc: devel@edk2.groups.io; Gao, Liming ; Liu, >

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: RISC-V: TimerLib: Fix delay function to use 64-bit

On Tue, Jun 06, 2023 at 10:02:08AM -0700, Tuan Phan wrote: > On Tue, Jun 6, 2023 at 3:27 AM Sunil V L wrote: > > > On Fri, May 26, 2023 at 04:25:18PM -0700, Tuan Phan wrote: > > > The timer compare register is 64-bit so simplifying the delay > > > function. > > > > > > Signed-off-by: Tuan Phan

[edk2-devel] [PATCH 1/1] MdePkg/BaseSynchronizationLib: Fix RISC-V synchronization functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4433 There is a return value bug. SyncIncrement and SyncDecrement functions should return the updated value. But destination register rd in amoadd instruction will not have final incremented value. Fix this by loading the incremented value from

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: RISC-V: TimerLib: Fix delay function to use 64-bit

On Tue, Jun 6, 2023 at 3:27 AM Sunil V L wrote: > On Fri, May 26, 2023 at 04:25:18PM -0700, Tuan Phan wrote: > > The timer compare register is 64-bit so simplifying the delay > > function. > > > > Signed-off-by: Tuan Phan > > --- > > MdePkg/Include/Register/RiscV64/RiscVImpl.h | 1 - > >

Re: [edk2-devel] [PATCH v1 4/8] MdePkg/Rng: Add GUIDs to describe Rng algorithms

Hello, The mantis ticket (created by Jose Marinho) is available at: https://mantis.uefi.org/mantis/view.php?id=2386 Also, are there any comments on the patch-set ? Regards, Pierre On 5/9/23 15:50, Samer El-Haj-Mahmoud wrote: Hi Jiewen, There is an open ECR for UEFI spec review:

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg: Add UnitTestPeiServicesTablePointerLib

It looks like you're following a similar pattern to a library instance already in UnitTestFrameworkPkg/Library like UnitTestUefiBootServicesTableLib. I can't find where these types of libraries are explicitly called out in the UnitTestFrameworkPkg/ReadMe.md file [1]. You don't need to add it

Re: [edk2-devel] [edk2-rfc] [RFC] Introduce new status code for ManageabilityPkg and Redfish*Pkg

I agree. These additions make sense. Perhaps you can format the submission per https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-First-Process in order to have this included in a future UEFI PI specification https://uefi.org/specs/PI/1.8/V3_Status_Codes.html. I can help you w/

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg: Introduce Hii2RedfishBiosDxe driver

Add Hii2RedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg: Introduce Hii2RedfishBootDxe driver

Add Hii2RedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg: Add a sample memory configuration HII driver

This is an HII sample driver of memory configuration. This demonstrates the communication between platform configuration (EDK2/HII) and Redfish service (Memory resource) base on RedfishClientPkg. The language ("x-uef-redfish-*") defined in the Redfish-specific uni file is the connection between

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Introduce HII to Redfish sample drivers

Introduce three sample drivers to demonstrate the way of providing Redfish attributes in HII provider driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (3): RedfishClientPkg: Add a sample memory configuration HII driver RedfishClientPkg: Introduce

Re: [edk2-devel] [PATCH 0/1] bhyve: TPM support for OVMF

On Tue, 2023-06-06 at 15:20 +0200, Corvin Köhne wrote: > Hi, > > I'm currently working on TPM emulation for bhyve. Therefore, the > guest > firmware has to set up the TPM device properly for the guest OS. I'd > like to send the attached patch to the EDKII project. > > Any comments are

[edk2-devel] [PATCH 0/1] bhyve: TPM support for OVMF

Hi, I'm currently working on TPM emulation for bhyve. Therefore, the guest firmware has to set up the TPM device properly for the guest OS. I'd like to send the attached patch to the EDKII project. Any comments are appreciated. Thanks, Corvin Corvin Köhne (1): OvmfPkg/Bhyve: include TPM

[edk2-devel] [PATCH 1/1] OvmfPkg/Bhyve: include TPM driver

From: Corvin Köhne Bhyve will gain support for TPM emulation in the near future. Therefore, prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the bhyve OVMF DSC. Signed-off-by: Corvin Köhne --- OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++-- OvmfPkg/Bhyve/BhyveX64.fdf |

[edk2-devel] [edk2-redfish-client][PATCH v2 9/9] RedfishClientPkg/ComputerSystemDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../v1_5_0/Dxe/ComputerSystemDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 8/9] RedfishClientPkg/MemoryDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 7/9] RedfishClientPkg/BiosDxe: Fix build error

- Fix "variable set but not used" error. - Fix missing "EFIAPI" error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 20 ++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 6/9] RedfishClientPkg/RedfishConfigLangMapDxe: Fix build error

Add missing "EFIAPI" and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 5/9] RedfishClientPkg/RedfishETagDxe: Fix build error

- Fix missing "EFIAPI" build error. - Fix typos. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Include/Protocol/EdkIIRedfishETagProtocol.h | 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c| 13 - 2 files changed, 9 insertions(+), 6

[edk2-devel] [edk2-redfish-client][PATCH v2 4/9] RedfishClientPkg/RedfishFeatureUtilityLib: Fix build error

Follow latest definition of EDKII_REDFISH_VALUE_TYPES and rename all corresponding variable in RedfishFeatureUtilityLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.c| 50 +-- 1 file changed, 25

[edk2-devel] [edk2-redfish-client][PATCH v2 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 3/9] RedfishClientPkg/EdkIIRedfishResourceConfigLib: Fix build error

Remove uncessary parameter and fix build error. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../EdkIIRedfishResourceConfigLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-redfish-client][PATCH v2 2/9] RedfishClientPkg/RedfishAddendumLib: Fix build error

Rename ProvisioningCallback() to GetData() and OemCallback() to GetOemData() and fix build error Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../Library/RedfishAddendumLib/RedfishAddendumLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[edk2-devel] [edk2-redfish-client][PATCH v2 1/9] RedfishClientPkg/ConverterLib: Fix unused-but-set-variable error

Add GCC flag "-Wno-unused-but-set-variable" to remove build error because ConverterLib is 3rd party library. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../edk2library/Bios/v1_0_9/Lib.inf | 102 +-

[edk2-devel] [edk2-redfish-client][PATCH v2 0/9] Fix RedfishClientPkg build errors

V2: Instead of modifying ConverterLib, use build option in INF file to fix build error V1: Fix RedfishClientPkg build errors and typos. The compiler toolchain is GCC5. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (9): RedfishClientPkg/ConverterLib: Fix

Re: [edk2-devel] [PATCH v6 0/3] OvmfPkg/Bhyve: install ACPI tables from memory

On Tue, 6 Jun 2023 at 11:22, Corvin Köhne wrote: > > CI: https://github.com/tianocore/edk2/pull/4379/checks > > Corvin Köhne (3): > OvmfPkg/Xen: export search of RSDP into a library function > OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib > OvmfPkg/Bhyve: install ACPI

Re: [edk2-devel] [PATCH v3 4/7] OvmfPkg/RiscVVirt: Remove satp bare mode setting

On Fri, May 26, 2023 at 04:17:30PM -0700, Tuan Phan wrote: > MMU now is initialized in CpuDxe. There is no point to set satp to bare > mode as that should be the default mode when booting edk2. > > Signed-off-by: Tuan Phan > Reviewed-by: Andrei Warkentin > --- >

Re: [edk2-devel] [PATCH v3 5/7] OvmfPkg/RiscVVirt: VirtNorFlashPlatformLib: Fix wrong flash size

On Fri, May 26, 2023 at 04:17:31PM -0700, Tuan Phan wrote: > The size should be for single region, not the whole firmware FD. > > Signed-off-by: Tuan Phan > Reviewed-by: Andrei Warkentin > --- Thanks for the fix. LGTM. Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH v3 2/7] MdePkg/Register: RISC-V: Add satp mode bits shift definition

On Fri, May 26, 2023 at 04:17:28PM -0700, Tuan Phan wrote: > The satp mode bits shift is used cross modules. It should be defined > in one place. > > Signed-off-by: Tuan Phan > Reviewed-by: Andrei Warkentin > --- LGTM. Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH v3 1/7] MdePkg/BaseLib: RISC-V: Support getting satp register value

On Fri, May 26, 2023 at 04:17:27PM -0700, Tuan Phan wrote: > Add an API to retrieve satp register value. > > Signed-off-by: Tuan Phan > Reviewed-by: Andrei Warkentin > --- LGTM. Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: RISC-V: TimerLib: Fix delay function to use 64-bit

On Fri, May 26, 2023 at 04:25:18PM -0700, Tuan Phan wrote: > The timer compare register is 64-bit so simplifying the delay > function. > > Signed-off-by: Tuan Phan > --- > MdePkg/Include/Register/RiscV64/RiscVImpl.h | 1 - > .../BaseRiscV64CpuTimerLib/CpuTimerLib.c | 62

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: CpuTimerDxeRiscV64: Fix incorrect value sent to SbiSetTimer

On Fri, May 26, 2023 at 04:25:17PM -0700, Tuan Phan wrote: > SbiSetTimer expects core tick value. > > Signed-off-by: Tuan Phan > --- Thanks for the patch!. LGTM. Reviewed-by: Sunil V L -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH] Maintainers.txt: Drop Radoslaw from sbsa-ref maintainers

W dniu 5.06.2023 o 21:26, Radoslaw Biernacki pisze: Regardless of the long standing desire to resume involvement in the project, I'm unable to double the time in a day. That's why I'm removing myself from sbsa-ref maintainers. Thanks for your contributions Radosław! -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Maintainers.txt: Drop Radoslaw from sbsa-ref maintainers

On Mon, Jun 05, 2023 at 21:26:18 +0200, Radoslaw Biernacki wrote: > Regardless of the long standing desire to resume involvement > in the project, I'm unable to double the time in a day. > That's why I'm removing myself from sbsa-ref maintainers. Many thanks for your contributions! >

[edk2-devel] [PATCH v6 3/3] OvmfPkg/Bhyve: install ACPI tables from memory

It's much easier to create configuration dependend ACPI tables for bhyve than for OVMF. For this reason, don't use the statically created ACPI tables provided by OVMF. Instead prefer the dynamically created ACPI tables of bhyve. If bhyve provides no ACPI tables or we are unable to detect those,

[edk2-devel] [PATCH v6 2/3] OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib

This makes the function reuseable by bhyve. Signed-off-by: Corvin Köhne Reviewed-by: Anthony PERARD Acked-by: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Julien Grall Cc: Rebecca Cran Cc: Peter Grehan --- .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 -

[edk2-devel] [PATCH v6 1/3] OvmfPkg/Xen: export search of RSDP into a library function

Xen and bhyve are placing ACPI tables into system memory. So, they can share the same code. Therefore, create a new library which searches and installs ACPI tables from system memory. Signed-off-by: Corvin Köhne Reviewed-by: Anthony PERARD Acked-by: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen

[edk2-devel] [PATCH v6 0/3] OvmfPkg/Bhyve: install ACPI tables from memory

CI: https://github.com/tianocore/edk2/pull/4379/checks Corvin Köhne (3): OvmfPkg/Xen: export search of RSDP into a library function OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib OvmfPkg/Bhyve: install ACPI tables from memory OvmfPkg/OvmfPkg.dec

[edk2-devel] [PATCH edk2-platforms v2 0/2] SbsaQemu: get GIC data from QEMU

Those changes make use of recently added SMC calls to get GIC data from QEMU instead of having them hardcoded. This is a beginning of changing this platform to be more flexible. My blog post about our plans to QEMU SBSA Reference Platform:

[edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/SbsaQemu: read platform version

Qemu has versioning for sbsa-ref platform. TF-A reads it from provided DeviceTree and provides as SMC. This change adds reading platform version into EDK2. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/SbsaQemu.dec| 3 +++ Platform/Qemu/SbsaQemu/SbsaQemu.dsc

[edk2-devel] [PATCH edk2-platforms v2 2/2] Platform/SbsaQemu: read GIC base from TF-A

Qemu has versioning for sbsa-ref platform. TF-A reads data from provided DeviceTree and provides as SMC. This change adds reading GIC base addresses into EDK2. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemuPlatformDxe.inf| 5 +

Re: [edk2-devel] [PATCH] Maintainers.txt: Drop Radoslaw from sbsa-ref maintainers

On Mon, 5 Jun 2023 at 21:26, Radoslaw Biernacki wrote: > > Regardless of the long standing desire to resume involvement > in the project, I'm unable to double the time in a day. > That's why I'm removing myself from sbsa-ref maintainers. > > Signed-off-by: Radoslaw Biernacki Understood - thanks

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

[AMD Official Use Only - General] I can't retrigger the CI to try it. @Kinney, Michael D, could you please help to retrigger it? Thanks Abner From: Wu, Hao A Sent: Tuesday, June 6, 2023 10:25 AM To: Andrew Fish ; Leif Lindholm ; Kinney, Michael D ; Gao,

Re: [edk2-devel] [edk2-platforms][PATCH 0/4] Add support new SMBIOS Tables and refactor to adapt with ArmPkg/SMBIOS

Hi Ard, The error is created by this commit https://github.com/tianocore/edk2/commit/e6447d2a08f5ca585816d093e79a01dad3781f98. We are investigating and will get back to you soon. Thanks for merging our patches. -Nhi On 6/2/2023 7:48 PM, Ard Biesheuvel wrote: On Wed, 24 May 2023 at 02:41,

[edk2-devel] [PATCH v14 8/8] OvmfPkg: Uses MmSaveStateLib library

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Uses new MmSaveStateLib library instance. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by:

[edk2-devel] [PATCH v14 7/8] UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Removes SmmCpuFeaturesReadSaveStateRegister and SmmCpuFeaturesWirteSaveStateRegister function from SmmCpuFeaturesLib library. MmSaveStateLib library replaces the functionality of the above functions. Platform old/new need to use

[edk2-devel] [PATCH v14 6/8] UefiCpuPkg: Implements MmSaveStateLib for Intel

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements MmSaveStateLib library interfaces to read and write save state registers for Intel processor family. Moves Intel and AMD common functionality to common area. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul

[edk2-devel] [PATCH v14 5/8] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from

[edk2-devel] [PATCH v14 4/8] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Paul Grimes Cc:

[edk2-devel] [PATCH v14 1/8] MdePkg: Adds AMD SMRAM save state map

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds an SMM SMRAM save-state map for AMD processors. SMRAM save state maps for the AMD processor family are now supported. Save state map structure is added based on AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2. The AMD

[edk2-devel] [PATCH v14 3/8] UefiCpuPkg: Implements MmSaveStateLib library instance

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements MmSaveStateLib Library class for AMD cpu family. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Lateef Attar Reviewed-by: Abner

[edk2-devel] [PATCH v14 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

Backward-compatibility changes: This patch series removes the SmmCpuFeaturesReadSaveStateRegister and SmmCpuFeaturesWriteSaveStateRegister interface/function. SmmReadSaveState() and SmmWriteSaveState() now directly invokes MmSaveStateLib routines to save/restore registers. PR:

[edk2-devel] [PATCH v14 2/8] UefiCpuPkg: Adds MmSaveStateLib library class

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds MmSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Lateef Attar Reviewed-by:

[edk2-devel] [PATCH] ShellPkg: Increase PcdShellPrintBufferSize from UINT16 to UINT32

Increase max buffer size to support more than 64K. Signed-off-by: Giri Mudusuru Cc: Ray Ni Cc: Zhichao Gao Cc: Andrew Fish --- ShellPkg/Application/Shell/Shell.c | 5 +++-- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 19 ++- ShellPkg/ShellPkg.dec