Re: [edk2-devel] [PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry

2023-06-27 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Joey Vagedes > Sent: Tuesday, June 27, 2023 5:34 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > ; Igor Kulchytskyy > Subject: [PATCH v1 18/24] RedfishPkg: CI: Add PrEval entry > >

Re: [edk2-devel] [PATCH v1 09/24] EmbeddedPkg: CI: Add PrEval entry

2023-06-27 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Joey Vagedes > Sent: Tuesday, June 27, 2023 5:34 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > ; Chang, Abner ; > Daniel Schaefer > Subject: [PATCH v1 09/24] EmbeddedPkg: CI:

Re: [edk2-devel] [PATCH V3] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-27 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/4584 > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, June 27, 2023 5:50 PM > To: Clark-williams, Zachary ; Li, Yi1 > ; devel@edk2.groups.io; Andrew Fish ; > Leif Lindholm > Cc: Maciej Rabeda ; Kinney, Michael D > > Subject:

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Update NetworkPkg maintainers and reviewers

2023-06-27 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/4586 > -Original Message- > From: Kinney, Michael D > Sent: Thursday, June 15, 2023 11:55 AM > To: Clark-williams, Zachary ; Kasbekar, > Saloni ; devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm > ; Kinney, Michael D > Subject: RE: [PA

[edk2-devel] [PATCH] UefiCpuPkg: CpuTimerDxeRiscV64: Fix timer event not working correctly

2023-06-27 Thread Tuan Phan
The timer notify function should be called with timer period, not the value read from timer register. Signed-off-by: Tuan Phan --- UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/CpuTimerDxeRiscV64/Timer.c b/UefiCpuPkg/

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

2023-06-27 Thread Nickle Wang via groups.io
May I know if someone can help to review this patch? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Friday, February 10, 2023 8:34 PM > To: devel@edk2.groups.io > Cc: Maciej Rabeda ; Siyuan Fu > ; Abner Chang ; Igor Kulch

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Joey Vagedes
Hi Michael, PeImage.h currently references rev 8.3 as the latest revision. The DLLCHARACTERISTICS field of the optional header existed in the revision, but I believe it was never added as it was not needed. I'm happy to add information to the header if needed, just let me know what you're looking

Re: [edk2-devel] [PATCH v1 0/2] Automatically set NXCOMPAT bit if requirements are met

2023-06-27 Thread Joey Vagedes
Hi Ard, Talked to the team and I think the appropriate answer to this is to follow what is currently done through the MSVC FLAGS, i.e. that any PE that knowingly does not meet these requirements manually opts out of NXCOMPAT via the /NXCOMPAT:no flag. That means adding a flag to GENFW: "--nxcompat

Re: [edk2-devel] [PATCH V3] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-27 Thread Michael D Kinney
Working on it: https://github.com/tianocore/edk2/pull/4584 > -Original Message- > From: Clark-williams, Zachary > Sent: Tuesday, June 27, 2023 2:46 PM > To: Li, Yi1 ; devel@edk2.groups.io; Kinney, Michael D > ; Andrew Fish ; Leif Lindholm > > Cc: Maciej Rabeda > Subject: RE: [PATCH V3

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI

2023-06-27 Thread Kun Qin
Hi Ard, Thanks for the feedback. I updated the patch as you suggested and sent out a v3 here: https://edk2.groups.io/g/devel/message/106443. The only call-out was the "CONST" qualifier for "mPeiMmCommunication" was cast away when initializing "mPeiMmCommunicationPpi". This was because the "Pp

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Michael D Kinney
Sounds like 9.3 would be better for consistent names. Mike From: Joey Vagedes Sent: Tuesday, June 27, 2023 2:42 PM To: Kinney, Michael D Cc: devel@edk2.groups.io; Gao, Liming ; Liu, Zhiguang Subject: Re: [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics Hi Michael, PeImage.h

[edk2-devel] [PATCH v3 2/2] MdeModulePkg: Variable: Introduce MM based variable read service in PEI

2023-06-27 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This change introduced the Standalone MM based variable read capability in PEI phase for applicable platforms (such as ARM platforms). Similar to the x86 counterpart, MM communicate PPI is used to request variable informatio

[edk2-devel] [PATCH v3 1/2] ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI

2023-06-27 Thread Kun Qin
From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This change introduced the MM communicate support in PEI phase for ARM based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is used as communicate buffer and SMC will be invoked to communicate to TrustZone when

[edk2-devel] [PATCH v3 0/2] Support MM based variable services in PEI for ARM

2023-06-27 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 This patch series is a follow-up of previous submission: https://edk2.groups.io/g/devel/message/106372 The main changes between v2 and v3 patches are: - Removed header file for MM communicate PEI module - Added constant qualifiers to ap

Re: [edk2-devel] [PATCH V3] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-27 Thread Clark-williams, Zachary
Reviewed-by: Zachary Clark-Williams Hey Michael, Can you help with this change merge? Thanks, Zack -Original Message- From: Li, Yi1 Sent: Sunday, June 25, 2023 10:41 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Maciej Rabeda ; Clark-williams, Zachary Subject: [PATCH V3] NetworkPkg: C

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

2023-06-27 Thread Michael D Kinney
It is better if we can use the same include guard names, but is not strictly required for builds to work. What is the specific error message seen when using the same include guard names as other CPU types? Include guards have 2 elements work discussing: * Use of define names that start with '_'

Re: [edk2-devel] IpmiCommandLib's IpmiGetSystemUuid clarification

2023-06-27 Thread Aaron Pop
Re sending and adding maintainers directly On Monday, 6/26/2023 12:43 PM, Aaron Pop wrote: I was hoping to get a clarification on the IpmiGetSystemUuid from MdeModulePkg... IPMI specification's Get Device Guid Command says that data is returned in "least signification byte first" and "this i

Re: [edk2-devel] [PATCH v1] MdePkg: Add UefiBootServicesTableLib gmock support

2023-06-27 Thread Michael D Kinney
I only see a few services from the UEFI Boot Services Table supported. I recommend the commit message be updated to indicate it is only partial supppot and list the APIs supported. Mike > -Original Message- > From: Huang, LakX > Sent: Monday, June 19, 2023 1:38 AM > To: devel@edk2.gro

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

2023-06-27 Thread Michael D Kinney
Hi Joey, Was the link to the PE/COFF specs that added these updated in the file header? Also, shouldn't it be DLL_CHARACTERISRICS instead of DLLCHARACTERISRICS? Mike > -Original Message- > From: Joey Vagedes > Sent: Friday, June 23, 2023 8:45 AM > To: devel@edk2.groups.io > Cc: Kinney,

Re: [edk2-devel] [PATCH v4 2/7] MdePkg/Register: RISC-V: Add satp mode bits shift definition

2023-06-27 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Tuan Phan > Sent: Friday, June 23, 2023 11:39 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > suni...@ventanamicro.com; g...@danielschaefer.me; Warkentin, Andrei > ; ardb+tianoc...@kernel

Re: 回复: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Add "-fno-unwind-tables" to GCC5_RISCV64_CC_FLAGS

2023-06-27 Thread Sunil V L
On Sun, Jun 25, 2023 at 09:06:34AM +0800, gaoliming wrote: > Reviewed-by: Liming Gao > Hi Rebecca, Liming, Appreciate your help with reviewing the patch. This is merged now as part of PR #4581. Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format

2023-06-27 Thread Clark-williams, Zachary
Looks good to me. From: Li, Yi1 Sent: Monday, June 26, 2023 1:36 AM To: Clark-williams, Zachary ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] NetworkPkg: Correct the length of EAP Identity when in ASCII format Hi Zack, Please check V3 patch, thanks for review. Regards, Yi From: C

Re: [edk2-devel] [PATCH v1 00/24] Update Edk2-pytools to latest versions

2023-06-27 Thread Joey Vagedes
Yes this change is currently required to enable Policy 5 for a given package. I'm tempted to move this patch series to individual patch series so that I can merge individual changes as they are approved in a package. We could try and set the dsc automatically as you suggested. It would be preferre

[edk2-devel] [PATCH v1 0/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Joey Vagedes
Removes the dependency on xdrlib and replaces it with custom logic to pack a per the xdr requirements. Necessary as xdrlib is being deprecated in python 3.13. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael D Kinney Joey Vagedes (1): BaseTools: BinToPcd: Resolve xdr

[edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Joey Vagedes
Removes the dependency on xdrlib and replaces it with custom logic to pack a per the xdr requirements. Necessary as xdrlib is being deprecated in python 3.13. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Michael D Kinney Signed-off-by: Joey Vagedes --- BaseTools/Scripts/B

Re: [edk2-devel] Need help to add me to the edk-ii-maintainers and edk-ii-reviewers team

2023-06-27 Thread Michael D Kinney
I have sent the invite. Mike From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Monday, June 26, 2023 5:53 PM To: devel@edk2.groups.io; Duggapu, Chinni B Cc: Chiu, Chasel ; Kinney, Michael D Subject: 回复: [edk2-devel] Need help to add me to the edk-ii-maintainers and edk-i

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

2023-06-27 Thread Michael D Kinney
Thank you for fixing this. Reviewed-by: Michael D Kinney > -Original Message- > From: Joey Vagedes > Sent: Tuesday, June 27, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chen, > Christine ; Kinney, Michael D > > Subject: [PATCH v1 1/1] Base

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI

2023-06-27 Thread Ard Biesheuvel
On Mon, 26 Jun 2023 at 22:00, Kun Qin wrote: > > From: Kun Qin > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4464 > > This change introduced the MM communicate support in PEI phase for ARM > based platforms. Similar to the DXE counterpart, `PcdMmBufferBase` is > used as communicate buff

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call

2023-06-27 Thread Gerd Hoffmann
On Tue, Jun 27, 2023 at 01:17:16PM +0200, Ard Biesheuvel wrote: > The UEFI driver model invokes the supported() method on every driver > every time a connection attempt is made on any handle, and so doing an > unconditional DEBUG() print inside this method produced a lot of noise. > > So let's dro

Re: [edk2-devel] [Patch V7 01/14] OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry

2023-06-27 Thread Lendacky, Thomas via groups.io
On 6/27/23 00:23, Dun Tan wrote: Remove code that apply AddressEncMask to non-leaf entry when split s/apply/applies the/ s/entry/entries/ s/split/splitting/ smm page table by MemEncryptSevLib. In FvbServicesSmm driver, it s/smm page table by/SMM page table entries in/ s/In FvbServicesSmm dr

Re: [edk2-devel] guest boot with edk2 on Xen hypervisor takes more time

2023-06-27 Thread A Sudheer
i tried changing  gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOu to 0  but dint help. "gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|0x|UINT16| *0x0* " in   MdePkg/MdePkg.dec  . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#10642

[edk2-devel] guest boot with edk2 on Xen hypervisor takes more time

2023-06-27 Thread A Sudheer
Hi all, On AMD platform with xen hypervisor, when booting android guest/domu with edk2, takes more time to boot. >From xl create to EDK2 BDS log, it takes 10sec. >From BDS to grub menu, it takes 20sec. Can someone tell me how to reduce the time taken by edk2 firmware. Thanks Sudheer -=-=-=-=-=

[edk2-devel] [PATCH] OvmfPkg/VirtioSerialDxe: Remove noisy debug print on supported() call

2023-06-27 Thread Ard Biesheuvel
The UEFI driver model invokes the supported() method on every driver every time a connection attempt is made on any handle, and so doing an unconditional DEBUG() print inside this method produced a lot of noise. So let's drop this DEBUG() call from the VirtioSerial driver's Supported() method. Si

Re: [edk2-devel] [PATCH] OvmfPkg/PlatformCI: Skip GCC5_OVMF_IA32X64_FULL_NOOPT build

2023-06-27 Thread Ard Biesheuvel
On Wed, 21 Jun 2023 at 16:13, Pedro Falcato wrote: > > On Wed, Jun 21, 2023 at 8:55 AM Gerd Hoffmann wrote: > > > > On Wed, Jun 21, 2023 at 01:40:06AM +0100, Pedro Falcato wrote: > > > On Tue, 20 Jun 2023, 12:11 Li, Yi, wrote: > > > > > > > The effect of LTO is limited with optimization turned o

[edk2-devel] Boot ubuntu23.04 error with risc-v UEFI EDKII

2023-06-27 Thread guoke0528
When booting the risc-v ubuntu23.04 with UEFI EDKII,the following error has occurred。 MotherBoard:Sifive Hifive Unmatched U740 SOC -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106422): https://edk2.groups.io/g/devel/message/106422 Mut

Re: 回复: [edk2-devel] [PATCH v1 0/8] SecurityPkg/MdePkg: RngLib GUID

2023-06-27 Thread PierreGondois
+ Rebecca Hello Liming, PcdCpuRngSupportedAlgorithm is currently not set by any platform in the edk2 or edk2-platforms repository. It was first introduced by Rebecca in: commit 4e5ecdbac8bd ("SecurityPkg: Add support for RngDxe on AARCH64") Except if Rebecca sees an issue in this change, I thin