Re: [edk2-devel] [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list

2023-07-03 Thread Sunil V L
On Wed, Jun 28, 2023 at 02:27:10PM -0700, Tuan Phan wrote: > On Wed, Jun 28, 2023 at 9:47 AM Sunil V L wrote: > > > On Fri, Jun 23, 2023 at 11:39:32AM -0700, Tuan Phan wrote: > > > Make sure VirtNorFlashDxe loaded before VariableRuntimeDxe as it > > > is the backend flash driver. > > > > > >

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, July 4, 2023 #cal-reminder

2023-07-03 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, July 4, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, July 3, 2023 #cal-notice

2023-07-03 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, July 3, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename RedfishResourceIdentifyLibComuterSystem

2023-07-03 Thread Mike Maslenkin
This patch fixes misprint in name of a directory and its files. The name of these files should be RedfishResourceIdentifyLibComputerSystem as well as implemented library instance. Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- There is no history for

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 3, 2023 #cal-reminder

2023-07-03 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, July 3, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [edk2 PATCH v2] MdePkg: Use same ProcessorBind guard define name

2023-07-03 Thread Gavin Xue
Using the same include guard define name is preferred for all CPU architecture. Cc: Kinney, Michael D Cc: Andrei Warkentin Cc: Sunil V L Cc: Yimin Wang Cc: Alan Sheng Cc: Pedro Falcato Signed-off-by: Gavin Xue --- MdePkg/Include/LoongArch64/ProcessorBind.h | 5 +++--

[edk2-devel] [PATCH 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWARD_NULL Coverity issues

2023-07-03 Thread Ranbir Singh
From: Ranbir Singh The function UsbHcGetPciAddressForHostMem has ASSERT ((Block != NULL)); and the UsbHcFreeMem has ASSERT (Block != NULL); statement after for loop, but these are applicable only in DEBUG mode. In RELEASE mode, if for whatever reasons there is no match inside the for

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

2023-07-03 Thread Xue, Gavin
If we agree to use the same include guard define name for all CPU architecture, I re-sent out the v2 new patch. Please help to review it. Thanks. Best regards, Gavin -Original Message- From: Kinney, Michael D Sent: Saturday, July 1, 2023 12:59 AM To: Xue, Gavin ; devel@edk2.groups.io;

[edk2-devel] [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__

2023-07-03 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README

2023-07-03 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- Tools/Redfish-Profile-Simulator/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tools/Redfish-Profile-Simulator/README.md b/Tools/Redfish-Profile-Simulator/README.md index

[edk2-devel] [PATCH 0/2][edk2-redfish-client] fix trivial misprint

2023-07-03 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106612): https://edk2.groups.io/g/devel/message/106612 Mute This Topic:

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg: RngDxe: Fixing mAvailableAlgoArray allocator

2023-07-03 Thread Kun Qin
Hi Sami, Would you prefer to have input from Jiewen or Jian to review this patch as well? Otherwise, would you mind helping me to merge the change? Thanks in advance! Regards, Kun On 6/29/2023 4:59 PM, Kun Qin via groups.io wrote: From: Kun Qin REF:

Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64

2023-07-03 Thread Pedro Falcato
On Fri, Jun 30, 2023 at 5:59 PM Michael D Kinney wrote: > > Using the same include guard define name is preferred. > > Why was anything other than that considered? I don't see the point of making the include guard an actual part of the "API". Consumers should not depend on it being named

[edk2-devel][edk2-platforms][PATCH V4-3] IpmiFeaturePkg:Provided multiple IPMI interface support in Library

2023-07-03 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

[edk2-devel][edk2-platforms][PATCH V4-2] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-07-03 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

[edk2-devel][edk2-platforms][PATCH V4-1] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-07-03 Thread Arun K via groups.io
Created IpmiTransport2 PPI/Protocol to support multiple IPMI BMC Interface support such as KCS/BT/SSIF/IPMB with 2 API's IpmiSubmitCommand2 & IpmiSubmitCommand2Ex. IpmiSubmitCommand2 - This API use the default interface (PcdDefaultSystemInterface) to send IPMI command. IpmiSubmitCommand2Ex - This

Re: [edk2-devel] [PATCH 0/4] Update CpuDxe MMU Logic to Improve Consistency

2023-07-03 Thread Ard Biesheuvel
On Thu, 29 Jun 2023 at 18:20, Taylor Beebe wrote: > > This patch series: > > 1. Updates applies uncrustify to noncompliant files > 2. Updates GetMemoryRegion() to handle the case where >BaseAddress is an unmapped page, and update some other >return values to be more consistent. > 3. Adds

[edk2-devel] [PATCH 3/3] RedfishPkg/JsonLib: add object clear interface

2023-07-03 Thread Nickle Wang via groups.io
-Add JsonObjectClear() interface for application to clear all elements in JSON object. -Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/JsonLib.h | 33 +-- RedfishPkg/Library/JsonLib/JsonLib.c | 39

[edk2-devel] [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message

2023-07-03 Thread Nickle Wang via groups.io
Change debug message level of showing ordered list op-code to REDFISH_PLATFORM_CONFIG_DEBUG. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c| 24 +-- 1 file changed, 12 insertions(+), 12

[edk2-devel] [PATCH 1/3] RedfishPkg/RedfishRestExDxe: fix CPU exception in RedfishRestExDxe

2023-07-03 Thread Nickle Wang via groups.io
RedfishRestExDxe driver failed to uninstall service binding protocol when driver binding stop is called. Application drivers may still use RedfishRestExDxe after it is disconnected in system. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

2023-07-03 Thread PierreGondois
On 6/30/23 01:01, Jeff Brasen wrote: Add API to generate a Name that contains a Unicode string buffer. Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534 Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal Also I forgot: the 'Change-Id' should be removed, Regards, Pierre

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support

2023-07-03 Thread Ard Biesheuvel
On Mon, 3 Jul 2023 at 10:08, Sunil V L wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 > > This series adds support for building RiscVVirtQemu EDK2 using > CLANGDWARF toolchain. Adding this support helps people to use > the same toolchain to build EDK2 for different

Re: [edk2-devel] [PATCH v1 3/3] OvmfPkg/BhyvePkg: enable bus enumeration

2023-07-03 Thread Corvin Köhne
On Mon, 2023-06-12 at 11:20 +0200, Corvin Köhne wrote: > bhyve supports adding a ROM to PCI devices. It was added to support > GPU > passthrough of dedicated AMD GPUs. At the moment, this ROM file is > mostly useless as it's not shadowed and executed by firmware. Change > that by enabling bus

Re: [edk2-devel] [PATCH 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

2023-07-03 Thread PierreGondois
Hello Jeff, Reviewed-by: Pierre Gondois On 6/30/23 01:01, Jeff Brasen wrote: Add API to generate a Name that contains a Unicode string buffer. Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534 Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal ---

Re: [edk2-devel] [PATCH 3/4] DynamicTablesPkg: Add support to add Strings to package

2023-07-03 Thread PierreGondois
Hello Jeff, On 6/30/23 01:01, Jeff Brasen wrote: Add API to add a String to a package created with NamedPackage API. Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 17

Re: [edk2-devel] [PATCH 2/4] DynamicTablesPkg: Add support for simple method invocation.

2023-07-03 Thread PierreGondois
Hello Jeff, On 6/30/23 01:01, Jeff Brasen wrote: Add support to add Return objects via AML that pass a single integer argument to the named method. Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h |

Re: [edk2-devel] [PATCH 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function

2023-07-03 Thread PierreGondois
Hello Jeff, Reviewed-by: Pierre Gondois On 6/30/23 01:01, Jeff Brasen wrote: Add API to generate a ThermalZone object to AmlLib. Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 28 +

[edk2-devel] [PATCH v2 1/1] MdePkg: Add Cxl20.h into IndustryStandard

2023-07-03 Thread Chris Li OS via groups.io
+To/Cc Updated places from v1: +#define CXL_2_0_DVSEC_REVISON_ID 0x1 -#define CXL20_DVSEC_REVISON_REGISTOR_LOCATOR 0x0 +#define CXL_2_0_DVSEC_REVISON_REGISTOR_LOCATOR0x0 -} HDM_DECODER_N_INFO; +} CXL_HDM_DECODER_N_INFO; - 1) Add CXL 2.0

[edk2-devel] [PATCH 4/4] OvmfPkg/RiscVVirt: Update README for CLANGDWARF support

2023-07-03 Thread Sunil V L
Update the README with instruction to build using CLANGDWARF toolchain. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin Signed-off-by: Sunil V L Reviewed-by: Heinrich Schuchardt --- OvmfPkg/RiscVVirt/README.md | 28 +---

[edk2-devel] [PATCH 3/4] BaseTools/tools_def: Add CLANGDWARF support for RISC-V

2023-07-03 Thread Sunil V L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 Add tools_def definitions to support CLANGDWARF toolchain for RISC-V. This uses clang and the llvm LLD linker. This helps people by not requiring to install multiple cross compilers for different architectures. Cc: Rebecca Cran Cc: Liming

[edk2-devel] [PATCH 2/4] OvmfPkg/RiscVVirt: SecEntry: Remove unnecessary assembly directives

2023-07-03 Thread Sunil V L
llvm fails to resolve _ModuleEntry when these extra directives are present. ASM_FUNC already takes care what is required. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin Signed-off-by: Sunil V L --- OvmfPkg/RiscVVirt/Sec/SecEntry.S | 3 --- 1

[edk2-devel] [PATCH 1/4] OvmfPkg/RiscVVirt: use 'auto' alignment and FIXED for XIP modules

2023-07-03 Thread Sunil V L
Use auto alignment and FIXED FFS attribute for XIP modules similar to [1]. Without this change, the CLANGDWARF toolchain will fail to build with below error. GenFfs: ERROR 1000: Unknown option SectionAlign option must be specified with section file. [1] -

[edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Add CLANGDWARF toolchain support

2023-07-03 Thread Sunil V L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478 This series adds support for building RiscVVirtQemu EDK2 using CLANGDWARF toolchain. Adding this support helps people to use the same toolchain to build EDK2 for different architectures. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: