Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Monday, July 3, 2023 7:44 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWARD_NULL
> Coverity
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Ranbir Singh
> Sent: Friday, June 9, 2023 8:33 PM
> To: devel@edk2.groups.io; rsi...@ventanamicro.com
> Cc: Wu, Hao A ; Ni, Ray
> Subject: [PATCH v2 1/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix
> SIGN_EXTENSION
Really sorry,
After referring to the Information Technology - AT Attachment with Packet
Interface (ATA/ATAPI) Specification,
It seems to me that the commands being executed in function
SetDriveParameters() are not mandatory during device initialization.
1. INITIALIZE DEVICE PARAMETERS command
[AMD Official Use Only - General]
Hi Isaac, thanks for the last minutes review.
Abner
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, July 12, 2023 10:06 AM
> To: Chang, Abner ; Chesley, Brit
> ; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle
> Wang
Reviewed-by: Isaac Oram
-Original Message-
From: Chang, Abner
Sent: Monday, July 10, 2023 6:36 PM
To: Chesley, Brit ; devel@edk2.groups.io
Cc: Oram, Isaac W ; Attar, AbdulLateef (Abdul Lateef)
; Nickle Wang
Subject: RE: [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set
[AMD Official Use Only - General]
Hi Brit, I am going to push this change with updating the file header with AMD
copyrights.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chang,
> Abner via groups.io
> Sent: Tuesday, July 11, 2023 9:36 AM
> To: Chesley,
I think the exception has something to do with gEfiPeiSmbus2PpiGuid.
Regards,
Isaac
-Original Message-
From: devel@edk2.groups.io On Behalf Of Isaac Oram
Sent: Tuesday, July 11, 2023 6:45 PM
To: Arun K ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Ramkumar
Krishnamoorthi ; Gao,
Arun,
My apologies that my feedback wasn't clear enough. I would like to avoid the
preprocessor optimization step of using #if in favor of using C code and using
link time optimization to remove unused code. I sent you a patch with examples
of using the PCD in normal C logic. I don't think
Looks like the title of this patch in the series was mixed up
with the title of the following patch. I'll wait for feedback
before sending out a v2, but the title of this patch
should be:
[PATCH 13/14] ArmVirtPkg: Delete Memory Protection PCDs
On 7/11/2023 4:52 PM, Taylor Beebe via groups.io
From: Taylor Beebe
Delete the memory protection PCDs
Signed-off-by: Taylor Beebe
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
---
MdeModulePkg/MdeModulePkg.dec | 169 --
MdeModulePkg/MdeModulePkg.uni | 153 --
2 files changed, 322
From: Taylor Beebe
Replace references to the memory protection PCDs with references
to the memory protection HOB.
The X64/DxeLoadFunc.c will check the PcdDxeIplBuildPageTables
PCD to determine if page tables should be built wheras before
they would check both the PcdDxeIplBuildPageTables PCD
From: Taylor Beebe
Now that references in the rest of the codebase have been updated
to reference the memory protection HOB, delete the memory protection PCDs.
Signed-off-by: Taylor Beebe
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
---
From: Taylor Beebe
Now that references in the rest of the codebase have been updated
to reference the memory protection HOB, delete the memory protection PCDs.
Signed-off-by: Taylor Beebe
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
---
From: Taylor Beebe
Replace references to the memory protection PCDs with references
to the memory protection HOB.
Stack guard will always be initialized after memory discovery
in PEI, but the memory protection HOB will be checked when
applying stack guard in DxeIpl when the page tables are
From: Taylor Beebe
Replace references to the memory protection PCDs with references
to the memory protection HOB.
The stack NX setting will no longer be fetched from the QEMU
configuration file and will instead be determined via the
HOB published in PlatformPei/Platform.c. PeilessStartup
will
From: Taylor Beebe
Replace references to the memory protection PCDs with references
to the memory protection HOB.
The memory protection HOB will be ingested during handoff to check
the memory proteciton settings when creating the page tables.
This patch also adjusts the logic for the memory
From: Taylor Beebe
Replace references to the memory protection PCDs to instead
reference the memory protection HOB.
Signed-off-by: Taylor Beebe
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Sami Mujawar
---
ArmPkg/ArmPkg.dsc| 1 +
ArmPkg/Drivers/CpuDxe/CpuDxe.c | 5 ++---
From: Taylor Beebe
Replace references to the memory protection PCDs with references
to the memory protection HOB.
Signed-off-by: Taylor Beebe
Cc: Andrew Fish
Cc: Ray Ni
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Taylor Beebe
Create the memory protection settings HOBs on Arm virtual platforms.
These platforms will use the DEBUG memory protection profile.
Signed-off-by: Taylor Beebe
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
---
ArmVirtPkg/ArmVirt.dsc.inc
From: Taylor Beebe
Create the memory protection settings HOB on Ovmf platforms with
DEBUG settings.
Signed-off-by: Taylor Beebe
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
---
OvmfPkg/AmdSev/AmdSevX64.dsc | 2 ++
OvmfPkg/Bhyve/BhyveX64.dsc
From: Taylor Beebe
These headers provide settings definitions for memory protections,
settings profiles for easily enabling memory protections,
and the GUIDs used for producing the memory protection HOB.
The settings options are functionally 1:1 with the existing
PCD bitfield definitions.
From: Taylor Beebe
Add DXE, SMM, and STANDALONE MM implementations of the
MemoryProtectionHobLib.
Signed-off-by: Taylor Beebe
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
---
.../DxeMemoryProtectionHobLib.c | 132 ++
.../DxeMemoryProtectionHobLib.inf
In the past, memory protection settings were configured via FixedAtBuild PCDs,
which resulted in a build-time configuration of memory mitigations. This
approach limited the flexibility of applying mitigations to the
system and made it difficult to update or adjust the settings post-build.
In a
Ajay,
In general the order of dispatch when all the DEPEX evaluate to TRUE and the
oder of events are not defined by the specification.
I think you are trying to say stuff that dispatches later is higher up the
stack and it would make more sense to send the rest to things higher up the
Ray,
Would you prefer this sort of use would be done by an extra dispatch after
the wait for everything being completed and the connect controller call in BDS
as opposed to the driver binding approach? Basically using a depex on the
library as we are currently doing.
-Jeff
>
Hi Nishant,
Thank you for sending out the patch. Can you please evaluate how much
effort it would be
to support the same for MmCommunicatePei? I think it would provide
better coverage for
the FFA support if we can have that change.
Thanks,
Kun
On 7/11/2023 7:36 AM, Nishant Sharma wrote:
[AMD Official Use Only - General]
Thanks Dun for clarifying, I'll submit the patch.
Regards,
AbduL
-Original Message-
From: devel@edk2.groups.io On Behalf Of duntan via
groups.io
Sent: Tuesday, July 11, 2023 3:21 PM
To: Attar, AbdulLateef (Abdul Lateef) ; Ni, Ray
;
[AMD Official Use Only - General]
Hi Ray,
I think Michael raised the similar concerned during the patch review.
Its intentionally kept it as gSmst because of the below reason.
2. AmdMmSaveStateLib and IntelMmSaveStateLib depend on SmmServicesTableLib. Can
they depend on
Update the README with instruction to build using CLANGDWARF
toolchain.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Andrei Warkentin
Signed-off-by: Sunil V L
Reviewed-by: Heinrich Schuchardt
Acked-by: Ard Biesheuvel
---
OvmfPkg/RiscVVirt/README.md | 28
llvm fails to resolve _ModuleEntry when these extra directives are
present. ASM_FUNC already takes care what is required.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Andrei Warkentin
Signed-off-by: Sunil V L
Acked-by: Ard Biesheuvel
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478
Add tools_def definitions to support CLANGDWARF toolchain
for RISC-V. This uses clang and the llvm LLD linker. This
helps people by not requiring to install multiple
cross compilers for different architectures.
Cc: Rebecca Cran
Cc: Liming
Use auto alignment and FIXED FFS attribute for XIP modules similar
to [1]. Without this change, the CLANGDWARF toolchain will fail to
build with below error.
GenFfs: ERROR 1000: Unknown option
SectionAlign option must be specified with section file.
[1] -
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4478
This series adds support for building RiscVVirtQemu EDK2 using
CLANGDWARF toolchain. Adding this support helps people to use
the same toolchain to build EDK2 for different architectures.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc:
From: Achin Gupta
This patch packages requests for accessing a Standalone MM driver
through the MM communication protocol as FF-A direct messages.
Corresponding changes in Standalone MM Core ensure that responses are
packaged in the same way.
Signed-off-by: Achin Gupta
Co-developed-by: Aditya
From: Achin Gupta
This patch adds support for correctly receiving a request for a
Standalome MM driver service using the MM communication protocol
packaged as an FF-A direct request message.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
From: Achin Gupta
This patch adds support for creating a hoblist from the reduced boot
information retrieved from the SP manifest.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
StandaloneMmPkg/Include/Library/Arm/StandaloneMmCoreEntryPoint.h
| 16 ++
From: Achin Gupta
This patch adds support for discovering the presence of the SP using the
EFI_MM_COMMUNICATION_PROTOCOL GUID that implements Standalone MM
drivers. This is done by querying the framework through
FFA_PARTITION_INFO_GET whether any partition that implements the
From: Achin Gupta
An FF-A partition can map only a single RX/TX buffer pair with the
framework. The DXE MM communication driver maps its pair before
ExitBootServices is called. The OS cannot re-use this pair once it boots
subsequently and loads its own FF-A driver. This patch ensures that the
From: Achin Gupta
This patch statically allocates an FF-A RX/TX buffer pair and registers
them with the framework. This enables discovery of the StMM SP in a
subsequent patch.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h |
From: Achin Gupta
This patch adds support for querying whether FF-A v1.1 is supported by the
FF-A impplementation.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 3 +++
ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
From: Achin Gupta
This patch invokes the FFA_ID_GET to obtain and stash the ID of the the
FF-A partition that implements the DXE MM communication driver. This ID
is used in subsequent patches for sending and receiving MM communication
protocol requests and responses that are packaged as FF-A
From: Achin Gupta
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
b/ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
index
From: Achin Gupta
This patch skips zero sized sections in the StMM SP image e.g. .reloc since
there is no point in attempting to change their permissions.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/Arm/SetPermissions.c | 18
From: Achin Gupta
This patch copies the value of the corresponding stack variable to a global
variable so that it can be used to determine whether FF-A v1.1 or earlier
ABIs should be used for communication with the SPMC.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
From: Achin Gupta
This patch discovers the SP manifest in DT format passed by the SPMC. It
then parses it to obtain the boot information required to initialise the
SP.
Signed-off-by: Achin Gupta
Signed-off-by: Sayanta Pattanayak
Signed-off-by: Nishant Sharma
---
From: Achin Gupta
For better or worse, an StMM SP can communicate with the SPM through one
of these interfaces.
1. SPM_MM interface
2. FF-A v1.0 interface
3. FF-A v1.1 interface
2) implements only minimal FF-A support. It reuses the initialisation ABI
defined by 1) and wraps the remaining
From: Achin Gupta
Add new fid for Success, error and wait. Also add macro to generate FFA
verions.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
---
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 21 +++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git
From: Achin Gupta
With FF-A v1.1, the SPMC sends a reduced amount of boot information as
compared to the original SPM implementation. For example, the stack layout,
MP information etc. This information could be accommodated in the old data
structure but this is too complicated. This patch
From: Achin Gupta
This patch uses the FFA_MEM_PERM_GET/SET ABIs to tweak the permissions of a
set of pages if FF-A v1.1 and above is supported by the SPMC. For FF-A v1.0
the previous method through FFA_MSG_SEND_DIRECT_REQ/RESP is used.
Signed-off-by: Achin Gupta
Signed-off-by: Nishant Sharma
From: Achin Gupta
The StMM SP will extract boot information from its manifest instead of a C
data structure populated by the SPM. The manifest will be passed by the
SPM. This patch includes support for libfdt to prepare for parsing the
manifest in future patches.
Signed-off-by: Sayanta
From: Achin Gupta
The SPMC will pass the manifest to the StMM SP which contains the boot
information required for SP initialisation. This patch defines the data
structures defined in Section 5.4 of the FF-A v1.1 BETA0 spec to enable
this support. The manifest is identified by the TF-A
V1 :
Following patchset add the support of ARM Firmware Framework protocol to
MM communication.
Following chagnes are made to enable the support
1> Changed the FFA enable flag(PcdFfaEnable) to integer to enable it
use in assembly.
2> Add the support to Reserved SP stack space and program in
From: Achin Gupta
This patch removes the dependency on the SPM to allocate and initialise
stack memory for the StMM SP. This is done by reserving 8K worth of memory
in the StMM image at a page aligned address in the data section. Then,
instead of jumping directly to the C entrypoint, an
FeatureFlag type PCD flags are declared by typecasting an integer value
to BOOLEAN. These flags cannot be use in assembly code as assembler does
not recognise C primitive types. Change the flag data type from BOOLEAN
to UINT32.
Signed-off-by: Nishant Sharma
---
ArmPkg/ArmPkg.dec
Abdul,
Can you please send a patch to fix MmSaveStateLib to use gMmst (instead of
gSmst)?
Using gSmst forbids the lib instance be linked by standalone MM modules.
Thanks,
Ray
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, July 5, 2023 4:42 PM
> To: devel@edk2.groups.io;
bhyve supports adding a ROM to PCI devices. It was added to support GPU
passthrough of dedicated AMD GPUs. At the moment, this ROM file is
mostly useless as it's not shadowed and executed by firmware. Change
that by enabling bus enumeration.
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
We like to enable bus enumartion for bhyve. Therefore, this patch needs
to be reverted.
This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c.
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Rebecca Cran
We like to enable bus enumeration for bhyve. Therefore, this patch needs
to be reverted.
This reverts commit 8c8f886f27556f2fb6e8b502d32aa9ccee930acc.
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
CI: https://github.com/tianocore/edk2/pull/4543
Corvin Köhne (3):
Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"
OvmfPkg/BhyvePkg: enable bus enumeration
OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote:
> On Mon, Jul 10, 2023 at 2:28 PM wrote:
> >
> > I have an existing install of Ubuntu 22.04 on a QEMU virtual machine which
> > I've decided to update the UEFI firmware. After doing so, GRUB no longer
> > boots ("Synchronous
Reviewed-by: James Lu
Thanks,
James
-Original Message-
From: Lin, MarsX
Sent: Monday, July 10, 2023 5:02 PM
To: devel@edk2.groups.io
Cc: Lin, MarsX ; Dong, Guo ; Ni, Ray
; Rhodes, Sean ; Lu, James
; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Integrate UiApp and BootManagerMenuApp
61 matches
Mail list logo
