Re: [edk2-devel] [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

> -Original Message- > From: Ranbir Singh > Sent: Friday, July 14, 2023 12:47 AM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix > UNUSED_VALUE Coverity issue > > From: Ranbir Singh > >

Re: [edk2-devel] [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list

On Thu, Jul 13, 2023 at 12:08:02PM -0700, Tuan Phan wrote: > On Tue, Jul 4, 2023 at 12:01 AM Sunil V L wrote: > > > On Mon, Jul 03, 2023 at 11:45:45PM -0700, Tuan Phan wrote: > > > As i said, VirtNorFlashDxe needed to be loaded before VariableRuntimeDxe > > so > > > your suggestion will not

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, July 13, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, July 13, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

A general approach to this type of issues is to enable the new feature by default and optionally provide a setup option to disable the new feature. If there is a way to detect the failure case and fail gracefully back to the boot manager with an error message that indicates the type of issue

Re: [edk2-devel] [edk2-platforms][PATCH V1 09/20] StandaloneMmPkg: parse SP manifest and populate new boot information

Hi Chris, Prior to FF-A, an impdef structure populated by TF-A was passed to a SPM_MM based StMM SP. The data structures used for this are EFI_SECURE_PARTITION_BOOT_INFO and EFI_SECURE_PARTITION_CPU_INFO. With FF-A, we have reduced the amount of information that is passed e.g. the per-cpu

Re: [edk2-devel] [PATCH v4 5/7] OvmfPkg/RiscVVirt: Add VirtNorFlashDxe to APRIORI list

On Tue, Jul 4, 2023 at 12:01 AM Sunil V L wrote: > On Mon, Jul 03, 2023 at 11:45:45PM -0700, Tuan Phan wrote: > > As i said, VirtNorFlashDxe needed to be loaded before VariableRuntimeDxe > so > > your suggestion will not work. > > > Okay, at least for me, by removing APRIORI patch and adding

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

On 7/13/2023 10:41 AM, Pedro Falcato wrote: On Thu, Jul 13, 2023 at 6:20 PM Ard Biesheuvel wrote: On Thu, 13 Jul 2023 at 18:57, Pedro Falcato wrote: On Tue, Jul 11, 2023 at 7:58 AM Gerd Hoffmann wrote: On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote: On Mon, Jul 10, 2023

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

On Thu, Jul 13, 2023 at 6:20 PM Ard Biesheuvel wrote: > > On Thu, 13 Jul 2023 at 18:57, Pedro Falcato wrote: > > > > On Tue, Jul 11, 2023 at 7:58 AM Gerd Hoffmann wrote: > > > > > > On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote: > > > > On Mon, Jul 10, 2023 at 2:28 PM wrote: >

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

On Thu, 13 Jul 2023 at 18:57, Pedro Falcato wrote: > > On Tue, Jul 11, 2023 at 7:58 AM Gerd Hoffmann wrote: > > > > On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote: > > > On Mon, Jul 10, 2023 at 2:28 PM wrote: > > > > > > > > I have an existing install of Ubuntu 22.04 on a QEMU

Re: [edk2-devel] [edk2-platforms][PATCH V1 18/20] ArmPkg/MmCommunicationDxe: Discover the StMM SP

Should |EFI_FFA_PART_INFO_DESC be packed since its used across an ABI? Also there are a few immediately actionable TODO's in this commit. | |-Chris | On 7/11/2023 7:36 AM, Nishant Sharma wrote: From: Achin Gupta This patch adds support for discovering the presence of the SP using the

[edk2-devel] [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue

From: Ranbir Singh The return value stored in Status after call to SetDriveParameters is not made of any use thereafter and hence it remains as UNUSED. Add error check as is done after calls to SetDeviceTransferMode. Cc: Hao A Wu Cc: Ray Ni REF:

[edk2-devel] [PATCH v3 1/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity issue

From: Ranbir Singh Line number 1348 does contain a typecast with UINT32, but it is after all the operations (16-bit left shift followed by OR'ing) are over. To avoid any SIGN_EXTENSION, typecast the intermediate result after 16-bit left shift operation immediately with UINT32. Cc: Hao A Wu Cc:

[edk2-devel] [PATCH v3 0/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix

v2 -> v3: - [Patch 2] Update as per review comments v1 -> v2: - Retain outer cast - Add error check instead of Status storage removal Ranbir Singh (2): MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity issue MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE

Re: [edk2-devel] ArmVirtPkg: non-executable EFI_LOADER_DATA breaks GRUB on Ubuntu 22.04

On Tue, Jul 11, 2023 at 7:58 AM Gerd Hoffmann wrote: > > On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote: > > On Mon, Jul 10, 2023 at 2:28 PM wrote: > > > > > > I have an existing install of Ubuntu 22.04 on a QEMU virtual machine > > > which I've decided to update the UEFI

Re: [edk2-devel] [edk2-platforms][PATCH V1 14/20] ArmPkg/MmCommunicationDxe: Introduce FF-A version check

Might as well use MAKE_FFA_VERSION from ArmFfaSvc.h for consistency. -Chris On 7/11/2023 7:36 AM, Nishant Sharma wrote: From: Achin Gupta This patch adds support for querying whether FF-A v1.1 is supported by the FF-A impplementation. Signed-off-by: Achin Gupta Signed-off-by: Nishant

Re: [edk2-devel] [edk2-platforms][PATCH V1 09/20] StandaloneMmPkg: parse SP manifest and populate new boot information

Achin/Nishant, could you explain the motivation behind falling back to device tree for some of the secure partition information? It seems like we have this large abstraction framework using FF-A and it seems a bit odd to have the secure partition have to directly read device tree for some of

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

Mike, Would you be able to help us merge the patch? Thanks, Saloni -Original Message- From: Nickle Wang Sent: Wednesday, July 12, 2023 11:54 PM To: devel@edk2.groups.io; Kasbekar, Saloni ; Clark-williams, Zachary Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: RE:

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

Sorry I haven’t had a chance to look at it. I’ll try and find some time this weekend. On Thu, Jul 13, 2023, at 9:26 AM, Joey Vagedes via groups.io wrote: > Thank you for the review Michael. @Rebecca Cran > , @Liming Gao > have you had

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: BinToPcd: Resolve xdrlib deprecation

Thank you for the review Michael. @Rebecca Cran , @Liming Gao have you had time to take a look at this? It is a fairly simple change, following the same logic as xdrlib with a few modifications to use some newer python functionality. Thanks, Joey On Tue, Jun 27, 2023 at 10:21 AM Kinney, Michael

[edk2-devel] [PATCH v3 2/2] BaseTools: GenFw: auto-set nxcompat flag

Automatically set the nxcompat flag in the DLL Characteristics field of the Optional Header of the PE32+ image. For this flag to be set automatically, the section alignment must be evenly divisible by 4K (EFI_PAGE_SIZE) and no section must be executable and writable. Adds a command line flag to

[edk2-devel] [PATCH v3 0/2] Automatically set NXCOMPAT bit if requirements are met

v3: Updates function to be Doxygen compliant v3: Updates commit message v2: Adds --nonxcompat flag to GenFw; updates man page v2: Updates PeImage.h to reference spec 9.3 rather then 8.3 Utilize GenFw to automatically set the NXCOMPAT bit of the DLL Characteristics field of the Optional Header if

[edk2-devel] [PATCH v3 1/2] MdePkg: IndustryStandard: Add DLL Characteristics

Add the bit masks for DLL Characteristics, used within the optional header of a PE, to the PeImage.h header file. Update the Visual Studio, Microsoft Portable Executable and Common Object File Format Specification, and the PE/COFF Specification to the latest version. Cc: Michael D Kinney Cc:

Re: [edk2-devel] [edk2-platforms][PATCH V1 09/20] StandaloneMmPkg: parse SP manifest and populate new boot information

I had one comment , in-line. Thanks Girish On 7/11/2023 8:36 AM, Nishant Sharma via groups.io wrote: External email: Use caution opening links or attachments From: Achin Gupta This patch discovers the SP manifest in DT format passed by the SPMC. It then parses it to obtain the boot

[edk2-devel] Now: TianoCore Community Meeting EMEA/NAMO - Thursday, July 13, 2023 #cal-notice

*TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, July 13, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join on the

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, July 13, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, July 13, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |

[edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix S3

Currently, resuming an S3 suspended guest results in the following assertion failure: ASSERT MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.c(41): MemoryLength > 0 This happens because some parts of the S3 suspend and resume paths are missing in order for S3 to work. For

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

Nit: AcpiView, not Acpivew On Wed, Jul 12, 2023 at 4:16 PM levi.yun wrote: > > Currently, GTDT only prints the value of timer flags in hex. > This change prints the detail informaiton about Timer flags in GTDT. Nit: information > > before: > Shell> acpiview -s GTDT > ... >

[edk2-devel] [PATCH v4 1/1] MdePkg:Implement RISCV CMO

From: Dhaval Sharma Implementing code to support Cache Management Operations (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs Notes: 1. CMO only supports block based Operations. Meaning complete cache flush/invd/clean Operations are not available. In that case we fallback on

[edk2-devel] [PATCH v4 0/1] MdePkg:Implement RISCV CMO

Implementing code to support Cache Management Operations (CMO) defined by RV spec https://github.com/riscv/riscv-CMOs Notes: CMO only supports block based Operations. Meaning complete cache flush/invd/clean Operations are not available. In that case we fallback on fence.i instructions. Rely

[edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: reset session when TCP timeout happens

Call ResetHttpTslSession() to reset HTTP session when TCP timeout failure happens. So that application can perform retry to the same URI. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishRestExDxe/RedfishRestExInternal.h | 14

Re: [edk2-devel] [PATCH v2 0/4] Add support for generating ACPI ThermalZones

Hello Jeff, Thanks for the new version: Reviewed-by: Pierre Gondois On 7/11/23 00:25, Jeff Brasen wrote: Add APIs needed to create thermal zones dynamically. Does not add a generator for this as creating the TMP method generically may be difficult. Change log: v2 - renamed NameString

Re: [edk2-devel] [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

Reviewed by Robert Kowalewski -Original Message- From: Huang, Jenny Sent: Thursday, July 13, 2023 8:01 AM To: Sheng, W ; devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Kowalewski, Robert Subject: RE: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors Reviewed

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

Hello Levi, The patch looks good to me, also: Tested-by: Pierre Gondois Regards, Pierre On 7/12/23 13:44, levi.yun wrote: Currently, GTDT only prints the value of timer flags in hex. This change prints the detail informaiton about Timer flags in GTDT. before: Shell> acpiview -s GTDT

Re: [edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix driver binding start issue.

Hi Saloni, Could you please help to merge this fix since there is no objection during past weeks? Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Saloni > Kasbekar via groups.io > Sent: Friday, June 30, 2023 6:28 AM > To: Nickle Wang ;

[edk2-devel] [PATCH v5 3/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm: Add USB Cdc NCM devices support

This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Tested-by: Tinh Nguyen Acked-by: Hao A Wu Reviewed-by: Rebecca Cran

[edk2-devel] [PATCH v5 2/3] MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm: Add USB Cdc ECM devices support

This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Tested-by: Tinh Nguyen Acked-by: Hao A Wu Reviewed-by: Rebecca Cran

Re: [edk2-devel] [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors

Reviewed by Jenny Huang -Original Message- From: Sheng, W Sent: Wednesday, July 12, 2023 10:52 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: [PATCH] IntelSiliconPkg/Vtd: Resolve parameter transfer errors Fix the capsule