For this patch set, Acked-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Rohit
> Mathew
> 发送时间: 2023年7月18日 21:15
> 收件人: devel@edk2.groups.io; Rohit Mathew
> 抄送: Michael D Kinney ; Liming Gao
> ; Thomas Abraham
> ; Sami Mujawar ;
> James Morse ; Ray Ni ; Zhichao
> G
Ard:
Now, there is no compatible way to introduce new library class for the basic
module. One possible solution is to define the default library instance in
package dec file together with the library class declaration.
Beebe:
This patch set looks good. But, the last patch 9/9 will require e
Pierre:
Thanks for your update. For the changes in MdePkg, Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> PierreGondois
> 发送时间: 2023年7月18日 19:52
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao ; Jian J Wan
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, July 18, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed
Looks good to me.
Reviewed-by: Yi Li
-Original Message-
From: devel@edk2.groups.io On Behalf Of levi.yun
Sent: Tuesday, July 18, 2023 11:13 PM
To: devel@edk2.groups.io
Cc: yeoreum@arm.com; Yao, Jiewen ; Li, Yi1
; Lu, Xiaoyu1 ; Jiang, Guomin
; sami.muja...@arm.com; pierre.gond...@
Reviewed-by: Gua Guo
-Original Message-
From: Taylor Beebe
Sent: Wednesday, July 19, 2023 2:40 AM
To: devel@edk2.groups.io
Cc: Dong, Guo ; Rhodes, Sean ; Lu,
James ; Guo, Gua
Subject: [PATCH v1 7/9] UefiPayloadPkg: Add ImagePropertiesRecordLib Instance
Add an instance of ImageProper
On Tue, 18 Jul 2023 at 20:40, Taylor Beebe wrote:
>
> Reference: https://github.com/tianocore/edk2/pull/4590
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4492
>
> The UEFI and SMM MAT logic contains duplicate logic for manipulating image
> properties records which is used to track ru
With the new ImagePropertiesRecordLib, UEFI and SMM no longer need
to carry duplicate image properties record logic in their respective
MAT implementations.
Signed-off-by: Taylor Beebe
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
---
MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 784 +
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Signed-off-by: Taylor Beebe
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/Uef
Create a host-based unit test for the ImagePropertiesRecordLib
SplitTable() logic. This test has 4 cases which tests different
potential image and memory map layouts. 3/4 of these tests fail
with the logic in its current state to provide proof of the bugs
in the current MAT logic.
Signed-off-by: T
Fix the bugs in ImagePropertiesRecordLib (which is a copy of the
current UEFI MAT logic) before switching the UEFI and SMM MAT logic
to use the new library.
Signed-off-by: Taylor Beebe
Cc: Jian J Wang
Cc: Liming Gao
Cc: Dandan Bi
---
MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Signed-off-by: Taylor Beebe
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
---
ArmVirtPkg/ArmVirt.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/
The function EnforceMemoryMapAttribute() in the SMM MAT logic will
ensure that the CODE and DATA memory types have the desired attributes.
The consumer of the SMM MAT should only override the Attributes field
in the MAT if it is nonzero. This also allows the UEFI and SMM MAT
logic to use ImagePrope
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Signed-off-by: Taylor Beebe
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
---
OvmfPkg/AmdSev/AmdSevX64.dsc| 1 +
OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
OvmfPkg/CloudHv/CloudHvX
Add an instance of ImagePropertiesRecordLib which will be used by the
DXE Core.
Signed-off-by: Taylor Beebe
Cc: Andrew Fish
Cc: Ray Ni
---
EmulatorPkg/EmulatorPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index b44435d7e6e
Create a library for manipulating image properties records. Image
properties record logic is already present in both the SMM and
UEFI MAT logic, and this is a copy of the UEFI MAT logic with added
function arguments to remove dependencies on global variables.
Signed-off-by: Taylor Beebe
Cc: Jian
Reference: https://github.com/tianocore/edk2/pull/4590
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4492
The UEFI and SMM MAT logic contains duplicate logic for manipulating image
properties records which is used to track runtime images.
This patch series adds a new library, ImagePrope
When EcGenerateKey() is called with PublicKeySize set to zero or
less than the required size,
it returns the size of the required buffer with failure.
However, EcGenerateKey() generates a key and then checks
if the buffer size is insufficient.
This can be optimised by moving the public key size che
https://bugzilla.tianocore.org/show_bug.cgi?id=4502
Update SplitFspBin.py to support child FV in FSP binary. Without the
patch, the tool won't be able to rebase the images in child FV in FSP
binary.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Cc: Chinni B Duggapu
Cc: Ray
John,
The UEFI Forum (https://uefi.org/) is the industry trade group that owns the
UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools
Thanks,
Andrew Fish
> On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io
> wrote:
>
> Hello,
>
> I am John Sellock, an
Hi,
Gentle reminder on the series.
Regards,
Rohit
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rohit
> Mathew via groups.io
> Sent: Monday, May 22, 2023 3:44 PM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Liming Gao
> ; Thomas Abraham
> ; Sami Mujawar ;
> James
From: Pierre Gondois
The first element of mAvailableAlgoArray is defined as the default
Rng algorithm to use. Don't go through the array at each RngGetRNG()
call and just return the first element of the array.
Signed-off-by: Pierre Gondois
Reviewed-by: Sami Mujawar
---
.../RandomNumberGenerat
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151
The EFI_RNG_PROTOCOL can rely on the RngLib. The RngLib has multiple
implementations, some of them are unsafe (e.g. BaseRngLibTimerLib).
To allow the RngDxe to detect when such implementation is used,
a GetRngGuid() fun
From: Pierre Gondois
The EFI_RNG_PROTOCOL can use the RngLib. The RngLib has multiple
implementations, some of them are unsafe (e.g. BaseRngLibTimerLib).
To allow the RngDxe to detect when such implementation is used,
add a GetRngGuid() function to the RngLib.
Signed-off-by: Pierre Gondois
Revi
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4441
The EFI_RNG_PROTOCOL can rely on the RngLib. The RngLib has multiple
implementations, some of them are unsafe (e.g. BaseRngLibTimerLib).
To allow the RngDxe to detect when such implementation is used,
a GetRngGuid() fun
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4441
The EFI_RNG_PROTOCOL can rely on the RngLib. The RngLib has multiple
implementations, some of them are unsafe (e.g. BaseRngLibTimerLib).
To allow the RngDxe to detect when such implementation is used,
a GetRngGuid() fun
From: Pierre Gondois
The DxeRngLib tries to generate a random number using the 3 NIST
SP 800-90 compliant DRBG algorithms, i.e. 256-bits CTR, HASH and HMAC.
If none of the call is successful, the fallback option is the default
RNG algorithm of the EFI_RNG_PROTOCOL. This default algorithm might
be
From: Pierre Gondois
In order to use PcdCpuRngSupportedAlgorithm in the MdePkg in a
following patch and to avoid making the MdePkg dependent on another
package, move PcdCpuRngSupportedAlgorithm to the MdePkg.
As the Pcd is only used for AARCH64, place it in an AARCH64
specific sections.
Signed-
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4504
To keep the MdePkg self-contained and avoid dependencies on GUIDs
defined in other packages, the BaseRngLibTimer was moved to the
MdePkg.
Add a constructor to warn and request to use the MdeModulePkg
implementation.
Si
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4504
The BaseRngLibTimerLib allows to generate number based on a timer.
This mechanism allows to have a basic non-secure implementation
for non-production platforms.
To bind and identify Random Number Generators implementati
From: Pierre Gondois
v5:
- Let an implementation of BaseRngLibTimer in MdePkg to give some
time to platform owners to use the MdeModulePkg implementation. [4]
- New patch:
- [2/8] MdePkg: Add deprecated warning to BaseRngLibTimer
v4:
- New patches:
- [1/8] MdePkg: Move BaseRngLibTimerLib t
From: Masahisa Kojima
Fix typo in Readme.md
Signed-off-by: Masahisa Kojima
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/Readme.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Qemu/SbsaQemu/Readme.md b/Platform/Qemu/SbsaQemu/Readme.md
index cdee8
From: Ranbir Singh
Line number 365 does contain a typecast with UINT32, but it is after
all the operations (16-bit left shift followed by OR'ing) are over.
To avoid any SIGN_EXTENSION, typecast the intermediate result after
16-bit left shift operation immediately with UINT32.
REF: https://bugzil
Ranbir Singh (1):
MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue
MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4
1 file changed, 4 deletions(-)
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
From: Ranbir Singh
The function NotifyPhase has a check
ASSERT (Index < TypeMax);
but this comes into play only in DEBUG mode. In Release mode, there is
no handling if the Index value is within array limits or not. If for
whatever reasons, the Index does not get re-assigned to Index2 at lin
From: Ranbir Singh
The function SubmitResources has a switch-case code in which the
case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to
case ACPI_ADDRESS_SPACE_TYPE_IO: if there is no scenario of
return EFI_INVALID_PARAMETER;
While this may be intentional, it is not evident to any general c
v1 -> v2:
- Retain outer cast
Ranbir Singh (1):
MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
From: Ranbir Singh
The function NotifyPhase has a check
ASSERT (Index < TypeMax);
but this comes into play only in DEBUG mode. In Release mode, there is
no handling if the Index value is within array limits or not. If for
whatever reasons, the Index does not get re-assigned to Index2 at lin
From: Ranbir Singh
The code can reach line 65 only through the else path above at line 53.
The else path already has the same NULL check at line 55 and hence the
duplicate code lines are totally redundant which can be deleted.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220
Cc: Hao A W
Ranbir Singh (2):
MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix OVERRUN Coverity issues
MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix MISSING_BREAK Coverity
issue
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 9 +
1 file changed, 9 insertions(+)
--
2.34.1
-=-=-=-=-=-=-=-=
From: Ranbir Singh
The function UsbHcGetPciAddressForHostMem has
ASSERT ((Block != NULL)); and
and the function UsbHcFreeMem has
ASSERT (Block != NULL);
statement after for loop, but these are applicable only in DEBUG mode.
In RELEASE mode, if for whatever reasons there is no match inside
From: Ranbir Singh
The function UhciConvertPollRate has a check
ASSERT (Interval != 0);
but this comes into play only in DEBUG mode. In Release mode, there is
no handling if the Interval parameter value is ZERO. To avoid shifting
by a negative amount later in the code flow in this undesirab
Ranbir Singh (2):
MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix OVERRUN Coverity issues
MdeModulePkg/Bus/Pci/PciHostBridgeDxe: Fix MISSING_BREAK Coverity
issue
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 9 +
1 file changed, 9 insertions(+)
--
2.34.1
-=-=-=-=-=-=-=-=
From: Ranbir Singh
The function SubmitResources has a switch-case code in which the
case ACPI_ADDRESS_SPACE_TYPE_MEM: which falls through to
case ACPI_ADDRESS_SPACE_TYPE_IO: if there is no scenario of
return EFI_INVALID_PARAMETER;
While this may be intentional, it is not evident to any general c
From: Ranbir Singh
The return value stored in Status after call to SetDriveParameters
is not made of any use thereafter and hence it remains as UNUSED.
Based on Hao's findings (https://edk2.groups.io/g/devel/message/106844),
the successful execution of SetDriveParameters() is not mandatory for
i
From: Ranbir Singh
Line number 365 does contain a typecast with UINT32, but it is after
all the operations (16-bit left shift followed by OR'ing) are over.
To avoid any SIGN_EXTENSION, typecast the intermediate result after
16-bit left shift operation immediately with UINT32.
REF: https://bugzil
Ranbir Singh (2):
MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue
MdeModulePkg/Bus/Pci/UhciDxe: Fix FORWARD_NULL Coverity issues
MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c | 4
MdeModulePkg/Bus/Pci/UhciDxe/UsbHcMem.c | 9 +
2 files changed, 13 insertions(+)
--
2.34.1
v3 -> v4:
- [Patch 2] Further update as per review comments
- Status storage removal at call point
- Error checks moved inside SetDriveParameters function
v2 -> v3:
- [Patch 2] Update as per review comments
v1 -> v2:
- Retain outer cast
- Add error check instead of Status sto
v1 -> v2:
- Retain outer cast
Ranbir Singh (1):
MdeModulePkg/Bus/Ata/AtaBusDxe: Fix SIGN_EXTENSION Coverity issue
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
From: Ranbir Singh
Line number 1348 does contain a typecast with UINT32, but it is after
all the operations (16-bit left shift followed by OR'ing) are over.
To avoid any SIGN_EXTENSION, typecast the intermediate result after
16-bit left shift operation immediately with UINT32.
REF: https://bugzi
Hello,
I am John Sellock, an Associate Software Engineering Technician at Leonardo
DRS.
I believe I need Self-Certification Test source code for UEFI 2.5, but I
cannot find any saved archive for it available in the tianocore or edk2-test
repositories.
I would appreciate if someone could point
From: Yang Wang
Check EmacGetDmaStatus input parameters
IrqStat may be a null pointer.
Cc: Michael D Kinney
Cc: Loh Tien Hock
Cc: Ooi Tzy Way
Cc: Ran Wang
Signed-off-by: Yang Wang
---
.../Drivers/DwEmacSnpDxe/DwEmacSnpDxe.c | 7 +--
.../Drivers/DwEmacSnpDxe/EmacDxeUtil.c
Thanks Chris, I will take some time to review it.
-Original Message-
From: Ni, Ray
Sent: Friday, June 30, 2023 2:08 PM
To: devel@edk2.groups.io; chri...@os.amperecomputing.com; Yao, Jiewen
; Nong, Foster
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Add Cxl20.h into IndustryStandard
Hi
We find a bug in xhci, USB DVD boot with emtpy disk will hang Xhci while
Ehci can pass.
The hang log is shown as : MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c(1847):
TrsRing != ((void *) 0)
We suggest a way to solve this bug is shown as:
https://github.com/suling-123/edk2 the late
Hi Li!
On 18/07/2023 07:03, Li, Yi1 wrote:
Hi,
This function has a special use case: when the input PublicKey array is NULL
and size is 0, the function will generate EC keypair and update context, and
fill PublicKeySize with non-zero keysize to indicate success.
(CryptEc.c L492)
if ((Pub
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4501
Modify the way of processing input arguments in
RebaseFspBinBaseAddress script.
Add an option to skip FSP rebase.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Jie Yang
---
.../Tools/Fs
56 matches
Mail list logo
