[edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

2023-08-07 Thread Tommy Huang via groups.io
1.Update the X64/AArch64 UEFI GOP driver into v1.13.03. 2.Update the .inf version. 3.Modify report framebuffer base behavior. Cc: Ard Biesheuvel Cc: Isaac Oram Cc: Nate DeSimone Cc: Leif Lindholm Cc: Michael D Kinney Cc: Ryan Chen Cc: BMC-SW Signed-off-by: Tommy Huang --- .../AArch64/ASp

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/AppPkg: Fix documentation issue with edk2module.c

2023-08-07 Thread Jayaprakash, N
Reviewed-by: Jayaprakash Nevara -Original Message- From: R, Vishal Sent: Thursday, August 3, 2023 10:12 PM To: devel@edk2.groups.io Cc: R, Vishal ; Rebecca Cran ; Kinney, Michael D ; Jayaprakash, N Subject: [edk2-libc Patch 1/1] edk2-libc/AppPkg: Fix documentation issue with edk2mod

Re: [edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API

2023-08-07 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107632): https://edk2.groups.io/g/devel/message/107632 Mute This Topic:

Re: [edk2-devel] [PATCH v2 1/4] DynamicTablesPkg: Add ThermalZone CodeGen function

2023-08-07 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. Other than the missing sign-off, this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107631): https://edk2.groups.io/g/devel/m

Re: [edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: Add support to add Strings to package

2023-08-07 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. Please see my response inline. On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote: > > + > + Status = AmlVarListAddTail ( > + (AML_NODE_HANDLE)PackageNode, > + (AML_NODE_HANDLE)DataNode > + ); > + ASSERT_EFI_ERROR (Status); > + I think if the above function

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add support for simple method invocation.

2023-08-07 Thread Sami Mujawar
Hi Jeff, Apologies for the delay in feedback. Please see my response inline. On Mon, Jul 10, 2023 at 03:26 PM, Jeff Brasen wrote: > > + > + // AmlCodeGenReturn() deletes DataNode if error. > + Status = AmlCodeGenReturn ( > + (AML_NODE_HEADER *)DataNode, > + ParentNode, > + &ObjectNode > + ); >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-08-07 Thread Wang, Yin
Hi Sunil, I will be providing a detailed update soon, along with a new version. Thank you for your careful review and comments. Best regards, Yin -Original Message- From: Sunil V L Sent: Monday, August 7, 2023 8:02 PM To: devel@edk2.groups.io; Wang, Yin Subject: Re: [edk2-devel] [PATCH

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, August 8, 2023 #cal-reminder

2023-08-07 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, August 8, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4e

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, August 7, 2023 #cal-notice

2023-08-07 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, August 7, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1

Re: [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes

2023-08-07 Thread Nate DeSimone
The series as been pushed as ~107ddf1..3c274c0 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, July 31, 2023 11:43 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: [edk2-devel] [PATCH v1 0/2] MdePkg: Add miss

Re: [edk2-devel] [PATCH v1 24/24] IntelFsp2WrapperPkg: CI: Add PrEval entry

2023-08-07 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Joey Vagedes > Sent: Monday, June 26, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Chen, Gang C ; > Zeng, Star ; Kuo, Ted ; S, Ashraf > Ali ; Mohapatra, Susovan > > Su

Re: [edk2-devel] [PATCH v1 12/24] IntelFsp2Pkg: CI: Add PrEval entry

2023-08-07 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Joey Vagedes > Sent: Monday, June 26, 2023 2:34 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Ng, Ray Han Lim ; > Zeng, Star ; Kuo, Ted ; S, Ashraf > Ali ; Mohapatra, Susovan > >

Re: [edk2-devel] [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry

2023-08-07 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Joey Vagedes > Sent: Monday, June 26, 2023 2:34 PM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Desimone, Nathaniel L > > Subject: [PATCH v1 19/24] PrmPkg: CI: Add PrEval entry > > Adds a PrEval entry to the package's ci.yam

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, August 7, 2023 #cal-reminder

2023-08-07 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, August 7, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-07 Thread Ard Biesheuvel
On Mon, 7 Aug 2023 at 13:31, Corvin Köhne wrote: > > On Mon, 2023-07-24 at 14:59 +0200, Corvin Köhne wrote: > > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. > > > > QemuFwCfgLib expect this HOB to be present, or fails to do anything. > > InternalQemuFwCfgIsAvailable() from Qe

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-08-07 Thread Rohit Mathew
Hi Pierre, > -Original Message- > From: Pierre Gondois > Sent: Friday, August 4, 2023 12:20 PM > To: Rohit Mathew ; devel@edk2.groups.io > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ray Ni > ; Zhichao Gao ; nd > > Subject: Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add M

Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-08-07 Thread Sunil V L
Hi Wang, Thanks for the patch! It will be good if you add versions to the patch subject. Even if you go back to v1, better to send as v3 with the change log. On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote: > Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig") fi

Re: [edk2-devel] [PATCH V6 0/2] SecureBoot: Support RSA 512 and RSA 384

2023-08-07 Thread Yao, Jiewen
> Set signature type to gEfiCertX509Guid when enroll RSA3072/RSA4096 KEK. === switch (KeyLenInBytes) { case WIN_CERT_UEFI_RSA2048_SIZE: CopyGuid (&KekSigList->SignatureType, &gEfiCertRsa2048Guid); break; case WIN_CERT_UEFI_RSA3072_SIZE: case WIN_CERT_UEFI_RSA4096_SIZE: Copy

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-07 Thread Corvin Köhne
On Mon, 2023-07-24 at 14:59 +0200, Corvin Köhne wrote: > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. > > QemuFwCfgLib expect this HOB to be present, or fails to do anything. > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not > check if the HOB is actually

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-07 Thread Laszlo Ersek
On 8/3/23 23:25, Ard Biesheuvel wrote: > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > wrote: >> >> Hi Ard, >> >> This is the email with the analysis and the flag >> setting required for SMP to work with SMM enabled for >> IA32/X64 QEMU. >> >> https://edk2.groups.io/g/devel/message/102364 >> >>

Re: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-08-07 Thread Sheng Wei
Hi Jiewen, I remove the new GUIDs. I use signature type gEfiCertX509Guid when enroll RSA3072/RSA4096 KEK. This signature type is used in below 6 places. 1) Show key name string in KEK delete page UpdateDeletePage() 2) Check supported SignatureType when delete KEK DeleteKe

[edk2-devel] [PATCH V6 2/2] SecurityPkg/SecureBoot: Support RSA 512 and RSA 384

2023-08-07 Thread Sheng Wei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413 Change-Id: Ic13595ffb0581a178db71d231ba34f17862fa5d8 Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Cc: Zeyi Chen Cc: Fiona Wang Signed-off-by: Sheng Wei --- .../Library/AuthVariableLib/AuthService.c | 218 +++--- .../AuthV

[edk2-devel] [PATCH V6 1/2] CryptoPkg/Library/BaseCryptLib: add sha384 and sha512 to ImageTimestampVerify

2023-08-07 Thread Sheng Wei
Register and initialize sha384/sha512 digest algorithms for PKCS#7 Handling. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413 Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu Cc: Zeyi Chen Cc: Fiona Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Change-Id: I208a618e3f6eb12704e

[edk2-devel] [PATCH V6 0/2] SecureBoot: Support RSA 512 and RSA 384

2023-08-07 Thread Sheng Wei
Patch V6: Remove the changes in MdePkg. The changes of patch v6 are in CryptoPkg and SecurityPkg. Set signature type to gEfiCertX509Guid when enroll RSA3072/RSA4096 KEK. This signature type is used to check the supported signature and show the strings. Patch V5: Using define KEY_TYPE_RSASSA to re