Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config

Hi Sunil, Qingyu is from Penglai team, when we were working together in enabling StandaloneMm variable service, we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the blockmap config is not aligned with the value in OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashS

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG？

Yes, the RELEASE build compiler flags should be relaxed, all error checks that the DEBUG target should do, it doesn't belong to the RELEASE's job. --- OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc b/O

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

Hi Ard and Ming, I have been seeing an issue with StandaloneMM HobLib that can be fixed by this patch as well. The function CreateHob() in the HobLib instance StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf does not work at all. The HobList is early created by the

Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config

On Wed, Aug 16, 2023 at 07:08:58AM +, Li, Yong wrote: > Hi Sunil, > > Qingyu is from Penglai team, when we were working together in enabling > StandaloneMm variable service, > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the > blockmap config is not aligned with the va

回复: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config

Hi Sunil, Happy you like that! I will CC all the related maintainers by that python script next time. Thanks! Qingyu -原始邮件- 发件人: "Sunil V L" 收件人: "Li, Yong" 抄送: devel@edk2.groups.io, 2931013...@sjtu.edu.cn, "Warkentin, Andrei" 已发送邮件: 星期三, 8 月 16, 2023 05:03:00 PM 主题: Re: [e

[edk2-devel] [PATCH edk2-platforms 0/1] Enlarge firmware offsets

I am back from vacations. Started debug build and was greeted with message that my firmware is too big: GenFv: ERROR 3000: Invalid the required fv image size 0x216510 exceeds the set fv image size 0x20 Which is weird as QemuSbsa uses 256MB flash images. So as quick hack I decided to bump s

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: enlarge firmware offsets

GenFv: ERROR 3000: Invalid the required fv image size 0x216510 exceeds the set fv image size 0x20 Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

[AMD Official Use Only - General] Hello Hao, Its no problem. I agree that the endpoint transfer rings should be allocated after the UsbSetConfig command, but this is not the case. In XhcControlTransfer, after the if statement checking for USB_REQ_SET_CONFIG, the for-loop loops through all of D

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG？

Can you provide the specific build error? So far, we have not had to relax that flag for any RELEASE builds. Thanks, Mike From: devel@edk2.groups.io On Behalf Of ?? Sent: Wednesday, August 16, 2023 12:46 AM To: Andrew (EFI) Fish Cc: edk2-devel-groups-io Subject: Re: [edk2-devel] Can RELEASE

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Hi @Yao, Jiewen, Could you please share your thoughts. Please let me know if you have any queries or concerns. Thanks & Regards Karunakar Poosapalli Firmware Principal Engineer, Client BIOS Customer BIOS | Dell Core BIOS CPG Software Engineering | Dell Technologies M

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG？

Mike, I seem to remember it was a maybe-uninitialized compiler error. The DEBUG build did not hit it due to the NULL check in the ASSERT. The NULL check only exists if ASSERT() is enabled. So if ASSERT is disabled this code in the DXE Core will dereference a NULL pointer. > ASSERT (Prot

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG？

Hi Andrew, There are compiler flags we set to suppress some of these types of specific warnings to avoid disable warnings as errors. For example, this commit to tools_def.template: https://github.com/tianocore/edk2/commit/8e985ac3fdb2b117968ac1fa1f54666e166af8ac I would like to see the compile

Re: [edk2-devel] How to report bugs in the Intel GigUndiDxe driver?

On Wed, 16 Aug 2023 at 05:40, Rebecca Cran wrote: > > Intel has been releasing the EDK2/UEFI source code for their network > drivers > (https://www.intel.com/content/www/us/en/download/15755/intel-ethernet-connections-boot-utility-preboot-images-and-efi-drivers.html) > but I've found a few problem

Re: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

Can I please get reviews/feedback on this patch series? On 8/4/2023 12:46 PM, Taylor Beebe via groups.io wrote: From: Taylor Beebe v4: - Expose additional functions in the Library API - Add NULL checks to library functions and return a status where applicable. v3: - Refactor patch series s

[edk2-devel] [0/2] Fixes for AmdSev OVMF package regressions

A couple changes broke booting of SEV and SNP guests when using the AmdSevX64 package in conjunction with QEMU: UefiCpuPkg:Wake up APs after power-up or RESET through SIPI. OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub Both fixes are fairly straightforward and mainly seem to stem from

[edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot

Booting an SEV guest with AmdSev OVMF package currently triggers the following assertion with QEMU: InstallQemuFwCfgTables: installed 7 tables PcRtc: Write 0x20 to CMOS location 0x32 [Variable]END_OF_DXE is signaled Initialize variable error flag (FF) ASSERT_EFI_ERROR (Status = Not Foun

[edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti

PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is true by default, but needs to be disabled for QEMU/OVMF where early INIT is not simulated. Commit 1d76560146 ("OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.") a

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti

On Wed, 16 Aug 2023 at 22:13, Michael Roth wrote: > > PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when > the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is > true by default, but needs to be disabled for QEMU/OVMF where early INIT > is not simulated. Commit 1

[edk2-devel] [PATCH v2 0/7] Uncrustify GoogleTest update

v1 -> v2: - Update commit message to explain the audit only mode change is temporary to prevent intermediate CI failures. - Format patch Cc's correctly v1 archive:https://edk2.groups.io/g/devel/message/107665 VivianNK (7): .pytool: Set uncrustify check to audit only (temporary) .pytool:

Re: [edk2-devel] About EDK2 supports Self Modifying Code

Hi Pedro, Sorry for the late reply, I was a bit busy yesterday. I think the better way is to use inline asm, because this issue must has to be dealt with in preprocessing stage, because in other stages, it has no chance to get immediate value except using SMC. But then we should ask to the Md

Re: [edk2-devel] [PATCH v2 5/7] SecurityPkg: Apply uncrustify formatting to relevant files

Reviewed-by: Jiewen Yao > -Original Message- > From: VivianNK > Sent: Thursday, August 17, 2023 5:15 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > Subject: [PATCH v2 5/7] SecurityPkg: Apply uncrustify formatting to relevant > files > > Apply uncrustify formatting to

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Hi Karunakar Thanks for the patient. I think my concern is universal, no matter it is after user input the key or not. The clear-screen behavior is a *change*. And it may break the compatibility. Unless all BIOS consumer in EDKII community agree the behavior, the risk is always there. To move

Re: [edk2-devel] About EDK2 supports Self Modifying Code

Loop Mike. Hi Mike and Liming, Please refer to history emails. The Self-Modifying-Code(SMC) method has security risks and no one approve it. Ard and Pedro suggest using inline ASM in MdePkg. For this problem, it can only dealt with in the preprocessing stage, because the CSR instructions ca

[edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

Deactivate PcdFirstTimeWakeUpAPsBySipi for AMD SEV and SNP to preserve the original execution of INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Yuanhao Xie --- OvmfPkg/AmdSev/AmdSevX64.dsc | 7 +

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG？

This is the failed build log: https://build.tarsier-infra.com/package/live_build_log/home:ouuleilei:branches:openEuler:Mainline/edk2/openEuler_Mainline_standard_riscv64_gcc/riscv64 arch:riscv64 gcc version： 10.3.1 -原始郵件- 發件人:"Kinney, Michael D" 發送時間:2023-08-17 0