Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-08-23 Thread Mike Beaton
Apologies, no Signed-off-by, I will send v2. On Thu, 24 Aug 2023 at 06:52, Mike Beaton wrote: > > --- > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[edk2-devel] [PATCH v2] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-08-23 Thread Mike Beaton
Signed-off-by: Mike Beaton --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c index

[edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-08-23 Thread Mike Beaton
--- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c index 96e05d4cf9..f67b7760f0 100644 ---

回复: [edk2-devel] PATCH v2] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU"

2023-08-23 Thread gaoliming via groups.io
Include Rebecca who makes the original change. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Mike Beaton > 发送时间: 2023年8月24日 13:00 > 收件人: devel@edk2.groups.io > 主题: [edk2-devel] PATCH v2] Revert "OvmfPkg: Update build.sh to allow > building OVMF then running QEMU" > >

[edk2-devel] PATCH v2] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU"

2023-08-23 Thread Mike Beaton
This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46. Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528 Signed-off-by: Mike Beaton --- OvmfPkg/build.sh | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index

Re: [edk2-devel] [PATCH] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU"

2023-08-23 Thread Mike Beaton
This includes an extraneous whitespace line at end of file, I will send a v2. On Thu, 24 Aug 2023 at 05:45, Mike Beaton wrote: > > This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46. > > Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528 > > Signed-off-by: Mike Beaton > --- >

[edk2-devel] [PATCH] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU"

2023-08-23 Thread Mike Beaton
This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46. Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528 Signed-off-by: Mike Beaton --- OvmfPkg/build.sh | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index

edk2-stable202308: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config

2023-08-23 Thread gaoliming via groups.io
Sunil: I agree this is a critical bug fix. The fix is correct. CI failure is not related to this change. If no other comment, I will help merge this change tomorrow. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Sunil V L > 发送时间: 2023年8月22日 14:26 > 收件人: devel@edk2.groups.io;

回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH 1/1] MdeModulePkg/PciBusDxe: Fix boot hang with faulty PCI Option ROM

2023-08-23 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nhi Pham via > groups.io > 发送时间: 2023年8月21日 11:41 > 收件人: devel@edk2.groups.io > 抄送: Nhi Pham ; Jian J Wang > ; Liming Gao ; Hao A > Wu > 主题: [ ** SPAMMAIL ** ][edk2-devel] [PATCH 1/1] > MdeModulePkg/PciBusDxe: Fix boot

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-23 Thread Pedro Falcato
On Wed, Aug 23, 2023 at 10:41 PM Rebecca Cran wrote: > > With Visual Studio 2019 adding C11 and C17 support as first-class > features, I think we should be safe nowadays to rely on them. But we > should check if older versions that we still support (VS 2015 etc.) > support them too. > >

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-23 Thread Rebecca Cran
With Visual Studio 2019 adding C11 and C17 support as first-class features, I think we should be safe nowadays to rely on them. But we should check if older versions that we still support (VS 2015 etc.) support them too.

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-08-23 Thread Pedro Falcato
On Wed, Aug 23, 2023 at 4:12 PM Ard Biesheuvel wrote: > > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > > > On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote: > > > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > > > > > > > Looks good to me. > > > > > > > > What is

Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF

2023-08-23 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On Wed, Aug 23, 2023, at 9:15 AM, Leif Lindholm wrote: > The CLANGDWARF progfile sets both -Wno-tautological-compare and > -Wno-tautological-constant-out-of-range-compare, but this prevents > compile-time detection of certain errors. > Drop these flags. > >

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-08-23 Thread Gerd Hoffmann
On Wed, Aug 23, 2023 at 05:11:49PM +0200, Ard Biesheuvel wrote: > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > > > On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote: > > > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > > > > > > > Looks good to me. > > > > > > > >

Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-23 Thread Sureshkumar Ponnusamy via groups.io
The changes looks good . Thanks Abhi and Sunny. -Original Message- From: Sunny Wang Sent: Wednesday, August 23, 2023 5:40 AM To: devel@edk2.groups.io; Abhi Singh Cc: G Edhaya Chandran ; Barton Gao ; Samer El-Haj-Mahmoud ; Sureshkumar Ponnusamy ; Felix Polyudov ; Sunny Wang Subject:

[edk2-devel] BUG:T imer callback in UEFI application is hanging only in AMI BIOS #bad_mem

2023-08-23 Thread sasha110397
While porting UEFI application from AARCH64 to X64 i ran into following problem: application was hanging after enabling periodic timer (timer is used in application for I/O polling). Timer callback finishes and nothing executes afterwards. During debugging i tried to find error in code but

Re: [edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF

2023-08-23 Thread Ard Biesheuvel
On Wed, 23 Aug 2023 at 17:15, Leif Lindholm wrote: > > The CLANGDWARF progfile sets both -Wno-tautological-compare and > -Wno-tautological-constant-out-of-range-compare, but this prevents > compile-time detection of certain errors. > Drop these flags. > > Signed-off-by: Leif Lindholm > Cc:

[edk2-devel] [RFC PATCH 1/1] BaseTools: drop tautological warning overrides for CLANGDWARF

2023-08-23 Thread Leif Lindholm
The CLANGDWARF progfile sets both -Wno-tautological-compare and -Wno-tautological-constant-out-of-range-compare, but this prevents compile-time detection of certain errors. Drop these flags. Signed-off-by: Leif Lindholm Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Ard

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-08-23 Thread Ard Biesheuvel
On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote: > > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > > > > > Looks good to me. > > > > > > What is the status? Merged? Or waiting for testing still? If so I can > > >

Re: [edk2-devel] [PATCH v6 02/11] BaseTools: add -fdirect-access-external-data to clang pie builds

2023-08-23 Thread Ard Biesheuvel
On Wed, 23 Aug 2023 at 13:09, Leif Lindholm wrote: > > Since I didn't find any previous record of the fact, I'm replying here > to say that this change breaks the build with clang11 as packaged in > Debian "bullseye" (old stable). > > If anyone could reply with which version of clang this flag

[edk2-devel] [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support

2023-08-23 Thread ManickamX Srinivasan
The length of the Board ID is being updated based on the BOARD_ID string. If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: T V

Re: [edk2-devel] [PATCH v6 02/11] BaseTools: add -fdirect-access-external-data to clang pie builds

2023-08-23 Thread Leif Lindholm
Since I didn't find any previous record of the fact, I'm replying here to say that this change breaks the build with clang11 as packaged in Debian "bullseye" (old stable). If anyone could reply with which version of clang this flag was added in, that would be ideal. Since no one else

Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy

2023-08-23 Thread Gerd Hoffmann
On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote: > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > > > Looks good to me. > > > > What is the status? Merged? Or waiting for testing still? If so I can > > create a test build with the patch and ask our QE department to check

[edk2-devel] [edk2-platforms][PATCH V3 1/1] Platform/ARM/N1sdp: Add support to parse NT_FW_CONFIG

2023-08-23 Thread sahil
NT_FW_CONFIG DTB contains platform information passed by Tf-A boot stage. This information is used for Virtual memory map generation during PEI phase and passed on to DXE phase as a HOB, where it is used in ConfigurationManagerDxe. This patch adds a PEI to parse NT_FW_CONFIG and pass it to other

Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-23 Thread G Edhaya Chandran
Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107974): https://edk2.groups.io/g/devel/message/107974 Mute This Topic: https://groups.io/mt/100899969/21656 Group Owner:

Re: [edk2-devel] [PATCH V1 1/1] uefi-sct/SctPkg: RouteConfig() returns EFI_ACCESS_DENIED passes with warning

2023-08-23 Thread Sunny Wang
Looks good to me. Thanks for working on this, Abhi. Cc people to the email. Somehow the people you added in your commit message haven't been automatically added to email's Cc list. I guess you might accidentally use " --suppress-cc=all" when you sent the patch out. Reviewed-by: Sunny Wang

[edk2-devel] [PATCH v2] DynamicTablesPkg: HOWTO for Handcrafted tables

2023-08-23 Thread Jose Marinho
Update the DynamicTablesPkg documentation to explain how to specify ACPI tables in RAW format, or when there are no defined table generators. Cc: Sami Mujawar Cc: Pierre Gondois Cc: Samer El-Haj-Mahmoud Signed-off-by: Jose Marinho --- DynamicTablesPkg/Readme.md | 120

[edk2-devel] [PATCH] DynamicTablesPkg: HOWTO for Handcrafted tables

2023-08-23 Thread Jose Marinho
Cc: Sami Mujawar Cc: Pierre Gondois Cc: Samer El-Haj-Mahmoud Signed-off-by: Jose Marinho --- DynamicTablesPkg/Readme.md | 120 + 1 file changed, 120 insertions(+) diff --git a/DynamicTablesPkg/Readme.md b/DynamicTablesPkg/Readme.md index