Re: [edk2-devel] [Patch V2 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

2023-09-05 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Wednesday, September 6, 2023 11:22 AM To: devel@edk2.groups.io ; Tan, Dun Cc: Ni, Ray ; Wang, Jian J ; Gao, Liming Subject: RE: [edk2-devel] [Patch V2 1/5] MdeModulePkg: add MpService2Ppi field in

Re: [edk2-devel] [Patch V3 5/5] UefiCpuPkg/PiSmmCpuDxe: use MpService2Ppi to wakeup AP in s3

2023-09-05 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Wednesday, August 30, 2023 3:34 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul R Subject: [Patch V3 5/5] UefiCpuPkg/PiSmmCpuDxe: use MpService2Ppi to wakeup AP in s3 Use

Re: [edk2-devel] [Patch V3 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement for CpuS3.c

2023-09-05 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Wednesday, August 30, 2023 3:34 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul R Subject: [Patch V3 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement for CpuS3.c This commit is code logic

Re: [edk2-devel] [Patch V2 1/5] MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE

2023-09-05 Thread duntan
Hi Jian and Liming, Could you please help to review this patch? Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Monday, August 21, 2023 10:10 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Wang, Jian J ; Gao, Liming Subject: [edk2-devel] [Patch V2 1/5]

Re: [edk2-devel] [Patch V2 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo

2023-09-05 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Monday, August 21, 2023 10:09 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul R Subject: [Patch V2 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo Add assert for

Re: [edk2-devel] [Patch V2 2/5] UefiCpuPkg/S3Resume2Pei: prepare MpService2Ppi in S3Resume

2023-09-05 Thread Ni, Ray
Reviewed-by: Ray Ni Thanks, Ray From: Tan, Dun Sent: Monday, August 21, 2023 10:09 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul R Subject: [Patch V2 2/5] UefiCpuPkg/S3Resume2Pei: prepare MpService2Ppi in S3Resume Prepare MpService2Ppi

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable

2023-09-05 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Wang, Yin Sent: Friday, September 1, 2023 4:21 PM To: devel@edk2.groups.io Cc: Wang, Yin ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann ; Sunil V L ; Warkentin, Andrei ; Bi, Dandan ; Dong, Eric

Re: [edk2-devel] [PATCH V7 0/2] Support RSA4096 and RSA3072

2023-09-05 Thread Yao, Jiewen
Thanks. Reviewed-by: Jiewen Yao > -Original Message- > From: Chen, Zeyi > Sent: Wednesday, September 6, 2023 9:56 AM > To: Sheng, W ; devel@edk2.groups.io; Yao, Jiewen > > Cc: Wang, Jian J ; Xu, Min M ; > Wang, Fiona ; Lu, Xiaoyu1 ; > Jiang, Guomin ; Kinney, Michael D > ; Yu, Ling >

Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable

2023-09-05 Thread Wang, Yin
Hi Ard, I have an EDK2 modification, which is located in the OvmfPkg/PlatformDxe/Platform.c file. The modification involves changing a Hii form name. Could you please review this change? Or do you know who I should ask to review it? Thanks Yin On 9/1/2023 4:21 PM, Yin Wang wrote: The Hii

[edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

2023-09-05 Thread Huang, Yanbo
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) == 1) {" will not be executed in current code, put it within "case SysInterfaceKcs:" to avoid this issue. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Yanbo Huang ---

[edk2-devel] [PATCH] IpmiFeaturePkg: Refine code to avoid warning report

2023-09-05 Thread Huang, Yanbo
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) == 1) {" will not be executed in current code, put it within "case SysInterfaceKcs:" to avoid this issue. M: Isaac Oram M: Nate DeSimone R: Liming Gao Signed-off-by: Yanbo Huang ---

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, September 5, 2023 #cal-reminder

2023-09-05 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, September 5, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-05 Thread Oliver Smith-Denny
On 9/4/2023 7:20 PM, Nhi Pham wrote: On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: If I am understanding this correctly, this is only an issue when HOBs are created in StMM, i.e. not from HOBs that are passed in. Is this correct? Yes, the

Re: [edk2-devel] [PATCH v2 1/1] Revert "ArmPkg: add ArmCpuInfo EFI application"

2023-09-05 Thread Leif Lindholm
On Tue, Sep 05, 2023 at 16:51:07 +0200, Marcin Juszkiewicz wrote: > W dniu 5.09.2023 o 15:52, Leif Lindholm pisze: > > > I am moving this command outside of EDK2. > > > > > > This reverts commit 2c2cb235289642775a7c4e6eaeffa6d3828d279c. > > > > Missing signed-off-by. I can add it before pushing

Re: [edk2-devel] [PATCH v2 1/1] Revert "ArmPkg: add ArmCpuInfo EFI application"

2023-09-05 Thread Marcin Juszkiewicz
W dniu 5.09.2023 o 15:52, Leif Lindholm pisze: I am moving this command outside of EDK2. This reverts commit 2c2cb235289642775a7c4e6eaeffa6d3828d279c. Missing signed-off-by. I can add it before pushing if you can confirm you meant for it to be there. Oops. Signed-off-by: Marcin

[edk2-devel] [PATCH 0/1] Drop ArmCpuInfo command

2023-09-05 Thread Marcin Juszkiewicz via groups.io
From: Marcin Juszkiewicz In June I sent patchset of improvements to ArmCpuInfo command. No one responded so I do not see sense in keeping it in EDK2. I created https://github.com/hrw/edk2-armcpuinfo to have a place to store final version. Will add information how to build it into README in

[edk2-devel] [PATCH 1/1] Revert "ArmPkg: add ArmCpuInfo EFI application"

2023-09-05 Thread Marcin Juszkiewicz via groups.io
I am moving this command outside of EDK2. This reverts commit 2c2cb235289642775a7c4e6eaeffa6d3828d279c. --- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2430 -- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 31 - ArmPkg/ArmPkg.dsc|1 - 3

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-09-05 Thread Ard Biesheuvel
On Tue, 5 Sept 2023 at 16:18, Gerd Hoffmann wrote: > > On Tue, Sep 05, 2023 at 03:38:49PM +0200, Ard Biesheuvel wrote: > > On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann wrote: > > > > > > On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote: > > > > Disable PcdFirstTimeWakeUpAPsBySipi for

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-09-05 Thread Gerd Hoffmann
On Tue, Sep 05, 2023 at 03:38:49PM +0200, Ard Biesheuvel wrote: > On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann wrote: > > > > On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote: > > > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to > > > preserve the original

Re: [edk2-devel] [PATCH v2 1/1] Revert "ArmPkg: add ArmCpuInfo EFI application"

2023-09-05 Thread Leif Lindholm
On 2023-09-04 18:56, Marcin Juszkiewicz wrote: I am moving this command outside of EDK2. This reverts commit 2c2cb235289642775a7c4e6eaeffa6d3828d279c. Missing signed-off-by. I can add it before pushing if you can confirm you meant for it to be there. / Leif ---

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-09-05 Thread Ard Biesheuvel
On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann wrote: > > On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote: > > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to > > preserve the original execution of INIT-SIPI-SIPI. > > Acked-by: Gerd Hoffmann > > Can we merge this

Re: [edk2-devel] [PATCH] OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.

2023-09-05 Thread Gerd Hoffmann
On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote: > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to > preserve the original execution of INIT-SIPI-SIPI. Acked-by: Gerd Hoffmann Can we merge this now? thanks, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: Disable PcdFirstTimeWakeUpAPsBySipti

2023-09-05 Thread Gerd Hoffmann
On Wed, Aug 16, 2023 at 10:22:30PM +0200, Ard Biesheuvel wrote: > On Wed, 16 Aug 2023 at 22:13, Michael Roth wrote: > > > > PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when > > the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is > > true by default, but needs

Re: [edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

2023-09-05 Thread Guo, Gua
Below it Edk2 developer guideline https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process You may need to follow it to send review. 寄件者: Lean Sheng Tan 寄件日期: 星期二, 9月 5, 2023 5:49:30 下午 收件者: devel@edk2.groups.io ; Tan, Lean Sheng 副本:

Re: [edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

2023-09-05 Thread Sheng Lean Tan
Reminder: Can anyone help to review this? Thanks! On Fri, 25 Aug 2023 at 10:33, Sheng Lean Tan via groups.io wrote: > Hi Michael, > You will need to CC the maintainers/reviewers for UEFIpayloadpkg. > I have added them in ;) > Best Regards, > *Lean Sheng Tan* > > > > 9elements GmbH,

Re: [edk2-devel] [PATCH v1] Pyrite support - Secure erase is only available if encryption is supported.

2023-09-05 Thread Linus Liu
++ Tina , Chen Xiao -Original Message- From: devel@edk2.groups.io On Behalf Of Linus Liu Sent: Monday, September 4, 2023 4:38 PM To: devel@edk2.groups.io Cc: Liu, Linus ; Zhang, Qi1 ; Kumar, Rahul R ; Yao, Jiewen Subject: [edk2-devel] [PATCH v1] Pyrite support - Secure erase is only

Re: [edk2-devel] [PATCH] Revert "OvmfPkg: Update build.sh to allow building OVMF then running QEMU"

2023-09-05 Thread Ard Biesheuvel
On Thu, 24 Aug 2023 at 06:46, Mike Beaton wrote: > > This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46. > > Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528 > > Signed-off-by: Mike Beaton > --- > OvmfPkg/build.sh | 13 - > 1 file changed, 8 insertions(+), 5

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-05 Thread Yuquan Wang
On 2023-09-05 14:30, marcin.juszkiewicz wrote: Project is meant to be buildable at every commit. Your patchset breaks that rule. Oh! I get it ! I did not consider this principle when designing these patches. Thanks for your explanation : ) I am going to recheck and combine some content

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-05 Thread Marcin Juszkiewicz
W dniu 5.09.2023 o 08:11, Yuquan Wang pisze: Hi, Leif On 2023-09-04 21:51,  quic_llindhol wrote: > > However, this version still breaks bisect: attempting to build at 1/3 > or 2/3 leads to: > --- > /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): > error

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU

2023-09-05 Thread Mike Beaton
On Mon, 4 Sept 2023, 21:14 Rebecca Cran, wrote: > Sorry I've not responded to your emails before now. > > I don't normally use the build.sh script, so I'm fine with reverting to > the previous behavior. > Ah - thank you for the response - that'd be great, if the original people who ack-d and

Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI

2023-09-05 Thread Yuquan Wang
Hi, Leif On 2023-09-04 21:51, quic_llindhol wrote: > > However, this version still breaks bisect: attempting to build at 1/3 > or 2/3 leads to: > --- > /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): > error 3000: PCD >