Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

2023-09-08 Thread Michael D Kinney
Hi Mike, I have created a PR to run EDK II CI while we wait for a review from one of the DXE Core Maintainers https://github.com/tianocore/edk2/pull/4815 Mike > -Original Message- > From: Kinney, Michael D > Sent: Friday, September 8, 2023 2:40 PM > To: Mike Maslenkin ; devel@edk2.gr

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVolBlock.c

2023-09-08 Thread Michael D Kinney
+Jian Cc: Jian J Wang Cc: Dandan Bi Cc: Liming Gao > -Original Message- > From: Mike Maslenkin > Sent: Thursday, August 31, 2023 5:11 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L ; Mike Maslenkin > > Subject: [PATCH 2/2]

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c

2023-09-08 Thread Michael D Kinney
+Jian Cc: Jian J Wang Cc: Dandan Bi Cc: Liming Gao > -Original Message- > From: Mike Maslenkin > Sent: Thursday, August 31, 2023 5:11 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L ; Mike Maslenkin > > Subject: [PATCH 1/2]

Re: [edk2-devel] [PATCH 0/2] MdeModulePkg/Core/Dxe: Fix memory leak issues

2023-09-08 Thread Michael D Kinney
Series Reviewed-by: Michael D Kinney > -Original Message- > From: Mike Maslenkin > Sent: Thursday, August 31, 2023 5:11 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Kinney, Michael D ; > Desimone, Nathaniel L ; Mike Maslenkin > > Subject: [PATCH 0/2] MdeModulePkg/Co

Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling

2023-09-08 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/commit/b240eab03530f063ef5438497d70a731b19a201e > -Original Message- > From: Kinney, Michael D > Sent: Friday, September 8, 2023 10:07 AM > To: Kasbekar, Saloni ; Li, Yi1 > ; devel@edk2.groups.io > Cc: Otcheretianski, Andrei ; Clark- > williams,

Re: [edk2-devel] [PATCH 0/2] Add New Intel Processor family

2023-09-08 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/commit/d4ae5df71190148c902942c3462245e97ed2fcc8 > -Original Message- > From: Kinney, Michael D > Sent: Friday, September 8, 2023 9:50 AM > To: devel@edk2.groups.io; Bhargava, Avinash ; > Gao, Liming > Cc: Kinney, Michael D > Subject: RE: [edk2

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/commit/d42ad81e2247bc6f1c30ef7be5fafc6fcfa0dfb9 > -Original Message- > From: Rebecca Cran > Sent: Friday, September 8, 2023 10:08 AM > To: Kinney, Michael D ; Ard Biesheuvel > ; devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm > > Subject

Re: [edk2-devel] [PATCH] NetworkPkg: Increase HTTP buffer size and enable TCP window scaling

2023-09-08 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Kasbekar, Saloni > Sent: Wednesday, September 6, 2023 3:41 PM > To: Li, Yi1 ; devel@edk2.groups.io; Kinney, Michael D > > Cc: Otcheretianski, Andrei ; Clark-williams, > Zachary ; Luo, Heng > Subject: RE: [PATCH] NetworkPkg: Increa

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Rebecca Cran
Looks good. $ file .editorconfig .editorconfig: ASCII text, with CRLF line terminators On 9/8/23 10:31, Kinney, Michael D wrote: I already have PR opened. https://github.com/tianocore/edk2/pull/4811 Can you verify the line endings are correct? Mike -Original Message- From: Ard B

Re: [edk2-devel] [PATCH 0/2] Add New Intel Processor family

2023-09-08 Thread Michael D Kinney
I have provided Rb on the update to the MdePkg. I will merge that one and you can send new patches for review with just the shell changes. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Avinash > Sent: Friday, September 8, 2023 5:59 AM > To: Gao, Liming ; devel@edk2

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/SmBios.h: Add New Intel Processor family for SMBIOS

2023-09-08 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Avinash > Sent: Thursday, September 7, 2023 12:00 PM > To: devel@edk2.groups.io > Cc: Bhargava, Avinash ; Liu, Zhiguang > ; Bi, Dandan ; Zeng, Star > ; Gao, Zhichao > Subject: [edk2-devel] [PATC

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Michael D Kinney
I already have PR opened. https://github.com/tianocore/edk2/pull/4811 Can you verify the line endings are correct? Mike > -Original Message- > From: Ard Biesheuvel > Sent: Friday, September 8, 2023 9:21 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Rebecca Cran ; Andrew Fish

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Rebecca Cran
On 9/8/23 10:21, Ard Biesheuvel wrote: On Fri, 8 Sept 2023 at 17:54, Michael D Kinney wrote: Acked-by: Michael D Kinney Thanks I can merge this but note that we'll need to convert it to CR-LF first. (My VIM editor with editorconfig integration seems perfectly happy with that) Good point

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Ard Biesheuvel
On Fri, 8 Sept 2023 at 17:54, Michael D Kinney wrote: > > Acked-by: Michael D Kinney > Thanks I can merge this but note that we'll need to convert it to CR-LF first. (My VIM editor with editorconfig integration seems perfectly happy with that) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You rece

Re: [edk2-devel] [PATCH] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent

2023-09-08 Thread Tuan Phan
On Fri, Sep 8, 2023 at 12:12 AM Yeo Reum Yun wrote: > > Signed-off-by: Tuan Phan > > --- > > .../Drivers/StandaloneMmCpu/EventHandle.c | 25 +++ > > .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +- > > .../StandaloneMmCpu/StandaloneMmCpu.inf | 9 ++-- > > .

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Ard Biesheuvel > Sent: Friday, September 8, 2023 8:14 AM > To: Rebecca Cran > Cc: devel@edk2.groups.io; Andrew Fish ; Leif Lindholm > ; Kinney, Michael D > > Subject: Re: [PATCH v2 1/1] Add a .editorconfig file to tell editors > b

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory

2023-09-08 Thread Ard Biesheuvel
On Fri, 8 Sept 2023 at 15:58, Rebecca Cran wrote: > > Reviewed-by: Rebecca Cran > > On 9/7/23 02:34, Corvin Köhne wrote: > > If OVMF fails to find the RSDP in memory, it should fall back installing > > the statically provided ACPI tables. > > > > Signed-off-by: Corvin Köhne > > Cc: Ard Biesheuve

Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details

2023-09-08 Thread Ard Biesheuvel
On Wed, 1 Mar 2023 at 23:11, Ard Biesheuvel wrote: > > On Wed, 1 Mar 2023 at 19:19, Rebecca Cran wrote: > > > > Add a .editorconfig file which editors can use for basic formatting > > details of files, such as tabs/spaces, line endings etc. > > > > Signed-off-by: Rebecca Cran > > Reviewed-by: Ar

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory

2023-09-08 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 9/7/23 02:34, Corvin Köhne wrote: If OVMF fails to find the RSDP in memory, it should fall back installing the statically provided ACPI tables. Signed-off-by: Corvin Köhne Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran

Re: [edk2-devel] [PATCH v2] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

2023-09-08 Thread Henz, Patrick
I saw your earlier message in regard to the build failure too, I'll make sure to run the CI check. Thanks, Patrick Henz -Original Message- From: Wu, Hao A Sent: Thursday, September 7, 2023 9:20 PM To: Henz, Patrick ; devel@edk2.groups.io; Mike Maslenkin Subject: RE: [edk2-devel] [PAT

Re: [edk2-devel] [PATCH 0/2] Add New Intel Processor family

2023-09-08 Thread Avinash
Thanks Gao. I will take it as separate patch under same Bugzilla as different module. Pls let me know If any concern. Regards, Avinash -Original Message- From: gaoliming Sent: Friday, September 8, 2023 6:18 AM To: devel@edk2.groups.io; Bhargava, Avinash Subject: 回复: [edk2-devel] [PAT

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

2023-09-08 Thread Konstantin Aladyshev
Hi, Chang! I've finished my initial implementation of the MCTP over KCS binding. You can find 'edk2-platform' patches and 'openbmc' patches along with all of the instructions in my repository https://github.com/Kostr/PLDM. I hope you'll be able to reproduce everything on your hardware configuratio

[edk2-devel] MdePkg/SmBios.h : Add New Intel Processor family

2023-09-08 Thread Avinash
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547 Add New Intel Processor family for SMBIOS Type 4 Hex value - 16h Name - Intel® Processor Signed-off-by: avinashbhargava Cc: Zhiguang Liu Cc: Dandan Bi Cc: Star Zeng Cc: Zhichao Gao Cc: Benny Lin Cc: Gua Guo Cc: Prakashan Krishnadas V

[edk2-devel] [PATCH 2/2] MdePkg/SmBios.h : Add New Intel Processor family

2023-09-08 Thread Avinash
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547 Add New Intel Processor family for SMBIOS Type 4 Hex value - 16h Name - Intel® Processor Signed-off-by: avinashbhargava Cc: Zhiguang Liu Cc: Dandan Bi Cc: Star Zeng Cc: Zhichao Gao Cc: Benny Lin Cc: Gua Guo Cc: Prakashan Krishnadas V

Re: [edk2-devel] [PATCH] MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version

2023-09-08 Thread Lien, HoraceX
Hi Mike, No, we didn't guarantee this before. Add comments to descript BCD field is good point. I have reviewed SMBIOS spec for SmbiosBcdRevision field, it mentions "If the value is 00h, only the Major and Minor Versions in offsets 6 and 7 of the Entry Point Structure provide the version inform

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/BootMaintenanceManagerUiLib: Check array index before access

2023-09-08 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: mikub...@linux.microsoft.com Sent: Friday, September 8, 2023 10:08 AM To: devel@edk2.groups.io Cc: Wang, Jian J ; Gao, Liming ; Bi, Dandan ; Dong, Eric Subject: [PATCH v1 1/1] MdeModulePkg/BootMaintenanceManagerUiLib:

Re: [edk2-devel] [PATCH] StandaloneMmPkg: Make StandaloneMmCpu driver platform independent

2023-09-08 Thread levi.yun
> Signed-off-by: Tuan Phan > --- > .../Drivers/StandaloneMmCpu/EventHandle.c | 25 +++ > .../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42 +- > .../StandaloneMmCpu/StandaloneMmCpu.inf | 9 ++-- > .../Library/Arm/StandaloneMmCoreEntryPoint.h | 17 ++-- > .../S