Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device cmd when time out

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: Cai, Xianglei > Sent: Thursday, September 21, 2023 11:58 AM > To: devel@edk2.groups.io > Cc: Cai, Xianglei ; Wu, Hao A ; > Ni, Ray ; Wang, Jian J ; Gao, > Liming ; Shih, More ; > Huang, Jenny > Subject: [PATCH V2 1

Re: [edk2-devel] [PATCH v2 1/1] RISCV: Fix InternalLongJump to return correct value

On Tue, Sep 19, 2023 at 03:16:59AM -0500, Andrei Warkentin wrote: > InternalLongJump was not returning the 2nd parameter passed > to LongJmp (Value) as the return value from SetJmp. > > Seen with code compiled with -Os, where an LongJmp (Buffer, -1) > somehow translated to SetJmp returning 0... >

[edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device cmd when time out

https://bugzilla.tianocore.org/show_bug.cgi?id=4552 Following XHCI spec 4.6.1.2, software may abort the execution of Address Device Command when command failed due to timeout. Cc: Hao A Wu Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Cc: More Shih Cc: Jenny Huang Signed-off-by

Re: [edk2-devel] [edk2-discuss] PLDM messages via MCTP over KCS

[AMD Official Use Only - General] Hi Aladyshev, Thanks for providing the details, I will take a look at your code first, implement it at my end and then response to your question. Abner > -Original Message- > From: Konstantin Aladyshev > Sent: Friday, September 8, 2023 8:57 PM > To: Ch

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, September 21, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, September 21, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

[AMD Official Use Only - General] Hi Nickle, As we may use a protocol that provide the JSON interface for other packages or drivers, could you please have a comment around the hardcoded number says the hardcoded number would be removed when we have a protocol on top of jansson lib? People can s

[edk2-devel] RFC: SetVariable callbacks

Hello We have a requirement to monitor setVariable calls, we'd like to get a callback before and after the variable update. Similar to VarCheckLib, except that VarCheckLib's set callbacks are called after endOfDxe. We were thinking of doing something like: === --- a/MdeModuleP

Re: [edk2-devel] 回复: [edk2-devel] UEFI spec version in system table, shall we update it to 2.8?

Mike, Agree with your points. Thanks for sharing the detailed info. Beautifully conveyed! -Karunakar Internal Use - Confidential From: Kinney, Michael D Sent: Thursday, September 21, 2023 12:30 AM To: Poosapalli, Karunakar; devel@edk2.groups.io; POLUDOV, FELIX; Yao, Jiewen Cc: Kinney, Michae

Re: [edk2-devel] [PATCH edk2-non-osi 0/1] Qemu/Sbsa: Update TF-A binaries

On Wed, Sep 20, 2023 at 13:44:22 +0200, Marcin Juszkiewicz wrote: > Update the TF-A binaries to have: > > - fixed FIP size > - Neoverse-N2 cpu support > > This support was merged into TF-A: > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417 > (align FIP base to BL1 size) > htt

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

On Tue, Sep 19, 2023 at 15:13:46 +0200, Ard Biesheuvel wrote: > On Mon, 18 Sept 2023 at 15:06, Marcin Juszkiewicz > wrote: > > > > W dniu 18.09.2023 o 14:33, Ard Biesheuvel pisze: > > > On Mon, 18 Sept 2023 at 13:35, Leif Lindholm > > > wrote: > > > > >> Note for the interested: > > >> https://r

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote: > There are some changes in progress which make BL1 bigger than 0x8000 > which EDK2 uses. > > TF-A defines BL1 size to be 0x12000 one. So let follow it. > > Signed-off-by: Marcin Juszkiewicz Tweaked the commit message a bit, and

Re: [edk2-devel] 回复: [edk2-devel] UEFI spec version in system table, shall we update it to 2.8?

Compliance of TianoCore is different than Compliance of a platform firmware image. * TianoCore should only update the version when all of the TianoCore contents conform to the spec version. * If the subset of TainoCore features integrated into a platform firmware image meets all of a n

Re: [edk2-devel] [PATCH edk2-platforms 0/2] some trivial changes

On 9/20/2023 9:55 AM, Marcin Juszkiewicz via groups.io wrote: Those changes float around whenever I do some changes in code. Time to send them for merge and stop bothering. Marcin Juszkiewicz (2): Silicon/SbsaQemu: drop duplicated Pcd Silicon/SbsaQemu: fix comment to show proper table name

[edk2-devel] [PATCH edk2-platforms 1/2] Silicon/SbsaQemu: drop duplicated Pcd

PcdAcpiDefaultOemRevision was listed twice. Signed-off-by: Marcin Juszkiewicz --- .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 2 -- 1 file changed, 2 deletions(-) diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf b/Silicon/Qemu/SbsaQemu/Driver

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/SbsaQemu: fix comment to show proper table name

Someone did copy/paste in past and forgot to alter table name in comment. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQe

[edk2-devel] [PATCH edk2-platforms 0/2] some trivial changes

Those changes float around whenever I do some changes in code. Time to send them for merge and stop bothering. Marcin Juszkiewicz (2): Silicon/SbsaQemu: drop duplicated Pcd Silicon/SbsaQemu: fix comment to show proper table name .../Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ArmLib: Add ArmHasVhe () helper function

On Wed, Sep 20, 2023 at 15:51:23 +0200, Marcin Juszkiewicz wrote: > W dniu 20.09.2023 o 14:39, Leif Lindholm pisze: > > Create a helper function to query whether ID_AA64MFR1_EL1 indicates > > presence of the Virtualization Host Extensions. This feature is only > > visible in AARCH64 state. > > > >

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Reviewed-by: Igor Kulchytskyy Regards, Igor -Original Message- From: Nickle Wang Sent: Monday, September 18, 2023 9:09 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue **CAUTION:

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Nickle, Yes, I understand the mechanism of how seed works. And when I used the RedfishPkg and Jansson parser in my modules, I passed the seed to each driver, so, all of them used the same seed. All of them call a json_object_seed() function with the same seed. Now, there is no need to do it. T

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, September 21, 2023 #cal-reminder

*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, September 21, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/SbsaQemu: generate GTDT from C

We need to have some conditional code while generating GTDT due to adding non-secure EL2 virtual timer. Signed-off-by: Marcin Juszkiewicz --- .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 - .../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 6 + .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.

[edk2-devel] [PATCH v2 edk2-platforms 0/2] define NS EL2 virtual timer

Arm BSA (Base System Architecture) specification requires Armv8.1+ cpus to have non-secure EL2 virtual timer. Which we lacked. In previous week I wrote a small patch to QEMU which enabled it for SBSA Reference Platform. Leif Lindholm refactored code around timers to make it more readable. Then he

[edk2-devel] [PATCH edk2-platforms 1/2] Silicon/SbsaQemu: move IORT structures to header file

There are more and more things in SbsaQemuAcpiDxe.c file which should be elsewhere. Signed-off-by: Marcin Juszkiewicz --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 37 +++ .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 24 +--- 2 files changed, 38 insertions(+), 23

Re: [edk2-devel] 回复: [edk2-devel] UEFI spec version in system table, shall we update it to 2.8?

Hi @Kinney, Michael D, Thanks for sharing your inputs. Agree with your point. As latest tianocore edk2 already added some of the interfaces or functionalities implemented from v2.8 by different communities, Can we say it’s compliant with v2.8? but as there is n

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ArmLib: Add ArmHasVhe () helper function

W dniu 20.09.2023 o 14:39, Leif Lindholm pisze: Create a helper function to query whether ID_AA64MFR1_EL1 indicates presence of the Virtualization Host Extensions. This feature is only visible in AARCH64 state. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Marcin Juszki

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ArmLib: Add ArmHasVhe () helper function

Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 20/09/2023, 13:39, "Leif Lindholm" mailto:quic_llind...@quicinc.com>> wrote: Create a helper function to query whether ID_AA64MFR1_EL1 indicates presence of the Vir

[edk2-devel] [PATCH 1/1] ArmPkg/ArmLib: Add ArmHasVhe () helper function

Create a helper function to query whether ID_AA64MFR1_EL1 indicates presence of the Virtualization Host Extensions. This feature is only visible in AARCH64 state. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Marcin Juszkiewicz --- ArmPkg/Include/Chipset/AArch64.h

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: define NS EL2 virtual timer in GTDT

W dniu 20.09.2023 o 12:04, Leif Lindholm pisze: On Wed, Sep 20, 2023 at 10:25:09 +0200, Marcin Juszkiewicz wrote: Armv8.1+ cpus have Virtual Host Extension (VHE) which added non-secure EL2 virtual timer. It's still valid to use other CPUs than "max" with this platform. Don't we need to condit

[edk2-devel] [PATCH edk2-non-osi 1/1] Qemu/Sbsa: Update TF-A binaries

Update the TF-A binaries to have: - fixed FIP size - Neoverse-N2 cpu support This support was merged into TF-A: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417 (align FIP base to BL1 size) https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23409 (add "neoverse-n2"

[edk2-devel] [PATCH edk2-non-osi 0/1] Qemu/Sbsa: Update TF-A binaries

Update the TF-A binaries to have: - fixed FIP size - Neoverse-N2 cpu support This support was merged into TF-A: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417 (align FIP base to BL1 size) https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23409 (add "neoverse-n2"

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: define NS EL2 virtual timer in GTDT

On Wed, Sep 20, 2023 at 10:25:09 +0200, Marcin Juszkiewicz wrote: > Armv8.1+ cpus have Virtual Host Extension (VHE) which added non-secure > EL2 virtual timer. > > This change adds it into GTDT to fullfil Arm BSA (Base System > Architecture) requirements. > > Signed-off-by: Marcin Juszkiewicz >

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Igor, According to my understanding to jansson implementation, json_object_seed() is only called in three places. Two of them are in test code and we don't use them in EDK2. The only chance to call json_object_seed() is in json_object(). So, it is called when driver create new JSON object an

Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg:Add variable store is full debug info

> I don't think a full variable store is the only reason we might end up > with EFI_OUT_OF_RESOURCES here, so this message could be misleading. > > Given that this is a DEBUG build, I'd expect the developer to be able > to infer from the context that this might be either an out of memory > or an ou

[edk2-devel] [PATCH edk2-platforms 0/1] Platform/QemuSbsa: define NS EL2 virtual timer in GTDT

Arm BSA (Base System Architecture) specification requires Armv8.1+ cpus to have non-secure EL2 virtual timer. Which we lacked. In previous week I wrote a small patch to QEMU which enabled it for SBSA Reference Platform. Leif Lindholm refactored code around timers to make it more readable. Then he

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: define NS EL2 virtual timer in GTDT

Armv8.1+ cpus have Virtual Host Extension (VHE) which added non-secure EL2 virtual timer. This change adds it into GTDT to fullfil Arm BSA (Base System Architecture) requirements. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 ++ Silicon/Qemu/SbsaQemu

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg\XhciDxe: Command Abort when times out

General level comments: 1. Some CI tests failed for the proposed patch: https://github.com/tianocore/edk2/pull/4844. Could you help to resolve them? Please help to follow the step 11 in page: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process and check the CI test r

Re: [edk2-devel] [PATCH v3] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Henz, > Patrick > Sent: Wednesday, September 13, 2023 2:06 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Henz, > Patrick > Subject: [edk2-devel] [PATCH v3] MdeModulePkg

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue

Pushed via: PR - https://github.com/tianocore/edk2/pull/4843 Commit - https://github.com/tianocore/edk2/commit/4317b4824bc881fe6079d04b7ee5b0f6bddf62ca Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Thursday, August 10, 2023 10:39