Hi Mike, Liming, Guomin and Dandan
Could you help review this change?
Best Regards
Fan
-Original Message-
From: devel@edk2.groups.io On Behalf Of Wang Fan
Sent: Monday, September 11, 2023 5:52 PM
To: devel@edk2.groups.io
Cc: Wang, Fan ; Kinney, Michael D
; Gao, Liming ; Jiang,
Guomin
Series pushed via:
PR - https://github.com/tianocore/edk2/pull/4856
Commits:
https://github.com/tianocore/edk2/commit/e9f5d8c0e066da55b3f79dfdbf4df5fc97ca5916
https://github.com/tianocore/edk2/commit/28a267af4024c329e58121ccd9bf5f4f7aabc0f4
Best Regards,
Hao Wu
> -Original Message-
>
*Reminder: TianoCore Community Meeting - APAC/NAMO*
*When:*
Thursday, September 21, 2023
7:30pm to 8:30pm
(UTC-07:00) America/Los Angeles
*Where:*
[AMD Official Use Only - General]
Thank you Nickle. RB is given to that patch.
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, September 21, 2023 9:00 PM
> To: Chang, Abner ; Igor Kulchytskyy
> ; devel@edk2.groups.io
> Cc: Nick Ramirez
> Subject: RE: [EXTERNAL]
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Thursday, September 21, 2023 8:56 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH v2] RedfishPkg/JsonLib: fix
I see you swapped the order of the functions, that looks good and avoids
special handling for that case. That looks good to me.
Thanks,
Jeff
From: Sami Mujawar
Sent: Thursday, September 21, 2023 2:07 PM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: Pierre Gondois ; Swatisri Kantamsetti
; Ashish
From: Vidya Sagar
Add helper functions to generate AML Resource Data describing I/O
ranges of four words long. API AmlCodeGenRdQWordIo () is exposed.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h | 67 ++
.../AmlLib/CodeGen/AmlResourceDataCodeGen.c
From: Vidya Sagar
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses
can be used to generate I/O packets over the PCIe bus.
Signed-off-by: Jeff Brasen
---
Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit
addresses can be used to generate I/O packets over the PCIe bus.
Changes:
v2 - Rebased and set transferEncoding = 8bit
Vidya Sagar (2):
DynamicTablesPkg: AML
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Locked with
Key State test cases
-Add
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Locked No Key
State test cases
-Add
See inline...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Unlocked State
test cases
-Add Assertions 19, 20, 21,
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLockSetVariable test
cases
-Add Assertions 9
See inline comments...
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlSetVariable test cases
-Add Assertions 5, 6, 7, and
On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
Resending to Cc the reviewers
These tests support platform firmware that implement
MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock
UEFI variables in accordance with TCG PC Platform Reset Attack
Mitigation
Only thing I see is if AmlCodeGenInteger fails we don’t delete DataNode right?
From: Sami Mujawar
Sent: Thursday, September 21, 2023 10:49 AM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: pierre.gond...@arm.com; Swatisri Kantamsetti ; Ashish
Singhal ; n...@arm.com
Subject: Re: [PATCH v4 2/4]
On Thu, 21 Sept 2023 at 16:26, Gerd Hoffmann wrote:
>
> On Thu, Sep 21, 2023 at 11:50:20AM +0100, Peter Maydell wrote:
> > Hi; I've been looking again at a very long standing missing feature in
> > the QEMU virt board, which is that we only have one UART. One of the
> > things that has stalled
Hi; I've been looking again at a very long standing missing feature in
the QEMU virt board, which is that we only have one UART. One of the
things that has stalled this in the past has been the odd behaviour of
EDK2 if the DTB that QEMU passes it describes two UARTs.
I'm going to describe the
On Thu, Sep 21, 2023 at 04:34:27PM +0100, Peter Maydell wrote:
> As long as EDK2 does something sensible when the DTB says "two
> UARTs here and here" and it also finds a virtio-serial PCI
> device, I don't mind what exactly it does. The problem here is
> more that EDK2 currently does strange
Hi Sami,
That sounds good.
Thanks,
Jeff
> -Original Message-
> From: Sami Mujawar
> Sent: Thursday, September 21, 2023 10:50 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: pierre.gond...@arm.com; Swatisri Kantamsetti ;
> Ashish Singhal ; n...@arm.com
> Subject: Re: [PATCH v4 3/4]
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
---
.../Include/Library/AmlLib/AmlLib.h
Hi Jeff,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 18/09/2023 04:46 pm, Jeff Brasen wrote:
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Signed-off-by: Jeff Brasen
---
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Locked with
Key State test cases
-Add remaining Assertions 33 - 49 from SCT spec
-Add Test Case to
From: "Abhi.Singh"
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement initial test infrastructure for all test cases
including updates to: CommonGenFramework.sh, UEFI_SCT.dsc,
and Category.ini.
-Add Guid.c and
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLockSetVariable test
cases
-Add Assertions 9 through 18 from SCT spec
-Add Test Case to MemoryOverwriteRequestFunctionTest
Cc: G
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlSetVariable test cases
-Add Assertions 5, 6, 7, and 8 from SCT spec
-Add Test Case to MemoryOverwriteRequestFunctionTest
Cc: G Edhaya
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Locked No Key
State test cases
-Add Assertions 23 - 32 from SCT spec
-Add Test Case to MemoryOverwriteRequestFunctionTest
Cc: G
SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
-Implement MemoryOverwriteRequestControlLock Unlocked State
test cases
-Add Assertions 19, 20, 21, and 22 from SCT spec
-Add Test Case to MemoryOverwriteRequestFunctionTest
Resending to Cc the reviewers
These tests support platform firmware that implement
MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock
UEFI variables in accordance with TCG PC Platform Reset Attack
Mitigation Specification.
The 6 patches are split up according to the six sections
Hello Nhi,
On 9/21/2023 1:41 AM, Nhi Pham via groups.io wrote:
External email: Use caution opening links or attachments
Can we write a DXE_RUNTIME driver to override the pointers of UEFI
Runtime Get/SetVariable() services? Then, we can add platform specific
or custom implementation
On Thu, Sep 21, 2023 at 11:50:20AM +0100, Peter Maydell wrote:
> Hi; I've been looking again at a very long standing missing feature in
> the QEMU virt board, which is that we only have one UART. One of the
> things that has stalled this in the past has been the odd behaviour of
> EDK2 if the DTB
*TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, September 21, 2023
8:00am to 9:00am
(UTC-07:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join
*Reminder: TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, September 21, 2023
8:00am to 9:00am
(UTC-07:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams
Hi Abner,
I add suggested comment in version 2:
https://edk2.groups.io/g/devel/message/108942
Thanks,
Nickle
> -Original Message-
> From: Chang, Abner
> Sent: Thursday, September 21, 2023 10:20 AM
> To: Igor Kulchytskyy ; Nickle Wang ;
> devel@edk2.groups.io
> Cc: Nick Ramirez
>
JsonObjectGetValue() cannot find corresponding JSON value
when the EDKII_JSON_VALUE object is created by another UEFI
driver. This is because "hashtable_seed" is initialized by
current time while JsonLib is loaded. So, "hashtable_seed"
will be different in each individual UEFI driver.
On Thu, 21 Sept 2023 at 10:50, Peter Maydell wrote:
>
> Hi; I've been looking again at a very long standing missing feature in
> the QEMU virt board, which is that we only have one UART. One of the
> things that has stalled this in the past has been the odd behaviour of
> EDK2 if the DTB that
On Thu, 21 Sept 2023 at 10:10, Tan, Dun wrote:
>
> Hi Ard,
>
> Could you send me your build and boot command?
>
> I think the paging mode for IA32 smm should be PagingPae instead of
> 'Paging32bit'. Also in previous code logic before my patch PagingPae is
> created for IA32 smm.
>
Build like
Spot on, that solved it!
I had attempted the NOOPT flag but I was missing the second part to do the trick
Now I can even generate amazing coverage output with genhtml (:
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108939):
Hi Ard,
Could you send me your build and boot command?
I think the paging mode for IA32 smm should be PagingPae instead of
'Paging32bit'. Also in previous code logic before my patch PagingPae is created
for IA32 smm.
Thanks,
Dun
-Original Message-
From: Ard Biesheuvel
Sent:
On Thu, 29 Jun 2023 at 10:09, duntan wrote:
>
> In the V8 patch set:
> In 'OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry', I
> refined the commit message and added comments in the code around the areas
> being changed to explain this code change.
>
> Only resend the changed
Can we write a DXE_RUNTIME driver to override the pointers of UEFI
Runtime Get/SetVariable() services? Then, we can add platform specific
or custom implementation before/after calling the original
Get/SetVariable()?
Regards,
Nhi
On 9/21/2023 3:27 AM, Girish Mahadevan via groups.io wrote:
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, September 21, 2023 11:58 AM
> To: devel@edk2.groups.io
> Cc: Cai, Xianglei ; Wu, Hao A ;
> Ni, Ray ; Wang, Jian J ; Gao,
> Liming ; Shih, More ;
> Huang, Jenny
> Subject: [PATCH V2
42 matches
Mail list logo
