[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Xing, Eric
> Sent: Friday, September 29, 2023 1:07 AM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Chang, Abner
> ; Leif Lindholm ; Attar,
> AbdulLateef (Abdul Lateef)
> Subject:
Thank you Nate!
Reviewed-by: Ray Ni
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109182): https://edk2.groups.io/g/devel/message/109182
Mute This Topic: https://groups.io/mt/101531560/21656
Group Owner: devel+ow...@edk2.groups.io
Hi Ray,
Responses inline below.
Thanks,
Nate
> From: Ni, Ray
> Sent: Tuesday, September 26, 2023 8:46 PM
> To: Desimone, Nathaniel L ;
> devel@edk2.groups.io
> Cc: Andrew Fish ; Kinney, Michael D
> ; Chiu, Chasel
> Subject: Re: [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows
>
>
Hi Sami,
I just sent the V3 series to address your comments.
Regards,
On Thu, Sep 28, 2023 at 11:16 AM Tuan Phan via groups.io wrote:
> Hi Sami,
> Please see my comments below.
>
> On Thu, Sep 28, 2023 at 9:16 AM Sami Mujawar wrote:
>
>> Hi Tuan,
>>
>> Thank you for this patch.
>>
>> Please
Update entry point library for Arm to use the new architecture independent
StandaloneMmCpu driver.
Signed-off-by: Tuan Phan
Reviewed-by: levi.yun
---
.../Library/Arm/StandaloneMmCoreEntryPoint.h | 17 +
.../Arm/CreateHobList.c | 43 ++--
StandaloneMmCpu now can supports more architectures like RISC-V besides
ARM/AARCH64.
Signed-off-by: Tuan Phan
Reviewed-by: levi.yun
Reviewed-by: Sami Mujawar
---
.../Drivers/StandaloneMmCpu/EventHandle.c | 25 +++
.../Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 42
This series makes StandaloneMmCpu architecture independent so other
architectures besides ARM/AARCH64 can use it without creating new driver.
There are two parts in this series:
1. Remove ARM/AARCH64 code from StandaloneMmCpu.
2. Update ARM/AARCH64 entry point library code.
V3:
- Addressed
On Thu, Sep 28, 2023 at 2:20 PM Daniel Samuelraj via groups.io
wrote:
>
> We tried GCC at https://sourceforge.net/projects/gcc-win64/
>
> And then we tried GCC ver5.4
>
> We are getting the following error:
>
>
Hi, Chang!
Did you have time to test libmctp MCTP KCS binding solution?
Here are some updates from my end. As I was saying, I was working on
the Linux kernel binding solution.
And now I've finished the initial implementation of the Linux kernel
binding driver for the MCTP-over-KCS binding and
Hi Sami,
Please see my comments below.
On Thu, Sep 28, 2023 at 9:16 AM Sami Mujawar wrote:
> Hi Tuan,
>
> Thank you for this patch.
>
> Please see my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
> On 15/09/2023 12:10 am, Tuan Phan wrote:
> > Update entry point library for Arm
On Wed, Sep 27, 2023 at 1:09 PM Gerd Hoffmann wrote:
>
> Hi,
>
> I've noticed that the edk2 ext4 driver does case-insensitive filename
> matching. I know the fat filesystem is case-insensitive, and the uefi
> spec describing the fat filesystem also explicitly says it is
> case-insensitive. On
Hi Eric,
Thanks.
You didn't really need to rework the patch, but I do want to see the
Reviewed-by's from the other added people before merging.
Best Regards,
Leif
On Thu, Sep 28, 2023 at 17:13:36 +, Xing, Eric wrote:
> [AMD Official Use Only - General]
>
> Thanks Leif for your quick
[AMD Official Use Only - General]
Thanks Leif for your quick response and reminder. I added Abner as CC in PATCH
v2.
Sorry troubling you, would you help review it again so I can get your approved
with v2 patch? Thanks again.
Eric
-Original Message-
From: Leif Lindholm
Sent: Friday,
From: Eric Xing
Cc: Michael D Kinney
Cc: Abner Chang
Cc: Leif Lindholm
Cc: Abdul Lateef Attar
Signed-off-by: Eric Xing
---
Maintainers.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index c42d135..1d5dacb 100644
--- a/Maintainers.txt
+++
[AMD Official Use Only - General]
Thanks Abner for the kindly reminder. Will correct it next time.
Eric
From: Chang, Abner via groups.io
Sent: Thursday, September 28, 2023 11:19 PM
To: Xing, Eric ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh
[AMD Official Use Only - General]
Thanks Abner for the prompt review. Will follow coding standard and correct the
new files’ name in PATCH V2.
Eric.
From: Chang, Abner via groups.io
Sent: Thursday, September 28, 2023 11:23 PM
To: Xing, Eric ; devel@edk2.groups.io
Subject: Re: [edk2-devel]
Hi Tuan,
Thank you for this patch.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 15/09/2023 12:10 am, Tuan Phan wrote:
Update entry point library for Arm to use the new platform independent
[SAMI] Should this be worded as architecture independent instead of
+Abner
Looks fine to me, but I'd like to have a Reviewed-by from Abner,
Abdul, Duke.
Best Regards,
Leif
On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.x...@amd.com wrote:
> From: Eric Xing
>
> Signed-off-by: Eric Xing
> Cc: Michael D Kinney
> Cc: Leif Lindholm
> Cc: Abdul Lateef Attar
>
Hi Tuan,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/09/2023 12:10 am, Tuan Phan wrote:
StandaloneMmCpu now can supports more platforms like RISC-V besides
ARM/AARCH64.
Signed-off-by: Tuan Phan
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/Cipher/CryptAes.c | 225 ++
1 file changed, 225 insertions(+)
create mode 100644
Update Readme for BaseCryptLibMbedTls.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
CryptoPkg/Readme.md | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git
Change CI for new Mbedtls submodule.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.pytool/CISettings.py | 2 ++
CryptoPkg/CryptoPkg.ci.yaml| 12 +++-
Add MD5/SHA1/SHA256/SHA384/SHA512 APIs.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/Hash/CryptMd5.c | 226 +
.../BaseCryptLibMbedTls/Hash/CryptSha1.c
Add Null functions to build. These feature are not supported now.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/Bn/CryptBnNull.c | 520
Add .inf files and other support files.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
CryptoPkg/CryptoPkg.dec | 4 +
CryptoPkg/CryptoPkgMbedTls.dsc| 280
Add RSA APIs.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/InternalCryptLib.h| 25 ++
.../BaseCryptLibMbedTls/Pk/CryptRsaBasic.c| 278 ++
Add mbedtls 3.3.0 as submodule in CryptoPkg.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.gitmodules | 3 +++
CryptoPkg/Library/MbedTlsLib/mbedtls | 1 +
2 files
Add HMAC APIS.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/Hmac/CryptHmac.c | 678 ++
.../BaseCryptLibMbedTls/Hmac/CryptHmacNull.c | 359
Purpose: This patch is needed to resolve the limitation from OpenSSL 3.0
that HMAC/HKDF/RSA cannot work in pre-memory phase.
There are five features based on mbedtls in the patch: HMAC/HKDF/RSA/HASH/AES.
Test: The patch has passed the unit_test and fuzz test. And the patch
has passed testing on
Add HKDF APIs.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/Kdf/CryptHkdf.c | 372 ++
.../BaseCryptLibMbedTls/Kdf/CryptHkdfNull.c | 192
Hi Eric,
As the file naming is defined in the edk2 C coding standard, the AMD
terminology used in the file name should follow edk2 C coding standard. Such as
APCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei.
Could you please review all of the files in this patch?
Thanks
Abner
Hi Eric,
You don't need the description follow "PATCH" actually, this makes the commit
subject too lone. It is better to keep the subject short. You can put the
detail information in the commit message body.
Thanks
Abner
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
From: Eric Xing
Signed-off-by: Eric Xing
Cc: Michael D Kinney
Cc: Leif Lindholm
Cc: Abdul Lateef Attar
Signed-off-by: Eric Xing
---
Maintainers.txt | 9 +
1 file changed, 9 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index c42d135..1d5dacb 100644
---
Hi,
> > Test case: try http boot from https server, set ciphers on the qemu
> > command line using:
> > -object tls-cipher-suites,id=tls-cipher0,priority=@SYSTEM
> > -fw_cfg name=etc/edk2/https/ciphers,gen_id=tls-cipher0
> For a successful handshake, we need the intersection of the
On Thu, 28 Sept 2023 at 08:54, Laszlo Ersek wrote:
>
> On 9/21/23 14:02, ardb at kernel.org (Ard Biesheuvel) wrote:
> > EDK2's DEBUG output is extremely noisy, so being able to redirect this
> > output to a different UART would be very useful.
> >
> > The stdout-path is the intended console, and
We tried GCC at https://sourceforge.net/projects/gcc-win64/
And then we tried GCC ver5.4
We are getting the following error:
x86_64-5.4.0-release-posix-sjlj-rt_v5-rev0/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/5.4.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
unrecognised emulation mode:
On 9/28/23 13:24, Peter Maydell wrote:
> On Thu, 28 Sept 2023 at 08:54, Laszlo Ersek wrote:
>>
>> On 9/21/23 14:02, ardb at kernel.org (Ard Biesheuvel) wrote:
>>> EDK2's DEBUG output is extremely noisy, so being able to redirect this
>>> output to a different UART would be very useful.
>>>
>>>
On 9/27/23 10:38, kraxel at redhat.com (Gerd Hoffmann) wrote:
> Hi,
>
> I've noticed that setting chipers for TLS stopped working in ovmf,
> most likely due to the openssl 3.0 update.
>
> Test case: try http boot from https server, set ciphers on the qemu
> command line using:
> -object
On 9/27/23 14:09, kraxel at redhat.com (Gerd Hoffmann) wrote:
> Hi,
>
> I've noticed that the edk2 ext4 driver does case-insensitive filename
> matching. I know the fat filesystem is case-insensitive, and the uefi
> spec describing the fat filesystem also explicitly says it is
>
On 9/21/23 14:02, ardb at kernel.org (Ard Biesheuvel) wrote:
> On Thu, 21 Sept 2023 at 10:50, Peter Maydell
> wrote:
>>
>> Hi; I've been looking again at a very long standing missing feature in
>> the QEMU virt board, which is that we only have one UART. One of the
>> things that has stalled
From: Ranbir Singh
The function FatInitializeDiskCache evaluates an expression
FAT_DATACACHE_GROUP_COUNT << DiskCache[CacheData].PageAlignment
and assigns it to DataCacheSize which is of type UINTN.
As per Coverity report,
FAT_DATACACHE_GROUP_COUNT << DiskCache[CacheData].PageAlignment is
From: Ranbir Singh
The functions FatGetDirEntInfo and FatOpenDirEnt contains the code
statements
Cluster= (Entry->FileClusterHigh << 16) | Entry->FileCluster;
and
OFile->FileCluster = ((DirEnt->Entry.FileClusterHigh) << 16) |
(DirEnt->Entry.FileCluster);
Ranbir Singh (2):
FatPkg/EnhancedFatDxe: Fix SIGN_EXTENSION Coverity issues
FatPkg/EnhancedFatDxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issue
FatPkg/EnhancedFatDxe/DirectoryManage.c | 4 ++--
FatPkg/EnhancedFatDxe/DiskCache.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
As per spec if xDSDT is avaialble, it should be used first.
Handle required flow when xDSDT is abscent or present.
Test: Tested on RISCV64 Qemu platform with xDSDT and booted to
linux kernel.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Dandan Bi
Signed-off-by: Dhaval Sharma
---
Enable detection of XDSDT table from ACPI HOB
Dhaval (1):
MdeModulePkg: Fix issue with ACPI table creation
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 15
++-
1 file changed, 14 insertions(+), 1 deletion(-)
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhiguang Liu
45 matches
Mail list logo
