Re: [edk2-devel] [PATCH v1 07/17] Platform/Loongson/LoongArchQemuPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Chao Li
Acked-by: Chao Li Thanks, Chao On 2023/12/1 08:34, Taylor Beebe wrote: ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Bibo Mao Cc: Xianglai li Cc: Chao Li --- Platform/Loongson/LoongArchQemuPkg/Loongson.d

Re: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase

2023-11-30 Thread Ashraf Ali S
Hi., Ray Yes, I agree. But if any device which needs to map above 512GB in Pre Memory (Early PreMem). if any device mapped any device below 512GB. And if the DRAM has 512GB then it would create a conflict. So we are not changing the default page table size, keeping 512GB only. So that it wil

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv: Fix syntax issue in markdown manual

2023-11-30 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -Original Message- From: Desimone, Nathaniel L Sent: Friday, December 1, 2023 7:26 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chiu, Chasel ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Suso

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-11-30 Thread Ni, Ray
Yes please! Thanks, Ray > -Original Message- > From: Nhi Pham > Sent: Thursday, November 30, 2023 9:59 PM > To: Oliver Smith-Denny ; devel@edk2.groups.io; > a...@kernel.org > Cc: Ni, Ray ; huangm...@linux.alibaba.com; Sami Mujawar > ; Ard Biesheuvel ; > Yao, Jiewen ; Supreeth Venkatesh >

Re: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase

2023-11-30 Thread Ni, Ray
Ashraf, When we implement the reset vector, we assume that 512GB page table occupies minimal flash size and also sufficient for XIP code. Any code that wants more page table coverage should create a new page table, either in the temporary ram (when physical mem is not ready) or in physical ram. Wh

Re: [edk2-devel] [PATCH v1] PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with XhciDxe

2023-11-30 Thread Ni, Ray
Mike, Thanks! Thanks, Ray > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 1, 2023 12:39 PM > To: Ni, Ray ; Desimone, Nathaniel L > ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [PATCH v1] PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with > Xhci

Re: [edk2-devel] [PATCH v1] PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with XhciDxe

2023-11-30 Thread Michael D Kinney
Hi Ray, 'static' is allowed and actually preferred for module globals that start with 'm' that are scoped to a single C file. Globals that start with 'g' that need to be access by multiple C files can not be static. Since 'm' globals could be changed to 'g' globals due to maintenance, we want t

Re: [edk2-devel] [PATCH v1] PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with XhciDxe

2023-11-30 Thread Ni, Ray
Mike, Does today's EDK2 C coding style spec allow using "STATIC" for global variables? Or lower case "static"? Or changing the variable to a name with lib name prefix, e.g.: " mTimerLibPerformanceCounterFrequency"? Thanks, Ray > -Original Message- > From: Desimone, Nathaniel L > Sent: F

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg: Support customized FV Migration Information

2023-11-30 Thread Ni, Ray
When PcdMigrateTemporaryRamFirmwareVolumes is TRUE, FV in flash (cached in code cache) is copied to physical memory and all C global pointers (PPIs, GUIDs) are fixed up. But TCG needs to measure the original FV contents, so the original FV is saved into MigratedFvInfo HOB when the FV migration i

Re: [edk2-devel] [PATCH v1 16/17] Silicon/Ampere/AmpereAltraPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Nhi Pham via groups.io
Thanks for update. Reviewed-by: Nhi Pham On 12/1/2023 7:34 AM, Taylor Beebe wrote: ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Nhi Pham Cc: Chuong Tran Cc: Leif Lindholm Cc: Rebecca Cran --- Silic

[edk2-devel] [PATCH v1] MdeModulePkg/Bus: Fix XhciDxe Linker Issues

2023-11-30 Thread Nate DeSimone
The DXE & MM standalone variant of AcpiTimerLib defines a global named mPerformanceCounterFrequency. A global with an identical name is also present in MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c Since XhciDxe has a dependency on TimerLib, this can cause link errors due to the same symbol being defined tw

[edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv: Fix syntax issue in markdown manual

2023-11-30 Thread Nate DeSimone
From: Ray Ni According to the markdown language syntax, headings should be after number signs (#). The number of number signs correspond to the heading level. But current PatchFvUserManual.md doesn't insert a space between the number signs and the heading title, resulting the markdown file is not

[edk2-devel] [PATCH v1] PcAtChipsetPkg: Fix AcpiTimerLib incompatibility with XhciDxe

2023-11-30 Thread Nate DeSimone
The DXE & MM standalone variant of AcpiTimerLib defines a global named mPerformanceCounterFrequency. A global with an identical name is also present in MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c Since XhciDxe has a dependency on TimerLib, this can cause link errors due to the same symbol being defined tw

Re: [edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase

2023-11-30 Thread Zhiguang Liu
Hi Ashraf For 1G page table, page table topology is like below Each Pml4 contains at most 512 Pdp. Each Pdp contains at most 512 Pdp entries. Now, we only have one Pml4, one Pdp and 512 Pdp entries. If increasing Ppd entries to more than 512, we need additional pdq, also need to change P

Re: [edk2-devel] [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Pushed as 10beadf -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Thursday, November 30, 2023 4:18 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Ni, Ray ; Chaganty, Rangasai V ; Gao, Liming ; Kinney, Michael D ; Sun, Zailiang ; Qian, Yi ; Taylor Beebe ;

Re: [edk2-devel] [PATCH v1 01/17] Platform/AMD/OverdriveBoard: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang I am good with this change if Ard and Leif has no additional comments on this. Abner > -Original Message- > From: Taylor Beebe > Sent: Friday, December 1, 2023 8:34 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Attar, Abdu

Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Pushed as 91e4065 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Thursday, November 30, 2023 4:18 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Ni, Ray ; Chaganty, Rangasai V ; Gao, Liming ; Kinney, Michael D ; Kelly Steele ; Taylor Beebe ; Kubacki, Mi

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg: Support customized FV Migration Information

2023-11-30 Thread gaoliming via groups.io
Fan: I add my comment below. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Wang Fan > 发送时间: 2023年10月27日 16:24 > 收件人: Kinney, Michael D ; > devel@edk2.groups.io > 抄送: Gao, Liming ; Jiang, Guomin > ; Bi, Dandan > 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg: Support customized > FV Migrat

Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

2023-11-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 30, 2023 4:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ni, Ray ; > Chaganty, Rangasai V ; Gao, Liming > ; Kinney, Michael D ; > Kelly Steele ; Taylor Beebe > ; Kubacki, M

Re: [edk2-devel] [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore Build Failures

2023-11-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 30, 2023 4:18 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ni, Ray ; > Chaganty, Rangasai V ; Gao, Liming > ; Kinney, Michael D ; > Sun, Zailiang ; Qian, Yi ; > Taylor Beebe

[edk2-devel] [PATCH v1 15/17] Platform/Sophgo/SG2042_EVB_Board: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Sunil V L Cc: dahogn Cc: meng-cz Cc: caiyuqing379 Cc: USER0FISH --- Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 + 1 file changed, 1 insertion(+) diff -

[edk2-devel] [PATCH v1 17/17] Silicon/Phytium/PhytiumCommonPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Leif Lindholm Cc: Peng Xie Cc: Ling Jia Cc: Yiqi Shu --- Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [PATCH v1 16/17] Silicon/Ampere/AmpereAltraPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Nhi Pham Cc: Chuong Tran Cc: Leif Lindholm Cc: Rebecca Cran --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + 1 file changed, 1 insertion(+) di

[edk2-devel] [PATCH v1 13/17] Silicon/Hisilicon: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Wenyi Xie --- Silicon/Hisilicon/Hisilicon.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Hisilicon/Hi

[edk2-devel] [PATCH v1 14/17] Silicon/Marvell/Armada7k8k: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Marcin Wojtas Cc: Leif Lindholm --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Marvell/Armada7k8k

[edk2-devel] [PATCH v1 11/17] Platform/SoftIron/Overdrive1000Board: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/So

[edk2-devel] [PATCH v1 12/17] Silicon/NXP: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Leif Lindholm Cc: Meenakshi Aggarwal --- Silicon/NXP/NxpQoriqLs.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Sil

[edk2-devel] [PATCH v1 09/17] Platform/SiFive/U5SeriesPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.

[edk2-devel] [PATCH v1 10/17] Platform/Socionext: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar

[edk2-devel] [PATCH v1 08/17] Platform/Qemu/SbsaQemu: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Graeme Gregory Cc: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [PATCH v1 06/17] Platform/RaspberryPi: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Jeremy Linton --- Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + 2 files changed, 2 i

[edk2-devel] [PATCH v1 07/17] Platform/Loongson/LoongArchQemuPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Bibo Mao Cc: Xianglai li Cc: Chao Li --- Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/Loongson/

[edk2-devel] [PATCH v1 04/17] Platform/Intel/Vlv2TbltDevicePkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Zailiang Sun Cc: Yi Qian Cc: Nate DeSimone Cc: Sai Chaganty --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + Platform/Intel/Vlv2TbltDevicePkg/P

[edk2-devel] [PATCH v1 05/17] Platform/LeMaker/CelloBoard: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/LeMaker/CelloBoard/

[edk2-devel] [PATCH v1 01/17] Platform/AMD/OverdriveBoard: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Abner Chang Cc: Abdul Lateef Attar Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + 1 file changed, 1 insertion(

[edk2-devel] [PATCH v1 02/17] Platform/ARM/Morello: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Thomas Abraham Cc: Sami Mujawar --- Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platfor

[edk2-devel] [PATCH v1 03/17] Platform/BeagleBoard/BeagleBoardPkg: Add ImagePropertiesRecordLib Instance

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Signed-off-by: Taylor Beebe Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/BeagleB

[edk2-devel] [PATCH v1 00/17] Add ImagePropertiesRecordLib Instances

2023-11-30 Thread Taylor Beebe
ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it needs to be added to most platforms. Taylor Beebe (17): Platform/AMD/OverdriveBoard: Add ImagePropertiesRecordLib Instance Platform/ARM/Morello: Add ImagePropertiesRecordLib Instance Platform/BeagleBoard/BeagleBoardPkg: Add Ima

Re: [edk2-devel] [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore Build Failures

2023-11-30 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 11/30/2023 7:18 PM, Nate DeSimone wrote: Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in Dx

回复: [edk2-devel] [PATCH v3 09/39] MdePkg: Add a new library named PeiServicesTablePointerLibReg

2023-11-30 Thread gaoliming via groups.io
Chao: I agree with Laszlo. I want to highlight that current design has meet with your requirement. So, I don’t think we need to add new APIs in PeiServicesTablePointerLib header file. Loong Arch can implement its PeiServicesTablePointerLib library instance base on its specific register. T

Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

2023-11-30 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 11/30/2023 7:18 PM, Nate DeSimone wrote: Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in Dx

Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Hey Taylor, I think I gotten everything in Platform/Intel, it should also fix QemuOpenBoardPkg and AmdMinBoardPkg. I saw that Levi also fixed ARM\VExpressPkg in https://edk2.groups.io/g/devel/message/111905. Everything else I'm not sure. Thanks for being proactive on fixing it! Best Regards, N

Re: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Pushed as 2e880c0 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Thursday, November 30, 2023 4:06 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Ni, Ray ; Chaganty, Rangasai V ; Gao, Liming ; Kinney, Michael D ; Taylor Beebe ; Kubacki, Michael Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

2023-11-30 Thread Taylor Beebe
Hey Nate, I'm about to send out a series to add the library across the repo -- just having some smtp authentication issues :D Are you updating all the packages or just a subset? -Taylor On 11/30/2023 4:18 PM, Nate DeSimone wrote: Commit 7284c44 in edk2 introduces an incompatibility that cau

[edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and

[edk2-devel] [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and

Re: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

2023-11-30 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 30, 2023 4:06 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ni, Ray ; > Chaganty, > Rangasai V ; Gao, Liming > ; Kinney, Michael D ; > Taylor Beebe ; Kubacki, M

[edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

2023-11-30 Thread Nate DeSimone
Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and

[edk2-devel] [PATCH 3/3] RedfishClientPkg: warn user about reboot if allowed.

2023-11-30 Thread Mike Maslenkin
Warn user about system reboot only if it has not been rejected by callbacks executed as result of EdkiiRedfishPhaseBeforeReboot notification Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 10 +

[edk2-devel] [edk2-redfish-client][PATCH 0/3] RedfishClientPkg: fix traces

2023-11-30 Thread Mike Maslenkin
This set contains a fix of misleading texts, format specifier and refines interaction with user about system reset. Here is link to PR: https://github.com/tianocore/edk2-redfish-client/pull/62 Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy

[edk2-devel] [PATCH 2/3] RedfishClientPkg: fix format specifier in DEBUG macro

2023-11-30 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../Features/MemoryCollectionDxe/MemoryCollectionDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c b/Red

[edk2-devel] [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces.

2023-11-30 Thread Mike Maslenkin
Update debug traces with the correct function names. Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 4 ++-- RedfishCl

Re: [edk2-devel] [PATCH v2 edk2-platforms 1/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support Standalone MM.

2023-11-30 Thread Nate DeSimone
Pushed as bd1c9ed -Original Message- From: Xu, Wei6 Sent: Thursday, November 30, 2023 7:07 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Bi, Dandan ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2 edk2-platforms 1/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support Standalone M

Re: [edk2-devel] [PATCH v2 edk2-platforms 1/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support Standalone MM.

2023-11-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Xu, Wei6 Sent: Thursday, November 30, 2023 7:07 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Bi, Dandan ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2 edk2-platforms 1/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support St

Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

2023-11-30 Thread Pedro Falcato
On Thu, Nov 30, 2023 at 9:31 PM Kinney, Michael D wrote: > > Hi Pedro, > > I agree that silent failures are terrible. > > The issue is documented with the requirement to use #include here: > > https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg#googletest-configuration > > Unit test

[edk2-devel] [PATCH 2/2] UnitTestFrameworkPkg/Readme.md: Remove the mention of the gtest main() limitation

2023-11-30 Thread Pedro Falcato
As of the previous commit, this limitation is no longer a thing. You can now write gtest unit tests with multiple files and no need for any hack such as #include. Signed-off-by: Pedro Falcato Cc: Michael D Kinney Cc: Michael Kubacki Cc: Sean Brogan --- UnitTestFrameworkPkg/ReadMe.md | 16

[edk2-devel] [PATCH 0/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

2023-11-30 Thread Pedro Falcato
Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by t

[edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files

2023-11-30 Thread Pedro Falcato
Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by t

Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

2023-11-30 Thread Michael D Kinney
Hi Pedro, I agree that silent failures are terrible. The issue is documented with the requirement to use #include here: https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg#googletest-configuration Unit tests are built with their own DSC configuration extensions. Does adding --wh

Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

2023-11-30 Thread Pedro Falcato
On Thu, Nov 30, 2023 at 7:32 PM Michael D Kinney wrote: > > With one comment below addressed > > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Pedro Falcato > > Sent: Wednesday, November 29, 2023 6:46 PM > > To: devel@edk2.groups.io > > Cc: Savva Mitrofanov ; Pedro Fal

Re: [edk2-devel] [PATCH 1/2] MdePkg/BaseLib: Fix CRC16-ANSI calculation

2023-11-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Pedro Falcato > Sent: Wednesday, November 29, 2023 6:46 PM > To: devel@edk2.groups.io > Cc: Savva Mitrofanov ; Pedro Falcato > ; Gao, Liming ; Kinney, > Michael D ; Liu, Zhiguang > > Subject: [PATCH 1/2] MdePkg/BaseLib: Fix CRC1

Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for BaseLib

2023-11-30 Thread Michael D Kinney
With one comment below addressed Reviewed-by: Michael D Kinney > -Original Message- > From: Pedro Falcato > Sent: Wednesday, November 29, 2023 6:46 PM > To: devel@edk2.groups.io > Cc: Savva Mitrofanov ; Pedro Falcato > ; Gao, Liming ; Kinney, > Michael D ; Liu, Zhiguang > > Subject: [P

[edk2-devel] [PATCH] UefiCpuPkg/ResetVector: Option for 1G Page Table Size increase

2023-11-30 Thread Ashraf Ali S
Currently 1G Page table is restricted 512GB. this patch can help to increase the page table size based on the input. default will be 512GB build option PAGE_TABLE_1G_SIZE is used to increase the page table size Cc: Rahul Kumar Cc: Ray Ni Cc: Catharine West Cc: V Sangeetha Signed-off-by: Ashraf

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Platform/ARM: Fix the build failure DxeCore

2023-11-30 Thread Thomas Abraham
On Thu, Nov 30, 2023 at 7:59 PM levi.yun wrote: > > The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16 > introduces a new library ImagePropertiesRecordLib to > consolidate the logic for manipulating the image properties > used to track runtime images and to remove duplicate code. > This lib

[edk2-devel] [PATCH v2 edk2-platforms 1/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support Standalone MM.

2023-11-30 Thread Xu, Wei6
Refactor UserAuthenticationSmm to support Standalone MM. - Factor out variable lock code logic that references boot services. - UserAuthenticationStandaloneMmDxe is added to lock the variables. It is only used for UserAuthenticationStandaloneMm. - UserAuthenticationStandaloneMm doesn't lock the v

[edk2-devel] [PATCH v2 edk2-platforms 0/1] UserAuthFeaturePkg/UserAuthenticationSmm: Support Standalone MM.

2023-11-30 Thread Xu, Wei6
v1: The this patch is to refator UserAuthenticationSmm to support MM_STANDALONE. PR: https://github.com/tianocore/edk2-platforms/pull/110 v2: Update copyright year on modified files. Rename UserAuthenticationVariableLockDxe to UserAuthenticationStandaloneMmDxe so that it is clear that this driver

[edk2-devel] [PATCH edk2-platforms v2 1/1] Platform/ARM: Fix the build failure DxeCore

2023-11-30 Thread levi.yun
The edk2 commit 7284c44951cffd52f1a08367d91b5c63c7bb9c16 introduces a new library ImagePropertiesRecordLib to consolidate the logic for manipulating the image properties used to track runtime images and to remove duplicate code. This library is further linked with DxeCore. Therefore, add an inst

Re: [edk2-devel] [edk2-platform] [PATCH] Platform/ARM: Fix build failure for FVP and Juno.

2023-11-30 Thread Sami Mujawar
Forwarding this discussion as it unfortunately missed the mailing list. Regards, Sami Mujawar On 29/11/2023 12:33 pm, Yeo Reum Yun wrote: Thanks Pierre :) +add Taylor Beebe @Taylor Beebe Hi Taylor! Thanks for your recent patch related to ImagePropertiesRecordLib! But, after applying your p

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-11-30 Thread Nhi Pham via groups.io
On 9/7/2023 10:38 PM, Nhi Pham wrote: > On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote: >> On 9/6/2023 1:50 AM, Ard Biesheuvel wrote: >>> On Wed, 6 Sept 2023 at 09:56, Nhi Pham >>> wrote: On 9/6/2023 1:33 PM, Ni, Ray wrote: > [EXTERNAL EMAIL NOTICE: This email originated from an exte

Re: [edk2-devel] [edk2-platform] [PATCH] Platform/ARM: Fix build failure for FVP and Juno.

2023-11-30 Thread Sami Mujawar
Hi Levi, Apparently, you have not posted the patch to the edk2 mailing list. Can you post a v2 series with the line ending issue fixed to the mailing list, please? Regards, Sami Mujawar On 30/11/2023, 10:30, "Sami Mujawar" mailto:sami.muja...@arm.com>> wrote: Hi Thomas, Before I go ahead

[edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

2023-11-30 Thread PierreGondois
Add definitions for: - _PSD version: added in ACPI 3.0 - C-state Coordination Types: added in ACPI 3.0 - _CPC version: added in ACPI 5.0 Signed-off-by: Pierre Gondois --- MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++ MdePkg/Include/IndustryStandard/Acpi40.h | 5 + MdePkg/Inc

[edk2-devel] [PATCH 0/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

2023-11-30 Thread PierreGondois
The patch-set at [1] aims to generate _CPC/_PSD information by querying the SCP through the SCMI protocol. Some _CPC/_PSD information is missing in the IndustryStandard folder. Extract the patch [2] from the patch-serie to avoid potentially re-submitting the whole patch-set and in case a new versi

Re: [edk2-devel] [PATCH v1 0/3] DynamicTablesPkg: Updated word I/O

2023-11-30 Thread PierreGondois
Hello Abdul, Thanks for the patches, Reviewed-by: Pierre Gondois Regards, Pierre On 11/29/23 17:05, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Code changes to Add API to generate word I/O ranges. Correct the parameter to generate word bus number. Corrects the function pointer typedef