Re: [edk2-devel] [PATCH v2 2/2] SctPkg: Fix the UefiSct -Wincompatible-pointer-types warnings

2023-12-10 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112271): https://edk2.groups.io/g/devel/message/112271 Mute This Topic: https://groups.io/mt/91642654/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH v2 1/2] SctPkg: Fix X64 build errors for GCC toolchain

2023-12-10 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112270): https://edk2.groups.io/g/devel/message/112270 Mute This Topic: https://groups.io/mt/91642649/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] Question about the boundary and difference between System Firmware and UEFI CXL drivers

2023-12-10 Thread Yuquan Wang
On 2023-12-08 15:42, Yoshinoya wrote: There is a description about UEFI Drivers in 1.4 Abbreviations in this doc. UEFI Drivers : UEFI CXL Bus and memory device drivers. I think UEFI CXL Drivers is a part of System Firmware(UEFI BIOS). These UEFI Drivers may do some basic configuation for some

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove HOB creation

2023-12-10 Thread Ni, Ray
Merged at bb13a4adab Thanks, Ray > -Original Message- > From: Ni, Ray > Sent: Saturday, December 9, 2023 9:27 AM > To: Nhi Pham ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar > ; Oliver Smith-Denny > Subject: RE: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: > Remove HOB

Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg.

2023-12-10 Thread duntan
Hi Laszlo, Previously I sent a patch set " Move gMpInformationHobGuid from StandaloneMmPkg to UefiCpuPkg. " and thanks for your review. To solve the issue that the maximum length of one HOB might not be enough when CPU count is 1-2000 or bigger and extend the HOB, we decide to create a new

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, December 11, 2023 #cal-reminder

2023-12-10 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, December 11, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v9 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

2023-12-10 Thread Dhaval Sharma
Thanks for the review. My comments inline: On Fri, Dec 8, 2023 at 9:58 AM Sunil V L wrote: > On Thu, Dec 07, 2023 at 10:31:48AM +0530, Dhaval Sharma wrote: > > Comments inline: > > > > > > On Wed, Dec 6, 2023 at 7:50 PM Sunil V L > wrote: > > > > > Hi Dhaval, > > > > > > Thank you very much

Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB

2023-12-10 Thread Mike Beaton
Resolves https://bugzilla.tianocore.org/show_bug.cgi?id=4620 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112262): https://edk2.groups.io/g/devel/message/112262 Mute This Topic: https://groups.io/mt/103087794/21656 Group Owner:

Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB

2023-12-10 Thread Mike Beaton
Repeats the commit already acked by Ard in https://edk2.groups.io/g/devel/topic/103083030, though with an attempt to provide an additional (not yet acked) useful commit message. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112261):

Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-10 Thread Mike Beaton
I've sent a patch to this list (with some kind of proposed comment about the issues!) under separate cover. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112260): https://edk2.groups.io/g/devel/message/112260 Mute This Topic:

[edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB

2023-12-10 Thread Mike Beaton
From: Mike Beaton This warning was already disabled in CLANGDWARF by commit d3225577123767fd09c91201d27e9c91663ae132. gcc can distinguish between optimised-away variable usage (as can occur in valid debug code) and genuinely unused variables, and only complains about the latter. clang cannot,

Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-10 Thread Mike Beaton
> Removing STATIC means that (modulo LTO) the compiler will not know > whether or not the definition can be dropped. It also pollutes the > global namespace. > > IMO, lack of the use of STATIC where appropriate is a severe issue > with the EDK2 codebase. Removing STATIC to appease compiler >

Re: [edk2-devel] RELEASE CLANGPDB OVMF currently does not compile

2023-12-10 Thread Ard Biesheuvel
On Sun, 10 Dec 2023 at 01:26, Mike Beaton wrote: > > Dear Ard, > > This one is about RELEASE CLANGPDB OVMF, which currently does not > compile, giving: > > ``` > /home/mjsbeaton/OpenSource/edk2/OvmfPkg/VirtioSerialDxe/VirtioSerial.c:28:22: > error: variable 'EventNames' is not needed and will not