[edk2-devel] 回复: [PATCH 2/2] BaseTools: Update keybaord map based on UEFI spec 2.10

2023-12-22 Thread gaoliming via groups.io
Don't need to update HiiFramework.h , because this protocol is from HII spec, not from UEFI spec. Thanks Liming > -邮件原件- > 发件人: Yi Li > 发送时间: 2023年12月22日 11:40 > 收件人: devel@edk2.groups.io > 抄送: Yi Li ; Rebecca Cran ; Liming > Gao ; Bob Feng ; Yuwei > Chen > 主题: [PATCH 2/2] BaseTools:

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig

2023-12-22 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 SuqiangX Ren > 发送时间: 2023年12月21日 10:41 > 收件人: devel@edk2.groups.io > 抄送: Ren,Suqiang ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Yi Li > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of >

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

2023-12-22 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 SuqiangX Ren > 发送时间: 2023年12月22日 14:33 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in >

[edk2-devel] 回复: [PATCH 1/1] MdePkg: Updated the definition of FileName on EFI_FILE_INFO

2023-12-22 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: RenSuqiang > 发送时间: 2023年12月22日 14:41 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [PATCH 1/1] MdePkg: Updated the definition of FileName on > EFI_FILE_INFO > > Add the description of FileName

回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2023-12-22 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ren, Suqiang > 发送时间: 2023年12月22日 16:11 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of > CapsuleImageSize on

回复: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of EFI_TCP6_OPTION

2023-12-22 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ren, Suqiang > 发送时间: 2023年12月22日 16:46 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Yi Li > > 主题: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of > EFI_TCP6_OPTION > >

[edk2-devel] [edk2-redfish-client][PATCH v3 3/3] RedfishClientPkg: fix access to unitialized variable.

2023-12-22 Thread Mike Maslenkin
It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used uninitialized in this function

[edk2-devel] [edk2-redfish-client][PATCH v3 2/3] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

2023-12-22 Thread Mike Maslenkin
Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v3 0/3] change method for provisioning + minor fixes

2023-12-22 Thread Mike Maslenkin
This patch set contains minor fixes. I have not added any copyrights as I have nothing to claim in this set. diff from v2: added Abner's RB tag diff from v1: original patch 4/4 with change related to BIOS resources provisioning removed. PR:

[edk2-devel] [edk2-redfish-client][PATCH v3 1/3] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

2023-12-22 Thread Mike Maslenkin
Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Igor

Re: [edk2-devel] [PATCH 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions

2023-12-22 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. I just have one comment marked inline as [SAMI]. Otherwise this patch looks good to me. With that addressed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 30/11/2023 11:09 am, Pierre Gondois wrote: Add definitions for: - _PSD version: added in

[edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

2023-12-22 Thread Kuo, Ted
https://bugzilla.tianocore.org/show_bug.cgi?id=4623 1.Added PeiCoreEntry.nasm, SecEntry.nasm and Stack.nasm for X64. 2.Made changes in common file to support both IA32 and X64. 3.Added the PCDs below for FSP-T UPD revisions and reset vector in FSP. - PcdFspWrapperBfvforResetVectorInFsp -

Re: [edk2-devel][edk2-platforms][PATCH v2] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

2023-12-22 Thread Kuo, Ted
Please drop v2. I'm going to update the patch to v3. Thanks, Ted -Original Message- From: devel@edk2.groups.io On Behalf Of Kuo, Ted Sent: Thursday, December 21, 2023 6:37 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Dong, Eric ; S,

Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

2023-12-22 Thread Chao Li
Thanks, Chao On 2023/12/22 17:47, Ard Biesheuvel wrote: On Fri, 22 Dec 2023 at 03:37, Ni, Ray wrote: Good to me. Thanks, Ray From: Chao Li Sent: Friday, December 22, 2023 9:15 AM To:devel@edk2.groups.io;a...@kernel.org; Ni, Ray Cc: Kumar, Rahul R; Gerd Hoffmann; Leif Lindholm; Ard

Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

2023-12-22 Thread Ard Biesheuvel
On Fri, 22 Dec 2023 at 03:37, Ni, Ray wrote: > > Good to me. > > > > Thanks, > > Ray > > From: Chao Li > Sent: Friday, December 22, 2023 9:15 AM > To: devel@edk2.groups.io; a...@kernel.org; Ni, Ray > Cc: Kumar, Rahul R ; Gerd Hoffmann > ; Leif Lindholm ; Ard > Biesheuvel ; Sami Mujawar >

Re: [edk2-devel] [Resend PATCH v5 0/4] DynamicTablesPkg: Adds WordIO and method invocation ability

2023-12-22 Thread Sami Mujawar
Series merged as 5d533bbc2773..d01defe06b35 Thanks. Regards, Sami Mujawar On 22/12/2023, 03:59, "Attar, AbdulLateef (Abdul Lateef)" mailto:abdullateef.at...@amd.com>> wrote: [AMD Official Use Only - General] Hi Sami, Below mentioned patch looks good;

[edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of EFI_TCP6_OPTION

2023-12-22 Thread Ren, Suqiang
Change the description of EnableTimeStamp and EnableWindowScaling to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 28.2.5 Signed-off-by: RenSuqiang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Protocol/Tcp6.h | 4 ++-- 1 file changed, 2

[edk2-devel] [PATCH 1/1] MdePkg: Update the definition of EFI_TCP6_OPTION

2023-12-22 Thread Ren, Suqiang
Change the description of EnableNagle and EnableTimeStamp to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 28.2.5 Signed-off-by: RenSuqiang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Protocol/Tcp6.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2023-12-22 Thread Ren, Suqiang
Add the description of CapsuleImageSize to align with UEFI spec 2.10. REF: UEFI spec 2.10 Table 8.5.3.1 Signed-off-by: RenSuqiang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Yi Li --- MdePkg/Include/Uefi/UefiSpec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff