Reviewed-by: James Lu
Thanks,
James
-Original Message-
From: Guo, Gua
Sent: Monday, January 8, 2024 3:30 PM
To: Chen, Gang C ; devel@edk2.groups.io
Cc: Dong, Guo ; Lu, James ; Rhodes,
Sean
Subject: RE: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling
check
Hi Liming,
Could you please have a check and merge this patch?
https://github.com/tianocore/edk2/pull/5167
Thanks
Ren, Suqiang
-Original Message-
From: gaoliming
Sent: Thursday, December 21, 2023 9:02 AM
To: devel@edk2.groups.io; Ren, SuqiangX
Cc: Kinney, Michael D ;
Add the Pull Request link: https://github.com/tianocore/edk2/pull/5186.
Hi Liming,
Could you please have a check and merge this patch?
Thanks
Ren, Suqiang
-Original Message-
From: Ren, SuqiangX
Sent: Tuesday, January 2, 2024 10:43 AM
To: 'gaoliming' ; devel@edk2.groups.io
Cc:
Reviewed-by: Gua Guo
-Original Message-
From: Chen, Gang C
Sent: Monday, January 8, 2024 3:26 PM
To: devel@edk2.groups.io
Cc: Guo, Gua ; Dong, Guo ; Lu, James
; Rhodes, Sean ; Chen, Gang C
Subject: [PATCH 1/1] UefiPayloadPkg/UefiPayloadEntry: Remove SCI enabling check
It's too
It's too early to check the SCI enable status, which is set in the BDS
phase ususally. Remove the check from UPL.
Signed-off-by: Gang Chen
Cc: Gua Guo
Cc: Guo Dong
Cc: James Lu
Cc: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 -
1 file changed, 38
Check SCI status too early will cause the below error message will be
printed out always:
ERROR: The ACPI enabling status is inconsistent: SCI is not enabled but
the ACPI table does not provide a means to enable it through
FADT->SmiCmd. This may cause issues in OS.
SCI will be set in BDS. So
It's too early to check the SCI enable status, which is set in the BDS
phase ususally. Remove the check from UPL.
Signed-off-by: Gang Chen
Cc: Gua Guo
Cc: Guo Dong
Cc: James Lu
Cc: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadEntry/AcpiTable.c | 38 -
1 file changed, 38
Check SCI status too early will cause the below error message will be
printed out always:
ERROR: The ACPI enabling status is inconsistent: SCI is not enabled but
the ACPI table does not provide a means to enable it through
FADT->SmiCmd. This may cause issues in OS.
SCI will be set in BDS. So
The IMD entry uses the 32bit start field as relative offset
to root. On Ia32X64 this works fine as UINTN is also 32 bit and
negative relative offsets are properly calculated due to an
integer overflow.
On X64 this doesn't work as UINTN is 64 bit and the offset
is no longer subtracted, but it's
On 2024/1/5 下午5:46, Chao Li wrote:
Add SEC code for LoongArch virtual machine.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Bibo Mao
Cc: Dongyan Qian
Signed-off-by: Chao Li
Co-authored-by: Xianglai
Yes. Please!
My local build cannot pass without this patch.
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Monday, January 8, 2024 1:37 PM
> To: devel@edk2.groups.io; Chen, Christine ; Joey
> Vagedes
> Cc: Rebecca Cran ; Gao, Liming
> ;
Hi Liming and Cran,
We should merge this fixing patch asap as it influences BaseTool's usage.
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Monday, January 8, 2024 9:16 AM
> To: Joey Vagedes ; devel@edk2.groups.io
> Cc: Rebecca
Please ignore the V2 patch set and help review the following V3 patch set.
" [Patch V3 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber"
" [Patch V3 1/2] UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0"
There was build error in the v2 patch series and the error was fixed in V3
patch
Check lower 24 bits of ProcessorNumber instead of
the value of ProcessorNumber in the API
MpInitLibGetProcessorInfo() of MpInitLibUp instance.
Lower 24 bits of ProcessorNumber contains the actual
processor number.
The BIT24 of input ProcessorNumber might be set to
indicate if the
Set EXTENDED_PROCESSOR_INFORMATION to 0 in API
MpInitLibGetProcessorInfo() of MpInitLibUp. This
commit use ZeroMem() to set all fileds in output
EFI_PROCESSOR_INFORMATION to 0 before StatusFlag
field is reassigned.
Previously EXTENDED_PROCESSOR_INFORMATION in the API
MpInitLibGetProcessorInfo()
Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib
headfile and lib instance in .inf to pass build since ZeroMem() is used.
Comparing to the V1 patch set:
In "set EXTENDED_PROCESSOR_INFORMATION to 0", set
EXTENDED_PROCESSOR_INFORMATION to 0 in API
Hi Pedro,
On Fri, Jan 05, 2024 at 07:10:40PM +, Pedro Falcato wrote:
> On Wed, Jan 3, 2024 at 1:59 PM Sunil V L wrote:
> >
> > This series adds the support for RISV-V Sstc extension in EDK2 timer
>
> nit: RISC-V
> > implementation. Sstc extension allows S-mode software to program the
> >
Thanks for the comments. The code has been updated in the V2 patch set.
Thanks,
Dun
-Original Message-
From: Laszlo Ersek
Sent: Friday, January 5, 2024 9:56 PM
To: Ni, Ray ; devel@edk2.groups.io; Tan, Dun
Cc: Kumar, Rahul R ; Gerd Hoffmann
; Xu, Min M
Subject: Re: [edk2-devel]
Check lower 24 bits of ProcessorNumber instead of
the value of ProcessorNumber in the API
MpInitLibGetProcessorInfo() of MpInitLibUp instance.
Lower 24 bits of ProcessorNumber contains the actual
processor number.
The BIT24 of input ProcessorNumber might be set to
indicate if the
Set EXTENDED_PROCESSOR_INFORMATION to 0 in API
MpInitLibGetProcessorInfo() of MpInitLibUp. This
commit use ZeroMem() to set all fileds in output
EFI_PROCESSOR_INFORMATION to 0 before StatusFlag
field is reassigned.
Previously EXTENDED_PROCESSOR_INFORMATION in the API
MpInitLibGetProcessorInfo()
In the V2 patch set:
In "set EXTENDED_PROCESSOR_INFORMATION to 0", set
EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of
MpInitLibUp. This commit use ZeroMem() to set all fileds in output
EFI_PROCESSOR_INFORMATION to 0 before StatusFlag field is reassigned.
In "Check
Hi Ard, Leif, Sami, Gred,
Can you please help to review this patch?
Thanks,
Chao
On 2024/1/5 17:45, Chao Li wrote:
Moved the PlatformBootManagerLib to OvmfPkg and renamed to
PlatformBootManagerLibLight for easy use by other ARCH.
Build-tested only (with "ArmVirtQemu.dsc").
Hi Ard, Leif, Sami, Gred,
Can you please help to review this patch?
Thanks,
Chao
On 2024/1/5 17:45, Chao Li wrote:
Move the PcdTerminalTypeGuidBuffer and PcdUninstallMemAttrProtocol into
OvmfPkg so other ARCh can easily use it.
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4584
Cc: Ard
Hi Ard, Leif, Sami, Gred,
Can you please help to review this patch?
Thanks,
Chao
On 2024/1/5 17:44, Chao Li wrote:
Move the FdtSerialPortAddressLib to Ovmfpkg so that other ARCH can
easily use it.
Build-tested only (with "ArmVirtQemu.dsc").
Hi Ard, Leif, Sami, Gred,
Can you please help to review this patch?
Thanks,
Chao
On 2024/1/5 17:44, Chao Li wrote:
CpuMmio2Dxe is supports MMIO, enable it.
Build-tested only (with "ArmVirtQemu.dsc").
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4584
Cc: Ard Biesheuvel
Cc: Leif
From: Abner Chang
Add PCD to disable ETag capability for the case Redfish
service doesn't support ETag.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Mike Maslenkin
---
RedfishClientPkg/RedfishClientPkg.dec | 3 +
.../RedfishFeatureUtilityLib.inf
[AMD Official Use Only - General]
Thanks for catching that, Igor. Will send out V4 for this change.
Abner
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, January 4, 2024 10:59 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Nickle Wang ; Mike Maslenkin
>
> Subject:
Hi Liming,
Thanks,
Chao
On 2024/1/8 09:35, gaoliming via groups.io wrote:
Chao:
Thanks for your update. The changes in MdePkg are good to me. Reviewed-by:
Liming Gao
But, I still have one minor comment on [PATCH v6 11/36] UefiCpuPkg: Add
CPU exception library for LoongArch.
Can
Chao:
Thanks for your update. The changes in MdePkg are good to me. Reviewed-by:
Liming Gao
But, I still have one minor comment on [PATCH v6 11/36] UefiCpuPkg: Add
CPU exception library for LoongArch.
Can you separate the change in MdePkg to another single commit?
Thanks
Liming
>
I just add push label for this PR.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ren, Suqiang
> 发送时间: 2024年1月3日 20:35
> 收件人: Gao, Liming ; devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Liu, Zhiguang
> ; Li, Yi1
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Yi Li
> 发送时间: 2023年12月25日 10:23
> 收件人: devel@edk2.groups.io
> 抄送: Yi Li ; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu ; Rebecca Cran ;
> Bob Feng ; Yuwei Chen
> 主题: [PATCH V2 0/2] Update keybaord map based on UEFI spec 2.10
>
> REF: UEFI
Hi Joey,
Thanks for fixing.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Joey Vagedes
> Sent: Friday, December 29, 2023 12:48 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [PATCH v1 1/1] BaseTools: Fix raw
This change looks good to me. Reviewed-by: Liming Gao
I will merge it.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ren, Suqiang
> 发送时间: 2024年1月3日 20:38
> 收件人: devel@edk2.groups.io; Gao, Liming
> 抄送: Kinney, Michael D ; Liu, Zhiguang
> ; Kasbekar, Saloni ;
> Clark-williams,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Igniculus.Fu
> via groups.io
> 发送时间: 2024年1月2日 14:27
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng ; Liming Gao
> ; Yuwei Chen ; Abner
> Chang ; Eric Xing ; Abdul
> Lateef Attar
> 主题: [edk2-devel] [PATCH] BaseTools/GenFds:
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, January 8, 2024
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
Reviewed-by: Yuwei Chen
> -Original Message-
> From: S, Ashraf Ali
> Sent: Monday, December 25, 2023 11:28 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chen, Christine
> ; Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chan,
> Amy ; Chaganty, Rangasai V
>
> Subject: [PATCH]
From: Abner Chang
Update Supported function to check it the given
controller handle is already started.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
.../RedfishRestExDxe/RedfishRestExDriver.h| 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
From: Abner Chang
Add HttpEventTlsConfigured HTTP callback event and notify
callback functions when TlsConfigureSession () returns.
Signed-off-by: Abner Chang
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Cc: Michael Brown
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: Michael Brown
From: Abner Chang
Implement EDKII_HTTP_CALLBACK_PROTOCOL that listens to
HttpEventTlsConfigured event for reconfiguring TLS configuration
data.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
.../RedfishRestExDxe/RedfishRestExDxe.inf | 3 +
From: Abner Chang
We still return EFI_SUCCESS to the caller when TlsConfigCertificate
returns error, for the use case the platform doesn't require
certificate for the specific HTTP session. This ensures
HttpInitSession function still initiated and returns EFI_SUCCESS to
the caller. The failure
From: Abner Chang
- Use HTTP instance as the parameter for TlsCreateChild function.
- Install TLS protocol on the HTTP instance thats create TLS child.
Signed-off-by: Abner Chang
Cc: Saloni Kasbekar
Cc: Zachary Clark-williams
Cc: Michael Brown
Cc: Nickle Wang
Cc: Igor Kulchytskyy
From: Abner Chang
For the HTTPS connetion that doesn't require TLS peer verification,
We introduce a new HTTP event HttpEventTlsConfigured to notify HTTP callback
functions after TlsConfigureSession(). With this event, the upper layer
HTTP application can listen to HttpEventTlsConfigured HTTP
[AMD Official Use Only - General]
> -Original Message-
> From: Chang, Abner
> Sent: Sunday, January 7, 2024 8:19 PM
> To: Michael Brown ; devel@edk2.groups.io
> Cc: Saloni Kasbekar ; Zachary Clark-williams
> ; Nickle Wang ; Igor
> Kulchytskyy
> Subject: RE: [PATCH 3/5]
[AMD Official Use Only - General]
> -Original Message-
> From: Michael Brown
> Sent: Saturday, January 6, 2024 1:15 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Saloni Kasbekar ; Zachary Clark-williams
> ; Nickle Wang ; Igor
> Kulchytskyy
> Subject: Re: [PATCH 3/5]
[AMD Official Use Only - General]
Hi Saloni,
We still create TLS child via service binding protocol, the difference is we
give HTTP handle to TLS service binding for installing TLS protocol on the HTTP
handle instead of a on a new EFI handle.
The logic is still the same just the code is moved
46 matches
Mail list logo
