[AMD Official Use Only - General]
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, January 9, 2024 3:15 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer.
>
> Caution:
On Mon, Jan 08, 2024 at 08:21:21PM +0100, Gerd Hoffmann wrote:
> ArmVirt and OVMF are doing the same.
>
> See commit d92eaabefbe0 ("OvmfPkg: simplify VARIABLE_STORE_HEADER
> generation") for details.
>
> Suggested-by: László Érsek
> Signed-off-by: Gerd Hoffmann
> ---
Thanks!, Gerd. Looks good t
Introduce DumpBuffer function to print the buffer content. This helps
developer to debug Redfish issue.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/Include/Library/RedfishDebugLib.h | 20 -
.../Library/RedfishDebugLib/RedfishDebugLi
Hi Laszlo,
Thanks,
Chao
On 2024/1/8 22:02, Laszlo Ersek wrote:
On 1/5/24 10:45, Chao Li wrote:
Moved the PlatformBootManagerLib to OvmfPkg and renamed to
PlatformBootManagerLibLight for easy use by other ARCH.
Build-tested only (with "ArmVirtQemu.dsc").
BZ:https://bugzilla.tianocore.org/show
On Mon, Jan 08, 2024 at 09:53:46PM +, Pedro Falcato wrote:
> On Mon, Jan 8, 2024 at 4:23 PM Dhaval Sharma wrote:
> >
> > Hi yangcheng/Pedro,
>
> +CC a bunch of relevant people
>
> Hi, (FYI you did not CC me)
>
> Looking at yangcheng's example:
>
> Status = PrepareDmaData (gpIdmacDesc, Le
Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5187
Could you help push it?
And there is another PR which reviewed by you and Wei:
https://github.com/tianocore/edk2/pull/5210
-Original Message-
From: gaoliming
Sent: Monday, January 8, 2024 9:16 AM
To: Li, Yi1 ; devel@ed
[AMD Official Use Only - General]
Hi @saloni.kasbe...@intel.com,
Could you please check patch 1/6 and 3/6 in V2 and give your RB if there is no
more concerns from you? Then I can merge this patch set. Thank you.
Abner
> -Original Message-
> From: Chang, Abner
> Sent: Sunday, January 7,
HI Liming,
All checks have passed in https://github.com/tianocore/edk2/pull/5075. What do
I need to do?
Thanks,
Heng
> -Original Message-
> From: Luo, Heng
> Sent: Wednesday, January 3, 2024 1:55 PM
> To: gaoliming ; devel@edk2.groups.io;
> Kasbekar, Saloni ; Clark-williams, Zachary
> ;
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, January 9, 2024
6:30pm to 7:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4
Hi Dhaval,
I can understand a little bit why ASSERT is used，If we can determine that
Riscv's BaseCacheMaintenanceLib needs to depend on the CMO instruction set,
then RISCV processor platforms that do not have the CMO instruction set should
not use this library. They should use BaseCacheMaintenan
I just add push label for this PR.
Thanks
Liming
> -邮件原件-
> 发件人: Ren, SuqiangX
> 发送时间: 2024年1月8日 15:50
> 收件人: Gao, Liming ; devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Liu, Zhiguang
> ; Li, Yi1
> 主题: RE: [edk2-devel] [PATCH V2 1/1] [MdePkg] Updated the definition of
> EFI_NVDIMM_LABE
Joey and Yanbo:
Thanks for your update. So, this one is new introduced issue. I agree to
resolve it asap.
Christine:
Can you create Pull Request to merge it?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Joey Vagedes via groups.io
发送时间: 2024年1月8日 23:09
收件人: Huang, Yanbo
抄送: Chen, Chr
*Tools, CI, Code base construction meeting series*
*When:*
Monday, January 8, 2024
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, January 8, 2024
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272
On Mon, Jan 8, 2024 at 4:23 PM Dhaval Sharma wrote:
>
> Hi yangcheng/Pedro,
+CC a bunch of relevant people
Hi, (FYI you did not CC me)
Looking at yangcheng's example:
Status = PrepareDmaData (gpIdmacDesc, Length, Buffer); <-- We write
to the IDMAC desc
if (EFI_ERROR (Status)) {
goto ou
Only accept gEfiAuthenticatedVariableGuid when checking the variable
store header in ValidateFvHeader().
The edk2 code base has been switched to use the authenticated varstore
format unconditionally (even in case secure boot is not used or
supported) a few years ago.
Suggested-by: László Érsek
S
Extend the ValidateFvHeader function, additionally to the header checks
walk over the list of variables and sanity check them.
In case we find inconsistencies indicating variable store corruption
return EFI_NOT_FOUND so the variable store will be re-initialized.
Signed-off-by: Gerd Hoffmann
---
ArmVirt and OVMF are doing the same.
See commit d92eaabefbe0 ("OvmfPkg: simplify VARIABLE_STORE_HEADER
generation") for details.
Suggested-by: László Érsek
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/RiscVVirt/VarStore.fdf.inc | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --
v4:
- turn into a little patch series.
- stop using gEfiVariableGuid in risc-v.
- stop accepting gEfiVariableGuid in VirtNorFlashDxe.
- refine variable checking.
Gerd Hoffmann (3):
OvmfPkg/RiscVVirt: use gEfiAuthenticatedVariableGuid unconditionally
OvmfPkg/VirtNorFlashDxe: stop accepting
The code was incorrectly assuming that root nodes had to be physical
package nodes and vice versa. This is not always true, so the check
is being removed.
Signed-off-by: Jeshua Smith
Tested-by: Ashish Singhal
Reviewed-by: Ashish Singhal
---
.../SsdtCpuTopologyGenerator.c| 23 ++
Hi yangcheng/Pedro,
Thanks for bringing this up. I understand the issue and probably we could just
keep it simple with a warning instead of an assert. But wanted to mention a
couple of points:
1. I think initially even in my patchset it was DEBUG message but there was a
comment to turn it into A
Hi Rebecca. I will investigate this for my account. joey.vage...@gmail.com is
correct on the mail map as it is my preference. Both my personal and
professional emails are linked to Bugzilla and github and
joey.vage...@gmail.com is what should be showing up as the author for commits.
Thanks for
Hi, all
I`m yangcheng, and I found this bug when using the
*edk2-platforms/Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe* driver on my
VisionFive2 development board, which does not support the *CMO* instruction
set. There are many functions in *DwEmmcDxe.c* that call Cache operations. For
exam
Reviewed-by: Dhaval Sharma
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113403): https://edk2.groups.io/g/devel/message/113403
Mute This Topic: https://groups.io/mt/103595210/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: h
Hi Liming,
It was introduced due to the fact that a few of the regex strings with
invalid escape sequences (due to regex using their own escape sequences)
also included valid escape sequences - for handling new lines. I did not
see the valid escape characters in the strings, and the virtual platfo
As per ACPI Spec 6.5+ Table 5-9 if xDSDT is available,
it should be used first. Handle required flow when xDSDT
is absent or present.
Test: Tested on RISCV64 Qemu platform with xDSDT and booted to
linux kernel.
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Dandan Bi
Cc: Pedro Falcato
Cc: devel@edk2.gro
Enable detection of XDSDT table from ACPI HOB and use it to comply
with ACPI spec 6.5+ Table 5-9. https://github.com/tianocore/edk2/pull/5235
Dhaval (1):
MdeModulePkg/AcpiTableDxe: Prefer xDSDT over DSDT when installing
tables
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c |
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Sunday, January 07, 2024 9:49 PM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy ; Mike
Maslenkin
Subject: [EXTERNAL] [edk2-redfish-client][PATCH V4] RedfishClientPkg: Add ETag
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: Chang, Abner
Sent: Sunday, January 07, 2024 9:43 PM
To: Igor Kulchytskyy ; devel@edk2.groups.io
Cc: Nickle Wang ; Mike Maslenkin
Subject: RE: [EXTERNAL] [edk2-redfish-client][PATCH V3] RedfishClientPkg: Add
ETag PCD
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Sunday, January 7, 2024 9:27 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 6/6] RedfishPkg/RedfishRestExDxe: Update Supported
> function
>
> E
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Sunday, January 7, 2024 9:27 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 5/6] RedfishPkg/RedfishRestExDxe: Uncrustify
> RedfishRestExDriver.h
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Sunday, January 7, 2024 9:27 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH V2 4/6] RedfishPkg/RedfishRestExDxe: Implement
> EDKII_HTTP_CALLBACK_PR
On 1/5/24 10:45, Chao Li wrote:
> Moved the PlatformBootManagerLib to OvmfPkg and renamed to
> PlatformBootManagerLibLight for easy use by other ARCH.
>
> Build-tested only (with "ArmVirtQemu.dsc").
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584
>
> Cc: Ard Biesheuvel
> Cc: Leif Li
Hi Liming,
This issue is introduced by this commit:
SHA-1: 9f0061a03b61d282fbc0ba5be22155d06a5e64a1
* BaseTools: Resolve regex syntax warnings
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) mod
Hi Liming,
Could you please help to check and merge this patch?
https://github.com/tianocore/edk2/pull/5170
Thanks
Ren, Suqiang
-Original Message-
From: gaoliming
Sent: Saturday, December 23, 2023 10:10 AM
To: devel@edk2.groups.io; Ren, SuqiangX
Cc: Kinney, Michael D
Christine:
Is this a regression issue? Or does it resolve new usage? I am curious why
it is not reported before.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Yuwei Chen
> 发送时间: 2024年1月8日 13:37
> 收件人: devel@edk2.groups.io; Chen, Christine ;
> Joey Vagedes
> 抄送: Rebecca Cran ; G
Hi Dhaval,
On 12/13/23 15:59, Dhaval Sharma wrote:
> Use newly defined cache management operations for RISC-V where possible
> It builds up on the support added for RISC-V cache management
> instructions in BaseLib.
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Laszlo Ersek
On 1/8/24 12:36, Sunil V L wrote:
> Sstc extension allows to program the timer and receive the interrupt
> without using an SBI call. This reduces the latency to generate the timer
> interrupt. So, detect whether Sstc extension is supported and use the
> stimecmp register directly to program the ti
On 1/8/24 06:08, duntan wrote:
> Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib
> headfile and lib instance in .inf to pass build since ZeroMem() is used.
Reviewed-by: Laszlo Ersek
>
> Comparing to the V1 patch set:
> In "set EXTENDED_PROCESSOR_INFORMATION to 0",
On 1/8/24 04:55, duntan wrote:
> In the V2 patch set:
> In "set EXTENDED_PROCESSOR_INFORMATION to 0", set
> EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of
> MpInitLibUp. This commit use ZeroMem() to set all fileds in output
> EFI_PROCESSOR_INFORMATION to 0 before Statu
On 1/5/24 19:38, Oliver Smith-Denny wrote:
> On 1/5/2024 9:22 AM, levi.yun wrote:
>>
>> Hi Ard :)
>>
>>> So now we will always initialize the serial port in the entrypoint
>>> only because DebugLib might use it later with doing the
>>> initialization.
>>>
>>> That doesn't sound quite correct to me.
Override Sstc extension and use SBI calls itself by default for RISC-V
qemu virt platform.
Cc: Andrei Warkentin
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Laszlo Ersek
Signed-off-by: Sunil V L
Reviewed-by: Laszlo Ersek
---
OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
1 file cha
Sstc extension allows to program the timer and receive the interrupt
without using an SBI call. This reduces the latency to generate the timer
interrupt. So, detect whether Sstc extension is supported and use the
stimecmp register directly to program the timer interrupt.
Cc: Gerd Hoffmann
Cc: Rah
stimecmp is a CSR supported only when Sstc extension is supported by the
platform. This register can be used to set the timer interrupt directly in
S-mode instead of going via SBI call. Add a function to update this
register.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Andrei Warke
Define the BIT 1 as the override bit for Sstc extension. This will be
used by the timer driver to decide whether to use SBI calls or direct
CSR access to configure the timer.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhiguang Liu
Cc: Andrei Warkentin
Signed-off-by: Sunil V L
---
MdePkg/MdePkg.
This series adds the support for RISC-V Sstc extension in EDK2 timer
implementation. Sstc extension allows S-mode software to program the
timer directly without using SBI calls.
Currently, PCD variable is used to detect whether feature is enabled. By
default the feature is enabled and platforms ne
Reviewed-by: levi.yun
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a
different mesh size and GIC ITS count. As part of the initial platform
support, add the corresponding platform and flash description files.
Use PcdPla
Reviewed-by: levi.yun
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
From: Pranav Madhu
Add RD-V2 platform identification values including the part number
and configuration number. This information will be used in populating
the SMBIOS tables.
Signed-off-by: Pranav Madhu
Signed-off-by:
Reviewed-by: levi.yun
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
From: Pranav Madhu
The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB
of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level
cache. Extend the SMBIOS support for RD-V2 platform with t
Reviewed-by: levi.yun
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
A new PCD named PcdPlatformVariant is introduced to specify the variant
number of a platform. This PCD can be used to select platform variant
specific configurations. The default value of this PCD is 0 which
selects the b
Reviewed-by: levi.yun
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
From: Omkar Anand Kulkarni
The software executing at a higher privileged level on the reference
design platforms have been updated to allow software executing at EL1
and EL0 to access the Advanced SIMD and floating-poin
Reviewed-by: levi.yun
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
From: Vijayenthiran Subramaniam
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3479
A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a
dependency to support dynamic variable flash information
Hi. Parabin
On 05/01/2024 15:38, Prabin CA via groups.io wrote:
Add the no-stack-protector compiler flag to allow StandaloneMM builds
on both AArch64 and x86 host. Without this flag, the link stage fails
with the following errors on multiple files when built with gcc
(Ubuntu 11.4.0-1ubuntu1~22.0
Hi Ard, all,
Could you please help explain how the depex section in an image is
mapped in terms of memory attribute?
As my observation, dispatcher locates[1] the depex section inside the
module image and write[2] an evaluated data to the depex if necessary
for scheduled boot order. The probl
Hello MdePkg Maintainers,
I forgot to include Liming's Reviewed-by tag:
https://edk2.groups.io/g/devel/message/112348
Regards,
Pierre
On 1/2/24 18:26, PierreGondois wrote:
Add definitions for:
- _PSD version: added in ACPI 3.0
- C-state Coordination Types: added in ACPI 3.0
- _CPC version: add
Sounds good, thank you.
Reviewed-by: Yi Li
-Original Message-
From: Hou, Wenxing
Sent: Monday, January 8, 2024 4:23 PM
To: Li, Yi1 ; devel@edk2.groups.io
Cc: Yao, Jiewen ; Jiang, Guomin
Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls
Hi,
For VS build, the
Hi,
For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISION,
because the previous code only had GCC build failure. This MACRO doesn't affect
the VS build.
For GCC build, the previous code didn`t have the size because of the build
failure.
To compare the size ,I add the dum
57 matches
Mail list logo
