Re: [edk2-devel] [PATCH v10 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

2024-01-11 Thread Dhaval Sharma
Based on the above discussion, and some more thoughts I am thinking it is okay to at least replace ASSERT from CMO code and let other platform code place its own guards to avoid calling this code when it is known that platform does not support such operations. If there are no objections to this we

Re: [edk2-devel] [PATCH v6 25/36] OvmfPkg/LoongArchVirt: Add stable timer driver

2024-01-11 Thread maobibo
On 2024/1/5 下午5:45, Chao Li wrote: Add a CPU timer driver named StableTimerDxe, which proviedes EFI_TIMER_ARCH_PROTOCOL for LoongArch. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Bibo Mao Cc: Dongyan

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishFeatureUtilityLib: Add two helper functions

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang - Add RedfishRemoveUnchangeableProperties () to remove unchangeable Redfish properties such as @OData.id. - Add DestoryRedfishCharArray () to free Redfish string array. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../RedfishFeatureUtilityLib.inf

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/ConverterLib: Function to remove Redfish unchangeable properties

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Update RedfishCsCommon.c to add a function to remove Redfish unchangeable properties. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../ConverterLib/include/RedfishCsCommon.h| 20 +++ .../ConverterLib/src/RedfishCsCommon.c| 55

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/jansson: Define json_object_del

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/PrivateInclude/jansson.h | 1 + 1 file changed, 1 insertion(+) diff --git a/RedfishClientPkg/PrivateInclude/jansson.h b/RedfishClientPkg/PrivateInclude/jansson.h index

[edk2-devel] [RESEND PATCH] RedfishPkg/JsonLib: Add JSON delete object function

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/Include/Library/JsonLib.h | 17 + RedfishPkg/Library/JsonLib/JsonLib.c | 24 2 files changed, 41 insertions(+) diff --git

[edk2-devel] [edk2-platforms][PATCH] RedfishPkg/JsonLib: Add JSON delete object function

2024-01-11 Thread Chang, Abner via groups.io
From: Abner Chang Add JSON delete object function to remove JSON object from the given JSON paylaod. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/Include/Library/JsonLib.h | 17 + RedfishPkg/Library/JsonLib/JsonLib.c | 24

Re: [edk2-devel] Memory Attribute for depex section

2024-01-11 Thread Andrew Fish via groups.io
Sorry need some more time to digest this…. First thoughts. 1) The actual performance issue we hit was the explosion of CoreValidateHandle() calls as the number of protocols got large for some diags. The newer handles tended to be at the end of the list if I remember correctly. a) It looks

[edk2-devel] [PATCH v3 4/4] MdeModulePkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v3 3/4] EmbeddedPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v3 1/4] UefiPayloadPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo PR: https://github.com/tianocore/edk2/pull/5252 V3 1. UefiPayloadPkg/Hob: Integer : Add error handle 2. StandaloneMmPkg/Hob: Integer Overflow in : Add error handle 3. EmbeddedPkg/Hob: Integer Overflow in CreateHob() : Add error handle V2 1. UefiPayloadPkg/Hob: Integer : Add

Re: [edk2-devel] Memory Attribute for depex section

2024-01-11 Thread Pedro Falcato
On Thu, Jan 11, 2024 at 8:46 AM Laszlo Ersek wrote: > > On 1/10/24 22:50, Pedro Falcato wrote: > > On Wed, Jan 10, 2024 at 1:45 PM Laszlo Ersek > > wrote: > >> > >> (+ Andrew) > >> > >> On 1/10/24 14:09, Laszlo Ersek wrote: > >> > >>> I think that keeping the depex section read-only is valuable,

Re: [edk2-devel] [PATCH 0/6] SECURITY PATCHES TCBZ4117 & TCBZ4118

2024-01-11 Thread Yao, Jiewen
Hi Doug Thanks for the fix. Please remember to CC all SecurityPkg maintainer and reviewer. I will merge after several days to see if there is any additional feedback from the community. Thank you Yao, Jiewen > -Original Message- > From: Douglas Flick [MSFT] > Sent: Friday, January

Re: [edk2-devel] [Patch V3] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-11 Thread duntan
Hi Gerd, I explain the reason why 47 here is since virtual addresses are sign-extended in the commit message. About the technical background, I also mentioned in the commit message " When 5-Level Paging is disabled and the PhysicalAddressBits retrived from CPU HOB or CpuId is bigger than 47".

Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5256 From: Joey Vagedes via groups.io Sent: Thursday, January 11, 2024 3:16 PM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest Thanks Mike, I've updated the PR / branch

Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Joey Vagedes via groups.io
Thanks Mike, I've updated the PR / branch with the reviewed-by tag. It is ready to be merged at your convenience. pip-requirements.txt: Update to latest by Javagedes · Pull Request #5256 · tianocore/edk2 (github.com) ( https://github.com/tianocore/edk2/pull/5256 ) Thanks, Joey

Re: [edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Joey Vagedes > Sent: Thursday, January 11, 2024 1:35 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Kinney, Michael D > Subject: [PATCH v1 1/1] pip-requirements.txt: Update to latest > > From: "Joey

Re: [edk2-devel] [PATCH] .pytool/Readme.md: Update matrix for DynamicTablesPkg

2024-01-11 Thread Joey Vagedes via groups.io
Hello. Reviewed-by: Joey Vagedes This has been merged via PR 5257 ( https://github.com/tianocore/edk2/pull/5257 ) , commit SHA 58355ec1926563efc954821a2851365182a4ebd4 Thanks, Joey -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

[edk2-devel] [PATCH v1 1/1] pip-requirements.txt: Update to latest

2024-01-11 Thread Joey Vagedes via groups.io
From: "Joey Vagedes (from Dev Box)" Updates edk2-pytool-extensions, edk2-pytool-library, and regex to their latest respective releases. Signed-off-by: Joey Vagedes Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney --- pip-requirements.txt | 6 +++--- 1 file changed, 3 insertions(+), 3

[edk2-devel] [PATCH v2 1/2] OvmfPkg: Add CloudHv support to PlatformScanE820 utility function.

2024-01-11 Thread Thomas Barrett
The PlatformScanE820 utility function is not currently compatible with CloudHv since it relies on the prescence of the "etc/e820" QemuFwCfg file. Update the PlatformScanE820 to iterate through the PVH e820 entries when running on a CloudHv guest. Cc: Anatol Belski Cc: Ard Biesheuvel Cc: Gerd

[edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv

2024-01-11 Thread Thomas Barrett
In addition to initializing the PhysMemAddressWidth and FirstNonAddress fields in PlatformInfoHob, the PlatformAddressWidthInitialization function is responsible for initializing the PcdPciMmio64Base and PcdPciMmio64Size fields. Currently, for CloudHv guests, the PcdPciMmio64Base is placed

[edk2-devel] [PATCH v2 0/2] Support CloudHv guests with >1TB of RAM.

2024-01-11 Thread Thomas Barrett
This series adds support for cloud-hypervisor guests with >1TiB of RAM to Ovmf. This bug was solved for Qemu back in 2017 https://bugzilla.redhat.com/show_bug.cgi?id=1468526. The bug is still occuring for CloudHv guests because the PlatformScanE820 utility is not currently supported for CloudHv.

Re: [edk2-devel] [PATCH] MdePkg/BaseLib: Fix InternalSwitchStack bug for RISCV64.

2024-01-11 Thread yorange
The problem has been fixed in this patch ( Re: [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform (groups.io) ( https://edk2.groups.io/g/devel/message/113624 ) ), no reply is needed here, thank you all. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to

Re: [edk2-devel] [PATCH 1/2] CloudHv: Add CloudHv support to PlatformScanE820 utility function.

2024-01-11 Thread Thomas Barrett
Hey Laslo, Thank you for the link to your git workflow and your patience. I will send out a ‘PATCH v2’ series that hopefully has all the necessary components by following the steps in the guide. Thomas On Thu, Jan 11, 2024 at 1:39 AM Laszlo Ersek wrote: > Hello Thomas, > > (+ Jianyong,

Re: [edk2-devel] [PATCH v2 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Sami Mujawar
Hi Gua, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 11/01/2024, 15:19, "Guo, Gua" mailto:gua@intel.com>> wrote: Maybe I can add error handle but they will have several case need to do if it's fine. It maybe increasing some BIOS size. Error Handle Error

Re: [edk2-devel] [PATCH v2] MdePkg/BaseLib:Fix boot DxeCore hang on riscv platform

2024-01-11 Thread Sunil V L
On Fri, Jan 05, 2024 at 03:47:07PM +, Andrei Warkentin wrote: > Looks reasonable to me. > > Reviewed-by: Andrei Warkentin > > > -Original Message- > > From: Yang Wang > > Sent: Wednesday, December 27, 2023 8:57 PM > > To: Warkentin, Andrei ; devel@edk2.groups.io > > Cc: Yang Wang ;

Re: [edk2-devel] [PATCH v2 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
Maybe I can add error handle but they will have several case need to do if it's fine. It maybe increasing some BIOS size. Error Handle Error HandleError Handle Error Handle A > B -> C --> CreateHob

Re: [edk2-devel] [PATCH v2 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Sami Mujawar
Hi Gua, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 11/01/2024, 14:19, "Guo, Gua" mailto:gua@intel.com>> wrote: You mean we need to add below error handle after all callers ? Hob = CreateHob (...) ASSERT (Hob != NULL); < Here [SAMI] That would

Re: [edk2-devel] [PATCH 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

2024-01-11 Thread Jeremy Linton
Hi, On 1/11/24 01:46, Ard Biesheuvel wrote: Hi Jeremy, Thanks for the patches. Thanks for looking at them! On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: The rpi's config.txt controls which uart (pl011, or miniuart) is selected as the console. TFA and edk2 follow its lead, but if

Re: [edk2-devel] [PATCH v2 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
You mean we need to add below error handle after all callers ? Hob = CreateHob (...) ASSERT (Hob != NULL); < Here Thanks, Gua -Original Message- From: Sami Mujawar Sent: Thursday, January 11, 2024 10:06 PM To: Guo, Gua ; devel@edk2.groups.io Cc: Marc Beatove ; Ard

Re: [edk2-devel] [PATCH v2 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Sami Mujawar
Hi Gua, Thank you for this patch. Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 11/01/2024, 09:15, "gua@intel.com " mailto:gua@intel.com>> wrote: From: Gua Guo mailto:gua@intel.com>> REF:

[edk2-devel] [PATCH 1/1] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads

2024-01-11 Thread Gerd Hoffmann
In some cases (specifically when the flash update region is small but crosses a multiple of P30_MAX_BUFFER_SIZE_IN_BYTES) NorFlashWriteSingleBlock reads only one instead of two P30_MAX_BUFFER_SIZE_IN_BYTES blocks into the shadow buffer. That leads to random crap being written to the second block,

Re: [edk2-devel] [PATCH v2 4/4] MdeModulePkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
Hi @Gao, Liming I may need to get your help to check this change when you're available. If it's fine for you from MdeModulePkg. I think we can merge this PR. https://github.com/tianocore/edk2/pull/5252 Thanks, Gua -Original Message- From: Guo, Gua Sent: Thursday, January 11, 2024

Re: [edk2-devel] [PATCH v2 0/4] RISC-V: Add support for Sstc extension

2024-01-11 Thread Sunil V L
On Mon, Jan 08, 2024 at 05:06:46PM +0530, Sunil V L wrote: > This series adds the support for RISC-V Sstc extension in EDK2 timer > implementation. Sstc extension allows S-mode software to program the > timer directly without using SBI calls. > > Currently, PCD variable is used to detect whether

Re: [edk2-devel] Memory Attribute for depex section

2024-01-11 Thread Laszlo Ersek
On 1/11/24 09:46, Laszlo Ersek wrote: > On 1/10/24 22:50, Pedro Falcato wrote: >> For the protocol database, you'd replace the linked list with a simple >> hashtable, hashed by protocol. Something as simple as LIST_ENTRY >> mProtocolHashtable[64]; would probably be enough to fan out most of >>

Re: [edk2-devel] [PATCH v2 0/4] Bz4166: Integer Overflow in CreateHob()

2024-01-11 Thread Gerd Hoffmann
On Thu, Jan 11, 2024 at 05:14:35PM +0800, gua@intel.com wrote: > From: Gua Guo > > Gua Guo (4): > UefiPayloadPkg/Hob: Integer Overflow in CreateHob() > StandaloneMmPkg/Hob: Integer Overflow in CreateHob() > EmbeddedPkg/Hob: Integer Overflow in CreateHob() > MdeModulePkg/Hob: Integer

Re: [edk2-devel] [Patch V3] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-11 Thread Gerd Hoffmann
On Thu, Jan 11, 2024 at 04:59:47PM +0800, Dun Tan wrote: > When creating smm page table, limit maximum > supported physical address bits returned by > CalculateMaximumSupportAddress() to 47 if > 5-Level Paging is disabled. > When 5-Level Paging is disabled and the > PhysicalAddressBits retrived

Re: [edk2-devel] [PATCH] UefiCpuPkg: change name of gMpInformationHobGuid2

2024-01-11 Thread Laszlo Ersek
On 1/11/24 10:00, Dun Tan wrote: > Change name of gMpInformationHobGuid2 to > gMpInformation2HobGuid. It's to align with > the file name MpInformation2.h and the > structure name MP_INFORMATION2_HOB_DATA. > > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd

Re: [edk2-devel] [PATCH 1/2] CloudHv: Add CloudHv support to PlatformScanE820 utility function.

2024-01-11 Thread Laszlo Ersek
Hello Thomas, (+ Jianyong, Anatol, Gerd) On 1/10/24 23:21, Thomas Barrett wrote: > Signed-off-by: Thomas Barrett > --- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 95 ++--- > 1 file changed, 65 insertions(+), 30 deletions(-) please don't paste patches in email bodies; they

[edk2-devel] [PATCH v2 3/4] EmbeddedPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v2 1/4] UefiPayloadPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v2 4/4] MdeModulePkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

[edk2-devel] [PATCH v2 0/4] Bz4166: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo V2 1. UefiPayloadPkg/Hob: Integer : Add Reviewed-by and Authored-by 2. StandaloneMmPkg/Hob: Integer Overflow in : Add Reviewed-by and Authored-by 3. EmbeddedPkg/Hob: Integer Overflow in CreateHob() : Add Reviewed-by and Authored-by 4. MdeModulePkg/Hob: Integer Overflow in

[edk2-devel] [PATCH v2 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
From: Gua Guo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166 Fix integer overflow in various CreateHob instances. Fixes: CVE-2022-36765 The CreateHob() function aligns the requested size to 8 performing the following operation: ``` HobLength = (UINT16)((HobLength + 0x7) & (~0x7));

Re: [edk2-devel] [Patch V3] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-11 Thread duntan
Hi Gerd, Could you help to review this V3 patch? The related code and comments has been modified based on your previous comments. Please ignore the V2 patch set. There was a typo error in the V2 patch and was corrected in V3 patch. Thanks, Dun -Original Message- From:

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Initialise serial port early in StandaloneMmEntryPoint

2024-01-11 Thread levi.yun
Hi Brian. > Ard didn't want a SerialPortInitialize() call directly in the > all-platform StandaloneMmCore _ModuleEntryPoint() function, which is > understandable. So perhaps you could either: Thanks to corret me :) > 1. Propose a platform-specific callout at that point and a library class >

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add EFI_UNSUPPORTED return for some Runtime Service functions

2024-01-11 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Wednesday, December 27, 2023 4:47 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject:

Re: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of FileName on EFI_FILE_INFO

2024-01-11 Thread Ren, Suqiang
Hi All, Any comments about this patch? Thanks Ren, Suqiang -Original Message- From: devel@edk2.groups.io On Behalf Of Ren, Suqiang Sent: Tuesday, December 26, 2023 1:22 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject:

[edk2-devel] [PATCH] UefiCpuPkg: change name of gMpInformationHobGuid2

2024-01-11 Thread duntan
Change name of gMpInformationHobGuid2 to gMpInformation2HobGuid. It's to align with the file name MpInformation2.h and the structure name MP_INFORMATION2_HOB_DATA. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/CpuMpPei/CpuMpPei.c

[edk2-devel] [Patch V3] UefiCpuPkg:Limit PhysicalAddressBits in special case

2024-01-11 Thread duntan
When creating smm page table, limit maximum supported physical address bits returned by CalculateMaximumSupportAddress() to 47 if 5-Level Paging is disabled. When 5-Level Paging is disabled and the PhysicalAddressBits retrived from CPU HOB or CpuId is bigger than 47, and since virtual addresses

Re: [edk2-devel] [Patch V2] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

2024-01-11 Thread duntan
Oh, thanks for your comments! Will correct it in next version patch. Thanks, Dun -Original Message- From: Laszlo Ersek Sent: Thursday, January 11, 2024 4:48 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; Kumar, Rahul R ; Gerd Hoffmann Subject: Re: [Patch V2] UefiCpuPkg:Limit

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix issue that IsModified is wrongly set in PageTableMap

2024-01-11 Thread Laszlo Ersek
On 1/11/24 03:03, Ni, Ray wrote: >> This function is incredibly complicated, so reviewing this patch is >> hard, even after reading the bugzilla ticket. >> >> The commit message is useless. It should contain a brief description of >> the problem, and how the fix resolves the problem. >> >> The

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent

2024-01-11 Thread Laszlo Ersek
On 1/11/24 03:08, Ni, Ray wrote: > > > Thanks, > Ray >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, January 10, 2024 7:57 PM >> To: Liu, Zhiguang ; devel@edk2.groups.io >> Cc: Ni, Ray ; Kumar, Rahul R ; >> Gerd Hoffmann >> Subject: Re: [PATCH] UefiCpuPkg/CpuMpPei:

Re: [edk2-devel] [Patch V2] UefiCpuPkg:Limit PhysicalAddressBits in speicial case

2024-01-11 Thread Laszlo Ersek
On 1/11/24 03:11, Dun Tan wrote: > When creating smm page table, limit maximum > supported physical address bits returned by > CalculateMaximumSupportAddress() to 47 if > 5-Level Paging is disabled. > When 5-Level Paging is disabled and the > PhysicalAddressBits retrived from CPU HOB or > CpuId is

Re: [edk2-devel] Memory Attribute for depex section

2024-01-11 Thread Laszlo Ersek
On 1/10/24 22:50, Pedro Falcato wrote: > On Wed, Jan 10, 2024 at 1:45 PM Laszlo Ersek > wrote: >> >> (+ Andrew) >> >> On 1/10/24 14:09, Laszlo Ersek wrote: >> >>> I think that keeping the depex section read-only is valuable, so I'd >>> rule out #2. I'd also not start with option #1 -- copying the

Re: [edk2-devel] [PATCH v1 0/4] Bz4166: Integer Overflow in CreateHob()

2024-01-11 Thread Ard Biesheuvel
On Thu, 11 Jan 2024 at 09:35, Guo, Gua wrote: > > CC: @Mathews, John and @Zimmer, Vincent > > Hi @Gerd Hoffmann > > My company teammate share me your patch can resolved > https://bugzilla.tianocore.org/show_bug.cgi?id=4166. So the signed-off name > is your name. > Again, a signed-off-by line

Re: [edk2-devel] [PATCH v1 0/4] Bz4166: Integer Overflow in CreateHob()

2024-01-11 Thread Guo, Gua
CC: @Mathews, John and @Zimmer, Vincent Hi @Gerd Hoffmann My company teammate share me your patch can resolved https://bugzilla.tianocore.org/show_bug.cgi?id=4166. So the signed-off name is your name. If you have any concern, you can also share for me, if you don't have concern please also