REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4659
When HPET timer is used as the timer interrupt and nested
interrupts into the HPET timer interrupt handler occur, the
elapsed time passed into the DXE Core is sometime too large
and this causes the DXE Core internal system time to run too
Thanks Tom.
Please give me some time to digest this patch set before I can give some
feedback.
One quick question to you:
With this patch, we need to support multiple SEV modes:
1. SEV guest firmware
2. SEV-ES guest firmware
3. SEV-SNP guest firmware
4. SEV-SNP SVSM guest firmware
And all these
On Fri, Jan 26, 2024 at 8:16 AM Tom Lendacky wrote:
>
> On 1/26/24 08:29, Gerd Hoffmann wrote:
> > Neat when doing ResetVector coding.
> > Incompatible with TDX and SEV, therefore not enabled by default.
> >
> > Signed-off-by: Gerd Hoffmann
>
> Acked-by: Tom Lendacky
>
Acked-by: Erdem Aktas
>
The memory returned by json_dumps() must be freed.
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
Variable 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Igor Kulchytskyy
Reviewed-by: Nickle Wang
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
1 file changed, 1 insertion(+)
This patchset contains a trivial fix for memory leak in ConverterLib
Also patch 1 is a resend of the same patch sent to list on 4th Jan with
added Rb (https://edk2.groups.io/g/devel/message/113162).
PR: https://github.com/tianocore/edk2-redfish-client/pull/74
Signed-off-by: Mike Maslenkin
Cc:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
Currently, an SEV-SNP guest will terminate if it is not running at VMPL0.
The requirement for running at VMPL0 is removed if an SVSM is present.
Update the current VMPL0 check to additionally check for the presence of
an SVSM is the guest
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The SVSM specification documents an alternative method of discovery for
the SVSM using a reserved CPUID bit and a reserved MSR.
For the CPUID support, the #VC handler of an SEV-SNP guest should modify
the returned value in the EAX register
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
When running under an SVSM, the VMPL level of the APs that are started
must match the VMPL level provided by the SVSM. Additionally, each AP
must have a Calling Area for use with the SVSM protocol. Update the AP
creation to properly support
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
Currently, the first time an AP is started for an SEV-SNP guest, it relies
on the VMSA as set by the hypervisor. If the list of APIC IDs has been
retrieved, this is not necessary. Instead, use the SEV-SNP AP Create
protocol to start the AP
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
If the hypervisor supports retrieval of the vCPU APIC IDs, retrieve
them before any APs are actually started. The APIC IDs can be used
to start the APs for any SEV-SNP guest, but is a requirement for an
SEV-SNP guest that is running under an
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
Create a PCD that can be used to set and get the APIC ID information that
is required for starting APs when an SVSM is present.
Signed-off-by: Tom Lendacky
---
UefiCpuPkg/UefiCpuPkg.dec | 7 ++-
UefiCpuPkg/UefiCpuPkg.uni | 3 +++
2
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
When an SVSM is present, starting the APs requires knowledge of the APIC
IDs. Create the definitions required to retrieve and hold the APIC ID
information of all the vCPUs present in the guest.
Signed-off-by: Tom Lendacky
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The RMPADJUST instruction is used to change the VMSA attribute of a page,
but the VMSA attribute can only be changed when running at VMPL0. When an
SVSM is present, use the SVSM_CORE_CREATE_VCPU and SVSM_CORE_DELTE_VCPU
calls to change the
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The RMPADJUST instruction is used to alter the VMSA attribute of a page,
but the VMSA attribute can only be changed when running at VMPL0. When
an SVSM is present, use the SVSM_CORE_CREATE_VCPU and SVSM_CORE_DELTE_VCPU
calls to add or remove
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The PVALIDATE instruction can only be performed at VMPL0. An SVSM will
be present when running at VMPL1 or higher.
When an SVSM is present, use the SVSM_CORE_PVALIDATE call to perform
memory validation instead of issuing the PVALIDATE
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
An SVSM requires a calling area page whose address (CAA) is used by the
SVSM to communicate and process the SVSM request.
Add a pre-defined page area to the OvmfPkg and AmdSev packages and define
corresponding PCDs used to communicate the
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
Add initial support for the new CcExitLib interfaces to the OvmfPkg
version of the library. The initial implementation will fully implement
the SVSM presence check API and the SVSM VMPL API, with later patches
fully implementing the other
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
In order to support an SEV-SNP guest running under an SVSM at VMPL1 or
lower, the CcExitLib library must be extended with new intefaces.
This includes an interface to detect if running under an SVSM, an
interface to return the current VMPL,
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The SVSM specification relies on a specific register calling convention to
hold the parameters that are associated with the SVSM request. The SVSM is
invoked by requesting the hypervisor to run the VMPL0 VMSA of the guest
using the GHCB MSR
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
The Secure VM Service Module specification defines the interfaces needed
to allow multi-VMPL level execution of an SEV-SNP guest.
Define the SVSM related structures for the SVSM Calling Area as well as
the SVSM CAA MSR. The SVSM CAA MSR is
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
In preparation for running under an SVSM at VMPL1 or higher (higher
numerically, lower privilege), re-organize the way a page state change
is performed in order to free up the GHCB for use by the SVSM support.
Currently, the page state
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654
This series adds SEV-SNP support for running OVMF under an Secure VM
Service Module (SVSM) at a less privileged VM Privilege Level (VMPL).
By running at a less priviledged VMPL, the SVSM can be used to provide
services, e.g. a virtual TPM,
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Douglas Flick [MSFT]
> Sent: Thursday, January 25, 2024 1:55 PM
> To: devel@edk2.groups.io
> Cc: Douglas Flick [MSFT] ; Kinney, Michael D
> ; Liming Gao ;
> Liu, Zhiguang
> Subject: [PATCH v2 12/15] MdePkg: Test: Add
Please make sure this change is also applied to the edk2-basetools repo.
Mike
From: devel@edk2.groups.io On Behalf Of Sami Mujawar
Sent: Friday, January 26, 2024 2:13 AM
To: devel@edk2.groups.io; Sami Mujawar ; Rebecca Cran
; nd
Subject: Re: [edk2-devel] [PATCH] Basetools: Include PCD
On 1/26/24 11:38, Tom Lendacky wrote:
+Min
Adding Min to see if TDX is also experiencing issues around this recent
change.
Thanks,
Tom
On 1/26/24 11:21, Tom Lendacky wrote:
On 1/22/24 00:47, Sheng Wei via groups.io wrote:
PciIoMap () need to feedback the status of
+Min
Adding Min to see if TDX is also experiencing issues around this recent
change.
Thanks,
Tom
On 1/26/24 11:21, Tom Lendacky wrote:
On 1/22/24 00:47, Sheng Wei via groups.io wrote:
PciIoMap () need to feedback the status of
mIoMmuProtocol->SetAttribute () return value.
REF:
On 1/22/24 00:47, Sheng Wei via groups.io wrote:
PciIoMap () need to feedback the status of
mIoMmuProtocol->SetAttribute () return value.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4652
I'm still investigating, but this commit breaks booting all types of SEV
guests. Without this
On 1/26/24 08:29, Gerd Hoffmann wrote:
Neat when doing ResetVector coding.
Incompatible with TDX and SEV, therefore not enabled by default.
Signed-off-by: Gerd Hoffmann
Acked-by: Tom Lendacky
---
OvmfPkg/ResetVector/QemuDebugCon.asm | 35 +++
Mike:
OK. I agree this patch can assure the memory type be always allocated at the
same address. I have no comments for this change.
Thanks
Liming
> -邮件原件-
> 发件人: Kinney, Michael D
> 发送时间: 2024年1月25日 9:39
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; 'Laszlo Ersek'
>
> 抄送:
BTW did you consider to remove this Private->Uri someday at all ?
I tried to remove it, but since it declared in a common header for all redfish
client feature drivers
those changes was huge comparing to a small memory leak I tried to fix.
And now such pattern spreads into new feature drivers.
Neat when doing ResetVector coding.
Incompatible with TDX and SEV, therefore not enabled by default.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/ResetVector/QemuDebugCon.asm | 35 +++
OvmfPkg/ResetVector/ResetVector.nasmb | 4 +++
2 files changed, 39 insertions(+)
create
[AMD Official Use Only - General]
It is no problem. Thank you Mike for looking into this patch.
Abner
> -Original Message-
> From: M M
> Sent: Friday, January 26, 2024 10:11 PM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; Nickle Wang ; Igor
> Kulchytskyy
> Subject: Re:
You are right.
Sorry for the noise!
No problems here.
I mixed up with tags in my editor while looked into patch.
Regards,
Mike
> On 26. 1. 2024., at 17:03, Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike,
> I can't identify the issue on %s as Private->Uri is defined as
[AMD Official Use Only - General]
Hi Mike,
I can't identify the issue on %s as Private->Uri is defined as EFI_STRING, or I
miss something?
Thanks
Abner
> -Original Message-
> From: M M
> Sent: Friday, January 26, 2024 9:55 PM
> To: devel@edk2.groups.io; Nickle Wang
> Cc: Chang, Abner
Hi,
> My preferred style is observed for example in:
>
> - NetworkPkg/NetworkLibs.dsc.inc
> - RedfishPkg/RedfishLibs.dsc.inc
>
> Alas, it is not observed in:
>
> - MdePkg/MdeLibs.dsc.inc
> - OvmfPkg/Include/Dsc/OvmfTpmLibs.dsc.inc
>
> At least, from the last two, OvmfTpmLibs.dsc.inc has an
Hi Abner,
> On 26. 1. 2024., at 05:20, Nickle Wang via groups.io
> wrote:
>
> Hi Abner,
>
> Same minor issue as 1_5_0. Please add "%a:" to below DEBUG call.
>
>> + DEBUG ((DEBUG_MANAGEABILITY, " No platform Redfish ConfigureLang
>> found for %s\n", __func__, Private->Uri));
>
>
Hi Duke,
Next time please also CC reviewers in the cover letter, thus the cover letter
can be also sent to reviewers directly.
For the entire patch set: Reviewed-by: Abner Chang
Thanks
Abner
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
On Thu, Jan 25, 2024 at 08:47:56PM +0100, Laszlo Ersek wrote:
> On 1/25/24 08:50, Gerd Hoffmann wrote:
> > On Wed, Jan 24, 2024 at 05:43:29PM -0800, Erdem Aktas wrote:
> >> Same for TDX, I did not run it but it should cause failure
> >> as debugShowPostCode is called
On Fri, Jan 26, 2024 at 02:49:13AM +, Liu, Zhiguang wrote:
> Hi Gerd,
> For the PCD, it current has below usage.
> 1) for 32-bit PEI and 64-bit DXE, this PCD will decide if use 5 level paging
> in DXE.
Yes. That is the only real use of the PCD today. I expect the days of
32bit BEI / 64bit
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114608): https://edk2.groups.io/g/devel/message/114608
Mute This Topic: https://groups.io/mt/103975493/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114601): https://edk2.groups.io/g/devel/message/114601
Mute This Topic: https://groups.io/mt/103975481/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114585): https://edk2.groups.io/g/devel/message/114585
Mute This Topic: https://groups.io/mt/103975449/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
From: Duke Zhai
BZ #:4640
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114578): https://edk2.groups.io/g/devel/message/114578
Mute This Topic: https://groups.io/mt/103975437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
From: Duke Zhai
BZ #:4640
In V2: Improve coding style
1.Remove the leading underscore and use double underscore at trailing in C
header files.
2.Remove old tianocore licenses and redundant license description.
3.Improve coding style. For example: remove space between @param.
In V1:
From: Duke Zhai
In V3: Improve coding style follow edk2 C coding standard.
1.Remove macro definition extra underscores.
2.Putting some AMD copyright in the right place.
In V2: Improve coding style.
1.Remove the leading underscore and use double underscore at trailing in C
header files.
Hi Pierre,
Thank you for the updated patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/01/2024, 15:19, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Add AmlCreatePsdNode() to the AmlLib to generate _PSD objects.
_PSD objects allow to describe 'performance control,
Hi Pierre,
Thank you for the updated patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/01/2024, 15:19, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Add an object describing _PSD information, cf. ACPI 6.5,
s8.4.5.5 _PSD (P-State Dependency).
Also add the corresponding
Hi Rebecca,
I have created a pull request at
https://github.com/samimujawar/edk2/pull/new/REVIEW_2986_basetools_pcd_declare_lib_instance_v1
Regards,
Sami Mujawar
From: on behalf of "Sami Mujawar via groups.io"
Reply to: "devel@edk2.groups.io" , Sami Mujawar
Date: Friday, 26 January 2024
Hi Levi,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114572): https://edk2.groups.io/g/devel/message/114572
Mute This Topic:
Hi Duke,
Besides the AMD copyright is put in an improper place. I also found that there
are several #include guards that don't follow edk2 C coding standard. There are
several trailing underscores (like four underscores) attached to the macro.
Please just put one trailing underscore as
Hi Rebecca,
Can you let me know if I can merge this patch, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114568): https://edk2.groups.io/g/devel/message/114568
Mute This Topic:
[AMD Official Use Only - General]
> -Original Message-
> From: Zhai, MingXin (Duke)
> Sent: Friday, January 26, 2024 2:01 PM
> To: devel@edk2.groups.io
> Cc: Xing, Eric ; Zhai, MingXin (Duke)
> ; Fu, Igniculus ; Chang,
> Abner
> Subject: [PATCH V2 21/32] AMD/VanGoghBoard: Check in
[AMD Official Use Only - General]
> -Original Message-
> From: Zhai, MingXin (Duke)
> Sent: Friday, January 26, 2024 2:00 PM
> To: devel@edk2.groups.io
> Cc: Zhai, MingXin (Duke) ; Yao, Ken
> ; Fu, Igniculus ; Chang, Abner
>
> Subject: [PATCH V2 01/32] AMD/AmdPlatformPkg: Check in AMD
77 matches
Mail list logo
