Re: [edk2-devel] Fixing edk2-basetools CI

2024-02-15 Thread Rebecca Cran
I've updated the PR https://github.com/tianocore/edk2-basetools/pull/116/ to include commits from the pyflake8 disable PR and a couple more commits that cause CI to start passing. I realize that disabling both flake8 and codecov isn't good, but my thinking is to get builds working again then we

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct %LX SctPrint code

2024-02-15 Thread G Edhaya Chandran
The patch is upstreamed by the commit: https://github.com/tianocore/edk2-test/commit/19e53ca9a39c5cb2deed1dc1d7758a6b0241991c -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115537): https://edk2.groups.io/g/devel/message/115537 Mute This

[edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-15 Thread cbduggap
Changes to support spec changes 1. Remove usage of Pcd. 2. Change code to validate the Temporary Ram size input. 3. Consume the input saved in YMM Register Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chiu Chasel Cc: Duggapu Chinni B Signed-off-by: Duggapu Chinni B --- IntelFsp2Pkg/FspSecCore/F

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Ard Biesheuvel
On Thu, 15 Feb 2024 at 20:55, Oliver Smith-Denny wrote: > > On 2/14/2024 11:50 PM, Ard Biesheuvel wrote: > > I looked at the EFI spec again, and EfiACPIReclaimMemory is not > > actually listed as a memory type that has this 64k alignment > > requirement. This makes sense, given that this memory ty

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Oliver Smith-Denny
On 2/14/2024 11:50 PM, Ard Biesheuvel wrote: I looked at the EFI spec again, and EfiACPIReclaimMemory is not actually listed as a memory type that has this 64k alignment requirement. This makes sense, given that this memory type has no significance to the firmware itself, only to the OS. OTOH, re

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Oliver Smith-Denny
On 2/15/2024 9:21 AM, Ard Biesheuvel wrote: Of the two options you presented in this paragraph, I prefer the one where the allocation presented to the caller may not be aligned, but the region plus guards is. But disabling it entirely for these regions is still perfectly fine with me, especially

Re: [edk2-devel] [PATCH v2 4/4] NetworkPkg: : Updating SecurityFixes.yaml

2024-02-15 Thread Doug Flick via groups.io
At this point - yes - but I don't have the ability to edit it. The advisory should reflect the current status. SecurtiyFixes.yaml is a way to express which commits are needed to be cherrypicked by a downstream consumer and what the current release is protected against. -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

2024-02-15 Thread Michael D Kinney
Hi Laszlo, I was also thinking the INF Version would be best approach. I recommend we identify the EDK II Build Specification and EDK II INF Specification changes required to resolve this issue. https://github.com/tianocore-docs/edk2-BuildSpecification https://github.com/tianocore-docs/edk2-Inf

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

2024-02-15 Thread Ard Biesheuvel
On Thu, 15 Feb 2024 at 18:08, Oliver Smith-Denny wrote: > > On 2/14/2024 11:50 PM, Ard Biesheuvel wrote> On Thu, 15 Feb 2024 at > 01:34, Oliver Smith-Denny > > wrote >> This could also be fixed with > > rearchitecting the heap guard system to > >> respect alignment requirements and shift the gua

[edk2-devel] [PATCH] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-15 Thread cbduggap
Changes to support spec changes 1. Remove usage of Pcd. 2. Change code to validate the Temporary Ram size input. 3. Consume the input saved in YMM Register Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chiu Chasel Signed-off-by: cbduggap --- .../FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 1 -

Re: [edk2-devel] [PATCH v3 0/7] EDK2-TEST TCG MOR Tests

2024-02-15 Thread Stuart Yoder
On 2/14/24 9:30 PM, Abhi Singh wrote: Updates after feedback from Stuart -add tests that checks if MOR variable can be deleted if MORLOCK is in a lock state. -fix some grammar/spelling/capitalization errors. -relaxed some tests to work with current edk2 implementation. -corrected incorrect

Re: [edk2-devel] 回复: [edk2-stable202402] [PATCH v5 1/1] MdeModulePkg/AcpiTableDxe: Prefer xDSDT over DSDT when installing tables

2024-02-15 Thread Leif Lindholm
Excellent, thank you. And it will still go in within the next few weeks, just not before we make the stable tag. / Leif On 2024-02-15 10:40, Dhaval Sharma wrote: For me it is not impacting a production system so I can wait a cycle more. @Liming Gao  I will

Re: [edk2-devel] [PATCH 1/1] SbsaQemu: AcpiDxe: Create SRAT table at runtime

2024-02-15 Thread Marcin Juszkiewicz
W dniu 31.01.2024 o 2:15 PM, Xiong Yining pisze: Add support to create SRAT(System resource affinity table) for sbsa platform at runtime. Signed-off-by: Xiong Yining Signed-off-by: Chen Baozi --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 27 ++ .../Include/Library/SbsaQemuHardware

Re: [edk2-devel] [PATCH v2 4/4] NetworkPkg: : Updating SecurityFixes.yaml

2024-02-15 Thread Rebecca Cran
I noticed the advisory at https://github.com/advisories/GHSA-h9v6-q439-p7j2 is labeled "Unreviewed". Should it be updated, and should the 'package', 'affected' and 'patched' fields be updated? -- Rebecca Cran On 2/13/2024 11:46 AM, Doug Flick via groups.io wrote: From: Doug Flick This capt

Re: [edk2-devel] mail-archive.com (secondary archive) feed resumed

2024-02-15 Thread Rebecca Cran
On 2/15/2024 4:28 AM, Laszlo Ersek wrote: mail-archive.com is an important secondary archive because it offers message-id-based lookup. "git am --message-id" captures patch email message IDs in the commit messages, and then those can be used for locating the related review discussion in the archi

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

2024-02-15 Thread Laszlo Ersek
On 2/15/24 12:09, eddie wang wrote: > Hi Laszlo, > Thanks for your reply. How can I enable the DEBUGs at RandomSeed() ? Or > any suggesting information that I can provide? Sorry, upon a closer look, I see you had already narrowed it down to RAND_seed() and RAND_status(), which are direct OpenSSL A

[edk2-devel] mail-archive.com (secondary archive) feed resumed

2024-02-15 Thread Laszlo Ersek
Hi, you may have noticed that the secondary archive at stopped receiving messages after 28 Jan 2024. The reason is described here: https://groups.io/static/reverifyfaq A message about the reverification ("Update on Groups.io Reverification P

Re: [edk2-devel] The API in BaseCryptLib can't seed the pseudorandom number generator properly

2024-02-15 Thread eddie wang
Hi Laszlo, Thanks for your reply. How can I enable the DEBUGs at RandomSeed() ? Or any suggesting information that I can provide? BR, Eddie Laszlo Ersek 於 2024年2月8日 週四 上午5:03寫道: > On 2/6/24 08:00, eddie wang wrote: > > Hi all, > > We had an UEFI application that used the EDK2(2023/12/05), and