Re: [edk2-devel] [PATCH] UefiCpuPkg: add volatile qualifier to page table related variable

Thank all for review. > Volatile-qualifying the local variables does not seem useful for > anything. It's fine -- actually: it's beneficial -- if the compiler > optimizes accesses to those locals -- being on the stack -- as heavily > as it can. In other words, those parts of the patch look like

[edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN

Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as IN. "IN" replaced with "IN OUT" in the following interfaces: PageTableLibSetPte4K(): Pte4K PageTableLibSetPleB(): PleB PageTableLibSetPle(): Ple PageTableLibSetPnle(): Pnle Reviewed-by: Ray Ni Signed-off-by: Zhou Jianfeng

[edk2-devel] [PATCH] MdeModulePkg/Xhci: Skip another size round up for TRB address translation

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4560 Commit f36e1ec1f0a5fd3be84913e09181d7813444b620 had fixed the DXE_ASSERT caused by the TRB size round up from 16 to 64 for most cases. However, there is a remaining case that the TRB size is also rounded up during setting TR dequeue pointer

[edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

Add volatile qualifier to page table related variable to prevent compiler from optimizing away the variables which may lead to unexpected result. Signed-off-by: Zhou Jianfeng Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Pedro Falcato Cc: Zhang Di Cc: Tan Dun --- .../L

[edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool

From: PhanindraX Babu Pabba Adding missed out call to FreePool API to free the allocated memory. Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: PhanindraX Babu Pabba --- .../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Fea

[edk2-devel] [PATCH] MinPlatformPkg: Add missed call to FreePool

From: PhanindraX Babu Pabba Adding missed out call to FreePool API to free the allocated memory. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: PhanindraX Babu Pabba --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +- Platform/Intel/MinPl

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

Hi @Mike Maslenkin, Can you please help me to add my reviewed-by to this commit message? https://github.com/tianocore/edk2-redfish-client/pull/76/commits/7110d17629d6131030a3c382ca46d9331e13f2af Then I can merge this pull request. Thanks, Nickle > -

[edk2-devel] [PATCH 0/2] ArmPkg/ArmLib: add functions to read system registers

My ArmCpuInfo tool reads system registers to check which features are supported by AArch64 cores in host system. I am updating it for 2023-12 update of "Arm A-profile Architecture Registers" document [1] and had to add reading of several new system registers. 1. https://developer.arm.com/document

[edk2-devel] [PATCH v2 2/2] ArmPkg/ArmLib: Add functions to read future system registers

https://developer.arm.com/documentation/ddi0601/2023-12/ lists more system registers than EDK2 supports now. ISAR3, MMFR3, MMFR4, PFR2, FPFR0 were added. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h| 34 --- .../Library/ArmLib/AArch64/AArc

[edk2-devel] [PATCH v2 1/2] ArmPkg/ArmLib: Add functions to read SVE/SME system registers

There are functions to read DFR, MMFR, PFR system registers. So let add ones for SMFR0 and ZFR0 ones too. ArmReadIdAA64Zfr0() uses s3_0_c0_c4_4 notation as clang 17 on my system does not recognize normal name. Bumps build flags to "armv8-a+sme" to get access to both registers. Signed-off-by: Mar

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Hi Nickle, %s/Resrouce/Resource/ this comes from RedfishClient autogenerated files... there are thousands of "Resrouce" typos. please, find my minor notes below: On Thu, Feb 22, 2024 at 12:11 PM Nickle Wang via groups.io wrote: > > implement Redfish HTTP protocol driver. > > Signed-off-by:

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

Hi Nickle, I've updated commit message with your R-b and pushed it to PR. Regards, Mike. > On 23. 2. 2024., at 12:38, Nickle Wang wrote: > > Hi @Mike Maslenkin , > > Can you please help me to add my reviewed-by to this commit message? > https://github.com/ti

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 22/02/2024 08:41, Zhou Jianfeng wrote: --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c @@ -20,13 +20,13 @@ **/ VOID PageTableLibSetPte4K ( - IN OUT IA32_PTE_4K *Pte4K, - IN UINT64 Offset, -

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceResourceFeatureCallback

Thanks Mike! I merged the pull request. Regards, Nickle From: M M Sent: Friday, February 23, 2024 7:32 PM To: Nickle Wang Cc: devel@edk2.groups.io; Abner Chang ; Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 2/4] RedfishClientPkg: refine RedfishExternalResourceRes

Re: [edk2-devel] Fixing edk2-basetools CI

Could someone review Fix build-publish-whl-steps.yml: we no longer use setup.py by bcran · Pull Request #117 · tianocore/edk2-basetools · GitHub please? It should be the last change needed to fix publishing releases. -- Rebecca Cran On 2/2

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

Hi, I was originally responsible for suggesting this change internally(more specifically - to switch from Intel specific LPSS UART driver to EDK2 driver which on inspection seemed to cover all relevant modes of operations of LPSS UART). First I would like to explain how exactly we are using th

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

On 23/02/2024 15:12, Zhou, Jianfeng wrote: While it may well cause the compiler to generate less optimised code, there is absolutely no way that this volatile declaration on a local stack variable can possibly change the outcome of the code. There can never be any meaningful side-effects from r

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

Hi Nickle, On Fri, Feb 23, 2024 at 5:07 PM Nickle Wang wrote: > > Thanks for your review, Mike. > > > %s/Resrouce/Resource/ this comes from RedfishClient autogenerated files... > > Typos are Addressed. I will send v3 later. > > >> +ON_ERROR: > >> + > >> + ReleaseRedfishPayload (NewPayload); > >>

[edk2-devel] [PATCH v3] MdePkg/SmBios.h: Add New ProcessorFamily definitions for SMBIOS Type4

From: Jason Lou The patch adds new ProcessorFamily definitions for SMBIOS Type4 based on SMBIOS 3.8.0. Signed-off-by: Jason Lou Cc: Zhiguang Liu Cc: Dandan Bi Cc: Star Zeng Cc: Zhichao Gao Cc: Benny Lin Cc: Gua Guo Cc: Michael D Kinney Cc: Liming Gao --- ShellPkg/Library/UefiShellDebug

Re: [edk2-devel] [PATCH] MinPlatformPkg/PhatAcpiLib: Add to CoreDxeLib dsc

Patch merged: https://github.com/tianocore/edk2-platforms/commit/e19e5d583d204a2011cab42e7b669ed274d1a8fb Thanks, Chasel > -Original Message- > From: Clark-williams, Zachary > Sent: Tuesday, February 20, 2024 9:18 PM > To: devel@edk2.groups.io > Cc: Clark-williams, Zachary ; Chiu, Cha

Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi:StandaloneMmGenericIpmi

Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of Huang, > Li-Xia > Sent: Monday, January 29, 2024 9:36 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 1/1] > IpmiFeaturePkg/GenericIpmi:StandaloneMmGenericIpmi > > StandaloneMmGener

Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi:StandaloneMmGenericIpmi

Pushed as 8517d20. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Huang, > Li-Xia > Sent: Monday, January 29, 2024 9:36 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 1/1] > IpmiFeaturePkg/GenericIpmi:StandaloneMmGenericIpmi > > StandaloneMmGenericIpmi dr

Re: [edk2-devel] Peims are not gettting Dispatched in EagleStream Platform

> -Original Message- > From: memristor2 > Sent: Thursday, February 22, 2024 5:51 AM > To: Desimone, Nathaniel L > Cc: devel@edk2.groups.io; ler...@redhat.com > Subject: RE: [edk2-devel] Peims are not gettting Dispatched in EagleStream > Platform > > Thank you. Based on what you told me (

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

Since this is not a standard PCI visible to PCI Bus Driver, did you consider using MdeModulePkg\Universal\SerialDxe that produces a Serial I/O Protocol from a SerialPortLib instance? That was SerialPortLib can be used for DEBUG() logging and the Serial I/O Protocol produced by SerialDxe can be u

Re: [edk2-devel] Fixing edk2-basetools CI

Thanks. I've merged that PR, but there's another problem - the 'build' package isn't available. I've created another PR to fix it: https://github.com/tianocore/edk2-basetools/pull/118 -- Rebecca Cran On 2/23/24 07:48, Rebecca Cran wrote: Could someone review Fix build-publish-whl-steps.yml

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

Hi Chinni, Using the FspGlobalDataPointer as a scratchpad for your top of CAR early and then putting the real global data into it later is an ugly hack. If you are going to initialize the FspGlobalDataPointer in FSP-T, then FSP-T needs to actually initialize that FSP global data structure fully

Re: [edk2-devel] [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, February 9, 2024 2:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build > > Adds library instances for MM_Standalon

Re: [edk2-devel] [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build

Pushed as 103c88b. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Friday, February 9, 2024 2:48 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-devel] [PATCH v1] PurleyOpenBoardPkg/TiogaPass: Fix Build > > Adds library instances

回复: [edk2-devel] [PATCH v3] MdePkg/SmBios.h: Add New ProcessorFamily definitions for SMBIOS Type4

Please separate it to two commits. One is for MdePkg, another is for ShellPkg. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Jason Lou > 发送时间: 2024年2月24日 0:11 > 收件人: devel@edk2.groups.io > 抄送: Jason Lou ; Zhiguang Liu ; > Dandan Bi ; Star Zeng ; Zhichao > Gao ; Benny Lin ; Gua Gu

Re: [edk2-devel] [Patch 4/4] BaseTools/Scripts/PatchCheck: Error if commit modifies multiple packages

Reviewed-by: Michael Kubacki On 2/18/2024 3:59 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679 Update PatchCheck.py to evaluate all the files modified in each commit and generate an error if: * A commit adds/modifies files in multiple package directories *