[edk2-devel] 回复: [PATCH] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread gaoliming via groups.io
Laszlo: Thanks for your work to make sure this issue be fixed. I agree this change. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Laszlo Ersek > 发送时间: 2024年2月25日 5:05 > 收件人: edk2-devel-groups-io > 抄送: Bob Feng ; Liming Gao > ; Michael D Kinney > ; Rebecca Cran ; Yuwei > Chen

Re: [edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

2024-02-24 Thread Laszlo Ersek
On 2/24/24 22:28, Laszlo Ersek wrote: > The first patch is a minor cleanup, the new feature is documented in the > second patch. > > Rendered version: > > > https://lersek.github.io/edk2-InfSpecification/ProcessLibraryConstructorList-SEC-991/ > >

Re: [edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
On 2/24/24 22:23, Laszlo Ersek wrote: > The first two patches are cleanups, the new feature is documented in the > third patch. > > I managed to render these updates to public HTML, following > > (a) Mike's note from October 2020: > > https://edk2.groups.io/g/devel/message/66426 > msgid >

[edk2-devel] [edk2-InfSpecification PATCH 2/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

2024-02-24 Thread Laszlo Ersek
Simply bump INF_VERSION (spec release version) as a fence for the feature AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules described comprehensively in the Build spec. (The INF spec does not seem to have an explicit compatibility table tied to INF_VERSION, except this

[edk2-devel] [edk2-InfSpecification PATCH 1/2] README.md: fix revision history whitespace

2024-02-24 Thread Laszlo Ersek
Fix the right-hand-side whitespace in the revision history table. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [edk2-InfSpecification PATCH 0/2] README: INF_VERSION >= 1.30: declare ProcessLibraryCon...() for SEC modules

2024-02-24 Thread Laszlo Ersek
The first patch is a minor cleanup, the new feature is documented in the second patch. Rendered version: https://lersek.github.io/edk2-InfSpecification/ProcessLibraryConstructorList-SEC-991/ https://github.com/lersek/edk2-InfSpecification/actions/workflows/gitbook-action.yml Cc: Bob Feng

[edk2-devel] [edk2-BuildSpecification PATCH 2/3] AutoGen.c: list the SEC module type for / (VOID)

2024-02-24 Thread Laszlo Ersek
Minimally as of edk2 commit edc6681206c1, the - CreateLibraryConstructorCode() - CreateLibraryDestructorCode() methods in "BaseTools/Source/Python/AutoGen/GenC.py" generate declarations and calls of the form - (VOID) - (VOID) (respectively), for pre-requisite libraries that have type BASE or

[edk2-devel] [edk2-BuildSpecification PATCH 3/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
Most module types have standardized entry point function prototypes. They are declared in headers like - MdePkg/Include/Library/PeiCoreEntryPoint.h - MdePkg/Include/Library/PeimEntryPoint.h - MdePkg/Include/Library/DxeCoreEntryPoint.h - MdePkg/Include/Library/UefiDriverEntryPoint.h -

[edk2-devel] [edk2-BuildSpecification PATCH 0/3] AutoGen.h: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
The first two patches are cleanups, the new feature is documented in the third patch. I managed to render these updates to public HTML, following (a) Mike's note from October 2020: https://edk2.groups.io/g/devel/message/66426 msgid (b) the github access token / project secrets steps at

[edk2-devel] [edk2-BuildSpecification PATCH 1/3] README.md: fix revision history whitespace

2024-02-24 Thread Laszlo Ersek
Fix the right-hand-side whitespace in the revision history table. Cc: Bob Feng Cc: Liming Gao Cc: Michael D Kinney Cc: Rebecca Cran Cc: Yuwei Chen Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=991 Signed-off-by: Laszlo Ersek --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2

[edk2-devel] [PATCH] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
Most module types have standardized entry point function prototypes. They are declared in headers like - MdePkg/Include/Library/PeiCoreEntryPoint.h - MdePkg/Include/Library/PeimEntryPoint.h - MdePkg/Include/Library/DxeCoreEntryPoint.h - MdePkg/Include/Library/UefiDriverEntryPoint.h -

[edk2-devel] [v2] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
v1 posting: https://edk2.groups.io/g/devel/message/115193 msgid <36593e23-d3e8-b71a-808d-ef94260b5...@redhat.com> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=991 In version 2, the feature is structured differently. Following Mike's advice, for compatibility, the

Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
On 2/15/24 18:29, Michael D Kinney wrote: > The current INF Spec uses INF_VERSION of 1.27. Side topic: the build spec says in 8.7: https://tianocore-docs.github.io/edk2-BuildSpecification/draft/8_pre-build_autogen_stage/87_generated_asbuilt_inf_files.html that the build tool will

Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules

2024-02-24 Thread Laszlo Ersek
Hi Mike, On 2/15/24 18:29, Michael D Kinney wrote: > Hi Laszlo, > > I was also thinking the INF Version would be best approach. > > I recommend we identify the EDK II Build Specification and > EDK II INF Specification changes required to resolve this > issue. > >

[edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-24 Thread Charles Hyde
There is a bug in the following source file: uefi-sct\ SctPkg\ TestCase\ UEFI\ EFI\ Protocol\ DevicePathFromText\ BlackBoxTest\ DevicePathFromTextBBTestCoverage.c Lines 1737, 1738, 1742, and

Re: [edk2-devel] Peims are not gettting Dispatched in EagleStream Platform

2024-02-24 Thread memristor2 via groups.io
Sent with Proton Mail secure email. On Saturday, February 24th, 2024 at 5:00 PM, memristor2 via groups.io wrote: > > > > > > Sent with Proton Mail secure email. > > > On Saturday, February 24th, 2024 at 12:15 AM, Desimone, Nathaniel L > nathaniel.l.desim...@intel.com wrote: > >

Re: [edk2-devel] Peims are not gettting Dispatched in EagleStream Platform

2024-02-24 Thread memristor2 via groups.io
Sent with Proton Mail secure email. On Saturday, February 24th, 2024 at 12:15 AM, Desimone, Nathaniel L wrote: > > -Original Message- > > From: memristor2 memrist...@proton.me > > Sent: Thursday, February 22, 2024 5:51 AM > > To: Desimone, Nathaniel L