Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread G Edhaya Chandran
Hi Li Chao, Thank you for the solution. Reviewed OK. Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116007): https://edk2.groups.io/g/devel/message/116007 Mute This Topic:

Re: [edk2-devel] [PATCH V1 0/3] OvmfPkg: Update TDVMCALL to avoid leaking secrets to the VMM

2024-02-26 Thread Min Xu
Reviewed-by: Min Xu > -Original Message- > From: Sun, CepingX > Sent: Tuesday, February 27, 2024 5:19 AM > To: devel@edk2.groups.io > Cc: Sun, CepingX ; Liming Gao > ; Kinney, Michael D > ; Aktas, Erdem ; > James Bottomley ; Yao, Jiewen > ; Xu, Min M ; Tom Lendacky > ; Michael Roth ; >

Re: [edk2-devel] [PATCH v1] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
Hi Heinrich, I guess it is not allowed to make them the same now, so I submitted V2, added your recomended fix message to the commit message, and also added more reviewers. Thanks, Chao On 2024/2/27 09:15, Chao Li wrote: Hi Heinrich, On 2024/2/26 19:02, Heinrich Schuchardt wrote: On

[edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will point to an unknown address. So fix

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions being deprecated

2024-02-26 Thread Michael D Kinney
> -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, February 26, 2024 8:39 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Joey Vagedes > ; Kinney, Michael D > > Subject: [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions > being deprecated > > From:

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Ni, Ray
Thank you, Laszlo! The changes you made look good to me. By the way, is the following a common way to call out additional changes? > +[ler...@redhat.com: define one local variable per line [Ray]] Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo >

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

2024-02-26 Thread Sivaraman Nainar via groups.io
Hi Laszlo, We can see the issue not only with SLES, it can be seen with Ubuntu 22 also. Do we have any channel to work with grub team to fix this issue? Thanks Siva -Original Message- From: Sivaraman Nainar Sent: Monday, February 26, 2024 4:01 PM To: devel@edk2.groups.io; Sivaraman

[edk2-devel] [PATCH v1 1/1] .github/workflows/codeql.yml: Update actions being deprecated

2024-02-26 Thread Michael Kubacki
From: Michael Kubacki Currently CodeQL runs have the following warnings: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/upload-artifact@v3, actions/cache@v3. For more information see:

Re: [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension

2024-02-26 Thread Tuan Phan
Hi Sunil/ Andrei, Any comments on this series? Regards, On Wed, Feb 14, 2024 at 10:16 PM Tuan Phan via groups.io wrote: > > > On Wed, Feb 14, 2024 at 9:43 PM Warkentin, Andrei < > andrei.warken...@intel.com> wrote: > >> Do you mind sharing a GH branch with the patch set? >> >

[edk2-devel] [PATCH v2] SecurityPkg/SecureBootConfigDxe: Update UI according to UEFI spec

2024-02-26 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4713 In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for EFI_BROWSER_ACTION_FORM_OPEN: NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with this browser action because question values have not been retrieved yet. So

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, February 27, 2024 #cal-reminder

2024-02-26 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, February 27, 2024 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] Fixing edk2-basetools CI

2024-02-26 Thread Rebecca Cran
Is anyone familiar with how publishing to PyPi works? The "Publish to PyPI" step is failing: Starting: Publish to PyPI == Task : Command line Description  : Run a command line script using Bash on Linux and

Re: [edk2-devel] [PATCH v1] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
Hi Heinrich, Thanks, Chao On 2024/2/26 19:02, Heinrich Schuchardt wrote: On 26.02.24 11:17, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi @Igor Kulchytskyy and @Mike Maslenkin, I would like to wait until your review to make sure we all agree with the usage of HTTP methods in edk2 Redfish implementation. Thanks Abner > -Original Message- > From: Nickle Wang > Sent: Monday, February

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] But thanks for this question. I update commit message and more some more explanations as below, Remove the references of "Redfish" from this driver. As REST JSON C Structure was not designed for Redfish only. Any RESTful applications can register the

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Usb/UsbNetwork: Check array index range before access

2024-02-26 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 2/20/2024 8:21 AM, mikub...@linux.microsoft.com wrote: From: Michael Kubacki Checks that an offset used to access array elements is within the expected range before accessing the array item. Cc: Liming Gao Cc: Ray Ni Cc: Rebecca Cran Cc: Richard Ho

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

2024-02-26 Thread Nickle Wang via groups.io
Thanks for your confirmation, Mike! Version 3 patch set is here: https://edk2.groups.io/g/devel/message/115985 Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, February 27, 2024 8:13 AM > To: Nickle Wang > Cc: devel@edk2.groups.io; Igor Kulchytskyy ; Abner

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Nickle Wang via groups.io
Thanks for your explanation, Abner. Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Regards, Nickle From: Chang, Abner Sent: Tuesday, February 27, 2024 8:40 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: RE: [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST

[edk2-devel] [PATCH v3 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue

2024-02-26 Thread Nickle Wang via groups.io
-Fix below compiler error reported in edk2 CI. ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg. -Add MathFtol.c to EccCheck IgnoreFiles. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor

[edk2-devel] [PATCH v3 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib

2024-02-26 Thread Nickle Wang via groups.io
Remove RedfishLib and use RedfishHttpLib for debug printing Redfish response data. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++--

[edk2-devel] [PATCH v3 4/6] RedfishPkg/RedfishLib: include RedfishServiceData.h

2024-02-26 Thread Nickle Wang via groups.io
Redfish common structures are moved to RedfishServiceData.h. Remove them from RedfishLib.h Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/Include/Library/RedfishLib.h | 17

[edk2-devel] [PATCH v3 3/6] RedfishPkg: introduce RedfishHttpLib

2024-02-26 Thread Nickle Wang via groups.io
RedfishHttpLib is a wrapper library for Redfish feature drivers to call Redfish HTTP Protocol easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec |

[edk2-devel] [PATCH v3 2/6] RedfishPkg: implement Redfish HTTP protocol

2024-02-26 Thread Nickle Wang via groups.io
implement Redfish HTTP protocol driver. Signed-off-by: Nickle Wang Co-authored-by: Igor Kulchytskyy Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec |7 +-

[edk2-devel] [PATCH v3 1/6] RedfishPkg: introduce Redfish HTTP protocol

2024-02-26 Thread Nickle Wang via groups.io
Introduce Redfish HTTP protocol to improve Redfish performance and communication stability between BIOS and Redfish service. - Feature drivers often query same Redfish resource multiple times for different purpose. Implement HTTP cache mechanism to improve HTTP GET performance. "UseCache"

[edk2-devel] [PATCH v3 0/6] Introduce Redfish http protocol

2024-02-26 Thread Nickle Wang via groups.io
v3: address review comments. 1) handle the condition while memory allocation failure happens to HTTP headers. Make sure that HTTP headers can be released properly while calling HttpFreeHeaderFields(). 2) Create macro ASCII_STR_DUPLICATE() to copy ASCII string. 3) Fix typos. v2: address review

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, As from spec viewpoint, REST JSON C Structure was not designed for Redfish only. Which was designed for any RESTful application that uses JSON as the representation of data model. I was proposed having this driver under MdeModulePkg long time ago

Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol

2024-02-26 Thread Mike Maslenkin
Hii Nickle, On Mon, Feb 26, 2024 at 4:44 PM Nickle Wang wrote: > > Hi Mike, > > > So finally we have > > HttpFreeHeaderFields (Response->Headers, Response->HeaderCount); > > but Response->HeaderCount does not count partially allocated elements. > > Right? > > > > To fix this, it is required to

[edk2-devel] Cancelled Event: Tools, CI, Code base construction meeting series - Monday, February 26, 2024 #cal-cancelled

2024-02-26 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20231222T233358Z

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, February 26, 2024 #cal-reminder

2024-02-26 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, February 26, 2024 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Laszlo Ersek
On 2/26/24 16:19, Laszlo Ersek wrote: > On 2/22/24 17:01, Gerd Hoffmann wrote: >> Needed to boot guests with thousands of vcpus. >> >> v3: >> - refine comments and commit messages. >> - fix MaxCpusPerHob calculation. >> - pick up review tags. >> - add patch to speed up GetBspNumber a bit. >>

回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Usb/UsbNetwork: Check array index range before access

2024-02-26 Thread gaoliming via groups.io
This change is good to me. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael > Kubacki > 发送时间: 2024年2月20日 23:22 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Ray Ni ; > Rebecca Cran ; Richard Ho > 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Usb/UsbNetwork: >

Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

2024-02-26 Thread Oliver Smith-Denny
Hi Liming, Now that the stable tag is finished, can you review this MdeModulePkg patch? Thanks, Oliver On 2/16/2024 5:27 PM, Oliver Smith-Denny wrote: This patch series is the second version of MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations​. The subject line has

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Laszlo Ersek
Hi Joey, On 2/26/24 16:41, Joey Vagedes wrote: > Hi Lazlo, > > I just looked at the pipelines - Looks like everything is fine, there is just > currently a backup of runners of jobs in the runners. It is common for jobs > that end in CODE_COVERAGE to appear frozen in queued status, but this is

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Laszlo Ersek
On 2/26/24 16:41, Joey Vagedes via groups.io wrote: > Taking a look at all the runners > (https://dev.azure.com/tianocore/edk2-ci/_settings/buildqueue?_a=concurrentJobs > [Click "Microsoft Hosted", "View in-progress jobs"]), I don't see any > runners that are frozen, which is why it appears it's

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Joey Vagedes via groups.io
Hi Lazlo, I just looked at the pipelines - Looks like everything is fine, there is just currently a backup of runners of jobs in the runners. It is common for jobs that end in CODE_COVERAGE to appear frozen in queued status, but this is expected as this job not queued until all others have

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

2024-02-26 Thread Laszlo Ersek
On 2/26/24 16:13, Albecki, Mateusz wrote: > 1. Using SerialDxe instead of PciSioSerialDxe - from our perspective > the main idea is to avoid maintaining our own implementation of > functions that actually communicate with UART controller. To use > SerialDxe we would have to still maintain our own

Re: [edk2-devel] [PATCH v4 1/2] MdePkg/SmBios.h: Add New ProcessorFamily definitions for SMBIOS Type4

2024-02-26 Thread Zeng, Star
Reviewed-by: Star Zeng to this series. -Original Message- From: gaoliming Sent: Monday, February 26, 2024 9:32 PM To: devel@edk2.groups.io; Lou, Yun Cc: Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao ; Lin, Benny ; Guo, Gua ; Kinney, Michael D Subject: 回复: [edk2-devel]

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Laszlo Ersek
On 2/22/24 17:01, Gerd Hoffmann wrote: > Needed to boot guests with thousands of vcpus. > > v3: > - refine comments and commit messages. > - fix MaxCpusPerHob calculation. > - pick up review tags. > - add patch to speed up GetBspNumber a bit. > v2: > - rework HOB loops for better performance:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

2024-02-26 Thread Albecki, Mateusz
1. Using SerialDxe instead of PciSioSerialDxe - from our perspective the main idea is to avoid maintaining our own implementation of functions that actually communicate with UART controller. To use SerialDxe we would have to still maintain our own SerialPortLib that actually goes and sends data

Re: [edk2-devel] [PATCH v3 0/6] UefiCpuPkg/MpInitLib: Add support for multiple MP_HAND_OFF HOBs

2024-02-26 Thread Laszlo Ersek
On 2/22/24 17:01, Gerd Hoffmann wrote: > Needed to boot guests with thousands of vcpus. > > v3: > - refine comments and commit messages. > - fix MaxCpusPerHob calculation. > - pick up review tags. > - add patch to speed up GetBspNumber a bit. > v2: > - rework HOB loops for better

[edk2-devel] [PATCH] SecurityPkg/SecureBootConfigDxe: Update UI according to UEFI spec

2024-02-26 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4713 In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for EFI_BROWSER_ACTION_FORM_OPEN: NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with this browser action because question values have not been retrieved yet. So

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber()

2024-02-26 Thread Laszlo Ersek
On 2/22/24 17:01, Gerd Hoffmann wrote: > After finding the BSP Number return the result instead of > continuing to loop over the remaining processors. > > Suggested-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 --- > 1 file changed,

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber()

2024-02-26 Thread Laszlo Ersek
On 2/23/24 03:33, Ni, Ray wrote: >> + ASSERT (FALSE); > > How about ASSERT (EFI_NOT_FOUND)? Which is more meaningful than FALSE. I'll edit the patch -- assuming you mean ASSERT_EFI_ERROR (EFI_NOT_FOUND); Laszlo > > No matter you change or not, Reviewed-by: Ray Ni > >> + return 0; >> }

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

2024-02-26 Thread Laszlo Ersek
On 2/23/24 03:16, Ni, Ray wrote: > > > Thanks, > Ray >> -Original Message- >> From: Gerd Hoffmann >> Sent: Friday, February 23, 2024 12:01 AM >> To: devel@edk2.groups.io >> Cc: Laszlo Ersek ; Ni, Ray ; Kumar, >> Rahul R ; Oliver Steffen ; >> Gerd Hoffmann >> Subject: [PATCH v3 5/6]

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to SaveCpuMpData()

2024-02-26 Thread Laszlo Ersek
On 2/22/24 17:01, Gerd Hoffmann wrote: > Add support for splitting Hand-Off data into multiple HOBs. > This is required for VMs with thousands of CPUs. > > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 44 +++-- > 1 file changed, 27

Re: [edk2-devel] [PATCH v3 4/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

2024-02-26 Thread Laszlo Ersek
On 2/22/24 17:01, Gerd Hoffmann wrote: > Loop over all MP_HAND_OFF HOBs instead of expecting a single HOB > covering all CPUs in the system. > > Add a new FirstMpHandOff variable, which caches the first HOB body for > faster lookups. It is also used to check whenever MP_HAND_OFF HOBs are >

Re: [edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-26 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Monday, February 26, 2024 12:55 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; > Mike Maslenkin > Subject: [edk2-redfish-client][PATCH] edk2-Redfish-client:

Re: [edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-26 Thread Nickle Wang via groups.io
Hi @abner.ch...@amd.com, RestJsonStructureDxe is a driver in RedfishPkg. May I know why we can not have dependency to RedfishPkg? Do we need to move it to MdeModulePkg for this goal (removing dependency to RedfishPkg)? Regards, Nickle > -Original

Re: [edk2-devel] [PATCH v3 1/6] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to GetMpHandOffHob

2024-02-26 Thread Laszlo Ersek
Hi Ray, On 2/23/24 03:35, Ni, Ray wrote: >> + @param[in] MpHandOff Previous HOB body. Pass NULL to get the >> first HOB. > > Can you replace "...HOB Body. Pass NULL..." with "...HOB Body. Pass NULL..."? > Your current comments contain two spaces. > > With that, Reviewed-by: Ray Ni The two

[edk2-devel] 回复: [PATCH v4 2/2] ShellPkg/SmbiosView: Support New ProcessorFamily for SMBIOS Type4

2024-02-26 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Jason > 发送时间: 2024年2月25日 17:06 > 收件人: devel@edk2.groups.io > 抄送: Jason Lou ; Liming Gao > ; Zhichao Gao > 主题: [PATCH v4 2/2] ShellPkg/SmbiosView: Support New ProcessorFamily for > SMBIOS Type4 > > From: Jason Lou > > The patch updates

回复: [edk2-devel] [PATCH v4 1/2] MdePkg/SmBios.h: Add New ProcessorFamily definitions for SMBIOS Type4

2024-02-26 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Jason Lou > 发送时间: 2024年2月25日 17:06 > 收件人: devel@edk2.groups.io > 抄送: Jason Lou ; Zhiguang Liu ; > Dandan Bi ; Star Zeng ; Zhichao > Gao ; Benny Lin ; Gua Guo > ; Michael D Kinney ; > Liming Gao > 主题: [edk2-devel] [PATCH v4

[edk2-devel] [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function description

2024-02-26 Thread Qingyu
Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData and SendData. Cc: Jiewen Yao Signed-off-by: Qingyu --- SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++-- 1 file changed, 6

[edk2-devel] [PATCH v4 2/3] MdeModulePkg: Update ReceiveData and SendData function description

2024-02-26 Thread Qingyu
AtaBusDxe, NvmExpressDxe, ScsiDiskDxe and EmmcDxe is used to back the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL, update the parameter 'MediaId' description for the protocal function ReceiveData and SendData as described in Uefi spec 2.10 section 13.14. Cc: Liming Gao Cc: Michael D Kinney

[edk2-devel] Introduction OSFF ByteTalks Vol.1 - Webinar Series about Open-Source Firmware

2024-02-26 Thread Christian Walter
Dear EDKII-Community, The Open-Source Firmware Foundation (OSFF) is pleased to announce ByteTalks, a new series of online webinars focused on the open-source firmware community. ByteTalks aims to provide a platform for learning, sharing, and discussing the latest developments in open-source

[edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description

2024-02-26 Thread Qingyu
Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData and SendData. V4: Split patch so there is one patch per package V3: Add maintainer to CC list. V2: Update some functions description in C and H header

[edk2-devel] [PATCH v4 1/3] MdePkg: Update ReceiveData and SendData function description

2024-02-26 Thread Qingyu
Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function ReceiveData and SendData. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Qingyu --- MdePkg/Include/Protocol/StorageSecurityCommand.h | 8

Re: [edk2-devel] [PATCH v1] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Heinrich Schuchardt
On 26.02.24 11:17, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will

Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue

2024-02-26 Thread Sivaraman Nainar via groups.io
@Saloni Kasbekar, @Zachary Clark-williams, Could you please add your feedback on the changes proposed? Thanks Siva -Original Message- From: devel@edk2.groups.io On Behalf Of Sivaraman Nainar via groups.io Sent: Thursday, February 22, 2024 7:33 AM To: Laszlo Ersek ;

[edk2-devel] [PATCH v1] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

2024-02-26 Thread Chao Li
DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, which will point to an unknown address. So fix

[edk2-devel] [PATCH v3] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-26 Thread cbduggap
Changes to support spec changes 1. Remove usage of Pcd. 2. Change code to validate the Temporary Ram size input. 3. Consume the input saved in YMM Register Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chiu Chasel Cc: Duggapu Chinni B Signed-off-by: Duggapu Chinni B ---