Re: [edk2-devel] [PATCH] MdeModulePkg/Xhci: Skip another size round up for TRB address translation

2024-03-08 Thread Dat Mach via groups.io
Hi Gao and Hao, Could you please take a look at my patch and see if anything I might have missed? Thanks, Dat -Original Message- From: gaoliming Sent: Monday, March 4, 2024 4:34 PM To: Dat Mach ; devel@edk2.groups.io Cc: gao.ch...@intel.com; hao.a...@intel.com; ray...@intel.com Subjec

[edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

2024-03-08 Thread Pethaiyan Madhan
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): Add the following sentence at the end of the Image parameter description. "May be NULL with a zero ImageSize in order to determine the size of the buffer needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageSize is n

[edk2-devel] [PATCH V1] SignedCapsulePkg: Update GetImage and GetImageInfo description details

2024-03-08 Thread Pethaiyan Madhan
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): Add the following sentence at the end of the Image parameter description. "May be NULL with a zero ImageSize in order to determine the size of the buffer needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageSize is n

[edk2-devel] [PATCH V5] FmpDevicePkg: GetImageInfo Add missing conditions

2024-03-08 Thread Pethaiyan Madhan
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): Add the following sentence at the end of the Image parameter description. "May be NULL with a zero ImageSize in order to determine the size of the buffer needed". Modify the description of "EFI_INVALID_PARAMETER" return code as "The ImageSize is n

Re: [edk2-devel] [PATCH] NetworkPkg Update Security Patch

2024-03-08 Thread Michael D Kinney
>From this CI run, you can see there are other packages impacted by this change. Missing RngLib mappings. Is this expected? https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=120372&view=logs&jobId=56079008-74ef-5d1a-7db6-78cd637f5fd1&j=56079008-74ef-5d1a-7db6-78cd637f5fd1&t=717a0b6b

Re: [edk2-devel] [PATCH] NetworkPkg Update Security Patch

2024-03-08 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Kasbekar, Saloni > Sent: Wednesday, February 7, 2024 2:58 PM > To: Santhosh Kumar V ; devel@edk2.groups.io > Cc: Sivaraman Nainar ; Raj V Akilan > ; Kinney, Michael D ; > Mathews, John ; Clark-williams, Zachary > > Subject: RE: [PA

Re: [edk2-devel] [PATCH v3 00/24] Provide SEV-SNP support for running under an SVSM

2024-03-08 Thread Lendacky, Thomas via groups.io
On 3/8/24 09:30, Lendacky, Thomas via groups.io wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 This series adds SEV-SNP support for running OVMF under an Secure VM Service Module (SVSM) at a less privileged VM Privilege Level (VMPL). By running at a less priviledged VMPL, the SV

Re: [edk2-devel] [edk2-platforms PATCH v3 5/7] Silicon/Marvell: Driver to publish device tree

2024-03-08 Thread Abdul Lateef Attar via groups.io
Hi Narinder,     Patch looks good with minor comment inline. Thanks AbduL On 18-01-2024 06:48, Narinder Dhillon via groups.io wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Narinder Dhillon Th

[edk2-devel] [PATCH v3 24/24] OvmfPkg/BaseMemEncryptLib: Check for presence of an SVSM when not at VMPL0

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 Currently, an SEV-SNP guest will terminate if it is not running at VMPL0. The requirement for running at VMPL0 is removed if an SVSM is present. Update the current VMPL0 check to additionally check for the presence of an SVSM is the guest is

[edk2-devel] [PATCH v3 23/24] Ovmfpkg/CcExitLib: Provide SVSM discovery support

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The SVSM specification documents an alternative method of discovery for the SVSM using a reserved CPUID bit and a reserved MSR. For the CPUID support, the #VC handler of an SEV-SNP guest should modify the returned value in the EAX register f

[edk2-devel] [PATCH v3 22/24] UefiCpuPkg/MpInitLib: AP creation support under an SVSM

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 When running under an SVSM, the VMPL level of the APs that are started must match the VMPL level provided by the SVSM. Additionally, each AP must have a Calling Area for use with the SVSM protocol. Update the AP creation to properly support r

[edk2-devel] [PATCH v3 21/24] OvmfPkg/AmdSvsmLib: Add support for the SVSM create/delete vCPU calls

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The RMPADJUST instruction is used to alter the VMSA attribute of a page, but the VMSA attribute can only be changed when running at VMPL0. When an SVSM is present, use the SVSM_CORE_CREATE_VCPU and SVSM_CORE_DELTE_VCPU calls to add or remove

[edk2-devel] [PATCH v3 20/24] OvmfPkg/BaseMemEncryptSevLib: Maximize Page State Change efficiency

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 Similar to the Page State Change optimization added previously, also take into account the possiblity of using the SVSM for PVALIDATE instructions. Conditionally adjust the maximum number of entries based on how many entries the SVSM calling

[edk2-devel] [PATCH v3 18/24] OvmfPkg: Create a calling area used to communicate with the SVSM

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 An SVSM requires a calling area page whose address (CAA) is used by the SVSM to communicate and process the SVSM request. Add a pre-defined page area to the OvmfPkg and AmdSev packages and define corresponding PCDs used to communicate the lo

[edk2-devel] [PATCH v3 19/24] OvmfPkg/AmdSvsmLib: Add support for the SVSM_CORE_PVALIDATE call

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The PVALIDATE instruction can only be performed at VMPL0. An SVSM will be present when running at VMPL1 or higher. When an SVSM is present, use the SVSM_CORE_PVALIDATE call to perform memory validation instead of issuing the PVALIDATE instru

[edk2-devel] [PATCH v3 17/24] OvmfPkg/BaseMemEncryptSevLib: Use AmdSvsmSnpPvalidate() to validate pages

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The PVALIDATE instruction is used to change the SNP validation of a page, but that can only be done when running at VMPL0. To prepare for running at a less priviledged VMPL, use the AmdSvsmLib library API to perform the PVALIDATE. The AmdSvsm

[edk2-devel] [PATCH v3 16/24] UefiCpuPkg/MpInitLib: Use AmdSvsmSnpVmsaRmpAdjust() to set/clear VMSA

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The RMPADJUST instruction is used to change the VMSA attribute of a page, but the VMSA attribute can only be changed when running at VMPL0. To prepare for running at a less priviledged VMPL, use the AmdSvsmLib library API to perform the RMPAD

[edk2-devel] [PATCH v3 14/24] Ovmfpkg: Prepare OvmfPkg to use the AmdSvsmLib library

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The MpInitLib library will be updated to use the new AmdSvsmLib library. To prevent any build breakage, update the OvmfPkg DSCs file to include the AmdSvsmLib NULL library. Cc: Anatol Belski Cc: Anthony Perard Cc: Ard Biesheuvel Cc: Corvi

[edk2-devel] [PATCH v3 15/24] Ovmfpkg/AmdSvsmLib: Create AmdSvsmLib to handle SVSM related services

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 Add initial support for the new AmdSvsmLib library to OvmfPkg. The initial implementation fully implements the library interfaces. The SVSM presence check, AmdSvsmIsSvsmPresent(), determines the presence of an SVSM by checking if an SVSM has

[edk2-devel] [PATCH v3 13/24] UefiPayloadPkg: Prepare UefiPayloadPkg to use the AmdSvsmLib library

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The MpInitLib library will be updated to use the new AmdSvsmLib library. To prevent any build breakage, update the UefiPayloadPkg DSC file to include the AmdSvsmLib NULL library. Cc: Gua Guo Cc: Guo Dong Cc: James Lu Cc: Sean Rhodes Acke

[edk2-devel] [PATCH v3 12/24] UefiCpuPkg/AmdSvsmLib: Create the AmdSvsmLib library to support an SVSM

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 In order to support an SEV-SNP guest running under an SVSM at VMPL1 or lower, a new library must be created. This library includes an interface to detect if running under an SVSM, an interface to return the current VMPL, an interface to perf

[edk2-devel] [PATCH v3 11/24] MdePkg/BaseLib: Add a new VMGEXIT instruction invocation for SVSM

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The SVSM specification relies on a specific register calling convention to hold the parameters that are associated with the SVSM request. The SVSM is invoked by requesting the hypervisor to run the VMPL0 VMSA of the guest using the GHCB MSR P

[edk2-devel] [PATCH v3 10/24] MdePkg/Register/Amd: Define the SVSM related information

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The Secure VM Service Module specification defines the interfaces needed to allow multi-VMPL level execution of an SEV-SNP guest. Define the SVSM related structures for the SVSM Calling Area as well as the SVSM CAA MSR. The SVSM CAA MSR is a

[edk2-devel] [PATCH v3 08/24] OvmfPkg/BaseMemEncryptSevLib: Re-organize page state change support

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 In preparation for running under an SVSM at VMPL1 or higher (higher numerically, lower privilege), re-organize the way a page state change is performed in order to free up the GHCB for use by the SVSM support. Currently, the page state chang

[edk2-devel] [PATCH v3 09/24] OvmfPkg/BaseMemEncryptSevLib: Maximize Page State Change efficiency

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 When building the Page State Change entries for a range of memory, it can happen that multiple calls to BuildPageStateBuffer() need to be made. If the size of the input work area passed to BuildPageStateBuffer() exceeds the number of entries

[edk2-devel] [PATCH v3 07/24] MdePkg: Avoid hardcoded value for number of Page State Change entries

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The SNP_PAGE_STATE_MAX_ENTRY is based on the number of entries that can fit in the GHCB shared buffer. As a result, the SNP_PAGE_STATE_CHANGE_INFO structure maps the full GHCB shared buffer based on the shared buffer size being 2032 bytes. I

[edk2-devel] [PATCH v3 06/24] OvmfPkg/BaseMemEncryptSevLib: Calculate memory size for Page State Change

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 Calculate the amount of memory that can be use to build the Page State Change data (SNP_PAGE_STATE_CHANGE_INFO) instead of using a hard-coded size. This allows for changes to the GHCB shared buffer size without having to make changes to the p

[edk2-devel] [PATCH v3 05/24] OvmfPkg/BaseMemEncryptSevLib: Fix uncrustify errors

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 In prep for follow-on patches, fix an area of the code that does not meet the uncrustify coding standards. Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Michael Roth Cc: Min Xu Reviewed-by: G

[edk2-devel] [PATCH v3 04/24] OvmfPkg/PlatformPei: Retrieve APIC IDs from the hypervisor

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 If the hypervisor supports retrieval of the vCPU APIC IDs, retrieve them before any APs are actually started. The APIC IDs can be used to start the APs for any SEV-SNP guest, but is a requirement for an SEV-SNP guest that is running under an

[edk2-devel] [PATCH v3 03/24] UefiCpuPkg/MpInitLib: Always use AP Create if GhcbApicIds HOB is present

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 Currently, the first time an AP is started for an SEV-SNP guest, it relies on the VMSA as set by the hypervisor. If the list of APIC IDs has been retrieved, this is not necessary. The list of APIC IDs will be identified by a GUIDed HOB. If th

[edk2-devel] [PATCH v3 02/24] MdePkg: GHCB APIC ID retrieval support definitions

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 When an SVSM is present, starting the APs requires knowledge of the APIC IDs. Create the definitions required to retrieve and hold the APIC ID information of all the vCPUs present in the guest. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhigu

[edk2-devel] [PATCH v3 01/24] OvmfPkg/BaseMemEncryptLib: Fix error check from AsmRmpAdjust()

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 The AsmRmpAdjust() function returns a UINT32, however in SevSnpIsVmpl0() the return value is checked with EFI_ERROR() when it should just be compared to 0. Fix the error check. Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Jiew

[edk2-devel] [PATCH v3 00/24] Provide SEV-SNP support for running under an SVSM

2024-03-08 Thread Lendacky, Thomas via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 This series adds SEV-SNP support for running OVMF under an Secure VM Service Module (SVSM) at a less privileged VM Privilege Level (VMPL). By running at a less priviledged VMPL, the SVSM can be used to provide services, e.g. a virtual TPM,

Re: [edk2-devel] [edk2-platforms PATCH v3 2/7] Silicon/Marvell: Odyssey SmcLib

2024-03-08 Thread Abdul Lateef Attar via groups.io
Hi Narinder,     Patch looks good with minor comments inline. Thanks AbduL On 18-01-2024 06:48, Narinder Dhillon via groups.io wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Narinder Dhillon

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

2024-03-08 Thread Pedro Falcato
On Fri, Mar 8, 2024 at 9:14 AM Laszlo Ersek wrote: > > On 3/6/24 23:22, Michael D Kinney wrote: > > Reviewed-by: Michael D Kinney > > Merged as commit ccf91b518f22, via > . > > Thank you all for everything, Thank you for your great (and often thankles

[edk2-devel] 回复: [Patch V3] BaseTools: VfrCompiler Adds DefaultValueError

2024-03-08 Thread gaoliming via groups.io
Zifeng: For Structure PCD, https://edk2.groups.io/g/devel/message/18432 is the summary of code change. Below is two wikis about its usage. https://github.com/lgao4/edk2/wiki/StrucutrePcd-Usage https://github.com/lgao4/edk2/wiki/StructurePcd-Enable-Steps For the patch table configur

[edk2-devel] 回复: [Patch V3] BaseTools: VfrCompiler Adds DefaultValueError

2024-03-08 Thread gaoliming via groups.io
Yuting: This patch also removes the trailing white space. If you want to do it, please separate them as the different commit. One is to remove the trailing white space, another is to add default value error support. Thanks Liming > -邮件原件- > 发件人: Yuting Yang > 发送时间: 2024年1月26日 10:54 > 收

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-08 Thread PierreGondois
Hell Abdul, On 3/8/24 13:45, Attar, AbdulLateef (Abdul Lateef) wrote: Hi Pierre,     I think the provided patch also serve the same purpose of validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFERS. Ok right, I didn't see it was checked in ValidateWsmtProtectionFlag().

Re: [edk2-devel] [edk2-platforms][PATCH v4 8/8] Platform/Sgi: Add CPPC support for RD-Fremont platform

2024-03-08 Thread levi.yun
> + CPPC_PACKAGE_INIT (0x200293000, 0x200293004, 20, 160, 160, 85, 85, > 5) In the FFH spec [1], section 'B.2.2 Performance Controls', the 'Performance Ltd Register' is set to a certain memory location. The ACPI spec. describes the following fields in the CPPC object 'Performance Limite

Re: [edk2-devel] [edk2-platforms][PATCH v4 7/8] Platform/Sgi: Low Power Idle States for RD-Fremont

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 7/8]

Re: [edk2-devel] [edk2-platforms][PATCH v4 6/8] Platform/Sgi: Extend SMBIOS support for RD-Fremont

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 6/8]

Re: [edk2-devel] [edk2-platforms][PATCH v4 5/8] Platform/Sgi: Add initial support for RD-Fremont platform

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 5/8]

Re: [edk2-devel] [edk2-platforms][PATCH v4 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 3/8]

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/8] Platform/Sgi: Refactor system memory base and size definitions

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 2/8]

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/8] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:32 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v4 1/8]

Re: [edk2-devel] [edk2-platforms][PATCH v4 4/8] Platform/Sgi: Add ACPI tables for RD-Fremont platform

2024-03-08 Thread levi.yun
Hi. Prabin! > +[Sources] > + Dbg2.aslc > + Fadt.aslc > + Gtdt.aslc > + RdFremont/Dsdt.asl > + RdFremont/Madt.aslc > + RdFremont/Pptt.aslc > + Spcr.aslc > + SsdtEvents.asl > + SsdtRos.asl > + SsdtRosVirtioP9.asl > + With the RdN2Cfg3 and RdV2 too, When would you support PCIE & IORT in th

Re: [edk2-devel] [edk2-platforms][PATCH v5 6/6] Platform/Sgi: Extend SMBIOS support for RD-V2 platform

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun From: devel@edk2.groups.io on behalf of Prabin CA via groups.io Sent: 01 March 2024 16:29 To: devel@edk2.groups.io Cc: Ard Biesheuvel; Leif Lindholm; Sami Mujawar; Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH v5 6/6]

Re: [edk2-devel] [edk2-platforms][PATCH v5 5/6] Platform/Sgi: Define RD-V2 platform id values

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116510): https://edk2.groups.io/g/devel/message/116510 Mute This Topic: https://groups.io/mt/104668455/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [edk2-platforms][PATCH v5 4/6] Platform/Sgi: Add support for RD-N2-Cfg3 platform

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116509): https://edk2.groups.io/g/devel/message/116509 Mute This Topic: https://groups.io/mt/104668453/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [edk2-platforms][PATCH v5 3/6] Platform/Sgi: Add a PCD to specify platform variant

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116508): https://edk2.groups.io/g/devel/message/116508 Mute This Topic: https://groups.io/mt/104668452/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [edk2-platforms][PATCH v5 2/6] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116507): https://edk2.groups.io/g/devel/message/116507 Mute This Topic: https://groups.io/mt/104668449/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [edk2-platforms][PATCH v5 1/6] Platform/Sgi: remove +nofp gcc option flag

2024-03-08 Thread levi.yun
Reviewed-by: levi.yun -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116506): https://edk2.groups.io/g/devel/message/116506 Mute This Topic: https://groups.io/mt/104668448/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-08 Thread Abdul Lateef Attar via groups.io
Hi Pierre,     I think the provided patch also serve the same purpose of validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFERS. Do you want me to remove the "ValidateReserved" implementation? Here is the sample test results. 1)   Protection Flag    : 0x5

Re: [edk2-devel] [PATCH] NanhuDev:Add BOSC NanhuDev platform

2024-03-08 Thread Sunil V L
On Fri, Mar 08, 2024 at 12:31:26AM -0800, WangYang wrote: > Hi,Sunil V L > > How about this status. > > > > -原始邮件- > > 发件人: WangYang > > 发送时间: 2024-02-28 14:34:11 (星期三) > > 收件人: devel@edk2.groups.io, suni...@ventanamicro.com > > 抄送: "Yang Wang" , "Ran Wang" , > > "YunFeng Yang" , "

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

2024-03-08 Thread Yao, Jiewen
Indeed. Appreciate your great contribution to make EDKII better. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Friday, March 8, 2024 5:38 PM > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Kinney, Michael D ; Andrew Fish > ; Gerd Hoffmann ; Ya

[edk2-devel] Where is the "build.exe"?

2024-03-08 Thread Gavin Lin
Hi, By browsing the document "edk2-BuildSpecification-release-1.28.pdf", the "build.exe" can be found on page 62 as below. But I just can find build.bat in edk2\BaseTools\BinWrappers\WindowsLike\. Thanks for the comment if any. [cid:image001.png@01DA70A4.62E9FC20] Best regards Gavin Lin The in

Re: [edk2-devel] [Patch V3] BaseTools: VfrCompiler Adds DefaultValueError

2024-03-08 Thread Zhang, Zifeng
Hi Liming, Could you help to review the patch for VFR compiler change submitted by Yuting? Btw, Dell need some introduction of Hii StructurePCD implementation especially for replacing patch table configurations. Would you like to share EDK2 wiki link or doc for it? Best Regards, Zifeng -

[edk2-devel] Build firmware for STM32MP25 with edk2

2024-03-08 Thread phanbagiabao2001
Hello everyone, I want to build the firmware for the platform STM32MP25. Can I use edk2 to build it? If yes, can you give me the idea because I don't see the STM32 platform in edk2-platforms? -- PHAN Ba Gia Bao Etudiant en 5A STI - INSA Centre Val de Loire -=-=-=-=-=-=-=-=-=-=-=- Groups.io Lin

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

2024-03-08 Thread Ard Biesheuvel
On Fri, 8 Mar 2024 at 10:14, Laszlo Ersek wrote: > > On 3/6/24 23:22, Michael D Kinney wrote: > > Reviewed-by: Michael D Kinney > > Merged as commit ccf91b518f22, via > . > > Thank you all for everything, Goodbye Laszlo. It was great to have you back,

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

2024-03-08 Thread Laszlo Ersek
On 3/8/24 10:13, Laszlo Ersek wrote: > On 3/5/24 12:38, Laszlo Ersek wrote: >> Bugzillas: >> - https://bugzilla.tianocore.org/show_bug.cgi?id=990 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=991 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 >> >> CI: >> - https://github.com/tianoc

Re: [edk2-devel] [edk2-platforms PATCH v2 0/4] clean up ProcessLibraryConstructorList() declarations in SEC modules

2024-03-08 Thread Laszlo Ersek
On 3/5/24 13:01, Laszlo Ersek wrote: > Bugzilla: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > > This patch series puts the recent BaseTools feature to use in which > AutoGen generates the ProcessLibraryConstructorList() declaration in > "AutoGen.h" for such non-library SEC modules whos

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-08 Thread PierreGondois
Hello Abdul, On 3/8/24 08:22, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Adds WSMT parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../UefiShellAcpiViewCommandLib/AcpiParser.

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

2024-03-08 Thread Laszlo Ersek
On 3/6/24 23:22, Michael D Kinney wrote: > Reviewed-by: Michael D Kinney Merged as commit ccf91b518f22, via . Thank you all for everything, Laszlo >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: Wedn

Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules

2024-03-08 Thread Laszlo Ersek
On 3/5/24 12:38, Laszlo Ersek wrote: > Bugzillas: > - https://bugzilla.tianocore.org/show_bug.cgi?id=990 > - https://bugzilla.tianocore.org/show_bug.cgi?id=991 > - https://bugzilla.tianocore.org/show_bug.cgi?id=4643 > > CI: > - https://github.com/tianocore/edk2/pull/5442 > > Branch: > - > https:

Re: [edk2-devel] [PATCH] NanhuDev:Add BOSC NanhuDev platform

2024-03-08 Thread WangYang
Hi,Sunil V L How about this status. > -原始邮件- > 发件人: WangYang > 发送时间: 2024-02-28 14:34:11 (星期三) > 收件人: devel@edk2.groups.io, suni...@ventanamicro.com > 抄送: "Yang Wang" , "Ran Wang" , > "YunFeng Yang" , "YaXing Guo" , > "Bamvor Jian ZHANG" > 主题: [edk2-devel] [PATCH] NanhuDev:Add B

Re: [edk2-devel] [PATCH v8 12/37] UefiCpuPkg: Add CPU exception library for LoongArch

2024-03-08 Thread Chao Li
Hi Ray, Thanks, Chao On 2024/2/2 11:30, Ni, Ray wrote: 1. Most of INF changes are not necessary for x86. Can you avoid them? + ## This PCD Contains the pointer to a CPU exception vector base address. + # @Prompt The pointer to a CPU exception vector base address. + gUefiCpuPkgTokenSpaceGuid