Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-15 Thread Marvin Häuser
> On 15. Mar 2024, at 23:57, Oliver Smith-Denny > wrote: > > I don't think this is what I'm saying. What I am trying to say is that > on MSVC, I see PE images getting created that have VirtualSize set to > the actual number of initialized bytes in that section (not padded to > the section

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-15 Thread Oliver Smith-Denny
On 3/14/2024 2:57 PM, Marvin Häuser wrote: On 14. Mar 2024, at 15:45, Oliver Smith-Denny wrote: This does not appear to be the case with MSVC built binaries. I am seeing that VirtualSize is the size of the data-initialized part of the section. What? :( So you are saying modern MSVC

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Build proper SD/MMC boot descriptions

2024-03-15 Thread Mario Bălănică
Bump -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116818): https://edk2.groups.io/g/devel/message/116818 Mute This Topic: https://groups.io/mt/103516251/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Support override for SD 1.8v signaling switch

2024-03-15 Thread Mario Bălănică
Can someone please take a look at this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116817): https://edk2.groups.io/g/devel/message/116817 Mute This Topic: https://groups.io/mt/103516142/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [PATCH] MdePkg: Add PciVenNameLib to get vendor name.

2024-03-15 Thread Michael D Kinney
That is a lot of string data. Where is this expected to be used? If it is limited to a UEFI Shell command, would it be better to add to ShellPkg so it does not get used for FW components? Thanks, Mike > -Original Message- > From: Simon Wang > Sent: Friday, March 15, 2024 2:05 AM >

Re: [edk2-devel] [PATCH edk2-platforms v6 2/7] Platform/SbsaQemu: read amount of cpus during init

2024-03-15 Thread Marcin Juszkiewicz
W dniu 14.03.2024 o 16:13, Ard Biesheuvel pisze: +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf @@ -1,7 +1,7 @@ ## @file # This driver effectuates SbsaQemu platform configuration settings # -# Copyright (c) 2019, Linaro Ltd. All rights reserved. +#

Re: [edk2-devel] [PATCH edk2-platforms v6 1/7] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

2024-03-15 Thread Marcin Juszkiewicz
W dniu 14.03.2024 o 16:14, Ard Biesheuvel pisze: +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.inf @@ -0,0 +1,32 @@ +#/* @file +# +# Copyright (c) Linaro Ltd. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +#*/ + +[Defines] +

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Add VirtHstiDxe driver

2024-03-15 Thread Gerd Hoffmann
On Thu, Mar 14, 2024 at 12:05:28PM +, Yao, Jiewen wrote: > I agree that not all bits make sense to virtual machine. > However, I do see some bits should be there if we really want to add HSTI to > report security propery. Setting the bits which are obviously correct makes sense indeed. >

Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/15 18:34, Gerd Hoffmann wrote: On Fri, Mar 15, 2024 at 06:19:12PM +0800, Chao Li wrote: Hi Gerd, Thanks, Chao On 2024/3/15 17:36, Gerd Hoffmann wrote: On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote: Add a early serial port output library into

[edk2-devel] [PATCH edk2-platform v2 1/3] Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm

2024-03-15 Thread levi.yun
Cc: sami.muja...@arm.com, pierre.gond...@arm.com, n...@arm.com, thomas.abra...@arm.com The NOR Flash1 is used for UEFI Variable storage. When Standalone MM is enabled the variable storage is managed in the secure world by Standalone MM. Therefore, add a new instance of NorFlashLib

[edk2-devel] [PATCH edk2-platform v2 3/3] Platform/Arm: Add Standalone MM support for FVP

2024-03-15 Thread levi.yun
Add Standalone MM support for FVP model. Signed-off-by: levi.yun --- Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 208 Platform/ARM/VExpressPkg/PlatformStandaloneMm.fdf | 106 ++ 2 files changed, 314 insertions(+) diff --git

[edk2-devel] [PATCH edk2-platform v2 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-03-15 Thread levi.yun
UEFI Secure variable support can be enabled using Standalone MM for FVP RevC model. The following steps enable UEFI variable service using StandaloneMm: 1. Add MmComminucationDxe. - Enables communication with StandaloneMm. The PcdMmBufferBase & PcdBufferSize definitions are used

[edk2-devel] [PATCH edk2-platform v2 0/3] StandloneMm support for FVP.

2024-03-15 Thread levi.yun
This patch adds StandloneMm feature on FVP RevC & AEMvA. StandaloneMm will be used for UEFI secure Variable support on these models. v1->v2: - Rebase to master - Use MmunblockLibNull when ENABLE_STMM == TRUE. levi.yun (3): Platform/Arm: FVP: Add a NorFlashLib instance for StandaloneMm

Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library

2024-03-15 Thread Gerd Hoffmann
On Fri, Mar 15, 2024 at 06:19:12PM +0800, Chao Li wrote: > Hi Gerd, > > > Thanks, > Chao > On 2024/3/15 17:36, Gerd Hoffmann wrote: > > On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote: > > > Add a early serial port output library into LoongArchVirt that named > > >

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-03-15 Thread Sami Mujawar
Hi Levi, I think we need some documentation on how this feature can be used. However, I will not hold this series. I expect a follow on patch that does this. This series as such looks good to me. If you can reply back to my query for patch 2/3, I will get this merged. With that, For this

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-03-15 Thread levi.yun
Hi. Sami. > Considering that Arm implementation does not support modification of the > StandaloneMm memory map from > normal world, should we just preprocess the > above line to say if ENABLE_STMM == TRUE then use the Null lib > instance? > If so, can fix that before merging this patch series.

Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/15 17:36, Gerd Hoffmann wrote: On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote: Add a early serial port output library into LoongArchVirt that named EarlyFdtSerialPortLib16550, this library is referenced from MdeModulePkg. Why create your own copy?

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-03-15 Thread levi.yun
Hi. Sami! > I am not able to apply these patches. Can you share a branch with your > patches, please? Okay, I'll send with v2 with rebase to recent master. Thanks! From: Sami Mujawar via Groups.Io Sent: 15 March 2024 10:10 To: Yeo Reum Yun;

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 2/3] Platform/Arm: Enable UEFI Secure Variable support for FVP

2024-03-15 Thread Sami Mujawar
Hi Levi, On Fri, Jan 19, 2024 at 01:33 AM, levi.yun wrote: > > +!if $(ENABLE_UEFI_SECURE_VARIABLE) == TRUE > + > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > > +!endif Considering that Arm implementation does not support modification of the StandaloneMm

Re: [edk2-devel] [PATCH v1 09/26] UefiCpuPkg: Added a new PCD named PcdCpuMmuIsEnabled

2024-03-15 Thread Gerd Hoffmann
Hi, > > > + ## This dynamic PCD indicates whether CPU MMU is enabled. > > > + # TRUE - CPU MMU is enabled. > > > + # FASLE - CPU MMU have not enabled. > > > + gUefiCpuPkgTokenSpaceGuid.PcdCpuMmuIsEnabled|FALSE|BOOLEAN|0x6023 > > Why create a PCD for this? Can't you simply read the

Re: [edk2-devel] [PATCH RESEND edk2-platforms v1 0/3] Platform/Arm: StandloneMm support for FVP.

2024-03-15 Thread Sami Mujawar
Hi Levi, I am not able to apply these patches. Can you share a branch with your patches, please? Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116800): https://edk2.groups.io/g/devel/message/116800 Mute This

Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-03-15 Thread Chao Li
Hi Ard, Thanks, Chao On 2024/3/15 17:51, Ard Biesheuvel wrote: On Fri, 15 Mar 2024 at 10:49, Chao Li wrote: Hi Gerd, Thanks, Chao On 2024/3/15 17:33, Gerd Hoffmann wrote: On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: Add a serial port hook library in LoongArchVirt named

Re: [edk2-devel] [PATCH v1 21/26] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 02:39:31AM -0700, Chao Li wrote: > This library for PEI phase, and obtains the QemuFwCfg base address by > directly parsing the FDT, reads and writes the data in QemuFwCfg by > operating on the QemuFwCfg base address. > create mode 100644 >

Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-03-15 Thread Ard Biesheuvel
On Fri, 15 Mar 2024 at 10:49, Chao Li wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/3/15 17:33, Gerd Hoffmann wrote: > > On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: > > Add a serial port hook library in LoongArchVirt named > Fdt16550SerialProtHookLib, this library is referenced

Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/15 17:33, Gerd Hoffmann wrote: On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: Add a serial port hook library in LoongArchVirt named Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. LoongArch QEMU virtual machine uses register of

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 02:39:24AM -0700, Chao Li wrote: > Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. What are the differences to the ArmVirtPkg version? Is it possible to have a FdtNorFlashQemuLib which is shared between arm and loongarch? And maybe risc-v too? take

Re: [edk2-devel] [PATCH v1 18/26] OvmfPkg/LoongArchVirt: Add the early serial port output library

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 05:39:08PM +0800, Chao Li wrote: > Add a early serial port output library into LoongArchVirt that named > EarlyFdtSerialPortLib16550, this library is referenced from > MdeModulePkg. Why create your own copy? What are the differences to

Re: [edk2-devel] [PATCH v1 09/26] UefiCpuPkg: Added a new PCD named PcdCpuMmuIsEnabled

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/15 17:09, Gerd Hoffmann wrote: On Mon, Mar 11, 2024 at 05:38:17PM +0800, Chao Li wrote: Added PcdCpuMmuIsEnabled to instruct that the CPU MMU is enabled. BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann

Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: > Add a serial port hook library in LoongArchVirt named > Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. > > LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to > transfer serial port base addres

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList()

2024-03-15 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Wang, BruceX Sent: Friday, March 15, 2024 5:21 PM To: devel@edk2.groups.io Cc: Wang, BruceX ; Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH v1 1/1] UefiPayloadPkg: Cleanup ProcessLibraryConstructorList() From: Bruce

Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 02:39:08AM -0700, Chao Li wrote: > Add a serial port hook library in LoongArchVirt named > Fdt16550SerialProtHookLib, this library is referenced from ArmVirtPkg. > > LoongArch QEMU virtual machine uses register of LOONGARCH_CSR_KS1 to > transfer serial port base addres

Re: [edk2-devel] [PATCH v1 16/26] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 02:39:02AM -0700, Chao Li wrote: > This Library is used to collect APs resources, but is currently NULL > for OvmfPkg, because it is not used by the LoongArch virtual machine. What is the point of having this library then? > +#include > +#include > +#include >

Re: [edk2-devel] [PATCH v1 09/26] UefiCpuPkg: Added a new PCD named PcdCpuMmuIsEnabled

2024-03-15 Thread Gerd Hoffmann
On Mon, Mar 11, 2024 at 05:38:17PM +0800, Chao Li wrote: > Added PcdCpuMmuIsEnabled to instruct that the CPU MMU is enabled. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Chao Li > --- >

[edk2-devel] [PATCH] MdePkg: Add PciVenNameLib to get vendor name.

2024-03-15 Thread Simon Wang via groups.io
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116786): https://edk2.groups.io/g/devel/message/116786 Mute This Topic: https://groups.io/mt/104943937/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 07/26] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/14 19:28, Gerd Hoffmann wrote: On Mon, Mar 11, 2024 at 05:38:06PM +0800, Chao Li wrote: Add a new header file CpuMmuLib.h, whitch is referenced from ArmPkg/Include/Library/ArmMmuLib.h. Currently, only support for LoongArch64 is added, and more architectures can

Re: [edk2-devel] [PATCH v1 05/26] UefiCpuPkg: Add LoongArch64 CPU Timer instance

2024-03-15 Thread Chao Li
Hi Gerd, This email was not send by EDK2 community, but other emails which you send were by EDK2 community, I don't know what happened. Regardless, I'll respond your question about this changes via this email. Here is my comments: Thanks, Chao On 2024/3/14 18:59, Gerd Hoffmann wrote:

Re: [edk2-devel] [PATCH v1 06/26] UefiCpuPkg: Add CPU exception library for LoongArch

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/14 19:22, Gerd Hoffmann wrote: Hi, +[Sources.LoongArch64] + LoongArch/DxeExceptionLib.c + LoongArch/ExceptionCommon.h + LoongArch/ExceptionCommon.c + LoongArch/LoongArch64/ArchExceptionHandler.c + LoongArch/LoongArch64/ExceptionHandlerAsm.S | GCC Hmm,

Re: [edk2-devel] [PATCH v1 03/26] UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically

2024-03-15 Thread Chao Li
Hi Gerd, Thanks, Chao On 2024/3/14 18:52, Gerd Hoffmann wrote: Hi, [LibraryClasses] BaseLib + CcExitLib + CpuLib + DebugAgentLib + HobLib LocalApicLib MemoryAllocationLib - HobLib + MicrocodeLib MtrrLib - CpuLib - UefiBootServicesTableLib - DebugAgentLib -