Changes to support spec changes
1. Remove usage of Pcd.
2. Change code to validate the Temporary Ram size input.
3. Consume the input saved in YMM Register
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Chiu Chasel
Cc: Duggapu Chinni B
Signed-off-by: Duggapu Chinni B
---
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wenxing Hou
> 发送时间: 2024年3月6日 11:24
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [edk2-devel] [PATCH v2 2/2] MdePkg: Add
> gEfiDeviceSignatureDatabaseGuid to dec
>
Wenxing:
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wenxing Hou
> 发送时间: 2024年3月6日 11:24
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [edk2-devel] [PATCH v2 1/2] MdePkg: Add UEFI 2.10
> DeviceAuthentication
>
> According to UEFI 2.10
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4648
The SavePasswordToVariable function takes in the password, generates a salt,
generates a SHA256 hash of the
password and saves the password hash to a variable. The KeyLipGenerateSalt
function calls RandomSeed with
NULL as the first
The KeyLibGenerateSalt function fails to check the return value of RandomSeed
and RandomBytes function
calls.
SavePasswordToVariable function also fails to check the status of calling
function KeyLibGenerateSalt
Added a status check for all the above mentioned function's
Signed-off-by: V V
Please aware that this option will cause potential security risk.
In case that any the guest component only knows one of vTPM or RTMR, and only
extends one of vTPM or RTMR, but the other one only verifies the other, then
the chain of trust is broken.
This solution is secure if and only if all
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4736
In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for
EFI_BROWSER_ACTION_FORM_OPEN:
NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with
this browser action because question values have not been retrieved yet.
So
I feel that ordering alphabetically may break the logical groups.
For example, below two might be placed in a reverse way.
CpuExceptionCommon.h
CpuExceptionCommon.c
But luckily, you didn't re-order the above to make .c above .h.
So, you are not simply ordering them alphabetically.
Reviewed-by: Ray Ni
Thanks,
Ray
From: Chao Li
Sent: Wednesday, March 20, 2024 16:42
To: devel@edk2.groups.io
Cc: Ni, Ray ; Kumar, Rahul R ; Gerd
Hoffmann
Subject: [PATCH v2 01/13] UefiCpuPkg/CpuTimerLib: Reorder the INF file
alphabetically
Some of the order
Hi Ray and other maintainers,
I submitted this series few days ago, could you review them and give me
the R-B?
Thanks,
Chao
On 2024/3/20 16:41, Chao Li wrote:
This patch set adjusted some order in UefiCpuPig alphabetically, added
LoongArch libraries and drivers into UefiCpuPkg, it is a
On Thu, Mar 21, 2024 at 9:59 AM qinkun Bao wrote:
>
> From: Qinkun Bao
>
> The UEFI v2.10 spec defines the protocol EFI_CC_MEASUREMENT_PROTOCOL
> to enable (for example) RTMR-based boot measurement for TDX VMs.
> With the current UEFI spec’s “should not” wording and EDK2
> implementation, TPM
Hello,
For reference:
Patchsets:
- https://edk2.groups.io/g/devel/message/116961 (first part)
- https://edk2.groups.io/g/devel/message/116978 (second part)
- https://edk2.groups.io/g/devel/message/117001 (platforms patches)
Branches:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. The following field:
(struct CmArchCommonProcHierarchyInfo).GicCToken
was renamed to 'AcpiIdObjectToken'. Reflect this change in the
edk2-platforms repository.
This patch modifies the
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- FVP
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Prepare the handling of these objects
in the ConfigurationManagers by adding a function handler for these
objects.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
-
Resend this patch since 'more than 40 messages in 30 minutes' have been
sent and the mailing list blocked/rejected some patches.
Following [1] and [2], other architectures than Arm aim to leverage
the DynamicTablesPkg. The package uses namespaces/domains to split
objects IDs. Currently most of
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Reflect this change by
renaming/moving the relevant object.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
- FVP
for the following Arch Common object Id:
-
Some DynamicTables objects have been moved from the Arm namespace
to a new Arch Common namespace. Prepare the handling of these objects
in the ConfigurationManagers by adding a function handler for these
objects.
This patch modifies the ConfigurationManager of the following
platforms:
- Juno
-
Following [1] and [2], other architectures than Arm aim to leverage
the DynamicTablesPkg. The package uses namespaces/domains to split
objects IDs. Currently most of the objects are part of the Arm
namespace. Some objects are generic enough to be re-used by other
architectures.
[3] and [4] moved
From: Sami Mujawar
Move the PCC Subspace Type 5 info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PCCT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer
From: Sami Mujawar
Move the PSD info object from Arm Namespace to the Arch Common
namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SSDT CPU topology generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
From: Sami Mujawar
Move the PCC Subspace Type2 info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PCCT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
From: Sami Mujawar
Move the PCC Subspace Type 3 & 4 info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PCCT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer
From: Sami Mujawar
Move the PCC Subspace Type1 info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PCCT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
From: Sami Mujawar
Move the PCC Subspace Type0 info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PCCT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
From: Sami Mujawar
Move PCC structure definitions from Arm Namespace header file to
the Arch Common namespace header file.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff Brasen
Cc: Girish Mahadevan
Cc: Leif Lindholm
Cc: Meenakshi Aggarwal
From: Sami Mujawar
Move the Cache info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PPTT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
Cc: Pierre
From: Sami Mujawar
Move the Continuous perfformance control info object from Arm
Namespace to the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SSDT CPU topology generator
- ConfigurationManagerObjectParser
- Dynamic
From: Sami Mujawar
Move the Processor hierarchy info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PPTT generator
- SSDT CPU topology generator
- ConfigurationManagerObjectParser
-
From: Sami Mujawar
The GicCToken field in the CM_ARM_PROC_HIERARCHY_INFO structure is
a reference to the associated object which has the corresponding
ACPI Processor ID, e.g. for Arm systems this is a reference to the
CM_ARM_GICC_INFO object.
For other architecture this may be a reference to a
From: Sami Mujawar
Move the LPI info object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SSDT Cpu Topology generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
From: Sami Mujawar
Move the Generic Initiator affinity info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SRAT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo
From: Sami Mujawar
Move the PCI device Handle object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SRAT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
Cc:
From: Sami Mujawar
Move the ACPI device Handle object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SRAT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
Cc:
From: Sami Mujawar
Move the Memory Affinity Info object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SRAT generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map.
From: Sami Mujawar
Move Pci Interrupt Map Info object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SSDT PCIe library
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map
-
From: Sami Mujawar
The CM_ARM_GENERIC_INTERRUPT struct describes a standard interrupt and
is generic. Therefore move it to the Arch Common namespace header file
and rename it as CM_ARCH_COMMON_GENERIC_INTERRUPT.
Correspondingly also update the following modules to reflect the
changes introduced
From: Sami Mujawar
Move Pci Address Map Info object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- SSDT PCIe generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer map
-
Following [1] and [2], other architectures than Arm aim to leverage
the DynamicTablesPkg. The package uses namespaces/domains to split
objects IDs. Currently most of the objects are part of the Arm
namespace. Some objects are generic enough to be re-used by other
architectures.
In [2], an Arch
From: Sami Mujawar
Move Pci Config Space Info object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- MCFG generator
- SSDT PCIe generator
- SSDT PCIe support library
-
From: Sami Mujawar
Move Cm Reference object from Arm Namespace to the Arch
Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- PPTT generator
- SSDT CPU topology generator
- SSDT PCIe generator
-
From: Sami Mujawar
Move FADT Fixed Features Flags object from Arm Namespace to the
Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- FADT Generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer
From: Sami Mujawar
Move Hypervisor Vendor Id info object from Arm Namespace to
the Arch Common namespace.
Correspondingly also update the following modules to reflect the
changes introduced by the move:
- FADT Generator
- ConfigurationManagerObjectParser
- Dynamic Plat Repo TokenFixer
From: Sami Mujawar
Move PowerManagementProfileInfo Object from Arm Namespace to the
Arch Common namespace.
The following updates are also done to reflect the changes introduced
by the move:
- Update the FADT Generator to migrate to use the Power Management
Profile Info object
From: Sami Mujawar
Update the Configuration Manager for Kvmtool guest firmware
to handle ArchComm namespace objects.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff Brasen
Cc: Girish Mahadevan
Cc: Leif Lindholm
Cc: Meenakshi Aggarwal
Signed-off-by:
From: Sami Mujawar
The Arm Namespace Object ID Reserved29 was a reserved ID
that was never used. Therefore, drop the EArmObjReserved29
object ID also update the Dynamic Plat Repo TokenFixer map
and the Configuration Manager Object Parser.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef
From: Sami Mujawar
The Arm Namespace Object ID for CPU info was not used.
Therefore, drop the EArmObjCpuInfo object ID. Also remove
- the partial listing of the Arm Namespace object IDs from
ConfigurationManagerObject.h and add a reference to the
location where they are defined.
- the
From: Sami Mujawar
Remove the partial listing of the Arm Namespace object IDs
from and add a reference to the enum EARM_OBJECT_ID that is
used to describe the object in the ARM Namespace.
Also document that the Arch Common namespace objects will be
described using the enum
From: Sami Mujawar
Update DynamicPlatRepo to reflect the introduction of the Arch
Common namespace. Also, update the TokenFixer map to reflect the
current state of the ArmNamespace Objects and add a note in the
documentation header for the EARM_OBJECT_ID enum, that the Token
fixer map needs
From: Sami Mujawar
Update the Token Fixer to return objects other than Arm Namespace
objects as unsupported.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff Brasen
Cc: Girish Mahadevan
Cc: Leif Lindholm
Cc: Meenakshi Aggarwal
Signed-off-by: Sami
From: Sami Mujawar
Update the Cm Object Parser to support parsing of Arch Common
namespace objects.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff Brasen
Cc: Girish Mahadevan
Cc: Leif Lindholm
Cc: Meenakshi Aggarwal
Signed-off-by: Sami Mujawar
From: Sami Mujawar
Introduce a new header file for defining the Arch Common Namespace
objects. Also include it in the Configuration Manager Object header
file so that the required definitions are propagated.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff
From: Sami Mujawar
Add ObjectId to CM_OBJ_PARSER_ARRAY so that the code can validate
the entries in the Cm object parser array. Also introduce helper
macros to populate the Cm Object Parser Arrays.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff Brasen
From: Sami Mujawar
The CM_ARM_PROC_NODE_ID_INFO was dropped by the patch at
"b2bbe3df5470 DynamicTablesPkg: Remove PPTT ID structure
from ACPI 6.4 generator" and the EArmObjProcNodeIdInfo was
made EArmObjReserved29.
Since ProcNodeIdInfo is no longer used drop the CM object
parser code from
The parameters of CreateAmlProcessorContainer() were not
updated in:
commit 5fb3f5723a1e ("DynamicTablesPkg: Allow for specified CPU names")
This causes the EccCheck CI test to fail. Fix this.
Cc: Pierre Gondois
Cc: Yeo Reum Yun
Cc: AbdulLateef Attar
Cc: Jeshua Smith
Cc: Jeff Brasen
Cc:
Following [1] and [2], other architectures than Arm aim to leverage
the DynamicTablesPkg. The package uses namespaces/domains to split
objects IDs. Currently most of the objects are part of the Arm
namespace. Some objects are generic enough to be re-used by other
architectures.
In [2], an Arch
Hi Gerd,
Thanks,
Chao
On 2024/3/21 19:39, Gerd Hoffmann wrote:
Hi,
QemuFwCfgLibMmio.inf is looks like a DXE stage library, while this patch is
the PEI stage library we are dicussing.
I have tow plans:
*Plan A:* Keep this library under LoongArchQemuVirt.
*Plan B:* Create a new INF
On Thu, Mar 21, 2024 at 08:39:13AM +, sunceping wrote:
> On Wednesday, March 20, 2024 6:05 PM Gerd Hoffmann wrote:
> >
> > We don't need to read + cache all fw_cfg data. We only need to cache the
> > entries which (a) must be measured, and (b) will not be measured in some
> > other way.
> >
Hi,
> QemuFwCfgLibMmio.inf is looks like a DXE stage library, while this patch is
> the PEI stage library we are dicussing.
>
> I have tow plans:
>
> *Plan A:* Keep this library under LoongArchQemuVirt.
>
> *Plan B:* Create a new INF named QemuFwCfgPeiLibMmio.inf under
>
Thank you Abhi, for your contributions to edk2-test.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116957): https://edk2.groups.io/g/devel/message/116957
Mute This Topic: https://groups.io/mt/104756650/21656
Group Owner:
Reviewed OK.
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116956): https://edk2.groups.io/g/devel/message/116956
Mute This Topic: https://groups.io/mt/104756657/21656
Group Owner:
Reviewed OK
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116955): https://edk2.groups.io/g/devel/message/116955
Mute This Topic: https://groups.io/mt/104756656/21656
Group Owner:
Reviewed OK
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116954): https://edk2.groups.io/g/devel/message/116954
Mute This Topic: https://groups.io/mt/104756655/21656
Group Owner:
Reviewed OK
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116953): https://edk2.groups.io/g/devel/message/116953
Mute This Topic: https://groups.io/mt/104756654/21656
Group Owner:
Reviewed OK
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116952): https://edk2.groups.io/g/devel/message/116952
Mute This Topic: https://groups.io/mt/104756652/21656
Group Owner:
Reviewed OK
Reviewed-by: G Edhaya Chandran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116951): https://edk2.groups.io/g/devel/message/116951
Mute This Topic: https://groups.io/mt/104756650/21656
Group Owner:
On Wednesday, March 20, 2024 6:05 PM Gerd Hoffmann wrote:
>
> We don't need to read + cache all fw_cfg data. We only need to cache the
> entries which (a) must be measured, and (b) will not be measured in some
> other way.
>
I am afraid that it is difficult to determine which fw_cfg items
are
Hi liming,
Gentle reminder, we have removed the whitespace. Please help review the patch~
Thanks,
Yuting
-Original Message-
From: devel@edk2.groups.io On Behalf Of Yuting Yang
Sent: Thursday, March 21, 2024 3:30 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Liming Gao ;
Feng, Bob C
Add --catch_default option
Raise a DefaultValueError when encountering
VFR default definitions to help remove default variables.
Signed-off-by: Yuting Yang
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Christine Chen
Cc: Zifeng Zhang
---
BaseTools/Source/C/VfrCompile/VfrCompiler.cpp |
Add --catch_default option
Raise a DefaultValueError when encountering
VFR default definitions to help remove default variables.
Signed-off-by: Yuting Yang
---
BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 8 +--
BaseTools/Source/C/VfrCompile/VfrCompiler.h | 1 +
81 matches
Mail list logo
