[edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Add cpuid_ex API to execute CPUID instructions on specific CPU

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4749 This commit adds cpuid_ex function to edk2module to provide capability to execute cpuid instruction on specific cpu. This feature was requested via BZ 4749 Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Vishal R

[edk2-devel] [edk2-libc Patch 0/1] Add cpuid_ex API to execute CPUID instructions on specific CPU

This commit adds cpuid_ex function to edk2module to provide capability to execute cpuid instruction on specific cpu. This feature was requested via BZ 4749 Vishal R (1): edk2-libc: Add cpuid_ex API to execute CPUID instructions on specific CPU .../PyMod-3.6.8/Modules/edk2module.c

回复: [edk2-devel] [PATCH v1 1/1] Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute.

Patrick: Commit message needs package name MdePkg. One comment for the change is below. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael Kubacki > 发送时间: 2024年5月17日 4:20 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Michael D Kinney > > 主题: [edk2-devel] [PATCH v1 1/1]

Re: [edk2-devel] [PATCH 0/5] AmdMinBoardPkg: AMD board specific modules

[AMD Official Use Only - AMD Internal Distribution Only] Already reviewed internally. Reviewed-by: Abner Chang Hi Abdul, please add the tag [edk2-platforms] in subject next time when send the patch for edk2-platforms changes. Thanks Abner > -Original Message- > From: devel@edk2.groups.

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

Thanks for confirming. Thanks, Ray From: Ding, Feng (Sunnyvale) Sent: Friday, May 17, 2024 8:39 To: Ni, Ray ; Hsueh, Hong-Chih (Neo) ; Laszlo Ersek ; devel@edk2.groups.io Cc: He, Jiangang ; Chang, Abner ; gaolim...@byosoft.com.cn Subject: RE: [PATCH v2] MdeMo

Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

Thanks for the review and approval. Could you please help merge this patch to the upstream? A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5644. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onlin

[edk2-devel] [PATCH 5/5] AmdMinBoardPkg: Implements BoardBdsHookLib library

Implements BoardBdsHookLib library class for AMD platforms. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 10 + .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc |2 + .../Include/Library/AmdBoardBdsHookLib.h | 130

[edk2-devel] [PATCH 4/5] AmdMinBoardPkg: Implement BoardInitLib for DXE phase

DxeBoardInitLib library provides board-specific initialization functions for the DXE phase. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 6 +- .../Library/DxeBoardInitLib/DxeBoardInitLib.c | 253 +++ .../Dxe

[edk2-devel] [PATCH 2/5] AmdMinBoardPkg/Library: Uncrustify the Library module

Uncrustify the library module. Update the function header. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../Library/PeiReportFvLib/PeiReportFvLib.c | 12 +++- .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c| 3 +-- 2 files changed, 12 insertions

[edk2-devel] [PATCH 3/5] AmdMinBoardPkg: Implement BoardInitLib for PEI phase

PeiBoardInitPreMemLib library provides board-specific initialization functions for the PEI phase. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 2 + .../PeiBoardInitPreMemLib/AmdMemoryInfoHob.h | 50 .../PeiBoardI

[edk2-devel] [PATCH 1/5] AmdMinBoardPkg: Uncrustify PciHotPlug module

Uncrustify PciHotPlug module. corrects the [in, out] parameters. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- Platform/AMD/AmdMinBoardPkg/PciHotPlug/PciHotPlugInit.c | 4 +++- Platform/AMD/AmdMinBoardPkg/PciHotPlug/PciHotPlugInit.inf | 5 +++-- 2 files changed, 6 ins

[edk2-devel] [PATCH 0/5] AmdMinBoardPkg: AMD board specific modules

PR: https://github.com/tianocore/edk2-platforms/pull/143 Adds various module common to AMD boards. Cc: Abner Chang Cc: Paul Grimes Abdul Lateef Attar (5): AmdMinBoardPkg: Uncrustify PciHotPlug module AmdMinBoardPkg/Library: Uncrustify the Library module AmdMinBoardPkg: Implement BoardInitL

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

> > On ARM, we can actually do better than this: I have taken Doug's v2 > and applied some changes on top to make it work with ArmVirtQemu. > > https://github.com/ardbiesheuvel/edk2/tree/doug-v2 > Ard, would you be comfortable with this patch series if I take the commits you're suggesting? I'm b

[edk2-devel] [PATCH v1 1/1] Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute.

From: Patrick Payne Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as per the PI 1.8 spec. This flag is used to indicate that the memory should be treated as special purpose memory (SPM). Also adds GCD code that marks the SPM with the EFI_MEMORY_SP bit and sets the GCD memory

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe

Hi Sahil, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 09/05/2024 07:25 am, Sahil wrote: Hi Pierre, Thanks for reviewing the patchset. Please find my comment inline below. On Thu, 2 May 2024 at 18:47, PierreGondois via groups.io wrote: > > Hel

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 14/14] Platform/ARM/N1Sdp: Enable FaultTolerantWrite Dxe driver for N1Sdp

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil This driver enables Fault Tolerant Write protocol, which provides fault tolerant write capability for block devices.

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 13/14] Platform/ARM/N1Sdp: Persistent storage for N1Sdp

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Enable persistent storage on QSPI flash device. Signed-off-by: sahil --- Platform/ARM/N1Sdp/N1SdpPlatform.dsc |

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe

Hi Sahil, Thank you for this patch. Please find my response inline marked [SAMI]. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil In N1Sdp platform, the SoC is connected to IOFPGA which has a Cadence Quad SPI (QSPI

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 11/14] Silicon/ARM/NeoverseN1Soc: NOR flash library for N1Sdp

Hi Sahil, Thank you for this patch. I have some suggestions marked inline below, otherwise this patch looks good to me. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Add NOR flash library, this library provides

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 10/14] Silicon/ARM/NeoverseN1Soc: Enable SCP QSPI flash region

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Enable SCP QSPI flash region access by adding it in the PlatformLibMem. This flash is shared between AP core and Sys

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 09/14] Platform/ARM: Add optional provision to fetch and print NOR Flash info

Hi Sahil, Thank you for this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawarnd On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil This patch adds an optional functionality in NorFlashDxe to fetch and print NOR Flash information from NorFlashInfoLib using its

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 08/14] Platform/ARM: Add HostRegisterBaseAddress variable

Hi Sahil, Thank you for this patch. I have a minor comment marked inline as [SAMI]. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil This variable holds the QSPI controller's base address. It is defined in ARM.dec

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 07/14] Platform/ARM/NorFlashDxe: Switch from NorFlash.c to NorFlashDeviceLib

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil NorFlashDeviceLib can be used to provide implementations of different NOR Flash to NorFlashDxe, i.e. NorFlashDxe lin

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 06/14] Platform/ARM: Add P30NorFlashDeviceLib Library

Hi Sahil, Thank you for this patch. Please find my response inline marked [SAMI]. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil This patch implements functions to interact with P30 NOR Flash. The code is taken f

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 05/14] Platform/ARM: Create NorFlashDeviceLib library interface for flash specific functions

Hi Sahil, Thank you for this patch. I have some feedback marked inline as [SAMI]. Other than that, is is possible to add documentation header for the functions and data streuctures in this file, please? With that fixed, Reviewed-by: Sami Mujawar Regards, Sami

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 04/14] Platform/ARM/NorFlashDxe: Move flash specific functions to NorFlash.c

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Refactoring done in this patch has two major parts: 1. Moving out NorFlashUnlockAndEraseSingleBlock and NorFlashWri

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 03/14] Platform/ARM/NorFlashDxe: Add NorFlashCommon.h header file

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil This patch splits NorFlash.h and adds NorFlashCommon.h which will have all the flash independent functions and macro

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 02/14] Platform/ARM/NorFlashDxe: Move NorFlashVirtualNotifyEvent

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Moving this function from NorFlash.c to NorFlashDxe.c as it is not dependent on any particular flash implementation.

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 01/14] Platform/ARM/NorFlashDxe: Move DiskIo related functions out of NorFlash.c

Hi Sahil, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/04/2024 06:56 am, Sahil Kaushal wrote: From: sahil Moving these functions from NorFlash.c to NorFlashBlockIoDxe.c as they are not dependent on any particular flash imp

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

We can have some protocol where all Redfish clients register saying that they are using the bootstrap credentials. And when they finish their job they notify RedfishBootstrapAccountDxe driver and when all of registered modules finish their job RedfishBootstrapAccountDxe driver delete the account

Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lin, Du > Sent: Thursday, May 9, 2024 1:27 PM > To: devel@edk2.groups.io > Cc: Lin, Du ; Ard Biesheuvel ; > Gerd Hoffmann ; Yao, Jiewen > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list che

Re: [edk2-devel] [PATCH V3 1/1] CryptoPkg: Remove deprecated code related to SHA-1

Looks good to me. Reviewed-by: Yi Li We are in Hard Freeze phase, will push it after freeze. Thanks. -Original Message- From: devel@edk2.groups.io On Behalf Of Qingyu Sent: Thursday, May 16, 2024 3:35 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 Subject: [edk2-devel] [PATCH V3

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

[AMD Official Use Only - AMD Internal Distribution Only] That is awesome! Thank you! Abner > -Original Message- > From: Nhi Pham > Sent: Thursday, May 16, 2024 4:50 PM > To: Chang, Abner ; devel@edk2.groups.io; > nick...@nvidia.com; Rebecca Cran > Cc: Isaac Oram ; Attar, AbdulLateef (

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

On 5/16/2024 3:44 PM, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Nhi, Are you using SSIF as the transport interface based on the ManabeabilityPkg framework? If yes, will you contribute that driver? yes, we are. I will need to update the SSIF driver to be

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

[AMD Official Use Only - AMD Internal Distribution Only] Hi Nhi, Are you using SSIF as the transport interface based on the ManabeabilityPkg framework? If yes, will you contribute that driver? Thanks Abner > -Original Message- > From: Nhi Pham > Sent: Thursday, May 16, 2024 4:40 PM > T

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Thanks Nickle. I'm reviewing and testing it. Will get back to you soon. On 5/15/2024 10:14 PM, Nickle Wang via groups.io wrote: Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922 For your con

[edk2-devel] [PATCH V3 1/1] CryptoPkg: Remove deprecated code related to SHA-1

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4698 The default drbg type of randlib has been switched to aes_256_ctr in openssl1.1.1, so sha1 is not really used in RandomSeed(). Remove related code which do SHA-1 support checking in CryptRand.c and CryptRandTsc.c to avoid potential compatibi

[edk2-devel] [PATCH] NetworkPkg:UefiPxeBcDxe:CoverityIssues

Resolved Coverity Issues in UefiPxeBcDxe 1.PxeBcHandleDhcp4Offer Expression "Private->SelectIndex - 1", where "Private->SelectIndex" is known to be equal to 0, underflows the type that receives it. 2.PxeBcDhcp4Discover Directly dereferencing pointer "Token.Packet" which might have NULL .As Token.