Re: [edk2-devel] CryptoPkg OpensslLib TLSv1.3 support

2024-05-20 Thread Li, Yi
No, Tls1.3 is not supported yet: https://github.com/tianocore/edk2/blob/7142e648416ff5d3eac6c6d607874805f5de0ca8/CryptoPkg/Library/OpensslLib/OpensslGen/include/openssl/configuration-ec.h#L271-L273 We have a BZ to track it but afaik no dedicated folk working on it.

[edk2-devel] CryptoPkg OpensslLib TLSv1.3 support

2024-05-20 Thread eddie wang
Hi all, I have a question about the OpenSSL library in CryptoPkg. Does tlsv1.3 support exist in the current OpensslLib? If not, is there a way to make TLSV1.3 support possible? Many thanks. BR, Eddie -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-20 Thread Michael D Kinney
Merged. https://github.com/tianocore/edk2/pull/5667 Mike > -Original Message- > From: Michael Kubacki > Sent: Monday, May 20, 2024 6:41 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > Andrew Fish ; Leif Lindholm ; > Liming Gao > Cc: Feng, Bob C ; Joey Vagedes > ; Rebecca Cran ;

Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3

2024-05-20 Thread Michael Kubacki
Just wanted to send a reminder that I recommend https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for those that are currently trying to test changes. Thanks, Michael On 5/17/2024 8:10 PM, Kinney, Michael D wrote: Approved. I agree there is no impact to FW. Mike

[edk2-devel] PR Process Wiki Updates

2024-05-20 Thread Michael Kubacki
In preparation for the transition to a pull request (PR) contribution process, I've updated the TianoCore wiki. - Current official TianoCore wiki: https://github.com/tianocore/tianocore.github.io/wiki/ - My fork with proposed changes: https://github.com/makubacki/tianocore.github.io/wiki

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, May 20, 2024 #cal-notice

2024-05-20 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, May 20, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, May 20, 2024 #cal-reminder

2024-05-20 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, May 20, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, May 20, 2024 #cal-reminder

2024-05-20 Thread Sean
FYI - Since PRs are targeted to be enabled on Friday may 24th we will host this meeting today to close/align on any concerns. Look forward to seeing everyone there. thanks Sean On 5/19/2024 4:30 PM, Group Notification wrote: *Reminder: Tools, CI, Code base construction meeting series*

Re: [edk2-devel] [PATCH 0/9] Allocate and unblock variable runtime cache buffer in PEI

2024-05-20 Thread Sean
I can't find patch 1 in the series in my email so putting a few comments here.  I really hope this patch series can wait for PRs so code comments can more easily be correlated with code change. Looking at your PR with commit: Allocate Varaible cache buffer in PEI by td36 · Pull Request #5607

Re: [edk2-devel] [PATCH ovmf v3 4/5] UefiCpuPkg: Add AMD SEV-ES features support

2024-05-20 Thread Lendacky, Thomas via groups.io
On 5/2/24 09:34, Alexey Kardashevskiy wrote: CONFIDENTIAL_COMPUTING_GUEST_ATTR is not a simple SEV level anymore and includes a feature mask since a previous commit. This fixes AmdMemEncryptionAttrCheck to check the level and feature correctly and adds DebugSwap support. Since the actual

Re: [edk2-devel] [PATCH ovmf v3 3/5] OvmfPkg: Add AMD SEV-ES DebugSwap feature support

2024-05-20 Thread Lendacky, Thomas via groups.io
On 5/2/24 09:34, Alexey Kardashevskiy wrote: The SEV-ES DebugSwap feature enables type B swaping of debug registers on #VMEXIT and makes #DB and DR7 intercepts unnecessary and unwanted. When DebugSwap is enabled, this stops booting if #VC for #DB or DB7 read/write occurs as this signals

Re: [edk2-devel] [PATCH ovmf v3 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr

2024-05-20 Thread Lendacky, Thomas via groups.io
On 5/2/24 09:34, Alexey Kardashevskiy wrote: PcdConfidentialComputingGuestAttr so far only contained an SEV mode bit but there are more other features which do not translate to levels such as DebugSwap or SecureTsc. This adds the features mask and the DebugSwap feature bit to a PCD. Cc: Liming

Re: [edk2-devel] [PATCH ovmf v3 1/5] MdePkg/Register/Amd: Define all bits from MSR_SEV_STATUS_REGISTER

2024-05-20 Thread Lendacky, Thomas via groups.io
On 5/2/24 09:34, Alexey Kardashevskiy wrote: For now we need DebugSwap but others are likely to be needed too. Cc: Tom Lendacky Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Alexey Kardashevskiy A recent APM has defined a few more and has slightly different naming

Re: [edk2-devel] [PATCH] MdePkg:Update UEFI version to 2.10

2024-05-20 Thread Michael D Kinney
Have you verified that every feature from 2.10 is in edk2? That includes both the include file content as well as all the Library/module implementations. A platform can always update this version value in their tables if the platform is using a subset of features that are all 2.10 conformant.

Re: [edk2-devel] [edk2-platforms RESEND v2 3/5] AmdMinBoardPkg: Implement BoardInitLib for PEI phase

2024-05-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, May 20, 2024 9:50 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; Grimes, Paul > Subject:

[edk2-devel] [edk2-platforms RESEND v2 3/5] AmdMinBoardPkg: Implement BoardInitLib for PEI phase

2024-05-20 Thread Abdul Lateef Attar via groups.io
PeiBoardInitPreMemLib library provides board-specific initialization functions for the PEI phase. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 + .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 5 +

Re: [edk2-devel] [edk2-platforms] AmdPlatformPkg: Adds SmbiosCommonDxe driver

2024-05-20 Thread Chang, Abner via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] Already reviewed internally. Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Monday, May 20, 2024 6:24 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ;

[edk2-devel] [edk2-platforms] AmdPlatformPkg: Adds SmbiosCommonDxe driver

2024-05-20 Thread Abdul Lateef Attar via groups.io
Adds SMBIOS common driver which generates various tables for AMD platforms. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 63 - .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 3 +-

[edk2-devel] [edk2-platforms PATCH v2 3/5] AmdMinBoardPkg: Implement BoardInitLib for PEI phase

2024-05-20 Thread Abdul Lateef Attar via groups.io
PeiBoardInitPreMemLib library provides board-specific initialization functions for the PEI phase. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 + .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 5 +

[edk2-devel] [edk2-platforms PATCH v2 0/5] Adds AMD board independent drivers/modules

2024-05-20 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2-platforms/pull/144 V2 delta changes: Updated the "AmdMinBoardPkg: Implement BoardInitLib for PEI phase" PATCH with correct .dec and .dsc file. Cc: Paul Grimes Cc: Abner Chang Abdul Lateef Attar (5): AmdMinBoardPkg: Uncrustify PciHotPlug module

Re: [edk2-devel] [PATCH 02/18] OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe

2024-05-20 Thread Ard Biesheuvel
On Fri, 10 May 2024 at 12:08, Dun Tan wrote: > > Save MTRR by lockbox in CpuS3DataDxe. In S3 boot, > The MTRR setting will be restored in S3Resume.c > in following patches. Then S3Resume.c will wakeup > all APs to load the MTRR setting. This can avoid > waking up APs in CpuS3.c. > >

Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

2024-05-20 Thread Du Lin
Thanks for the review and approval. Could you please help merge this patch to the upstream? A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5644. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [PATCH 0/9] Allocate and unblock variable runtime cache buffer in PEI

2024-05-20 Thread duntan
Hi Liming, I haven't created a Bugzilla for this change. Is a bugzila needed for this patch set? I can create one if needed. Thanks, Dun -Original Message- From: gaoliming Sent: Monday, May 20, 2024 9:41 AM To: devel@edk2.groups.io; Tan, Dun Cc: Ni, Ray ; Wu, Jiaxin ; 'Ard

Re: [edk2-devel] [PATCH 7/9] MdeModulePkg:Consume gEdkiiVariableRuntimeCacheInfoHobGuid

2024-05-20 Thread Ni, Ray
Kun, Good to know that you have no concerns on the patch. The patch set aims to finalize the unblock memory regions before standalone MM env is launched. The PeiNotifyPpi() can still notify the PPI callback when the PPI has been installed already. Thanks, Ray

Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver

2024-05-20 Thread Ni, Ray
Following 3 patches still require the Reviewed-by from package maintainers of MdeModulePkg and OvmfPkg. MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE The patch set is a good move to

Re: [edk2-devel] [PATCH 0/9] Allocate and unblock variable runtime cache buffer in PEI

2024-05-20 Thread Ni, Ray
I remember ARM platform could have a PEI-less design so that SEC directly invokes DXE. So I can imagine that a SEC logic to create the VARIABLE_RUNTIME_CACHE_INFO HOB. Then it comes to how to calculate the size before bios boots. I think it's doable. There are 3 caches. Volatile cache size is