Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi

2024-05-28 Thread Li, Zhihao
Issue description: 1. PeiCore only migrates Fsp-M in dispatch mode and doesn't migrate Fsp-T and Fsp-M in Api mode. 2. Fsp-T and Fsp-M will be measured in post-mem PEI and the measurement uses original addresses. RootCause: PeiCore only migrates installed FVs and Fsp-T/M may not be installed.

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, May 29, 2024 #cal-reminder

2024-05-28 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Wednesday, May 29, 2024 5:30pm to 6:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] GitHub PR Code Review process now active

2024-05-28 Thread Michael D Kinney
Hello, The GitHub PR code review process is now active. Please use the new PR based code review process for all new submissions starting today. * The Wiki has been updated with the process changes. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Big

Re: [edk2-devel] PR Process Wiki Updates

2024-05-28 Thread Michael D Kinney
Hi Michael, Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 23, 2024 1:55 PM > To: Michael Kubacki ; devel@edk2.groups.io; > r...@edk2.groups.io > Cc: quic_llind...@quicinc.com; af...@apple.com; Kinney, Michael D > > Subject:

[edk2-devel] [PATCH 1/1] EmulatorPkg: fix build error.

2024-05-28 Thread Gerd Hoffmann
GasketSecSetTime is EMU_SET_TIME and returns EFI_STATUS. Fix the declaration accordingly. Fixes build error with gcc 14. /home/kraxel/projects/edk2/EmulatorPkg/Unix/Host/EmuThunk.c:429:3: error: initialization of ‘EFI_STATUS (__attribute__((ms_abi)) *)(EFI_TIME *)’ {aka ‘long long

Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] SbsaQemu: support multiple PCI Express buses

2024-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2024 at 12:31, Marcin Juszkiewicz wrote: > > QEMU allows to have NUMA setup where each node has own cpus, memory and > i/o. We already handle cpus and memory. This patchset adds support for > having multiple PCI Express buses. > > SbsaQemu assumed that there is only bus 0. First

[edk2-devel] [edk2-platforms 2/3] AmdPlatformPkg: Implements SmmCorePlatformHookLib library

2024-05-28 Thread Abdul Lateef Attar via groups.io
Implements SmmCorePlatformHookLib library for AMD platform. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 5 + .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc | 6 + .../Library/AmdSmmCorePlatformHookLib.h | 68

[edk2-devel] [edk2-platforms 3/3] AmdPlatformPkg: Adds SPI smm core platform hook

2024-05-28 Thread Abdul Lateef Attar via groups.io
Register a smm core platform hook handler for SPI device, using AMD SmmCorePlatformHookLib library. This platform hook saves the SPI host controller state. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec | 3 +

[edk2-devel] [edk2-platforms 1/3] AmdPlatformPkg: Removes unused gBoardBdsBootFromDevicePathProtocolGuid

2024-05-28 Thread Abdul Lateef Attar via groups.io
Removes unused gBoardBdsBootFromDevicePathProtocolGuid protocol, and its corresponding code changes. Adds missing Pcd/SmbiosPcd.h file. Cc: Abner Chang Cc: Paul Grimes Signed-off-by: Abdul Lateef Attar --- .../AmdPlatformPkg/Include/Pcd/SmbiosPcd.h| 58

[edk2-devel] [edk2-platforms 0/3] AmdPlatformPkg: SmbiosDxe and SPI supporting libraries

2024-05-28 Thread Abdul Lateef Attar via groups.io
PR: https://github.com/tianocore/edk2-platforms/pull/148 Fix the build failure for SmbiosDxe driver by removing unused protocol. Adds PCD defines for smbios. Adds SPI supporting libraries. Cc: Abner Chang Cc: Paul Grimes Abdul Lateef Attar (3): AmdPlatformPkg: Removes unused

[edk2-devel] [PATCH edk2-platforms v2 0/3] SbsaQemu: support multiple PCI Express buses

2024-05-28 Thread Marcin Juszkiewicz
QEMU allows to have NUMA setup where each node has own cpus, memory and i/o. We already handle cpus and memory. This patchset adds support for having multiple PCI Express buses. SbsaQemu assumed that there is only bus 0. First patch does PCIe bus scan to find all host bridges (bus 0 one and

[edk2-devel] [PATCH edk2-platforms v2 3/3] SbsaQemu: generate MCFG table

2024-05-28 Thread Marcin Juszkiewicz
We want to have dynaminc PCI Express variables. Which forces us to generate MCFG from C code. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 - .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c| 83

[edk2-devel] [PATCH edk2-platforms v2 2/3] SbsaQemu: describe PCIe buses in SSDT tables

2024-05-28 Thread Marcin Juszkiewicz
We can have more than one PCI Express bus. So instead of having static description in DSDT we create SSDT table for each existing PCIe bus. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 + .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |

[edk2-devel] [PATCH edk2-platforms v2 1/3] SbsaQemu: scan for PCIe buses

2024-05-28 Thread Marcin Juszkiewicz
SbsaQemu assumes that there is only one PCI Express bus. But there can be multiple PCIe buses as NUMA systems can get 'pxb-pcie' HostBridge devices added. Let scan for all PCIe buses and report them back so EDK2 will be able to find all expansions. Signed-off-by: Marcin Juszkiewicz ---

Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

2024-05-28 Thread duntan
Liming, Sure, I think we can remove the field. Could you please add your reviewed-by for this patch? Thanks, Dun -Original Message- From: gaoliming Sent: Tuesday, May 28, 2024 5:39 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; Wang, Jian J Subject: 回复: [edk2-devel] [Patch V2

[edk2-devel] 回复: [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi

2024-05-28 Thread gaoliming via groups.io
Zhihao: Could you explain the situation that FSP-T/M is not migrated by PeiCore? Thanks Liming > -邮件原件- > 发件人: Zhihao Li > 发送时间: 2024年4月29日 11:20 > 收件人: devel@edk2.groups.io > 抄送: Chasel Chiu ; Nate DeSimone > ; Duggapu Chinni B > ; Chen Gang C ; Liming > Gao > 主题: [PATCH v1 1/2]

回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

2024-05-28 Thread gaoliming via groups.io
Dun: If you confirm that there is no impact on the existing module, you can remove it. Thanks Liming > -邮件原件- > 发件人: Tan, Dun > 发送时间: 2024年5月28日 17:34 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Ni, Ray ; Wang, Jian J > 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove

Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

2024-05-28 Thread duntan
Hi Liming, Sorry I didn't get what the code needs to be compatible with. Could you please explain more? The MpService2Ppi field was added in " MdeModulePkg: add MpService2Ppi field in SMM_S3_RESUME_STATE"( b1955cddb2) last year by me. Previously It was added to simplify the code logic to

回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

2024-05-28 Thread gaoliming via groups.io
Dun: To be compatible, I suggest to keep the same layout of SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not used any more. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 duntan > 发送时间: 2024年5月28日 14:35 > 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao > >

回复: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid

2024-05-28 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 duntan > 发送时间: 2024年5月28日 14:37 > 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao > > 抄送: Ni, Ray ; Wu, Jiaxin > 主题: Re: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add > gEdkiiS3MtrrSettingGuid > > Hi Liming, > >

Re: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid

2024-05-28 Thread duntan
Hi Liming, Could you please help to review this patch? This patch set is to simplify the X86 CPU SMM driver by removing most of S3 related logics and we want to merge it as soon as possible. Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday,

Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

2024-05-28 Thread duntan
Hi Liming, Could you please help to review this patch? This patch set is to simplify the X86 CPU SMM driver by removing most of S3 related logics and we want to merge it as soon as possible. Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday,