[edk2-devel] github impact:breaking-change

2024-07-08 Thread Leif Lindholm
Hi, I'm seeing something in several PRs in flight (and merged) that have "impact:breaking-change" set, where the purpose of the PR is to fix said breakage, not introduce API compatibilities. Am I correct in my understanding that this is not the intended use, and if so how do we address the m

Re: [edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 8, 2024 #cal-reminder

2024-07-08 Thread Sean
Just confirming this meeting will happen today. Discussion here: Tools and CI Meeting - Date 7/1 & 7/8 · tianocore/edk2 · Discussion #5843 (github.com) Thanks Sean On 7/7/2024 4:30 PM, Group Notification wrote: *Reminder: Tools, CI, C

[edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

2024-07-08 Thread Rebecca Cran
I noticed that RedfishPlatformConfigDxe prints an error message that it can't find EFI_REGULAR_EXPRESSION_PROTOCOL. Should the following change be made to make sure RegularExpressionDxe is loaded before RedfishPlatformConfigDxe? diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatfor

[edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-08 Thread Rohit Mathew
This series adds the following * definitions corresponding to MPAM ACPI 2.0 specification. * MPAM parser An MPAM ACPI table formulated using the newly added MPAM ACPI definitions were validated on the linux kernel tree at [1]. The same table was parsed via acpiview using the newly added parser. C

[edk2-devel] [PATCH V6 1/6] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2024-07-08 Thread Rohit Mathew
Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhiguang Liu Acked-by: Liming Gao Reviewed-by: Pierre Gondois Reviewed-by: Sa

[edk2-devel] [PATCH V6 2/6] ShellPkg/AcpiView: Update field-validator prototype

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew As of now, the field-validator implemented by FNPTR_FIELD_VALIDATOR function pointer takes two parameters, the pointer to the field and a context pointer. For cases where the validator has to have access to the length of the field, there is no clean way to currently do it. In o

[edk2-devel] [PATCH V6 3/6] ShellPkg/AcpiView: Update print-formatter prototype

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew As of now, the print-formatter implemented by the FNPTR_PRINT_FORMATTER function pointer takes two parameters, the format string and the pointer to the field. For cases where the print-formatter has to have access to the length of the field, there is no clean way to currently d

[edk2-devel] [PATCH V6 4/6] ShellPkg: acpiview: Add routine to print 16 chars

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: T

[edk2-devel] [PATCH V6 5/6] ShellPkg: acpiview: Add routines to print reserved fields

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew Most of the ACPI tables have fields that are marked reserved. Implement functions "DumpReserved" and "DumpReservedBits" aligning with the print-formatter prototype to print out reserved fields. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abraham

[edk2-devel] [PATCH V6 6/6] ShellPkg/AcpiView: Add MPAM Parser

2024-07-08 Thread Rohit Mathew
From: Rohit Mathew Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew Cc:

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, July 8, 2024 #cal-reminder

2024-07-08 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, July 8, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f98

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, July 8, 2024 #cal-notice

2024-07-08 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, July 8, 2024 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-4

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

2024-07-08 Thread Nickle Wang via groups.io
> Should the following change be made to make sure RegularExpressionDxe is > loaded before RedfishPlatformConfigDxe? It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigDxe because EfiCreateProtocolNotifyEvent() is used to get Regular expression protocol. And I don't have obj