Re: [edk2-devel] Proposing v3 of MM communicate buffer

2024-08-08 Thread Kun Qin via groups.io
Hi Ray, Thanks for your feedback. The ARM platforms I was exposed to have consistent operation mode is only AARCH64, so this proposal is not particularly attached to any ARM problem. I agree that 32bit PEI/DXE communicate into MM will have issue on x86 platforms as of today. But I have only he

[edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-08 Thread Ming Huang
It is better to output error address information When Address is invalid before ASSERT. Signed-off-by: Ming Huang --- MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 24 1 file changed, 24 insertions(+) diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLib.c b/MdePkg/Library/Ba

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-08 Thread Chang, Abner via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] No problem. You can add the tag on subject like Silicon/Ampere or something else distinguishable next time. 😊 Thanks Abner > -Original Message- > From: Nhi Pham > Sent: Friday, August 9, 2024 11:05 AM > To: Chang, Abner ; devel@

Re: [edk2-devel] Proposing v3 of MM communicate buffer

2024-08-08 Thread Ni, Ray
Kun, thanks for explaining that ARM does not require this. IMO, the proposal is only useful in X86 when: * BIOS uses standalone MM * BIOS launches standalone MM in PEI * BIOS PEI runs in 32bit mode I do not see any such platform in open source as the X86 standalone MM is not available yet in edk

[edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg/FlashFvbDxe: Sync up NVRAM FV with NVRAM cached

2024-08-08 Thread Nhi Pham via groups.io
From: Tam Chi Nguyen Currently, the NVRAM FV region is only updated once at FlashPei that makes the data in NVRAM FV outdated with data in NVRAM region in SPI-NOR. It causes the duplication of the valid NV variables when the Variable Reclaim process performs. Consequently, after rebooting, system

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-08 Thread Nhi Pham via groups.io
Sure, it appears the patch subject makes you confused. Regards, Nhi On 8/9/2024 9:44 AM, Chang, Abner wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, Just realize this patch is not for ManageabilityPkg when I go through the patch, I will leave this to the owner. Als

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

2024-08-08 Thread Chang, Abner via groups.io
[AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, Just realize this patch is not for ManageabilityPkg when I go through the patch, I will leave this to the owner. Also, I shouldn't suggest you to create PR as I am not the owner, sorry about this. Thanks Abner From: Nhi Pham OS

Re: [edk2-devel] [PATCH edk2-platforms 0/3] SbsaQemu: Move from ArmSmcLib to ArmMonitorLib

2024-08-08 Thread Marcin Juszkiewicz
On 8.08.2024 18:51, Leif Lindholm via groups.io wrote: During last weeks Ard updated ArmMonitorLib to current SMCCC specification. This allows to use 18 registers as both arguments and return values. We already have one SMC call with 5 return values (GetCpuTopology) so let move all calls to use

Re: [edk2-devel] [PATCH edk2-platforms 0/3] SbsaQemu: Move from ArmSmcLib to ArmMonitorLib

2024-08-08 Thread Leif Lindholm
+ .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 57 +++-- .../SbsaQemuHardwareInfoLib.c | 132 ++-- 5 files changed, 145 insertions(+), 87 deletions(-) --- base-commit: a8344967ba17584c13620a639fb24990be020878 change-id: 20240808-move-from-armsmclib-to

[edk2-devel] [PATCH edk2-platforms 3/3] SbsaQemu: drop not needed packages

2024-08-08 Thread Marcin Juszkiewicz
SbsaQemuPlatformDxe does not need ArmVirtPkg and EmbeddedPkg. SbsaHardwareInfoLib does not need EmbeddedPkg. Signed-off-by: Marcin Juszkiewicz --- .../Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf | 2 -- .../Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.inf

[edk2-devel] [PATCH edk2-platforms 2/3] SbsaQemu: move from ArmSmcLib to ArmMonitorLib

2024-08-08 Thread Marcin Juszkiewicz
ArmMonitorLib allows to use 18 registers are both arguments and results. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemuHardwareInfoLib.inf | 2 +- .../SbsaQemuHardwareInfoLib.c| 75 ++-- 2 files changed, 37 insertions(+), 40 delet

[edk2-devel] [PATCH edk2-platforms 1/3] SbsaQemu: move SMC calls to HardwareInfoLib

2024-08-08 Thread Marcin Juszkiewicz
We now have HardwareInfo library so let move all hardware queries there. Signed-off-by: Marcin Juszkiewicz --- .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf | 2 +- .../SbsaQemuHardwareInfoLib.inf | 5 ++ .../Qemu/SbsaQemu/Include/Library/HardwareInfoLib.h | 31 +++

[edk2-devel] [PATCH edk2-platforms 0/3] SbsaQemu: Move from ArmSmcLib to ArmMonitorLib

2024-08-08 Thread Marcin Juszkiewicz
| 132 ++-- 5 files changed, 145 insertions(+), 87 deletions(-) --- base-commit: a8344967ba17584c13620a639fb24990be020878 change-id: 20240808-move-from-armsmclib-to-armmonitorlib-7ce6c2456c95 Best regards, -- Marcin Juszkiewicz -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegion v3.2

2024-08-08 Thread Ck, Chitralekha
- Backlight related fields in MBOX2 has uncalibrated brightness support - Valid Bit added for BCL in MBOX2. Signed-off-by: Ck, Chitralekha Cc: Rangasai V Chaganty Cc: Ashraf Ali S Cc: Ray Ni --- .../Include/IndustryStandard/IgdOpRegion32.h | 59 +++ test.log

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Add GD25LB512ME nor flash info

2024-08-08 Thread Jingyu Li
From: Jingyu Li Add GigaDevice GD25LB512ME definition to NorFlashInfoLib. Cc: Leif Lindholm Signed-off-by: Jingyu Li --- EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.c b/EmbeddedP

Re: [edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Add HobPrintLib in StandaloneMm

2024-08-08 Thread PierreGondois
Hello Levi, NIT: I think it's commit 049e12c03d27 ("StandaloneMmPkg/Core: Dump all HOB info in entrypoint") which breaks the build (whenever StandaloneMmPkg/Core/StandaloneMmCore.inf is used). The following platforms should have the same modification I think: - Platform/Socionext/DeveloperBox/D

Re: [edk2-devel] Proposing v3 of MM communicate buffer

2024-08-08 Thread Ni, Ray
Kun, I like your proposed solution as it is backward compatible. But, I think the new PPI/Protocol is only useful when the CPU mode where PPI/Protocol is produced does not match the CPU mode in MM. In X86, it could be: 32bit PEI + 64bit MM, 32bit DXE + 64bit MM, or vice versa. But I doubt the v