Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts: Add package dependency graphing tool

2019-12-16 Thread Sean via Groups.Io
Mike/Steven/Ray, We have had a tool for a couple of years with similar functionality. It is a python tool you run on your code base and it creates a single (local) webpage that you can then use to build charts. Please give it a try and see if you think it is useful. Here is the tool. https://

Re: [edk2-devel] Instructions for running EDK2 CI on an Ubuntu system? ("System.TypeLoadException: Failure has occurred while loading a type.")

2019-12-17 Thread Sean via Groups.Io
Sorry Rebecca for the slow reply. We have identified the issue and will be adding some minor documentation to pytool docs to help. In short, nuget relies on new versions of mono.  Mono is not getting updated in linux distro maintained packages as fast as needed. This resolved the issue for our

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-01-06 Thread Sean via Groups.Io
On Mon, Jan 6, 2020 at 10:43 AM, Vitaly Cheptsov wrote: > > My original suggestion was to remove the assertions entirely, but several > people here said that they use them to verify usage errors when handling > trusted data. This makes good sense to me, so we suggest to support both > cases by in

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

2020-01-06 Thread Sean via Groups.Io
Thomas, Are you able to share the Clang-format file?  I would like to get a format file as close to edk2 style as possible and then see if we can move the community to auto formatted code.  This could then be easily enforced by a PR gate that requires all modified/new files to conform to auto f

Re: [edk2-devel] [Patch 01/11] .pytool: Add CI support for host based unit tests with results

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53489): https://edk2.groups.io/g/devel/message/53489 Mute This Topic: https://groups.io/mt/70061160/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 00/11] Add Unit Test Framework

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53488): https://edk2.groups.io/g/devel/message/53488 Mute This Topic: https://groups.io/mt/70061159/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 02/11] BaseTools/Plugin: Add HostBasedUnitTestRunner plugin

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53490): https://edk2.groups.io/g/devel/message/53490 Mute This Topic: https://groups.io/mt/70061161/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 03/11] MdePkg/Include/Library: Add UnitTestLib class

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53491): https://edk2.groups.io/g/devel/message/53491 Mute This Topic: https://groups.io/mt/70061162/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 04/11] UnitTestFrameworkPkg: Add public and private interfaces

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53492): https://edk2.groups.io/g/devel/message/53492 Mute This Topic: https://groups.io/mt/70061163/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 06/11] UnitTestFrameworkPkg/Test: Add unit test samples

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53494): https://edk2.groups.io/g/devel/message/53494 Mute This Topic: https://groups.io/mt/70061165/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 05/11] UnitTestFrameworkPkg/Library: Add library instances

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53493): https://edk2.groups.io/g/devel/message/53493 Mute This Topic: https://groups.io/mt/70061164/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 10/11] .azurepipelines: Enable CI for UnitTestFrameworkPkg and host tests

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53498): https://edk2.groups.io/g/devel/message/53498 Mute This Topic: https://groups.io/mt/70061170/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 07/11] UnitTestFrameworkPkg: Add DSC, DSC INC, and YAML files

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53495): https://edk2.groups.io/g/devel/message/53495 Mute This Topic: https://groups.io/mt/70061167/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 09/11] MdeModulePkg: Add DxeResetSystemLib unit test

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53497): https://edk2.groups.io/g/devel/message/53497 Mute This Topic: https://groups.io/mt/70061169/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 08/11] MdePkg/Test: Add SafeIntLib and BaseLib Base64 unit tests

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53496): https://edk2.groups.io/g/devel/message/53496 Mute This Topic: https://groups.io/mt/70061168/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch 11/11] Maintainers.txt: Add UnitTestFrameworkPkg

2020-01-27 Thread brbarkel via Groups.Io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53499): https://edk2.groups.io/g/devel/message/53499 Mute This Topic: https://groups.io/mt/70061171/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

2020-01-31 Thread Sean via Groups.Io
Mike, The hardcoded vs paths are not a safe assumption. I would rather see agreement of how the environment should be configured prior to calling edk2 build and if being capable of building host os specific binaries is the requirement then that should be clarified and the scripts can be updated.

Re: [edk2-devel] [PATCH v1 02/15] StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core

2021-03-24 Thread Dawn via groups.io
Importing spamReporting Tracking successful  On Fri, Mar 12, 2021 at 4:46 AM, Yao, Jiewen wrote: Can we merge the common part between X64 and AArch64 into one Common.c? > -Original Message- > From: Kun Qin > Sent: Saturday, December 19, 2020 2:50 AM > To: devel@edk2.groups.io > Cc: A

Re: [edk2-devel] [PATCH v1 03/12] ArmPkg: Add missing library headers to ArmPkg.dec

2021-04-21 Thread brbarkel via groups.io
1) To expedite the required reviews, you may want to add CC to the package maintainers for ArmPkg to this commit message and email. I know a lot of people filter based on direct mention vs mailing list. 2) Generally, other packages have a brief description of the lib in the DEC, as well. Exampl

Re: [edk2-devel] [PATCH v1 04/12] ArmPkg: Add OemMiscLibNull library to ArmPkg.dsc

2021-04-21 Thread brbarkel via groups.io
Same comment about CC to the package maintainers. Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74341): https://edk2.groups.io/g/devel/message/74341 Mute This Topic: https://groups.io/mt/82258505/21656 Group

Re: [edk2-devel] [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-26 Thread Sean via Groups.Io
So even though the scope for right now is to build the package only, since these are platforms I think they would better align with a platform build pipeline rather than the stuart_ci_build pipeline. Basically we would setup a new pipeline that builds each platform. To start they can just bui

[edk2-devel] Initial PXE boot over IPv6

2020-03-27 Thread per_sundstrom via Groups.Io
Hi, I want to exclusively use PXE/IPv6 when deploying a set of physical machines with some QEMU/KVM virtual machines on top. So far, the only [hacky] way I have managed to do this is to: 1) Bring up a VM with OVMF 2) Set the wanted boot-order with PXE over IPv6 at the top 3) Save this to the NVRA

Re: [edk2-devel] Initial PXE boot over IPv6

2020-03-27 Thread per_sundstrom via Groups.Io
Thanks for the quick reply. I sort of suspected that it was compiled in :-( How hard would it be to have it configured through fw_cfg ? We are on a supported distro and are not allowed homebrewed binaries. And, [more importantly] are there any other ways of persuading OVMF to boot from IPv6 with

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Sean via Groups.Io
There are two parts of this I think should be discussed. 1. Core-Ci for emulator, ovmf, armvirt packages. a. I think there is some value here for those package maintainers.  The core ci does spell checks, char encoding checks, lib class declaration, etc.  Those seem valuable to help keep the pack

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-27 Thread Sean via Groups.Io
"Stuart" gives the system a lot of structure and flexibility.  It lets us maintain the build process consistently in a cross platform way and allows platforms to use python instead of shell scripting.  This takes advantage of our investments in dependency management, optimized submodule manageme

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-28 Thread Sean via Groups.Io
Added support for EmulatorPkg running to UEFI shell. Segmentation fault on GCC / Ubuntu x64.  Works on Windows. Could very easily be user error. https://bugzilla.tianocore.org/show_bug.cgi?id=2639 Laszlo - can you point me to any docs, scripts, examples of how i would do the same thing with OVMF

Re: [edk2-devel] [EXTERNAL] [edk2-devel] Information about the VMs used to do EDK2 CI?

2020-03-28 Thread Sean via Groups.Io
Thanks I opened a bug to get this tracked. https://bugzilla.tianocore.org/show_bug.cgi?id=2640 In that bug i link to a commit which does the above using python.  It saves about 20 seconds for each build on linux in Azure pipelines. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You recei

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-28 Thread Sean via Groups.Io
Ard, I agree.  How would we do this with AARCH64?  I don't believe azure devops pipelines has a native AARCH64 platform available.  I briefly looked over ArmVirtPkg but not sure where to start. OVMF readme only talks about ia32/x64.  I could also see a scenario for a self hosted agent that is aa

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-29 Thread Sean via Groups.Io
Ard/Laszlo or anyone familiar with QEMU. I read up on the ovmf readme and the qemu wiki but still have a few issues i am hoping for quick/easy answers. 1. How do i programmatically exit the emulator.   Seems like uefi shell > reset just reboots.  Other ideas? 2. Is there an easy way to map a lo

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
Thanks.  I was missing the "-s" and Andrew you solution worked for the filesystem. OVMF: Windows builds and Linux builds and boot to shell. IA32, X64 and IA32x64 - https://dev.azure.com/tianocore/edk2-ci-play/_build/results?buildId=4950&view=results Emulator: Windows and linux builds and boots

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 02:36 AM, Ard Biesheuvel wrote: > > It should be trivial to extend this to ARM, using TCG emulation. > > One question though: what happens if the boot does not make it to the > shell, and crashes for some reason? The QEMU process will hang, so I'd > assume some kind of ti

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 10:04 AM, Ard Biesheuvel wrote: > > Is there any way I could contribute ArmVirtQemu to this? Or would it > be easier if I provided comments/instructions? Either way. Any instructions you provide would be great.  I was going to hack something up for feedback but happy for

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 10:44 AM, Ard Biesheuvel wrote: > > Thanks. But can I get these actions to trigger from my branch as well? > Or do I need special powers for that? Right now it requires manually running so it requires "special powers". :) I am happy to get this into a branch that you can

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
Laszlo/Ard - I have cleaned up git history and pushed to https://github.com/spbrogan/edk2 master. If you want you can create a PR against that branch and it should kick OVMF, Emulator, and ArmVirt to build and run. Looking for feedback. @Laszlo - I followed Ard's parameters but feel free to m

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
@Rebecca - Agree.  I need to package up a newer version.  I have treated this as lower priority.  Is there a feature you need or just best practices on keeping current? @Ard - Padding in python is easy.  I just need to understand the requirements. @Mike - I would like to get to read/write filesys

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-30 Thread Sean via Groups.Io
@Ard - pflash change: https://github.com/spbrogan/edk2/pull/12 Logging change - I actually switched OVMF to use stdio since the log is captured either way and now it shows up in the web log output. https://github.com/spbrogan/edk2/pull/13 Do you have instructions for the cmdline for Qemu for Ar

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Sean via Groups.Io
A couple of thoughts. 1. I would suggest that ASSERT should not be the only protection for an invalid operation as ASSERT is usually disabled on release builds. 2. We do have a library to make this more explicit and common. https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/Safe

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-03-31 Thread Sean via Groups.Io
On Mon, Mar 30, 2020 at 11:41 PM, Ard Biesheuvel wrote: > > Not sure I follow. Which command line are we talking about? @Ard - In this Platform CI, ArmVirt is building and running AARCH64 but not ARM 32bit.  Would it be valuable to build for ARM too? I prototyped it but want to make sure I am

Re: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast

2020-03-31 Thread Sean via Groups.Io
I agree that safeintlib is not doing anything too interesting in this case but that's not really the point.  The argument for it is that it becomes the central point of code to check for safe conversions and an indicator that the developer was thoughtful about this conversion and didn't just cas

Re: [edk2-devel] [PATCH] CryptoPkg/FltUsedLib: Add FltUsedLib for float.

2020-03-31 Thread Sean via Groups.Io
Does anyone know off hand if defining this and enabling floating point has any negative side effects if you don't need it?  Size? Optimization? Other?   That is my only concern for enabling in all modules which is why the initial proposal was for a new library. -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] How to add ignore "IgnoreFiles" for CharEncodingCheck

2020-03-31 Thread Sean via Groups.Io
On Tue, Mar 31, 2020 at 08:52 AM, Zhang, Shenglei wrote: > > > > "CharEncodingCheck": { > > > > "IgnoreFiles": > [[(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c),(MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c)] > > > > > } > > This syntax

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-02 Thread Sean via groups.io
I am not a fan of this.  The community and design meetings have had a few discussions about tools (PyTools has been presented twice) and a few brief discussions about common patterns to build platforms but I don't think there is real alignment.  Each "platform" has its own way of doing things.

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Sean via groups.io
I would have much rather seen this implemented independent of the GenFds tool as this is a nice feature but shouldn't be tightly coupled into the tool that does building and packaging firmware. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onli

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Sean via groups.io
Not sure I follow.  The changes are in BaseTools/Source/Python/GenFds/GenFds.py I am suggesting this functionality to be written outside the GenFds.py files so that we don't add complexity to the critical tools used for building and packaging FW binaries. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

2020-04-04 Thread Sean via groups.io
Platform and Core CI patches are ready for review.  I have 14 commits here. https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages This adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and EmulatorPkg. Each readme has live status and links to the builds as wel

Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment

2020-04-06 Thread Sean via groups.io
Bob and Ray, My point isn't that there is anything wrong with script.  This script is designed to work with edk2-platforms repo or other repos of similar layout.    This is a "platform" thing that is needed on some platforms (not edk2 core platforms).  To me this means it does't belong in edk2 r

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

2020-04-07 Thread Sean via groups.io
Guomin, Can you speak to why you implemented differently than the suggested and validated patch?  Seems you created a local whereas ours just used the internal data member. Thanks sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/PersistenceLib: Correct the allocated size.

2020-04-07 Thread Sean via groups.io
Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57054): https://edk2.groups.io/g/devel/message/57054 Mute This Topic: https://groups.io/mt/72670002/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-09 Thread Sean via groups.io
Ard/Laszlo, On the topic of Package files. 1. The *.ci.yaml is designed to be at the root of the package and this follows all other Core ci usage.  The Core CI will only look for this file at the root as of now. 2.  The PlatformBuild.py file is exactly like a build.bat or build.sh file found in

Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-14 Thread Sean via groups.io
what do you mean "test for the adding pipelines"? The pipeline currently builds the platforms and then runs them to the shell where it has a startup.nsh which does reset -h. If the boot fails or hangs the task will timeout in 1 minute and then fail. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-14 Thread Sean via groups.io
Any thoughts?  I would like to get this in before any more failures get checked in causing more dependencies. I have a branch here: https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages_v7 but am waiting for more feedback to make V2 patchset. Thanks Sean -=-=-=-

Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-15 Thread Sean via groups.io
No local server.  I use a free devops account.  When i was standing up the original Core CI project for tianocore I created a Azure devops project here https://dev.azure.com/tianocore/edk2-ci-play In this project I can connect to my fork on github and run builds.  Anyone else could also setup th

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-15 Thread Sean via groups.io
On Wed, Apr 15, 2020 at 09:58 AM, Laszlo Ersek wrote: > > I have not ignored your email. Instead, I have not seen it. > > The reason is that you messaged the list only -- you didn't put me in > the To: or Cc: headers, despite addressing me by name in the message body. I use the groups.io web cl

Re: [edk2-devel] [PATCH v1 3/6] EmulatorPkg: Add Platform CI and configuration for Core CI

2020-04-15 Thread Sean via groups.io
Andrew/Jordan, Any thoughts? On the Ovmf and ArmVirt package they have requested the files move into a PlatformCI folder. This is a "new" pattern so I want to understand what you would like for EmulatorPkg? See thread https://edk2.groups.io/g/devel/message/57423 -=-=-=-=-=-=-=-=-=-=-=- Groups.i

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-15 Thread Sean via groups.io
On Wed, Apr 15, 2020 at 10:18 AM, Laszlo Ersek wrote: > > ArmVirtPkg/ArmVirtPkg.ci.yaml > ArmVirtPkg/PlatformCI/Ubuntu-GCC5.yml > ArmVirtPkg/PlatformCI/PlatformBuild.py > ArmVirtPkg/PlatformCI/README-pytools.md > ArmVirtPkg/PlatformCI/iasl_ext_dep.yaml I am ok with the above except one thought o

Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-15 Thread Sean via groups.io
Rebecca, Each CI framework has different syntax, capabilities, and requirements.  The PyTools environment attempts to generalize the edk2/uefi aspects of the setup, build, and test but regardless there are things that should be done as "steps" in the CI framework being targeted.  This is why th

Re: [edk2-devel] [PATCH v1 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-15 Thread Sean via groups.io
If it is a pytool general failure please open an issue here: https://github.com/tianocore/edk2-pytool-extensions/issues with details. If the PlatformBuild.py in this patchset has an issue please reply here with logs or reproducible steps. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Yo

Re: [edk2-devel] [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures

2020-04-17 Thread Sean via groups.io
Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57545): https://edk2.groups.io/g/devel/message/57545 Mute This Topic: https://groups.io/mt/72907803/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

2020-04-19 Thread Sean via groups.io
Laszlo, Regarding your comments about disliking the verbosity of the markdown table/html table for build status both in Core Ci and now these Platform CI readme files. As a learning experience I updated the OvmfPkg readme to use reStructuredText instead of markdown. Not sure if I like RST b

Re: [edk2-devel] edk2 repo for RedfishPkg

2020-04-20 Thread Sean via groups.io
also helps avoid "core" features becoming entangled or dependent on an optional features. Current UiApp would be another great example. Just my opinion. Thanks Sean From: devel@edk2.groups.io On Behalf Of Abner Chang via groups.io Sent: Monday, April 20, 2020 8:08 AM To: devel@ed

Re: [edk2-devel] FW: Discussion: Basetools a separate repo

2020-04-20 Thread Sean via groups.io
y to manage and is one of the reasons we are proposing this change. Thanks Sean -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek via groups.io Sent: Monday, April 20, 2020 5:49 AM To: Matthew Carlson Cc: devel@edk2.groups.io; ray...@intel.com; Ard Biesheuvel (ARM add

Re: [edk2-devel] [EXTERNAL] Re: [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-22 Thread Sean via groups.io
I was hoping that because it wasn't "HTML tag soup" that build status could be front and center in the package readme as I find that more in line with expectations on github based projects. Nesting it deeper in the package just means less people find it when looking at your package. But I co

Re: [EXTERNAL] [edk2-devel] EDK2 environment setup

2020-04-23 Thread Sean via groups.io
Thanks Sean From: devel@edk2.groups.io On Behalf Of Navdeeppal.Singh via groups.io Sent: Thursday, April 23, 2020 9:14 AM To: Bret Barkelew ; devel@edk2.groups.io Subject: Re: [EXTERNAL] [edk2-devel] EDK2 environment setup Hi Bret, Yes PIP requirements are up to date. On further digging thro

Re: [edk2-devel] [PATCH v2 0/6] Edk2 Platform and Core CI for ArmVirtPkg, EmulatorPkg, and OvmfPkg

2020-04-23 Thread Sean via groups.io
Thanks for providing feedback. My V10 branch is up which will be sent to the mailing list tomorrow as the V3 patch set unless there are any changes requested. This now includes a 7th patch which converts the edk2 ReadMe.md to ReadMe.rst and shows the Platform CI status. The other package Read

Re: [edk2-devel] [PATCH v1 0/2] Drop FrameworkHandle param from SaveFrameworkState()

2020-04-24 Thread brbarkel via groups.io
Reviewed-by: Bret Barkelew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58124): https://edk2.groups.io/g/devel/message/58124 Mute This Topic: https://groups.io/mt/73179709/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: http

Re: [edk2-devel] [PATCH v1 0/3] Enable RISC-V architecture for RISC-V EDK2 CI.

2020-04-24 Thread Sean via groups.io
Please run a a test PR with this patchset?  I would like to see how it impacts the build times. Patche series look fine to me. Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58126): https://edk2.groups.io/g/dev

Re: [edk2-devel] [Patch v2 07/11] UnitTestFrameworkPkg: Add DSC, DSC INC, and YAML files

2020-02-07 Thread Sean via Groups.Io
Looks great. Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54062): https://edk2.groups.io/g/devel/message/54062 Mute This Topic: https://groups.io/mt/71060085/21656 Group Owner: devel+ow...@edk2.groups.io Unsub

Re: [edk2-devel] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues

2020-02-10 Thread Sean via Groups.Io
Reviewed by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54158): https://edk2.groups.io/g/devel/message/54158 Mute This Topic: https://groups.io/mt/71145488/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https:

Re: [edk2-devel] TianoCore Community Meeting Minutes - Feb 6

2020-02-14 Thread Sean via Groups.Io
Soumya, I would like to add three things to community discussions especially around governance and process. 1. RFC: The RFC process seems to get only minimal comments and a lot gets lost in the noise of the lists.  There isn't a good "final" state where all approved RFCs can be seen.  The proce

Re: [edk2-devel] TianoCore Community Meeting Minutes - Feb 6

2020-02-14 Thread Sean via Groups.Io
On Fri, Feb 14, 2020 at 02:14 PM, Laszlo Ersek wrote: > > I think Bugzilla tickets are the best place to capture the focused > analysis of a bug. I write a *lot* of text in Red Hat bugzillas (most of > them are public, luckily!) -- I want to document my own "adventure" with > the issue, even if m

Re: [edk2-devel] TianoCore Community Meeting Minutes - March

2020-03-06 Thread Sean via Groups.Io
@edk2.groups.io On Behalf Of Soumya Guptha via Groups.Io Sent: Thursday, March 5, 2020 8:32 PM To: annou...@edk2.groups.io; devel@edk2.groups.io Cc: annou...@edk2.groups.io Subject: [EXTERNAL] [edk2-announce] TianoCore Community Meeting Minutes - March TianoCore Community Meeting Minutes March 5, 2

Re: [edk2-devel] EDK II Python development process specification -draft

2020-03-07 Thread Sean via Groups.Io
This looks fine but it seems focused on writing a new module/project.  Most python work going into edk2 is part of existing code. I would like to see additional documentation about how this applies to edk2 basetools. * A flake8 config file could be added to basetools python. * Documentation of d

Re: [edk2-devel] Running CI on FreeBSD - can't run NuGet.exe directly (need "mono NuGet.exe")

2020-03-07 Thread Sean via Groups.Io
Rebecca, If I understand you correctly we already do something like this on linux. You can see the code here: https://github.com/tianocore/edk2-pytool-extensions/blob/master/edk2toolext/environment/extdeptypes/nuget_dependency.py#L31 For better support can we move this conversation over to the p

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 6/6] .pytool: Add RISC-V architecture on RISC-V EDK2 CI.

2020-03-07 Thread Sean via Groups.Io
I never saw a patch in the series that actually added the submodule to the .gitmodules file but maybe i missed that.  If that is approved then the changes to this file look ok.  I have no idea why all the line endings are shown but the substantial changes here look fine to me. -=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 4/6] BaseTools: Enable RISC-V architecture for RISC-V EDK2 CI.

2020-03-07 Thread Sean via Groups.Io
On Tue, Mar 3, 2020 at 10:02 PM, Abner Chang wrote: > > BaseTools/Bin/gcc_riscv64_unknown_ext_dep.yaml Web extdeps can have a hash so we are sure we get the expected file.  My opinion is for edk2 extdeps we should use this feature. https://github.com/tianocore/edk2-pytool-extensions/blob/maste

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 3/6] MdeModulePkg: Revise MdeModulePkg yaml file for RISC-V EDK2 CI.

2020-03-07 Thread Sean via Groups.Io
Given that i think MdeModulePkg depending on ArmPkg is a bug that should get fixed, I don't agree with this change.  If there is an api needed for these different architectures then the definition of the API should move to Mde or MdeModulePkg. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Link

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 2/6] RiscVPkg: Add RiscVPkg yaml file for EDK2 CI.

2020-03-07 Thread Sean via Groups.Io
The options in the spellcheck object seem to be copied from a different package.  I would start with an empty set and then add in "ExtendWords" for unique and valid words in the package.  I would also suggest that for any new package we should start with the spellcheck on (not in auditonly mode)

Re: [edk2-devel] reg: Host Name Validation with Wild Card Certificate

2020-03-07 Thread Sean via Groups.Io
The name of this flag is terrible but if you read the 2.8 spec. https://uefi.org/sites/default/files/resources/UEFI_Spec_2_8_A_Feb14.pdf page 1436. Says: EFI_TLS_VERIFY_FLAG_NONE means no additional flags set for hostname validation. Wildcards are supported and they match only in the left-most lab

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2020-03-08 Thread Sean via Groups.Io
Laszlo - Added comment to your PR. @Mike Kinney (michael.d.kin...@intel.com) who has mergify permission? I tried to add comment "@Mergifyio refresh" to the PR but since I don't have "command" permission it was rejected. I am happy to look at mergify a little closer if you give me access. >Fr

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-08 Thread Sean via Groups.Io
Ard/Lazlo, I find your position on OvmfPkg, ArmVirtPkg,and edk2-platforms in edk2 to be detrimental to the overall success of the edk2 project.  The majority of edk2 consumers already have to deal with their platform not being part of the edk2 git repo and the fact that changes to edk2 may not

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-09 Thread Sean via Groups.Io
Sorry let me clarify a little more.  I don't doubt that you spending the time to validate a patch using OVMF catches issues and regressions.  I am very appreciative of that effort, my point is you could do that without being in the edk2 tree and in fact we need to enable and request that more do

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-10 Thread Sean via Groups.Io
I don't see the difference besides the mechanics of the operation (which you have described clearly).  To guarantee a repo or repos is "git-bisectable" you need to build and test every commit on your platform.  For example in the recent ArmMmuLib patchset, you were able to build every commit in

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-10 Thread Sean via Groups.Io
On Tue, Mar 10, 2020 at 10:54 AM, Ard Biesheuvel wrote: > > This means we can reasonably require any contributor not to regress on > those platforms, given how they have full access to it, and this is > actually where i would like us to take the next step when it comes to > ci automation, i.e., a

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-10 Thread Sean via Groups.Io
If I look around i don't see that documented. https://github.com/tianocore/edk2#code-contributions https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions https://github.com/tianocore/tianocore.github.io/wiki/How-To-Contribute https://github.com/tianocore/tianocore.github.io/wiki/H

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-10 Thread Sean via Groups.Io
Well time to let this one simmer a while.  I appreciate the viewpoints. For what it is worth, I am unconvinced that leaving OVMF, ArmVirt, or Emulator packages in the edk2 tree is the right choice.  I would be opposed to adding more as that would just continue the growth and noise of platforms w

Re: [edk2-devel] [EXTERNAL] [edk2-devel] Information about the VMs used to do EDK2 CI?

2020-03-21 Thread Sean via Groups.Io
Rebecca - I think for any platform testing it would make more sense to use self hosted agents.  They could even be your own VM.  QEMU and emulator might be the two where we could explore using the DevOps VMs but I worry we will spend too much time downloading and install dependencies since the V

[edk2-devel] Question about display interface (EDID)

2021-12-02 Thread renan.moraes2 via groups.io
Good Afternoon, I am trying to collect information from the display device connected to the machine. For this I'm using the EFI_EDID_PROTOCOL protocol. According to the VESA EDID spec 1.4 (pages 19 and 60), the field Video Input Definition representing the video type should look like this: But

回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-13 Thread gaoliming via groups.io
That's great. I give my reviewed-by for this patch. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Kun Qin via > groups.io > 发送时间: 2022年7月12日 5:30 > 收件人: gaoliming ; devel@edk2.groups.io; > Kinney, Michael D ; 'Albecki, Mate

回复: 回复: [edk2-devel] [PATCH] MdeModulePkg\CoreDxe: Allow DXE Drivers to use untested memory

2022-07-15 Thread gaoliming via groups.io
If no other objection, I will merge this patch next week. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Howell, Stacy > 发送时间: 2022年4月25日 22:11 > 收件人: Kinney, Michael D ; > devel@edk2.groups.io; spbro...@outlook.com; Gao, Liming > > 抄送: Bi, Dandan ; Howell, Stacy > > 主题: Re: 回复:

[edk2-devel] 回复: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way to reconnect driver

2022-07-18 Thread gaoliming via groups.io
Walon: This change looks good. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Li, Walon > 发送时间: 2022年7月18日 9:15 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: Wang, Nickle (Server BIOS) ; Li, Walon > > 主题: RE: [PATCH] MdeModulePkg/SetupBrowserDxe:Follow spec'd way

回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

2022-07-18 Thread gaoliming via groups.io
Jeff: I want to confirm why UFS apply the same rule to SCSI. Does UFS follows SCSI spec? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Jeff Brasen > via groups.io > 发送时间: 2022年6月15日 1:54 > 收件人: devel@edk2.groups.io > 抄送: jian.j.w...@intel.com; gaolim

[edk2-devel] 回复: [PATCH v3] MdeModulePkg/Include: Long debug string is truncated to 104 char

2022-07-18 Thread gaoliming via groups.io
Dandan: Good point. I suggest to also define EFI_STATUS_CODE_DATA_MAX_SIZE into the MdeModulePkg\Include\Guid\StatusCodeDataTypeDebug.h. Its value can be MAX_EXTENDED_DATA_SIZE + sizeof (EFI_STATUS_CODE_DATA) Thanks Liming > -邮件原件- > 发件人: Bi, Dandan > 发送时间: 2022年7月18日 16:38 > 收件人: Lai,

[edk2-devel] 回复: [PATCH v5] MdeModulePkg/Include: Long debug string is truncated to 104 char

2022-07-20 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Bi, Dandan > 发送时间: 2022年7月21日 9:42 > 收件人: Lai, Cosmo ; devel@edk2.groups.io > 抄送: Wang, Jian J ; Gao, Liming > > 主题: RE: [PATCH v5] MdeModulePkg/Include: Long debug string is truncated > to 104 char > > Reviewed-by: Dandan Bi > > > > Thanks,

回复: [edk2-devel] [PATCH v3] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-24 Thread gaoliming via groups.io
Jason: Thanks for you to add the detail usage model in BZ 3928. I have no other comments. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Lin, Jason1 > 发送时间: 2022年7月8日 19:42 > 收件人: devel@edk2.groups.io > 抄送: Jason1 Lin ; Bob Feng ; > Liming Gao ; Yuwei Che

回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs

2022-07-24 Thread gaoliming via groups.io
This change has been merged in edk2 master. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming via > groups.io > 发送时间: 2022年7月13日 15:48 > 收件人: devel@edk2.groups.io; kun@microsoft.com; 'Kinney, Michael D' > ; 'Albecki, Mateusz' > > 抄送

[edk2-devel] 回复: [PATCH v4 00/21] Add Raw algorithm support using Arm FW-TRNG interface

2022-07-24 Thread gaoliming via groups.io
Pierre: The change in MdePkg is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: pierre.gond...@arm.com > 发送时间: 2022年7月22日 22:32 > 收件人: devel@edk2.groups.io > 抄送: Sami Mujawar ; Leif Lindholm > ; Ard Biesheuvel ; > Rebecca Cran ; Michael D Kinney > ; Liming Gao ; > Jie

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/26/2022 #cal-reminder

2022-07-26 Thread gaoliming via groups.io
Few issues are reported this week. Let’s cancel the meeting. Thanks Liming 发件人: devel@edk2.groups.io 代表 Group Notification 发送时间: 2022年7月26日 9:30 收件人: devel@edk2.groups.io 主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/26/2022 #cal-reminder Reminder: TianoCore Bug Triag

[edk2-devel] 回复: [PATCH v1 3/5] MdeModulePkg: Fix imbalanced debug macros

2022-08-04 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: mikub...@linux.microsoft.com > 发送时间: 2022年8月3日 2:04 > 收件人: devel@edk2.groups.io > 抄送: Dandan Bi ; Guomin Jiang > ; Hao A Wu ; Jian J Wang > ; Liming Gao ; Ray Ni > > 主题: [PATCH v1 3/5] MdeModulePkg: Fix imbalanced debug macros > > From: Michael K

回复: [edk2-devel] [PATCH] MdePkg/UefiDevicePathLib: reback the DevicePathUtilitiesStandaloneMm

2022-08-04 Thread gaoliming via groups.io
Yanbo: Previous change has been reviewed and merged. Please see the detail https://edk2.groups.io/g/devel/message/91799 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Huang, Yanbo > 发送时间: 2022年8月5日 10:42 > 收件人: devel@edk2.groups.io > 抄送: Yanbo Huang ; Michael D Kinney > ; Liming

回复: [edk2-devel] [PATCH] MdeModulePkg/DumpDynPcd: Remove unsupported format specifiers

2022-08-04 Thread gaoliming via groups.io
Thanks for your update. This change is good to me. Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Konstantin > Aladyshev > 发送时间: 2022年7月27日 16:45 > 收件人: devel@edk2.groups.io > 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; > dandan...@intel.com; shenglei.zh...@inte

<    2   3   4   5   6   7   8   9   10   11   >