Reviewed-by: Prince Agyeman
Prince
-Original Message-
From: devel@edk2.groups.io On Behalf Of Desimone,
Nathaniel L
Sent: Tuesday, November 2, 2021 3:07 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Leif Lindholm
; Kinney, Michael D
Subject: [edk2-devel] [PATCH v1
Reviewed-by: Prince Agyeman
-Original Message-
From: Zhang, Shenglei
Sent: Tuesday, July 28, 2020 8:34 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince
Subject: [PATCH] SimicsOpenBoardPkg: Update usage of functions to be removed
REF:https://bugzilla.tianocore.org/show_bug.cgi?id
Reviewed-by: Prince Agyeman
-Original Message-
From: Tan, Ming
Sent: Tuesday, June 9, 2020 4:24 AM
To: devel@edk2.groups.io
Cc: Agyeman, Prince
Subject: [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type about
status code
REF: https://bugzilla.tianocore.org
+ Ray and Hao who are the MdeModulePkg/Bus/ maintainers
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Thursday, May 28, 2020 1:28 AM
To: devel@edk2.groups.io; tiger...@zhaoxin.com; Agyeman, Prince
Subject: Re: [edk2-devel] IsaBus driver's usage
+Agyeman Prince
On 5/28
Reviewed-by: Prince Agyeman
-Original Message-
From: Desimone, Ashley E
Sent: Tuesday, May 12, 2020 11:45 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update
Hi Ashley,
Comment below
Prince
-Original Message-
From: Desimone, Ashley E
Sent: Wednesday, April 22, 2020 2:35 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH V2 2/3
Reviewed-by: Prince Agyeman
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, March 26, 2020 2:26 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add
Hi Chasel,
No specific BZ was filed for the missing GUID issue, though reported on this
mailing list.
Thanks
Prince
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, February 26, 2020 1:16 AM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc
Added missing GUID gEfiMemoryTypeInformationGuid to
PeiPolicyUpdateLib.inf to fix VS2017 build issue
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git
a/Platfo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2408
The patch series add VS2017 build support to the
edk2-plaforms/Intel boards
Cc: Chasel Chiu
Cc: Nate DeSimone
Prince Agyeman (2):
CoffeelakeSiliconPkg: Add Missing GUID
CoffeelakeSiliconPkg: Add missing library
.../PeiPolicyUpdateL
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2408
Added GbeMdiLib implementation and added additional registers
definitions needed by GbeMdilib. This fixes the linker errors seen
during VS2017 builds
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Pch/Include/L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2191
This patch series add the initial Up Xtreme board support to the
WhiskeylakeOpenBoardPkg
V4 Changes:
- Removed MTRR configuration function
- Rearranged FVs to improve boot time
V3 Changes:
- Updated copyright year
- Added function
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/WhiskeylakeOpenBoardPkg/Include/PlatformBoardId.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Pla
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Adds the DSC and build files necessary to build the
UpXtreme board instance.
Key files
=
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The UpXtreme board description file.
* OpenBoardPkgPcd.dsc -
Removes BoardFuncInit related functionality in WhiskeylakeURvp.
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Library/BoardInitLib/BoardFunc.c | 19
.../Library/BoardInitLib/BoardFunc.h | 20 -
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2191
This patch series add the initial Up Xtreme board support to the
WhiskeylakeOpenBoardPkg
V3 Changes:
- Updated copyright year
- Added function to increase cache code size
- Uncommmented the GPIO group tier configuration
- Updated S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Adds the DSC and build files necessary to build the
UpXtreme board instance.
Key files
=
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The UpXtreme board description file.
* OpenBoardPkgPcd.dsc -
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/WhiskeylakeOpenBoardPkg/Include/PlatformBoardId.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Pla
Removes BoardFuncInit related functionality in WhiskeylakeURvp.
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Library/BoardInitLib/BoardFunc.c | 19
.../Library/BoardInitLib/BoardFunc.h | 20 -
Hi Felix,
Try building with VS2015. There's a known issue with VS2017 builds as
documented here https://bugzilla.tianocore.org/show_bug.cgi?id=2408
Thanks
Prince
From: devel@edk2.groups.io On Behalf Of Felix Polyudov
Sent: Friday, February 14, 2020 8:01 AM
To: Agyeman, Prince ; devel
Hi Felix,
Can you include a log or details of the build error you're seeing ?
Also what are the FSP , edk2-non-osi, edk2-platform and edk2 commit IDs you are
using ?
Thanks
Prince
Prince
From: devel@edk2.groups.io On Behalf Of Felix Polyudov
Sent: Thursday, February 13, 2020 3:11 PM
To: deve
Thanks Chasel, I have updated the readme.md in my v2 patch set and the BZ with
the current status
Prince
-Original Message-
From: Chiu, Chasel
Sent: Thursday, February 13, 2020 12:22 AM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L
Subject: RE: [edk2-platforms
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2191
This patch series add the initial Up Xtreme board support to the
WhiskeylakeOpenBoardPkg
V2 Changes:
- Updated Readme.md to reflect the Current Status
Current Status:
1. Basic boot to windows 10 (Home) and Ubuntu 18.04 from NVMe
*
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Adds the DSC and build files necessary to build the
UpXtreme board instance.
Key files
=
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The UpXtreme board description file.
* OpenBoardPkgPcd.dsc -
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/WhiskeylakeOpenBoardPkg/Include/PlatformBoardId.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Pla
Removes BoardFuncInit related functionality in WhiskeylakeURvp.
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Library/BoardInitLib/BoardFunc.c | 19
.../Library/BoardInitLib/BoardFunc.h | 20 -
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/WhiskeylakeOpenBoardPkg/Include/PlatformBoardId.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Pla
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191
Adds the DSC and build files necessary to build the
UpXtreme board instance.
Key files
=
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The UpXtreme board description file.
* OpenBoardPkgPcd.dsc -
Removes BoardFuncInit related functionality in WhiskeylakeURvp.
Co-authored-by: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Library/BoardInitLib/BoardFunc.c | 19
.../Library/BoardInitLib/BoardFunc.h | 20 -
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2191
This patch series add the initial Up Xtreme board support to the
WhiskeylakeOpenBoardPkg
Current Status:
1. Basic boot to windows 10 (Home) and Ubuntu 18.04 from NVMe
* UpXtreme:
- Intel(R) Core(TM) i3-8145UE CPU @ 2.20GHz
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2453
Fixed coding style issues as reported by the ECC tool
Cc: Shenglei Zhang
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
---
.../BoardModulePkg/LegacySioDxe/ComponentName.h | 5 +
.../BoardM
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points, to BoardX58Ich10 board.
These hooks are triggered on the BDS hook events
What was done:
* Included a board specific instance of BoardBdsHookLib
and BoardBootManagerLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added BDS hook point guids as defined in the
Minimum Platform specification. These GUIDs
shall be used in the identification of three
of the BDS hook point event groups.
These event groups are Before Console After Trusted,
Before Console Be
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
This is a sample/generic DXE driver that registers
all the BDS hook points or callbacks as defined in
BoardBdsHookLib.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../BoardBdsHookDxe/BoardBd
This library implements a generic PlatformBootManagerWaitCallback
and PlatformBootManagerUnableToBoot which will be linked Minplatform's
PlatformBootManager library instance.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../BoardBootManagerLib/Board
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added BDS hook points to the Minplatform boot manager library
as defined in the Minimum Platfrom specifcations.
Changes made:
* Added functions to signal three BDS event groups.
These event groups are BeforeConsoleAfterTrustedConsole,
Befo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
This patch series implements BDS hook points as defined in
the EDK II Minimum Platform Specification. For details, see
https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/appendix_a_full_maps/a3_bds_hook_points.html
What wa
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a generic board BDS hook library that implements
BDS hook points as defined in the Minimum platform specification.
This library implements callbacks for the three MinPlatformPkg
BDS event groups, namely gBdsEventBeforeConsoleAfterTrus
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added Board BDS Hook library that implements simics specific
Bds hook points or callbacks.
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
---
.../Library/BoardBdsHookLib/BoardBdsHook.h| 173 ++
.../Library/Boa
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points for the GalagoPro3 and KabylakeRvp3 boards.
These hooks are triggered on the BDS hook events
What was done:
* Included an instance of BoardBdsHookLib and BoardBootManag
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
As Minplatform's PlatformBootManager library instance implements
event signals (as specified in the minimum platform specification)
to trigger board actions, some of its functions namely
PlatformBootManagerWaitCallback and PlatformBootManage
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
This library implements PlatformBootManagerWaitCallback
and PlatformBootManagerUnableToBoot which can be linked Minplatform's
PlatformBootManager libary instance.
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336
Added a DXE driver that registers the minimum platform
BDS hook points, to WhiskeylakeURvp board.
These hooks are triggered on the BDS hook events
What was done:
* Included an instance of BdsHookLib and BoardBootManagerLib
from BoardModule
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409
Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing.
This fixes the boot failure seen with the latest Coffee Lake (CFL)
FSP binary (v 7.0.68.41)
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
Thanks for clarifying.
Yes the minimum stack size of 160KB works as well.
I will update this patch
Thanks
Prince
-Original Message-
From: Desimone, Nathaniel L
Sent: Friday, December 13, 2019 2:27 PM
To: devel@edk2.groups.io; Desimone, Nathaniel L
; Agyeman, Prince
Cc: Chiu
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x1
-Original Message-
From: Desimone, Nathaniel L
Sent: Thursday, December 12, 2019 3:07 PM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Chiu, Chasel ; Kubacki, Michael A
Subject: RE: [edk2-platforms] [PATCH
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409
Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing.
This fixes the boot failure seen with the latest Coffee Lake (CFL)
FSP binary (v 7.0.68.41)
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2330
Changes:
* Added CmosMap.h that defines CMOS addresses used in
SimicsOpenBoardPkg as macros
* Replaced hardcoded CMOS addresses with the macros
defined in CmosMap.h
Cc: Nate DeSimone
Cc: Michael Kubacki
Signed-off-by: Prince Agyeman
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, November 25, 2019 4:17 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Agyeman, Prince
Subject: [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Update maintainers for
Simics packages
David
Removed unused variable 'RegEmptied' in BdsPs2KbcLib.c
to avoid gcc 5 build error unused-but-set-variable.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c| 2 --
1 file changed, 2 deletio
* Added ps2 keyboard and Uart enable PCDs.
* Added PCDs to define IO ports for Uart1 and Uart2
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/BoardModulePkg/BoardModulePkg.dec | 21 +++
1 file changed, 21 insertions(+)
dif
Included PCDs to the Super I/O DXE driver,
to allow the enable/disable of Ps2 keyboard/mouse,
UART1 and UART2 ports.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../LegacySioDxe/LegacySioDxe.inf | 12
.../BoardModulePkg/LegacySioDx
Added BIOS keyboard support to BoardX58Ich10
* Included BoardModulePkg's generic Super I/O DXE driver
* Configured Super I/O and Ps2 keyboard related PCD
to enable Ps2 keyboard
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/SimicsOpenBoardP
Added gBoardModulePkgTokenSpaceGuid to BoardModulePkg
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
Platform/Intel/BoardModulePkg/BoardModulePkg.dec | 4
1 file changed, 4 insertions(+)
diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.
Removed the Super I/O DXE driver from SimicsOpenBoardPkg.
This driver will be added to the BoardModulePky as it is
generic and can be shared by other open board packages
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../BoardX58Ich10/OpenBoardPkg.dsc
Added a generic Super I/O driver that produces the
Sio protocol. This driver was moved from the
SimicsOpenBoardPkg.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/BoardModulePkg/BoardModulePkg.dsc | 5 +
.../LegacySioDxe/ComponentName.c
This patch series enables BIOS Ps2 keyboard in GalagoPro3
Changes in v2:
* fixed typos
* fixed discriptions
* broke patches down as per recommendation from Michael Kubacki
* renamed the Ps2KbcLib to BdsPs2KbcLib
* moved BdsPs2KbcLib to BoardModulePkg as it is generic and can be
shared
What was do
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2228
What was done:
* Added BDS Ps2 keyboard DXE driver.
* Added Super I/O DXE driver to publish the SIO protocol
needed by the Ps2 keyboard DXE driver.
* Included a Ps2 Library to BdsDxe driver
to add the Ps2 device path to ConIn and ConInDev
What was done:
* Added BDS Ps2 keyboard DXE driver.
* Included Super I/O DXE driver to publish the SIO protocol
needed by the Ps2 keyboard DXE driver.
* Included a Ps2 Library to BdsDxe driver
to add the Ps2 device path to ConIn and ConInDev
variables
* Configured the Super I/O Pci to Isa bri
Added a generic Ps2 keyboard library
that adds ps2 device path to ConIn and ConInDev
Uefi variables
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../Intel/BoardModulePkg/BoardModulePkg.dsc | 1 +
.../Library/BdsPs2KbcLib/BdsPs2KbcLib.c | 2
Hi Chasel,
I will fix the descriptions and typos as suggested in my v2 patch series.
Thanks for the feedback!
Prince
-Original Message-
From: Chiu, Chasel
Sent: Monday, November 4, 2019 1:04 AM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2164
Replaced Cmos.c and Cmos.h with BoardModulePkg's
Cmos library CmosAccessLib
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BoardInitLib/PeiX58Ich10InitPreMemLib.c | 46 ---
Added GalagoPro3 board ps2 keyboard library
that adds ps2 device path to ConIn and ConInDev
Uefi variables
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../GalagoPro3/Library/Ps2KbcLib/Ps2KbcLib.c | 202 ++
.../GalagoPro3/Library/Ps
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2228
This patch series enables BIOS Ps2 keyboard in GalagoPro3
What was done:
Patch 0001 adds PCDs to BoardModulePkg that will enable/disable,
describe Super I/O , Ps2 keyboard/mouse, uart1 and uart2 com ports
Patch 0002 moves the generic Supe
Added gBoardModulePkgTokenSpaceGuid to BoardModulePkg
Added ps2 keyboard and Uart enable PCDs.
Added PCDs to define IO ports for Uart1 and Uart2
Enabled KabylakeOpenBoardPkg and WhiskeylakeOpenBoardPkg
boards to use the ps2 keyboard enable PCD.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeS
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2228
Added Ps2Keyboard DXE driver.
Added Sio dxe driver to publish the SIO protocol
needed by the Ps2Keyboard DXE driver.
Included a Ps2 null Library to BdsDxe driver
to add the Ps2 device path to ConIn and ConInDev
variables
Configured the Su
Moved LegacySioDxe from SimicsOpenBoardPkg
to BoardModulePkg as LegacySioDxe is generic
and can be shared between open board packages
Removed unused libraries and functions in LegacySioDxe
Pointed BoardX58Ich10 to the current LegacySioDxe
location
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate D
Included PCDs to the Sio dxe driver,
to allow the enable/disable of Ps2 keyboard/mouse,
UART1 and UART2 com ports.
Renamed the Sio driver's base name
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../LegacySioDxe/LegacySioDxe.inf | 15 ++
Reviewed-by: Prince Agyeman
-Original Message-
From: Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Wei, David Y ; Agyeman, Prince
Subject: [edk2-platforms: PATCH v3 6/6] SimicsOpenBoardPkg/BoardX58Ich10: Add
SetCacheMtrrLib library class.
REF
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2225
Currently, gcc 5 encounters an error "unused-but-set-variable" in
BdsPlatform.c as a result of a Status variable not being used
after it's set.
This was fixed by printing the Status variable when
EfiBootManagerDeleteLoadOptionVariable func
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2164
Replaced Cmos.c and Cmos.h with BoardModulePkg's
Cmos library CmosAccessLib
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BoardX58Ich10/OpenBoardPkg.dsc| 2 +
.../Intel/Simi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2250
Changed BoardX558ich10's build directory to
Build/SimicsOpenBoardPkg/BoardX58Ich10 to align it with
align with the other Intel board packages
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
..
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2211
Added BIOS Info PEIM to publish Bios Info
HOB. This PEIM currently publishes the microcode
FV information.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BiosInfo/BiosInfo.c
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2210
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2211
Added gBiosInfoGuid to be used in
publishing the BIOS information HOB
which is needed in FIT generation
Also added the BIOS Info header
file BiosInfo.h that defines the
BIOS info struct
Changes in v3:
- Added PcdLib to BiosInfo.inf's LibraryClasses section
- Cleaned up OpenBoardPkg.dscs for all three platforms
- Added bugzilla references
Changes in v2:
- Moved BIOS Info PEIM to KabylakeOpenBoardPkg
shared by both KabylakeRvp3, GalagoPro3
- Moved BIOS Info PEIM to WhiskeylakeOpe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2210
Added BIOS Info PEIM to KabylakeRvp3 and GalagoPro3
to publish the BIOS info HOB. This PEIM currently publishes
the board's microcode region information.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agye
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2210
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2211
Added FitGen tool build and FIT generation
to the BIOS build process.
What was done:
- Build the FIT generation tool
- Added default/empty BIOS_INFO_GUID to the build.cfg
- Added BIOS_
Added BIOS Info PEIM to publish Bios Info
HOB. This PEIM currently publishes the microcode
FV information.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BiosInfo/BiosInfo.c | 93 +++
.../BiosInfo/BiosInfo.i
Added gBiosInfoGuid to be used in
publishing the BIOS information HOB
which is needed in FIT generation
Also added the BIOS Info header
file BiosInfo.h that defines the
BIOS info struct and GUID
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../In
Changes in v2:
- Moved BIOS Info PEIM to KabylakeOpenBoardPkg
shared by both KabylakeRvp3, GalagoPro3
- Moved BIOS Info PEIM to WhiskeylakeOpenBoardPkg
used by WhiskeylakeURvp
- Moved BiosInfo.h to BoardModulePkg/Include/Guid
- Fixed typos, cleaned up commit messages and comments
Prince Agyema
Added BIOS Info PEIM to KabylakeRvp3 and GalagoPro3
to publish the BIOS info HOB. This PEIM currently publishes
the board's microcode region information.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../KabylakeOpenBoardPkg/BiosInfo/BiosInfo.c |
Added FitGen tool build and FIT generation
to the BIOS build process.
What was done:
- Build the FIT generation tool
- Added default/empty BIOS_INFO_GUID to the build.cfg
- Added BIOS_INFO_GUID to GalagoPro3,KabylakeRvp3
and WhiskeylakeURvp's build_config.cfg
This allows a board to specify the GU
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 17/17] SimicsOpenBoardPkg: Assign unique
token namespace
REF:https
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 16/17] SimicsOpenBoardPkg/BoardX58Ich10: DSC
cleanup
REF:https
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 15/17] SimicsOpenBoardPkg/BoardX58Ich10:
Remove OpenBoardPkgConfig.dsc
Reviewed-by: Prince Agyeman
-Original Message-
From: Kubacki, Michael A
Sent: Monday, October 7, 2019 10:17 PM
To: devel@edk2.groups.io
Cc: Agyeman, Prince ; Wei, David Y
Subject: [edk2-platforms][PATCH V1 14/17] SimicsOpenBoardPkg/BoardX58Ich10:
Relocate DSC includes
This change
Added BIOS Info PEIM to KabylakeRvp3 to publish
the BIOS info HOB. This PEIM currently publishs
the board's microcode region info.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../KabylakeRvp3/BiosInfo/BiosInfo.c | 93 +++
Added fit generation tool to the build
process.
What was done:
Added BIOS_INFO_GUID to the build.cfg
Added BIOS_INFO_GUID to GalagoPro3,
KabylakeRvp3 and WhiskeylakeURvp build_config.cfg
This allows the boards to specify the GUID
associated with the its Bios Info PEIM
BIOS_INFO_GUID is passed a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2210
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2211
This series of patches
1. Add the generation of the FitGen tool to build_bios.py
2. Add Firmware Interface Table (FIT) to the final images of:
a. KabylakeOpenBoardPkg/KabylakeRvp
Added BIOS info PEIM to publish Bios Info
HOB. This PEIM currently publishes the microcode
FV info.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../WhiskeylakeURvp/BiosInfo/BiosInfo.c | 93 +++
.../WhiskeylakeURvp/BiosInfo/B
Added gBiosInfoGuid to be used to
publish BIOS information HOB which
is needed in FIT generation
Also added the Bios Info header
file BiosInfo.h
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../Intel/BoardModulePkg/BoardModulePkg.dec | 3 +
..
Added BiosInfo PEIM to publish the
Bios Info HOB. Currently this PEIM publishes
one Bios Info entry which is the microcode
region information.
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../GalagoPro3/BiosInfo/BiosInfo.c| 92
From: "Agyeman, Prince"
Removed unused functions in secMain.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../PlatformBoot
From: "Agyeman, Prince"
Removed Status variable as the SmmClear
function always returns EFI_SUCCESS.
Refer to the Smmclear function for
details
Removed SpiBaseAddress variable as this
address was never used in the SendSpiCmd function.
REF: https://bugzilla.tianocore.org/show_bug.c
From: "Agyeman, Prince"
Changed include file name Smbios.h to
SmBios.h to fix gcc file not found
build issue, due to case sensitive
file names in Linux
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
C
What changed from v1:
* Added detailed commit messages
This patch series fix gcc build issues seen
in SimicsOpenBoardPkg.
Patches were tested on GCC 5
Agyeman, Prince (3):
AdvancedFeaturePkg: Fix GCC build
SimicsOpenBoardPkg: Fix GCC build issues
SimicsIch10Pkg: Fix GCC build issues
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../PlatformBootManagerLib/BdsPlatform.c | 38 ---
.../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ---
2 files
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../LibraryPrivate/BasePchSpiCommonLib/SpiCommon.c | 3 ---
.../SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c | 7 ++-
2 files
Cc: David Wei
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Agyeman Prince
Cc: Kubacki Michael A
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/Intel
This patch series fix gcc build issues seen
in SimicsOpenBoardPkg.
Patches were tested on GCC 5
Prince Agyeman (3):
AdvancedFeaturePkg: Fix GCC build
SimicsOpenBoardPkg: Fix GCC build issues
SimicsIch10Pkg: Fix GCC build issues
.../Smbios/SmbiosBasicDxe/SmbiosBasic.h | 2 +-
.../Pla
1 - 100 of 132 matches
Mail list logo
