Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter

2024-01-19 Thread Ankit Sinha
Reviewed-by: Ankit Sinha > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, January 10, 2024 5:20 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Sinha, Ankit > > Subject: [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter >

Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

2023-05-30 Thread Ankit Sinha
Reviewed-by: Ankit Sinha Thank you, Ankit > -Original Message- > From: Ke, VincentX > Sent: Wednesday, May 24, 2023 1:39 AM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eri

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update ACPI 6.5 definition

2023-05-15 Thread Ankit Sinha
Thank you Aryeh. Reviewed-by: Ankit Sinha > -Original Message- > From: Chen, Aryeh > Sent: Wednesday, May 10, 2023 8:58 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, E

Re: [edk2-devel] [PATCH v7] MinPlatformPkg: Update HWSignature filed in FACS

2023-05-15 Thread Ankit Sinha
Reviewed-by: Ankit Sinha > -Original Message- > From: Ke, VincentX > Sent: Thursday, May 11, 2023 3:00 AM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric ; Sinha,

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00

2023-01-31 Thread Ankit Sinha
Hi Aryeh, Is it possible to use a FixedPCD for "PCI0"/"PC00" string itself? That way we don't have to keep adding conditional statements for future changes. It will scale better. Declare in MinPlatformPkg.dec and provide the value in OpenBoardPkg.dsc. Thank you, Ankit > -Original

Re: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported

2022-12-19 Thread Ankit Sinha
: Michael Kubacki ; Desimone, Nathaniel > L ; Sinha, Ankit > Subject: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported > > From: Michael Kubacki > > The SpellCheck plugin began reporting new typos that were previously > missed. This change fixes those typos. > >

Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.

2022-11-07 Thread Ankit Sinha
Reviewed-by: Ankit Sinha > -Original Message- > From: Xu, Wei6 > Sent: Monday, November 7, 2022 3:58 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael ; Desimone, > Nathaniel L ; Sinha, Ankit > > Subject: [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

2022-09-28 Thread Ankit Sinha
Hi Aryeh, Thank you for testing. Reviewed-by: Ankit Sinha > -Original Message- > From: Chen, Aryeh > Sent: Wednesday, September 21, 2022 12:34 AM > To: Sinha, Ankit ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao,

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

2022-09-12 Thread Ankit Sinha
57 > > According to ASL Coding Guidelines - Device Identifiers "A Device should > contain either an _ADR or a _HID object, never both." > , so remove _ADR due to _HID exist. > > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram

Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl

2022-09-12 Thread Ankit Sinha
n either an _ADR or a _HID object, never both." > > , so remove _ADR due to _HID exist. > > I'm curious where exactly in ACPI spec it's said... > > > Signed-off-by: Aryeh Chen > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > >