On Fri, 27 Oct 2023 at 16:26, Pedro Falcato wrote:
>
> On Fri, Oct 27, 2023 at 3:13 PM Ard Biesheuvel wrote:
> >
> > On Fri, 27 Oct 2023 at 16:09, Jake Garver via groups.io
> > wrote:
> > >
> > > Hi Ard:
> > >
> > > > C
On Fri, 27 Oct 2023 at 16:09, Jake Garver via groups.io
wrote:
>
> Hi Ard:
>
> > Can you double check the object file? I suspect this is a linker relaxation
> > not a compiler issue.
>
> With LTO in play, is there a way to check the object file? It's not in
> aarch64 assembly.
>
Perhaps not.
Hello all,
Apologies for the late response.
On Fri, 27 Oct 2023 at 14:44, Jake Garver via groups.io
wrote:
>
> Thanks for your response, Pedro.
>
> I chased this as a toolchain bug originally, but concluded that the ADR
> indeed works before GenFw rewrites it. But I see your point regarding
On Thu, 26 Oct 2023 at 17:19, Laszlo Ersek wrote:
>
> On 10/26/23 16:21, Peter Maydell wrote:
> > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote:
> >> On 10/10/23 09:43, Ard Biesheuvel wrote:
> >>> Thanks for looking into this - a cleanup was overdue her
On Thu, 26 Oct 2023 at 16:46, Julien Grall wrote:
>
> Hi,
>
> On 26/10/2023 15:21, Peter Maydell wrote:
> > On Tue, 10 Oct 2023 at 16:33, Laszlo Ersek wrote:
> >> On 10/10/23 09:43, Ard Biesheuvel wrote:
> >>> Thanks for looking into this - a cleanup wa
notify the DXE Foundation
> about said runtime services being available.)
>
> Clean up ArmPlatformPkg/PL031RealTimeClockLib accordingly (it only has
> code that's redundant for step (3); it does not try to set "gRT" fields).
>
> (Note that the lib instance INF file already doe
e already performs those actions.
>
> Cc: Ard Biesheuvel
> Cc: Bibo Mao
> Cc: Chao Li
> Cc: Leif Lindholm
> Cc: Ling Jia
> Cc: Marcin Wojtas
> Cc: Peng Xie
> Cc: Wenyi Xie
> Cc: Xianglai li
> Cc: Yiqi Shu
>
> Thanks
> Laszlo
>
> Laszlo Ersek (7):
On Fri, 20 Oct 2023 at 11:49, Laszlo Ersek wrote:
>
> On 10/18/23 10:57, Ard Biesheuvel wrote:
> > On Wed, 18 Oct 2023 at 10:49, YuinYee Chew
> > wrote:
> >>
> >> Dear Maintainers,
> >>
> >> Just a friendly reminder to ask if you could tak
hat module is a
> > *driver*, not a library instance; what's more,
> > PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all.
> > Treat that module too as case (a), right at the front of the series.
> >
> > Finally, drop the LibRtcVirtualNotifyEven
I'm happy to merge it if someone else reviews it
>
> -Original Message-
> From: YuinYee Chew
> Sent: Friday, September 29, 2023 9:35 PM
> To: 'Heinrich Schuchardt'
> Cc: Sunil V L ; Li Yong ; Leif
> Lindholm ; Ard Biesheuvel
> ; Abner Chang ; Daniel
> Schaefer ;
On Tue, 17 Oct 2023 at 00:55, Rebecca Cran wrote:
>
> Reviewed-by: Rebecca Cran
>
>
> Looks like this is still waiting to be merged by an ArmPkg maintainer.
>
>
Thanks for the reminder
Really queued up now
>
> On 6/29/23 14:46, Jeff Brasen wrote:
> > Add EFI_NOT_READY return if the CPU can
On Wed, 18 Oct 2023 at 07:56, Marcin Juszkiewicz
wrote:
>
> W dniu 18.10.2023 o 05:28, Nhi Pham pisze:
> > Hi Marcin,
> >
> > There is a nitpicking below.
> >
> > Other than, it looks good to me.
> >
> > Acked-by: Nhi Pham
> >
> >>
On Wed, 18 Oct 2023 at 10:45, Ard Biesheuvel wrote:
>
> On Tue, 17 Oct 2023 at 15:23, Marcin Juszkiewicz
> wrote:
> >
> > We want to check "if platver < 0.3" in an easy way.
> > ---
> > .../IndustryStandard/SbsaQemuPlatformVersion.h | 25
&g
On Tue, 17 Oct 2023 at 15:23, Marcin Juszkiewicz
wrote:
>
> We want to check "if platver < 0.3" in an easy way.
> ---
> .../IndustryStandard/SbsaQemuPlatformVersion.h | 25
>
> 1 file changed, 25 insertions(+)
>
> diff --git
>
ic. If needed, hoist the function definition above the
> reference. In case (b), remove the function definition.
>
> (3) Some affected RealTimeClockLib instances turn out to be entirely
> unused / superfluous; drop those altogether.
>
> Cc: Ard Biesheuvel
> Cc: Bibo Mao
>
hen a library instance file (INF) is updated, PrEval will review each
>> package's DSC as described in the ci.yaml file to determine if the
>> package uses said library instance. If the package does use the library
>> instance, it will be built and tested to ensure the package is not
&g
ting with these platforms would be welcome.
>
> I also test-built "ArmVirtCloudHv.dsc" and "ArmVirtQemuKernel.dsc".
> Those *are* supposed to receive the same feature, but I couldn't /
> didn't boot them, respectively.
>
> I've formatted the p
transition to 3.12 can take place with more time to evaluate the
> >>> changes needed.
> >>>
> >>> Thanks,
> >>> Michael
> >>>
> >>> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
> >>>> Could someone please expla
Could someone please explain what went wrong this time? Many of the
tests are failing, and i don't see a 're-run failed tests' button.
https://github.com/tianocore/edk2/pull/4893
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109367):
vices:
> >> BaseAddress - 0x4800 Length - 0xF800 MinimalMemorySizeNeeded -
> >> 0x38C8000
> >> InstallProtocolInterface: [EfiLoadedImageProtocol] 46EFC3E0
> >> ProtectUefiImageCommon - 0x46EFC3E0
> >> - 0x46EB2000 - 0x00068000
> >
On Tue, 3 Oct 2023 at 17:22, Leif Lindholm wrote:
>
> +Zhiguang
>
> Tested-by: Leif Lindholm
>
> MdePkg maintainers - this is currently breaking several platforms in
> edk2-platforms.
>
Acked-by: Ard Biesheuvel
Please just merge this - it is an obvious and trivial bug
e much appreciated :)
> >
> > On 8/28/23 9:38 AM, Ard Biesheuvel wrote:
> >> I was hoping to get around to this before the end of the week (but I
> >> am not a MdeModulePkg maintainer)
> >>
> >>
> >> On Mon, 28 Aug 2023 at 18:27, Taylor Beeb
On Fri, 29 Sept 2023 at 15:11, Sami Mujawar wrote:
>
> Reviewed-by: Sami Mujawar
>
Reviewed-by: Ard Biesheuvel
>
> On 27/09/2023 12:06 pm, Leif Lindholm wrote:
> > We added Sami as a reviewer to ArmPkg early last year, and I think it was
> > always our intentio
On Thu, 21 Sept 2023 at 10:50, Peter Maydell wrote:
>
> Hi; I've been looking again at a very long standing missing feature in
> the QEMU virt board, which is that we only have one UART. One of the
> things that has stalled this in the past has been the odd behaviour of
> EDK2 if the DTB that
On Thu, 21 Sept 2023 at 10:10, Tan, Dun wrote:
>
> Hi Ard,
>
> Could you send me your build and boot command?
>
> I think the paging mode for IA32 smm should be PagingPae instead of
> 'Paging32bit'. Also in previous code logic before my patch PagingPae is
> created for IA32 smm.
>
Build like
On Thu, 29 Jun 2023 at 10:09, duntan wrote:
>
> In the V8 patch set:
> In 'OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry', I
> refined the commit message and added comments in the code around the areas
> being changed to explain this code change.
>
> Only resend the changed
that gets
merged has been reviewed sufficiently, either by themselves or by
other people they have confidence in.
> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote:
> > On Wed, 13 Sept 2023 at 19:07, wrote:
> >>
> >> From: Michael Kubacki
> >>
> >> Ad
Hello Andrei,
On Tue, 19 Sept 2023 at 04:43, Andrei Warkentin
wrote:
>
> InternalLongJump was not returning the 2nd parameter passed
> to LongJmp (Value) as the return value from SetJmp.
>
> Seen with code compiled with -Os, where an LongJmp (Buffer, -1)
> somehow translated to SetJmp returning
tLib to:
> - Only assert on receiving less information that required through DT.
> - Set PcdArmArchTimerHypVirtIntrNum if provided through DT.
>
> Reported-by: Peter Maydell
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Leif Lindholm (2):
> ArmPkg: add EL2 virtual timer int
On Mon, 18 Sept 2023 at 15:06, Marcin Juszkiewicz
wrote:
>
> W dniu 18.09.2023 o 14:33, Ard Biesheuvel pisze:
> > On Mon, 18 Sept 2023 at 13:35, Leif Lindholm
> > wrote:
>
> >> Note for the interested:
> >> https://review.trustedfirmware.org/c/TF-A/trusted
On Mon, 18 Sept 2023 at 13:35, Leif Lindholm wrote:
>
> On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote:
> > There are some changes in progress which make BL1 bigger than 0x8000
> > which EDK2 uses.
> >
> > TF-A defines BL1 size to be 0x12000 one. So let follow it.
> >
> >
On Wed, 13 Sept 2023 at 19:07, wrote:
>
> From: Michael Kubacki
>
> Adds a CI YAML entry to acknowledge a case where a macro is expanded
> that contains a print specifier.
>
> Cc: Ard Biesheuvel
> Cc: Leif Lindholm
> Cc: Sami Mujawar
> Cc: Gerd Hoffmann
&g
i Warkentin
> Cc: Andrew Jones
> Cc: Ard Biesheuvel
> Cc: Gerd Hoffmann
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Sunil V L
> Signed-off-by: Laszlo Ersek
> ---
> OvmfPkg/RiscVVirt/README.md | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --gi
On Mon, 11 Sept 2023 at 04:47, Zhenyu Zhang wrote:
>
> From: "Zhenyu Zhang"
>
> We observed that EDK2 hits an ASSERT (Out of Resources) when
> booting with a full variable store. The message provided in
> this case is not helpful for non-experts.
> Add debug information to help users understand
On Tue, 12 Sept 2023 at 16:11, Michael D Kinney
wrote:
>
> Reviewed-by: Michael D Kinney
>
Thanks I'll queue this up
> > -Original Message-----
> > From: Ard Biesheuvel
> > Sent: Tuesday, September 12, 2023 5:36 AM
> > To: devel@edk2.groups.io
> > C
ee
>
> - X64:
>
> > DXEFV [93%Full] 15204352 (0xe8) total, 14219192 (0xd8f7b8) used,
> > 985160 (0xf0848) free
>
...
>
> Cc: Ard Biesheuvel
> Cc: Gerd Hoffmann
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Signed-off-by: Laszlo Ersek
Acked-by: Ard Biesheu
SerialDxe). We should use it in
> OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3.
>
> Cc: Anthony Perard
> Cc: Ard Biesheuvel
> Cc: Gerd Hoffmann
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Julien Grall
> Cc: Marc-André Lureau
> Cc: Stefan Ber
On Tue, 12 Sept 2023 at 14:16, Sunil V L wrote:
>
> Since I take care of maintaining the contents in RiscVVirt, update my entry
> from R to M.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Signed-off
On Tue, 12 Sept 2023 at 12:01, Leif Lindholm wrote:
>
> On Tue, Sep 12, 2023 at 07:42:30 +0000, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel
> >
> > Jake reports that the IS_ARM_MEMORY_REGION_ATTRIBUTES_SECURE() macro is
> > no longer accurate since commit 852227a
From: Ard Biesheuvel
Jake reports that the IS_ARM_MEMORY_REGION_ATTRIBUTES_SECURE() macro is
no longer accurate since commit 852227a9d52e3cb9 ("ArmPkg/Mmu: Remove
handling of NONSECURE memory regions").
Fortunately, it only affects the NS bit in level 1 short descriptors,
which is ig
On Tue, 12 Sept 2023 at 08:23, Sunil V L wrote:
>
> On Thu, Sep 07, 2023 at 04:58:25PM +0200, Laszlo Ersek wrote:
> > Explain how users can compose their pre-OS environment purely from
> > binaries they've built themselves.
> >
> > Cc: Andrei Warkentin
> &
On Thu, 7 Sept 2023 at 11:02, Linus Liu wrote:
>
> From: Linus Liu
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3004
>
> Cc: Qi Zhang
> Cc: Rahul Kumar
> Cc: Jiewen Yao
> Cc: Tina Chen
> Cc: Xiao X Chen
This patch is missing a signed-off-by line
> ---
>
On Mon, 11 Sept 2023 at 07:30, Laszlo Ersek wrote:
>
> On 9/8/23 01:58, Sean Brogan wrote:
> >
> > On 9/7/2023 1:54 PM, Laszlo Ersek wrote:
> >> On 9/7/23 19:50, Sean Brogan wrote:
> >>> I would argue that by declaring that your library class supports type
> >>> DXE_CORE (or any core type) that
On Fri, 8 Sept 2023 at 17:54, Michael D Kinney
wrote:
>
> Acked-by: Michael D Kinney
>
Thanks
I can merge this but note that we'll need to convert it to CR-LF
first. (My VIM editor with editorconfig integration seems perfectly
happy with that)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
On Fri, 8 Sept 2023 at 15:58, Rebecca Cran wrote:
>
> Reviewed-by: Rebecca Cran
>
> On 9/7/23 02:34, Corvin Köhne wrote:
> > If OVMF fails to find the RSDP in memory, it should fall back installing
> > the statically provided ACPI tables.
> >
> > Sign
On Wed, 1 Mar 2023 at 23:11, Ard Biesheuvel wrote:
>
> On Wed, 1 Mar 2023 at 19:19, Rebecca Cran wrote:
> >
> > Add a .editorconfig file which editors can use for basic formatting
> > details of files, such as tabs/spaces, line endings etc.
> >
> > Signe
On Thu, 7 Sept 2023 at 16:51, Laszlo Ersek wrote:
>
> On 9/7/23 16:27, Ard Biesheuvel wrote:
> > On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev
> > wrote:
> >>
> >> EL3 firmware may implement PSCI interface on aarch64 platforms,
> >> including
On Mon, 16 Jan 2023 at 12:39, Evgeny Iakovlev
wrote:
>
> EL3 firmware may implement PSCI interface on aarch64 platforms,
> including qemu-tcg-aarch64. However, EL3 firmware does not usually own
> pulling and deploying ACPI tables from qemu fw_cfg. Thus the only way
> EL3 can advertise PSCI on
in.
>
> Signed-off-by: Jeff Brasen
Acked-by: Ard Biesheuvel
I'll queue this up - thanks.
> ---
> ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Drivers/ArmPsciMpServicesDxe/Arm
On Thu, 6 Jul 2023 at 14:30, Gerd Hoffmann wrote:
>
> Be consistent with pl011-based serial console setup.
>
> Suggested-by: Laszlo Ersek
> Signed-off-by: Gerd Hoffmann
Acked-by: Ard Biesheuvel
I'll queue this one up too
> ---
> ArmVirtPkg/Library/PlatformBootManage
Gerd Hoffmann
Acked-by: Ard Biesheuvel
I'll queue this one up as well.
> ---
> .../Include/Register/QemuSmramSaveStateMap.h | 178 --
> .../PeiDxeMemEncryptSevLibInternal.c | 4 +-
> .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 21 +--
> 3
On Thu, 6 Jul 2023 at 17:31, Gerd Hoffmann wrote:
>
> Add DetectAndPreparePlatformVirtioDevicePath() helper function
> to setup virtio-mmio devices. Start with virtio-serial support.
>
> This makes virtio console usable with microvm.
>
> Signed-off-by: Gerd Hoffmann
Ack
On Tue, 4 Jul 2023 at 09:28, Gerd Hoffmann wrote:
>
> On Fri, Jun 30, 2023 at 02:26:03AM +0400, Joursoir wrote:
> > Add the new section for Secure Boot.
> >
> > Signed-off-by: Alexander Goncharov
>
> Acked-by: Gerd Hoffmann
>
Thanks all
Queued as #4800
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
use an explicitly compile-time string length calculation
> (both compile-time and run-time approaches are currently used elsewhere in
> the codebase for copying static strings).
>
> Signed-off-by: Mike Beaton
Thanks for the fix.
Reviewed-by: Ard Biesheuvel
> ---
> MdeModulePkg/Uni
thub PR: https://github.com/tianocore/edk2/pull/4793
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Gerd Hoffmann
>
> Signed-off-by: Oliver Smith-Denny
Thanks for the patch. I agree that omitting early DXE core DEBUG
output is not great.
However,
On Thu, 7 Sept 2023 at 10:34, Corvin Köhne wrote:
>
> If OVMF fails to find the RSDP in memory, it should fall back installing
> the statically provided ACPI tables.
>
> Signed-off-by: Corvin Köhne
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: G
On Wed, 6 Sept 2023 at 11:38, Mike Beaton wrote:
>
> This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46
>
> Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528
>
> The build.sh qemu option starts the correct qemu executable for the selected
> architecture (build.sh -a option, or
On Thu, 13 Jul 2023 at 12:48, Xenia Ragiadakou wrote:
>
> Currently, resuming an S3 suspended guest results in the following
> assertion failure:
> ASSERT
> MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.c(41):
> MemoryLength > 0
> This happens because some parts of the S3
On Tue, 5 Sept 2023 at 18:05, Oliver Smith-Denny
wrote:
>
> Gentle reminder on this now that the stable tag has passed.
>
Thanks for the reminder.
Merging as #4790
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108318):
n without this series on some
> platforms.
>
> If there are no further comments by end of this week, I plan to merge this
> series along with https://edk2.groups.io/g/devel/topic/99863881#106547
>
For the series, and the intent to merge it as-is
Acked-by: Ard Biesheuvel
-=-=-=-=
On Wed, 6 Sept 2023 at 09:56, Nhi Pham wrote:
>
> On 9/6/2023 1:33 PM, Ni, Ray wrote:
> > [EXTERNAL EMAIL NOTICE: This email originated from an external sender.
> > Please be mindful of safe email handling and proprietary information
> > protection practices.]
> >
> > I am a bit confused.
> >
> >
orm is named "MainFormState" while the EFI variable is named
> "PlatformConfig".
> This discrepancy in names causes the following SCT cases to fail on
> RiscVVirtQemu:
> ExtractConfigConformance
> ExtractConfigFunction
> ExtractConfig_Func
>
> Cc: Ard Biesheuvel
&
On Wed, 6 Sept 2023 at 08:33, Ni, Ray wrote:
>
> I am a bit confused.
>
> The HOB list in standalone MM is read-only. Why could any module call
> BuildGuidHob() to modify the HOB.
>
> I saw Oliver mentioned something about StMM. I don't know what that is. But
> it seems that's ARM specific.
On Tue, 5 Sept 2023 at 16:18, Gerd Hoffmann wrote:
>
> On Tue, Sep 05, 2023 at 03:38:49PM +0200, Ard Biesheuvel wrote:
> > On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann wrote:
> > >
> > > On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> > >
On Tue, 5 Sept 2023 at 15:34, Gerd Hoffmann wrote:
>
> On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> > Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> > preserve the original execution of INIT-SIPI-SIPI.
>
> Acked-by: Gerd Hoffmann
>
> Can we merge this
On Thu, 24 Aug 2023 at 06:46, Mike Beaton wrote:
>
> This reverts commit 173a7a7daaad560cd69e1000faca1d2b91774c46.
>
> Fixes https://bugzilla.tianocore.org/show_bug.cgi?id=4528
>
> Signed-off-by: Mike Beaton
> ---
> OvmfPkg/build.sh | 13 -
> 1 file changed, 8 insertions(+), 5
On Mon, 4 Sept 2023 at 13:45, Gerd Hoffmann wrote:
>
> On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote:
> > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
> > >
> > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> > > >
&g
On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote:
>
> On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > I have tried the patch below, and I don't see any slowdowns with or
> > > without the patch, running both DEBUG and RELE
On Thu, 31 Aug 2023 at 15:06, Leif Lindholm wrote:
>
> Hi,
>
> Apologies for the long delay reviewing this set.
>
> I have rebased your patches onto:
> https://github.com/leiflindholm/edk2-platforms/tree/sbsa-xhci
>
> I had to move one hunk (.dec change) from 2/3 to 1/3 in order to
> not break
On Wed, 16 Aug 2023 at 10:56, Nhi Pham wrote:
>
> Hi Ard and Ming,
>
> I have been seeing an issue with StandaloneMM HobLib that can be fixed
> by this patch as well.
>
> The function CreateHob() in the HobLib instance
> StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf
>
On Tue, 29 Aug 2023 at 16:37, Laszlo Ersek wrote:
>
> On 8/29/23 15:29, Ard Biesheuvel wrote:
> > Laszlo reports that the efi_gdb.py script fails to produce a full
> > backtrace when attaching it to an ARM firmware build that has halted on
> > an unhandled excep
-off-by: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Rebecca Cran
Reviewed-by: Ard BIesheuvel
> ---
>
> Ultimately, the size is still restricted to 32-bit since it is set
> directly from a PcdGet32 (PcdFvSize). This should ideally be broken
> out into an OemMiscLib functio
Laszlo reports that the efi_gdb.py script fails to produce a full
backtrace when attaching it to an ARM firmware build that has halted on
an unhandled exception.
The reason is that the asm code that processes the exception was not
implemented with this in mind, and therefore lacks any handling of
On Mon, 28 Aug 2023 at 20:37, Kinney, Michael D
wrote:
>
> Hi Ard,
>
> I think your main question is how all developers can find the
> details of any of these types of test failures. It is not
> obvious until you notice there is a "Tests" tab on one of the
> Azure Pipelines pages.
>
> The main
Could someone please explain to me how I can figure out why this PR
was rejected by the CI?
https://github.com/tianocore/edk2/pull/4763
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108060):
; The second patch adds a unit test for the ImagePropertiesRecordLib. The
> >> logic tests various potential layouts of the EFI memory map and runtime
> >> images. 3/4 of these tests will fail which demonstrates the MAT logic
> >> bugs.
> >>
> >> The third
On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
>
> Hi,
>
> > I have tried the patch below, and I don't see any slowdowns with or
> > without the patch, running both DEBUG and RELEASE builds under
> > ordinary KVM/nested-virt. Note that the change in the first hunk will
> > cause the
On Thu, 24 Aug 2023 at 10:06, Gerd Hoffmann wrote:
>
> On Wed, Aug 23, 2023 at 07:10:52PM +0100, Pedro Falcato wrote:
> > On Wed, Aug 23, 2023 at 4:12 PM Ard Biesheuvel wrote:
> > >
> > > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote:
> > > >
: Leif Lindholm
> Cc: Rebecca Cran
> Cc: Liming Gao
> Cc: Bob Feng
> Cc: Yuwei Chen
> Cc: Ard Biesheuvel
Acked-by: Ard Biesheuvel
> ---
>
> Does anyone remember why these were added?
I added those when I first introduced Clang 3.5 support, and I am
quite sure i only a
On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote:
>
> On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote:
> > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote:
> > >
> > > Looks good to me.
> > >
> > > What is the status? Mer
ything.
>
OK.
> On 2023-05-24 15:05, Gerd Hoffmann wrote:
> > Tell clang to not use external (via got) references for data access.
> >
> > Signed-off-by: Gerd Hoffmann
> > Reviewed-by: Ard Biesheuvel
> > ---
> > BaseTools/Conf/tools_def.template | 6
On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote:
>
> On Thu, Jul 20, 2023 at 03:45:57PM +0200, Ard Biesheuvel wrote:
> > Instead of relying on raising the TPL to protect the critical sections
> > that manipulate the global bitmask that keeps track of bounce buffer
> >
GitHub PR: https://github.com/tianocore/edk2/pull/4750
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
> Cc: Gerd Hoffmann
>
> Signed-off-by: Oliver Smith-Denny
Reviewed-by: Ard Biesheuvel
Feel free to remind me to queue this up after the stable tag releas
On Tue, 15 Aug 2023 at 10:10, Ard Biesheuvel wrote:
>
> On Mon, 14 Aug 2023 at 10:15, Corvin Köhne wrote:
> >
> > On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> > > I'm not sure why test results are not being reported that may be a
> > > larger is
tTimeWakeUpAPsBySipi to false for AmdSev
> package, as was previously done for OvmfPkg variants.
>
> Fixes: eaffa1d7ff ("UefiCpuPkg:Wake up APs after power-up or RESET through
> SIPI.")
> Cc: YuanhaoXie
> Cc: Tom Lendacky
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Rahul Kum
On Wed, 16 Aug 2023 at 05:40, Rebecca Cran wrote:
>
> Intel has been releasing the EDK2/UEFI source code for their network
> drivers
> (https://www.intel.com/content/www/us/en/download/15755/intel-ethernet-connections-boot-utility-preboot-images-and-efi-drivers.html)
> but I've found a few
On Tue, 15 Aug 2023 at 18:31, Andrew Fish via groups.io
wrote:
>
>
>
> > On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote:
> >
> > On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io
> > wrote:
> >>
> >> Chao,
> >>
> >> From a quick google it looks like CSR* is used to access banks of
>
On Tue, 15 Aug 2023 at 10:20, Chao Li wrote:
>
> Hi Andrew,
>
> Yes, you are right, I also think that SMC is a bit flawed in terms of
> security, but can we use some security mechanism to protect the SMC, like
> encryption and decryption? Sorry, I'm not consider mature enough about SMC
>
On Mon, 14 Aug 2023 at 10:15, Corvin Köhne wrote:
>
> On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> > I'm not sure why test results are not being reported that may be a
> > larger issue.
> >
> > I pulled the branch locally, run uncrustify, and it automatically
> > fixed
> > the code
Could someone please decipher this for us please? I am sick and tired
of the CI impeding my work.
On Thu, 10 Aug 2023 at 15:33, Corvin Köhne wrote:
>
> On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote:
> > On Thu, 10 Aug 2023 at 14:53, Corvin Köhne
> > wrote:
> >
On Thu, 10 Aug 2023 at 14:53, Corvin Köhne wrote:
>
> On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote:
> > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote:
> > >
> > > Nit: "sizeof" is normally used like a function. And this patch
> > > m
On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote:
>
> The implementation of this new behavior aligns with the
> guidelines outlined in the Intel SDM.
>
> Following a power-up or RESET of an MP system, system hardware
> dynamically selects one of the processors on the system bus as
> the BSP. The
On Mon, 31 Jul 2023 at 00:44, Yuanhao Xie wrote:
>
> Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by
> INIT-SIPI-SIPI.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
>
Hi,
On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny
wrote:
>
> Hi Ard,
>
> I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head
> Allocated In First Page) to fix HeapGuard GuardAlignedToTail behavior on
> ARM64. However, this raised a question of why ARM64 sets
>
he pool head in the first place.
>
> With this patch in place, ArmVirtQemu boots with GuardAlignedToTail
> set to true (and when it is false, also).
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4521
> Github PR: https://github.com/tianocore/edk2/pull/4731
>
> Cc: L
t;
> > 1.Update the X64/AArch64 UEFI GOP driver into v1.13.03.
> > 2.Update the .inf version.
> > 3.Modify report framebuffer base behavior.
> >
> > Cc: Ard Biesheuvel
> > Cc: Isaac Oram
> > Cc: Nate DeSimone
> > Cc: Leif Lindholm
> > Cc: Micha
On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote:
>
> Nit: "sizeof" is normally used like a function. And this patch mixes the
> two styles.
>
Actually, this is not unidiomatic for OVMF - sizeof takes either a
type name (in which case the () are required) or an expression (in
which case they are
upported +
> > mQemuFwCfgDmaSupported")
> > Signed-off-by: Corvin Köhne
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Gerd Hoffmann
> > Cc: Rebecca Cran
> > Cc: Peter Grehan
> > ---
> > OvmfPkg/Bh
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran wrote:
>
> There's an extra format specifier in the DEBUG_ERROR message that
> gets printed when the PCIe link check fails. This causes a
> synchronous exception. Remove the string format specifier.
>
> Signed-off-by: Rebecca Cran
Thanks
Pushed as
On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote:
>
> On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D
> wrote:
> >
> > Hi Ard,
> >
> > This is the email with the analysis and the flag
> > setting required for SMP to work with SMM enabled for
> > IA
301 - 400 of 3197 matches
Mail list logo
