ute concurrently. (It will be very hard to
catch/reproduce true concurrency issues in TCG anyway)
Oliver, mind spinning a v2?
Thanks,
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Thursday, August 3, 2023 9:54 AM
> > To: devel@edk2.groups.io; mikub.
On Thu, 3 Aug 2023 at 16:37, Michael Kubacki
wrote:
>
> For the series.
>
> Reviewed-by: Michael Kubacki
>
Thanks
I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG
keeps timing out for me
https://github.com/tianocore/edk2/pull/4718
Might it help if we restrict SMP to a
>
Is there any basis in the UEFI or PI specifications for this functionality?
> On 7/26/2023 1:45 AM, Ard Biesheuvel wrote:
> > On Mon, 24 Jul 2023 at 22:15, Kun Qin wrote:
> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466
> >>
> >> This p
t allocate memory when ConOut is available and instead use
> stack memory to convert the Ascii string needed for SerialPortWrite
> to the Unicode string needed for ConOut->OutputString. Correspondingly,
> ArmVirtQemu can now output the stack dump and CPU state when hitting
> an exceptio
On Tue, 18 Jul 2023 at 12:22, Marcin Juszkiewicz
wrote:
>
> From: Masahisa Kojima
>
> Fix typo in Readme.md
>
> Signed-off-by: Masahisa Kojima
> Signed-off-by: Marcin Juszkiewicz
> ---
> Platform/Qemu/SbsaQemu/Readme.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Pushed,
On Wed, 19 Jul 2023 at 14:09, Marcin Juszkiewicz
wrote:
>
> SBSA Reference Platform can have GIC ITS present. And when it has then
> we can have complex PCI Express setup (and some other things).
>
> First patch adds support for GIC ITS. Address is read from TF-A via SMC
> call. IORT is
On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324
> PR: https://github.com/tianocore/edk2/pull/4711
>
> This series switches the OVMF CI jobs on Windows to a recent Qemu
> version and re-enables SMP in the Qemu "Run to shell" CI jobs.
e boot
support, and everything appears to operate as intended. (I didn't
manage to unlock my Linux root volume automatically but that appears
to be broken with openssl 1.1.1 as well)
So for the series
Acked-by: Ard Biesheuvel
Tested-by: Ard Biesheuvel
Let's not sit on this too long - Tianoco
On Wed, 2 Aug 2023 at 18:21, Oliver Smith-Denny
wrote:
>
> On 8/2/2023 9:06 AM, Ard Biesheuvel wrote:
> > On Tue, 1 Aug 2023 at 00:04, Oliver Smith-Denny
> > wrote:
> >>
> >> If gST->ConOut is available when Arm's DefaultExceptionHandler
> >> i
ode string needed for ConOut->OutputString. Correspondingly,
> ArmVirtQemu can now output the stack dump and CPU state when hitting
> an exception in memory code.
>
> GitHub PR: https://github.com/tianocore/edk2/pull/4703
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
&g
Thanks all.
Merged now as #4701
On Mon, 31 Jul 2023 at 13:29, Rebecca Cran wrote:
>
> Sorry for the delay. I've just added my R-b.
>
>
> --
>
> Rebecca
>
>
> On 7/31/23 04:29, Ard Biesheuvel wrote:
> > On Fri, 28 Jul 2023 at 07:32, Sunil V L wrote:
>
On Fri, 28 Jul 2023 at 07:32, Sunil V L wrote:
>
> On Tue, Jul 25, 2023 at 05:59:25PM +0200, Ard Biesheuvel wrote:
> > On Fri, 21 Jul 2023 at 06:52, Sunil V L wrote:
> > >
> > > On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote:
> > > > O
On Mon, 31 Jul 2023 at 02:46, Rebecca Cran wrote:
>
> For the series:
>
>
> Reviewed-by: Rebecca Cran
>
Thanks for taking care of this.
In the future, when you merge patches for a package that you don't
maintain, could you please mention this in a reply to the thread? That
way, I'll know I
On Mon, 31 Jul 2023 at 03:39, Rebecca Cran wrote:
>
> I've set up a public-inbox instance for edk2-devel at
> https://openfw.io/edk2-devel .
>
Excellent, thanks for doing this!
> This lets people use the 'b4' tool
> (https://b4.docs.kernel.org/en/latest/) to apply patches from the
> mailing
corrupt memory or straight-up crash.
>
> Make it EFI spec compliant, by adding proper NULL pointer checks
> around RI_SET_MSK and TI_SET_MSK retrieval/clearing.
>
> --
>
> In any case, take my:
>
> Acked-by: Pedro Falcato
>
Thanks,
I've pushed this as 4f316893c9ed..cbab
On Fri, 14 Jul 2023 at 15:03, Marcin Juszkiewicz
wrote:
>
> Update the TF-A binaries to have Neoverse-V1 cpu support.
>
> This support was merged into TF-A:
>
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/21813
>
> This allows SBSA Reference Platform to boot Linux on
;
> This change was tested on QEMU, FVP and proprietary hardware platforms.
>
> Pathc v1 branch: https://github.com/kuqin12/edk2/tree/improve_gic_v1
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Kun Qin (3):
> ArmPkg: ArmGic: Added support to sen
On Fri, 21 Jul 2023 at 06:52, Sunil V L wrote:
>
> On Mon, Jul 17, 2023 at 11:38:31AM +0200, Ard Biesheuvel wrote:
> > On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io
> > wrote:
> > >
> > > Sunil:
> > > Do you use whic
On Mon, 24 Jul 2023 at 19:28, Pedro Falcato wrote:
>
> On Mon, Jul 24, 2023 at 6:07 PM wrote:
> >
> > I am developing a UEFI application which functions as a bootloader. It is
> > required to handle loading between two Linux kernels dependending on which
> > one failed last (A/B system).
> >
On Sat, 22 Jul 2023 at 00:55, Pedro Falcato wrote:
>
> On Thu, Jul 20, 2023 at 2:46 PM Ard Biesheuvel wrote:
> >
> > Instead of relying on raising the TPL to protect the critical sections
> > that manipulate the global bitmask that keeps track of bounce buffer
>
comment to reflect that AllocatePool() is being avoided due to its
64k allocation size limit when the library is incorporated into a PEI
component.
Thanks,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel
> Sent: Friday, July 21, 2023 10:49 PM
>
On Fri, 21 Jul 2023 at 17:38, chitralekha ck wrote:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4507
> AllocatePool limits to allocate memory of 64 KB at most.
What is the basis for this observation? In DXE, pool allocations are
unbounded afaik.
> if the the image size is higher than
On Thu, 20 Jul 2023 at 19:10, Michael D Kinney
wrote:
>
> Hi Ard,
>
> This is my mistake. I usually check the Author field when
> adding Rb/Ab tags because I have seen lots of cases where
> the Author field needs updating as well. I forgot to do this
> step in this one.
>
> I agree a CI check
On Thu, 20 Jul 2023 at 03:41, Michael D Kinney
wrote:
>
> Merged: https://github.com/tianocore/edk2/pull/4666
>
This commit is now merged as
commit 6510dcf6f71adbe282bff0ba2b236f1d074f819f
Author: devel@edk2.groups.io
AuthorDate: Fri Feb 10 04:34:03 2023 -0800
Commit: mergify[bot]
On Thu, 20 Jul 2023 at 16:30, G Edhaya Chandran wrote:
>
> The patch is upstreamed by:
> https://github.com/tianocore/edk2-test/commit/315e3a56a6d9261d4fad4c1950f2d01a052eeba4
Checking the memory map for memory below 4G only makes sense if the
system has no IOMMU and does not use translation
: Michael Brown
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2211060
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 100
OvmfPkg/IoMmuDxe/IoMmuDxe.inf | 1 +
2 files changed, 60 insertions(+), 41 deletions(-)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
On Thu, 20 Jul 2023 at 10:28, Gerd Hoffmann wrote:
>
> > > > mReservedMemBitmap &= (UINT32)(~MapInfo->ReservedMemBitmap);
> > >
> > > I'd expect modern compilers optimize that to a single instruction,
> >
> > You mean something along the lines of
> >
> > andl %reg, mReservedMemBitmap(%rip)
>
On Thu, 20 Jul 2023 at 10:24, Gerd Hoffmann wrote:
>
> IoMmuAllocateCommonBuffer has the very same allocation pattern
> IoMmuAllocateBounceBuffer uses, so the fix added by commit a52044a9e602
> ("OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer") is needed
> here too.
>
> Reported-by:
On Wed, 19 Jul 2023 at 19:40, Michael Brown wrote:
>
> On 19/07/2023 17:52, Ard Biesheuvel wrote:
> > On Wed, 19 Jul 2023 at 18:32, Gerd Hoffmann wrote:
> >> On Wed, Jul 19, 2023 at 04:04:28PM +, Michael Brown wrote:
> >>> It looks as though IoMmuFre
On Wed, 19 Jul 2023 at 18:31, Gerd Hoffmann wrote:
>
> Searching for an unused bounce buffer in mReservedMemBitmap and
> reserving the buffer by flipping the bit is a critical section
> which must not be interrupted. Raise the TPL level to ensure
> that.
>
> Without this fix it can happen that
On Wed, 19 Jul 2023 at 18:32, Gerd Hoffmann wrote:
>
> On Wed, Jul 19, 2023 at 04:04:28PM +, Michael Brown wrote:
> > On 19/07/2023 12:33, Gerd Hoffmann wrote:
> > > Searching for an unused bounce buffer in mReservedMemBitmap and
> > > reserving the buffer by flipping the bit is a critical
from existing DSCs for library classes that only
have a single implementation.
For this series,
Acked-by: Ard Biesheuvel
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107031): https://edk2.groups.io/g/devel/message/107031
Mute This Topic
On Mon, 17 Jul 2023 at 18:15, Pedro Falcato wrote:
>
> On Wed, Jul 12, 2023 at 12:53 AM Taylor Beebe wrote:
> >
> > In the past, memory protection settings were configured via FixedAtBuild
> > PCDs,
> > which resulted in a build-time configuration of memory mitigations. This
> > approach
On Mon, 17 Jul 2023 at 03:51, gaoliming via groups.io
wrote:
>
> Sunil:
> Do you use which CLANG version is used to verify this change?
>
For the series,
Tested-by: Ard Biesheuvel # Debian clang version 14.0.6
> > -邮件原件-
> > 发件人: Sunil V L
> > 发送时间: 2
On Fri, 14 Jul 2023 at 22:28, Tom Lendacky wrote:
>
> Commit 63c50d3ff2854a76432b752af4f2a76f33ff1974 changed the check that is
> used to determine if SEV-ES is active. Originally, a CMP instruction with
> a supporting JZ instruction was used for the check. It was changed to use
> the BT
On Thu, 13 Jul 2023 at 18:57, Pedro Falcato wrote:
>
> On Tue, Jul 11, 2023 at 7:58 AM Gerd Hoffmann wrote:
> >
> > On Mon, Jul 10, 2023 at 04:58:15PM +0100, Pedro Falcato wrote:
> > > On Mon, Jul 10, 2023 at 2:28 PM wrote:
> > > >
> > > > I have an existing install of Ubuntu 22.04 on a QEMU
On Wed, 12 Jul 2023 at 10:41, Gerd Hoffmann wrote:
>
> Hi,
>
> Tried to debug a bug which looks like memory corruption, turned on page
> and heap guard:
>
> PcdHeapGuardPageType=0x7e
> PcdHeapGuardPoolType=0x7e
> PcdHeapGuardPropertyMask=0x03
>
> With that the firmware
On Wed, 12 Jul 2023 at 09:06, Wu, Hao A wrote:
>
> It works for me, better to override by:
>
> Status = EFI_SUCCESS;
>
>
So now we're adding unnecessary assignments just to please coverity? I
don't think this is a good idea.
If Coverity does not understand that the source references Status
d potetial return values.
>
> Taylor Beebe (4):
> ArmPkg: Apply Uncrustify to Non-Compliant Files
> ArmPkg: Update GetMemoryRegion() to Handle No mapping
> ArmPkg: Fix Unsafe ASSERTs in MMU Logic
> ArmPkg: Add Function Headers to MMU Logic
>
> Cc: Leif Lindholm
EDK2 for different architectures.
>
> Cc: Rebecca Cran
> Cc: Liming Gao
> Cc: Bob Feng
> Cc: Yuwei Chen
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc Gerd Hoffmann
> Cc: Andrei Warkentin
> Cc: Heinrich Schuchardt
>
> Sunil V L (4):
> OvmfP
k2/tree/arm_var_pei_v3
>
> Cc: Hao A Wu
> Cc: Liming Gao
> Cc: Jian J Wang
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Kun Qin (2):
> ArmPkg: MmCommunicationPei: Introduce MM communicate in PEI
> MdeModulePkg: Variable: Introduce
> used as communicate buffer and SMC will be invoked to communicate to
> TrustZone when MMI is requested.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Cc: Sami Mujawar
>
> Co-authored-by: Ronny Hansen
> Co-authored-by: Shriram Masanamuthu Chinnathurai
> Co-auth
.
Signed-off-by: Ard Biesheuvel
---
OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
index df545c080e9d9212..fd34ad75a9a079ce 100644
--- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
On Wed, 21 Jun 2023 at 16:13, Pedro Falcato wrote:
>
> On Wed, Jun 21, 2023 at 8:55 AM Gerd Hoffmann wrote:
> >
> > On Wed, Jun 21, 2023 at 01:40:06AM +0100, Pedro Falcato wrote:
> > > On Tue, 20 Jun 2023, 12:11 Li, Yi, wrote:
> > >
> > > > The effect of LTO is limited with optimization turned
On Mon, 26 Jun 2023 at 12:38, Gerd Hoffmann wrote:
>
> Smallest IO window size for PCI bridges is 0x1000. Fix default size
> accordingly. Avoids broken resource assignments like this:
>
> [ ... ]
> PciBus: Resource Map for Root Bridge PciRoot(0x0)
> Type = Io16; Base = 0x6000;
On Tue, 20 Jun 2023 at 16:27, Gerd Hoffmann wrote:
>
> On Mon, Jun 12, 2023 at 07:27:37PM +, Kallol Biswas [C] wrote:
> > Hi,
> > We have been observing an issue that IO BARs can't be claimed due to
> > resource
> > conflict.
> >
> > [0.457693] pci :00:1d.0: can't claim BAR 4 [io
On Sun, 25 Jun 2023 at 04:59, gaoliming via groups.io
wrote:
>
> For the changes in MdeModulePkg, Reviewed-by: Liming Gao
>
>
Merged as #4573
Thanks all.
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Michael
> > Kubacki
> > 发送时间: 2023年6月7日 7:13
Now that we have a sane API to set and clear memory permissions that
works the same on ARM and AArch64, we no longer have a need for the
individual set/clear no-access/read-only/no-exec helpers so let's drop
them.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuDxe.c
The OP-TEE secure OS exposes a non-secure memory region for
communication between the secure OS itself and any clients in the
non-secure firmware. This memory is writable by non-secure and is not
used for code only data, and so it should be mapped non-executable.
Signed-off-by: Ard Biesheuvel
StandaloneMm has its own version of the ArmMmuLib library class, but
includes the ArmMmuLib header. This happens to work because the
prototypes that are referenced are the same, but this will no longer be
the case after a future patch. So correct the #includes.
Signed-off-by: Ard Biesheuvel
A couple of tweaks for the memory attribute handling code to go on top
of the memory attribute PPI changes.
Cc: Sami Mujawar
Cc: Leif Lindholm
Ard Biesheuvel (3):
StandaloneMmPkg: Include correct MmuLib header
ArmPkg: Drop individual memory permission helpers
ArmPkg/OpteeLib: Map shared
ran
> Acked-by: Gerd Hoffmann
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Peter Grehan
Merged as #4568
Thanks.
> ---
> OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++--
> OvmfPkg/Bhyve/BhyveX64.fdf | 7 +++
> 2 files changed, 22 insert
On Wed, 21 Jun 2023 at 09:31, Corvin Köhne wrote:
>
> CI: https://github.com/tianocore/edk2/pull/4545
>
> Corvin Köhne (6):
> OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
> OvmfPkg: avoid including AcpiPlatformLib twice
> OvmfPkg: move PciEncoding into AcpiPlatformLib
>
On Tue, 20 Jun 2023 at 19:07, Sean Brogan wrote:
>
> I don't think a MemoryAttributes2Protocol with a single API would have
> avoided the errors.
>
> The programming pattern that triggered this would still need multiple calls
> to any API and in the future where all memory is allocated as NX
On Fri, 23 Jun 2023 at 18:03, Joey Vagedes wrote:
>
> Utilize GenFw to automatically set the NXCOMPAT bit of the DLL Characteristics
> field of the Optional Header if the following requirements are met:
>
> 1. It is a 64bit PE
> 2. The section alignment is evently divisible by 4K
> 3. No section
On Tue, Jun 20, 2023, 12:33 Gerd Hoffmann wrote:
> On Mon, Jun 19, 2023 at 10:32:25PM +0200, Oliver Steffen wrote:
> > Recent versions of shim (15.6 and 15.7) crash when the newly added
> > EFI_MEMORY_ATTRIBUTE_PROTOCOL is provided by the firmware. To allow
> > existing installations to boot,
ential VMs).
It also provides a better basis for architectures to carry their own
specific logic for this, instead of having a subdirectory for each
arch under DxeIpl/
> On 6/8/2023 2:27 PM, Sean wrote:
> > On 6/8/2023 10:48 AM, Ard Biesheuvel wrote:
> >> On Thu, 8 Jun 2023 a
On Thu, 8 Jun 2023 at 19:39, Oliver Smith-Denny
wrote:
>
> On 6/8/2023 10:23 AM, Ard Biesheuvel wrote:
> > Currently, we rely on the logic in DXE IPL to create new page tables
> > from scratch when executing in X64 mode, which means that we run with
> > the initial page t
The DEBUG print that outputs the base and size of the page table
allocation always prints 0x0 for the size, given that BufferSize will be
updated by PageTableMap () and contain the unused allocation on return.
So move the DEBUG print right after the allocation.
Signed-off-by: Ard Biesheuvel
that switching
between 4 and 5 levels of paging is not currently supported without
dropping out of 64-bit mode temporarily, all we can do is carry on
without changing the number of levels.
Signed-off-by: Ard Biesheuvel
---
UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 2 +
UefiCpuPkg/CpuMpPei/CpuPaging.c
Beebe
Cc: Oliver Smith-Denny
Cc: Dandan Bi
Cc: Dun Tan
Cc: Liming Gao
Cc: "Kinney, Michael D"
Cc: Michael Kubacki
Cc: Eric Dong
Cc: Rahul Kumar
Cc: Kun Qin
Ard Biesheuvel (2):
UefiCpuPkg/CpuMpPei: Print correct buffer size used for page table
UefiCpuPkg/CpuMpPei X64: Reall
On Thu, 8 Jun 2023 at 04:28, duntan wrote:
>
> Remove RO and NX protection when unset guard page.
> When UnsetGuardPage(), remove all the memory attribute protection
> for guarded page.
>
Why is it acceptable to remove NX protections here?
> Signed-off-by: Dun Tan
> Cc: Liming Gao
> Cc: Ray
> This mitigates the issue seen, however, additional investigations
> >
> > into setting the GCD attributes earlier and maintaining a better
> >
> > sync between the GCD and the page table are being done.
> >
> >
> >
> > Feedback on this proposal is g
On Wed, 7 Jun 2023 at 19:02, Rebecca Cran wrote:
>
>
> On 6/7/23 11:00, Ard Biesheuvel wrote:
> > On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote:
> >> I've pushed it.
> >>
> >
> > Thanks! How did you manage that?
>
>
> I just rea
On Wed, 7 Jun 2023 at 17:39, Rebecca Cran wrote:
>
> I've pushed it.
>
Thanks! How did you manage that?
>
> On 6/7/23 09:09, Ard Biesheuvel wrote:
> > I found the button too, and it works as expected.
> >
> > While the ongoing CI issues are investigat
> because without this patch, the GCD sync will show all memory as
> EFI_MEMORY_RP.
>
I already attempted to merge this iirc, but whether it got merged in
the end is anyone's guess :-)
>
> On 5/23/2023 1:48 PM, Ard Biesheuvel wrote:
> > On Tue, 23 May 2023 at 22:36, Oliver
e and the drop down for "Re-run failed checks" is available.
>
> Best Regards,
> Hao Wu
>
> > -Original Message-
> > From: Kinney, Michael D
> > Sent: Wednesday, June 7, 2023 11:08 AM
> > To: Wu, Hao A ; devel@edk2.groups.io; Ard
> > Biesheu
On Wed, 7 Jun 2023 at 12:32, Sami Mujawar wrote:
>
> Supreeth is no longer supreeth.venkat...@arm.com. Therefore,
> remove the reviewer entry from StandaloneMmPkg.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Ray Ni
>
> Signed-off-by: Sami Mujawar
Th
On Wed, 7 Jun 2023 at 05:26, Ni, Ray wrote:
>
> The Shell binaries are not generated anymore in each
> stable tag release.
> So, remove the section.
>
> Cc: Zhichao Gao
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: Ray Ni
Reviewed-by: Ard Biesheuvel
&
gned-off-by: Ray Ni mailto:ray...@intel.com>>
> Cc: Ard Biesheuvel <mailto:ardb+tianoc...@kernel.org>>
> Cc: Sami Mujawar mailto:sami.muja...@arm.com>>
> Cc: Jiewen Yao mailto:jiewen@intel.com>>
> Cc: Supreeth Venkatesh <mailto:supreeth.venkat...@
On Tue, 6 Jun 2023 at 20:48, Michael Kubacki
wrote:
>
> On 6/2/2023 11:17 AM, Ard Biesheuvel wrote:
> > The Risc-V and LoongArch specific versions of the DXE core handoff code
> > in DxeIpl are essentially copies of the EBC version (modulo the
> > copyright in the head
On Tue, 6 Jun 2023 at 21:55, Kinney, Michael D
wrote:
>
> All EDK II Maintainers should now have permissions to "re-run failed jobs".
>
> If you see a PR with failed jobs that are not related to the code change,
> then try rerunning the specific failed job or select "re-run failed jobs"
> from
On Tue, 6 Jun 2023 at 11:22, Corvin Köhne wrote:
>
> CI: https://github.com/tianocore/edk2/pull/4379/checks
>
> Corvin Köhne (3):
> OvmfPkg/Xen: export search of RSDP into a library function
> OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib
> OvmfPkg/Bhyve: install ACPI
b/Maintainers.txt
> @@ -374,7 +374,6 @@ F: Silicon/Qemu/SbsaQemu/
> M: Ard Biesheuvel
> M: Leif Lindholm
> R: Graeme Gregory
> -R: Radoslaw Biernacki
>
> Raspberry Pi platforms and silicon
> F: Platform/RaspberryPi/
> --
> 2.41.0.rc0.172.g3f132b7071-goog
&g
On Mon, 5 Jun 2023 at 14:48, Yuquan Wang wrote:
>
> This patchset implements XHCI on sbsa-ref board to replace EHCI.
> As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
> that only has 32-bit DMA capablity. Now this board has XHCI as
> an available usb controller with 64-bit DMA
On Mon, 5 Jun 2023 at 12:53, wangyuquan1236
wrote:
>
> Sorry for my awkward operations, because I felt the email refused problem
> with devel@edk2.groups.io;
Are you subscribed to the mailing list?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
On Mon, 5 Jun 2023 at 12:50, Yuquan Wang wrote:
>
> This patchset implements XHCI on sbsa-ref board to replace EHCI.
> As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
> that only has 32-bit DMA capablity. Now this board has XHCI as
> an available usb controller with 64-bit DMA
ny promotion to unsigned long, which should make the warning go away.
>
> On Mon, Jun 5, 2023 at 4:28 AM Ard Biesheuvel wrote:
>>
>> On Fri, 2 Jun 2023 at 21:42, Ranbir Singh wrote:
>> >
>> > From: Ranbir Singh
>> >
>> > Line number 1348 does
developers / owners / maintainers if they indeed feel
> that there is a bug here and it needs to be fixed.
>
Thanks - I agree that it is a good thing that people are aware of this now.
> On Mon, Jun 5, 2023 at 4:33 AM Ard Biesheuvel wrote:
>>
>> On Sat, 3 Jun 2023 at 18:04, Pedro
On Sat, 3 Jun 2023 at 18:04, Pedro Falcato wrote:
>
> On Fri, Jun 2, 2023 at 8:42 PM Ranbir Singh wrote:
> >
> > From: Ranbir Singh
> >
> > The return value stored in Status after call to SetDriveParameters
> > is not made of any use thereafter and hence it remains as UNUSED.
> > Assuming, this
On Fri, 2 Jun 2023 at 21:42, Ranbir Singh wrote:
>
> From: Ranbir Singh
>
> Line number 1348 does contain a typecast with UINT32, but it is after
> all the operations (16-bit left shift followed by OR'ing) are over.
> To avoid any SIGN_EXTENSION, typecast the intermediate result after
> 16-bit
Another one
https://github.com/tianocore/edk2/pull/4473
On Sat, 3 Jun 2023 at 00:32, Ard Biesheuvel wrote:
>
> Thanks!
>
> On Fri, 2 Jun 2023 at 18:38, Michael D Kinney
> wrote:
> >
> > Done.
> >
> > Mike
> >
> > > -Original Message-
On Sat, 3 Jun 2023 at 00:49, Ard Biesheuvel wrote:
>
> On Fri, 2 Jun 2023 at 23:20, Lendacky, Thomas via groups.io
> wrote:
> >
> > On 1/26/23 14:26, Mikolaj Lisik wrote:
> > > Edk2 was failing, rather than creating more PML4 entries, when they
> > >
On Fri, 2 Jun 2023 at 23:20, Lendacky, Thomas via groups.io
wrote:
>
> On 1/26/23 14:26, Mikolaj Lisik wrote:
> > Edk2 was failing, rather than creating more PML4 entries, when they
> > weren't present in the initial memory acceptance flow. Because of that
> > VMs with more than 512G memory were
> ; Sean Brogan
> > Cc: Kinney, Michael D
> > Subject: RE: [edk2-devel] failed pr
> >
> > I am working on it.
> >
> > Mike
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io On Behalf Of Ard
> > > Biesheuvel
>
Could someone push the merge button on this pr please?
https://github.com/tianocore/edk2/pull/4470
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105661): https://edk2.groups.io/g/devel/message/105661
Mute This Topic:
any discretion on the part of the maintainer.
[0] https://github.com/tianocore/edk2/pull/4470
>
> On 6/2/2023 4:51 AM, Ard Biesheuvel wrote:
> > Uncrustify checks are too rigid, making them counter-productive:
> >
> > - it leads to code that is arguably harder to parse visually
Now that ArmSetMemoryAttributes() permits a mask to be provided, we can
simplify the implementation the UEFI memory attribute protocol
substantially, and just pass on the requested mask to be set or cleared
directly.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/MemoryAttribute.c | 50
Now that we have a generic method to manage memory permissions using a
PPI, we can switch to the generic version of the DXE handoff code in
DxeIpl, and drop the ARM specific version.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 71
Implement the newly defined PPI that permits the PEI core and DXE IPL to
manage memory permissions on ranges of DRAM, for doing things like
mapping the stack non-executable, or granting executable permissions to
shadowed PEIMs.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuPei/CpuPei.c
an AttributeMask parameter to ArmSetMemoryAttributes(),
which is permitted to be non-zero if no memory type is being provided,
in which case only memory permission attributes covered in the mask will
be affected by the update.
Signed-off-by: Ard Biesheuvel
---
ArmPkg/Drivers/CpuDxe/CpuMmuCommon.c
If the associated PCD is set to TRUE, use the memory attribute PPI to
remap the stack non-executable. This provides a generic method for doing
so, which will be used by ARM and AArch64 as well once they move to the
generic DxeIpl handoff implementation.
Signed-off-by: Ard Biesheuvel
, let's merge these versions, so we only need to
add this logic once.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/DxeIplPeim/{Ebc/DxeLoadFunc.c => DxeHandoff.c} | 2 +-
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 10 +--
MdeModulePkg/Core/DxeIplPeim/LoongArc
writable and executable at the same time.
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Include/Ppi/MemoryAttribute.h | 83
MdeModulePkg/MdeModulePkg.dec | 3 +
2 files changed, 86 insertions(+)
diff --git a/MdeModulePkg/Include/Ppi/MemoryAttribute.h
b
: Oliver Smith-Denny
Cc: Dandan Bi
Cc: Dun Tan
Cc: Liming Gao
Cc: "Kinney, Michael D"
Cc: Leif Lindholm
Cc: Michael Kubacki
Ard Biesheuvel (7):
MdeModulePkg: Define memory attribute PPI
MdeModulePkg/DxeIpl: Merge EBC, RISCV64 and LOONGARCH code
MdeModulePkg/DxeIpl: Use memory
On Wed, 24 May 2023 at 02:41, Minh Nguyen
wrote:
>
> These patches helps to add new SMBIOS Tables (Type 16, 17, 19) and refactor
> SmbiosPlatformDxe.
>
> Minh Nguyen (4):
> JadePkg: Correct PCD names for SMBIOS Type 0
> JadePkg: Leverage ArmPkg/Smbios (Type 0, 1, 2, 3, 13, 32)
> JadePkg:
On Thu, 11 May 2023 at 10:10, Minh Nguyen
wrote:
>
> These patches support NVMe Hot Plug feature for Ampere Altra and Ampere Altra
> Max.
>
> Minh Nguyen (2):
> AmpereAltraPkg: Add Hot Plug Slot Capable during PCIe port
> initialization
> AmpereAltraPkg: Change PCIe Amba Link Timeout
On Wed, 24 May 2023 at 02:45, Minh Nguyen
wrote:
>
> Hi Leif and Ard
>
> Could you please help merge this series?
>
Pushed as 4303f7782c08..a869bae89a6d
Thanks,
>
> On 5/11/2023 2:51 PM, Minh Nguyen wrote:
> > These patches help to improve PCIe core for Link training sequence and
> > add
On Fri, 2 Jun 2023 at 05:10, Michael Kubacki
wrote:
>
> Sounds good, thanks for the quick response. Can you please send a
> calendar invite when you get a chance?
>
> On 6/1/2023 10:42 PM, Ni, Ray wrote:
> > It's a good idea to have a focus area ("project") for everyone working
> > together on
On Fri, 2 Jun 2023 at 04:53, Yao, Jiewen wrote:
>
> Hi Ard
> Would you please take a look at
> https://github.com/tianocore/edk2-staging/tree/OpenSSL30, which is our
> current working version? If you have any idea, please propose patch.
>
> Also, could you please try that on ARM/AARCH64
401 - 500 of 3197 matches
Mail list logo