Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 16:32, Ard Biesheuvel wrote: > > On Mon, 15 Jan 2024 at 16:27, Gerd Hoffmann wrote: > > > > On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote: > > > This series adds support for cloud-hypervisor guests with >1TiB > > >

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2024-01-15 Thread Ard Biesheuvel
.cgi?id=1468526. The bug is > > still occuring for CloudHv guests because the PlatformScanE820 > > utility is not currently supported for CloudHv. > > > > My working branch for these changes can be found here: > > https://github.com/thomasbarrett/edk2/tree/cloud-hv-1tb-ram

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > > On 1/12/24 12:37, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > Gerd Hoffmann (4): > >

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-16 Thread Ard Biesheuvel
On Tue, 16 Jan 2024 at 10:37, Laszlo Ersek wrote: > > On 1/15/24 18:56, Ard Biesheuvel wrote: > > On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > >> > >> On 1/12/24 12:37, Gerd Hoffmann wrote: > >>> This is a little series containing the flash c

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: drop support for TPM 1.2

2024-01-16 Thread Ard Biesheuvel
(cc Jiewen. Laszlo) On Tue, 16 Jan 2024 at 16:42, Gerd Hoffmann wrote: > > > > Gerd Hoffmann (2): > OvmfPkg: remove TPM1_ENABLE build option > OvmfPkg/Tcg2Config: remove unused TPM 1.2 support > Good riddance Acked-by: Ard Biesheuvel -=-=-=-=-=-=-=-=-=-=-=- Groups.

Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-18 Thread Ard Biesheuvel
On Thu, 18 Jan 2024 at 21:28, Laszlo Ersek wrote: > > On 1/16/24 18:10, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > v3: > > - fix diagram >

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-19 Thread Ard Biesheuvel
On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: > > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1)

Re: [edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

2024-01-23 Thread Ard Biesheuvel
eInterrupts(), which also sets both > flags). > > Tested by patching ArmPkg's TimerDxe to use NestedInterruptTplLib and > verifying that ArmVirtQemu passes the NestedInterruptTplLib self-tests > for both ARM and AARCH64. > > Cc: Ard Biesheuvel > Signed-off-by: Michael

Re: [edk2-devel] [PATCH RESEND 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

2024-01-23 Thread Ard Biesheuvel
On Mon, 22 Jan 2024 at 03:34, Nhi Pham via groups.io wrote: > > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1)

Re: [edk2-devel] [PATCH v5 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

2024-01-25 Thread Ard Biesheuvel
vant information > > A patchset for Juno-r2 platforms will be submitted to demonstrate > this functionality. > > [1] https://edk2.groups.io/g/devel/message/111901 > > Pierre Gondois (11): > ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION > ArmPkg/ArmScmiDxe: Add PERFORMANCE_DE

Re: [edk2-devel] [PATCH] OvmfPkg/VirtioMmioDeviceLib: virtio 1.0: Fix SetQueueAlignment.

2023-04-12 Thread Ard Biesheuvel
On Fri, 24 Mar 2023 at 13:30, Gerd Hoffmann wrote: > > On Fri, Mar 24, 2023 at 01:42:17AM +, Jeff Brasen wrote: > > Nothing to do here for virtio 1.0 devices > > > > Signed-off-by: Jeff Brasen > > --- > > .../Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 4 +++- > > 1 file chan

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Platform/ARM/JunoPkg: Increase FV size and enable NOOPT build

2023-04-12 Thread Ard Biesheuvel
On Tue, 11 Apr 2023 at 15:46, Rebecca Cran wrote: > > The current FV size of 996KB for the Juno platform is rather restrictive > nowadays: a NOOPT build can be made to fit, but when enabling HTTPS boot > the firmware size becomes far too large even with an optimized DEBUG build. > > Since the size

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-14 Thread Ard Biesheuvel
On Fri, 14 Apr 2023 at 16:37, Gerd Hoffmann wrote: > > On Fri, Apr 14, 2023 at 12:29:21PM +, Marvin Häuser wrote: > > Hi Gerd, > > > > Thanks for your effort! > > > > Sorry, but I *really* dislike this “BASETOOLS” notion. There might be > > external tools that also want to use the header (like

Re: [edk2-devel] Strange behavior between GCC 11 and GCC 12

2023-04-14 Thread Ard Biesheuvel
On Fri, 14 Apr 2023 at 22:23, Tom Lendacky wrote: > > I've been trying to debug a problem I'm seeing when I moved to the GCC 12 > compiler. Under SEV it results in the guest crashing. > > I narrowed the issue down to the call to TemporaryRamMigration() in > PeiCheckAndSwitchStack() of MdeModulePkg

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-17 Thread Ard Biesheuvel
acro, which > > declares the alignment constraint right before the function label. > > > > Signed-off-by: Marvin Häuser > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Cc: Vitaly Cheptsov > > --- > > ArmPkg/Include/AsmMac

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 08:40, Marvin Häuser wrote: > > > > On 17. Apr 2023, at 23:18, Ard Biesheuvel wrote: > > > > Agree with all of this. > > > > And thanks for tracking this down - must not have been fun :-) > > No worries - it wasn’t. :) It was m

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 10:18, Marvin Häuser wrote: > > > > > On 18. Apr 2023, at 10:10, Ard Biesheuvel wrote: > > > > On Tue, 18 Apr 2023 at 08:40, Marvin Häuser wrote: > >> > >> > >>> On 17. Apr 2023, at 23:18, Ard Biesheuvel wrote: &

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 13:52, Gerd Hoffmann wrote: > > Hi, > > > > Underlying problem is that x64 ProcessorBind.h sets visibility to > > > hidden (anyone knows why?). > > > > Yes. Toolchains tend to assume that you are generating code for a > > shared library once you enabled -fpic, and this res

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver

2023-04-18 Thread Ard Biesheuvel
On Mon, 17 Apr 2023 at 11:03, Gerd Hoffmann wrote: > This seems useful - how do I use it? > > > Gerd Hoffmann (4): > OvmfPkg: add IndustryStandard/VirtioSerial.h > OvmfPkg/VirtioSerialDxe: add driver > OvmfPkg/VirtioSerialDxe: wire up in OvmfPkg* > OvmfPkg/PlatformBootManagerLib: setup

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-04-18 Thread Ard Biesheuvel
On Tue, 18 Apr 2023 at 15:20, Gerd Hoffmann wrote: > > On Tue, Apr 18, 2023 at 01:59:43PM +0200, Ard Biesheuvel wrote: > > On Tue, 18 Apr 2023 at 13:52, Gerd Hoffmann wrote: > > > > > > Seems to work fine on fedora 37, even without adding --relax, maybe this > &g

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-19 Thread Ard Biesheuvel
; Best regards, > Marvin > > > On 18. Apr 2023, at 10:18, Marvin Häuser wrote: > > > > On 18. Apr 2023, at 10:10, Ard Biesheuvel wrote: > > On Tue, 18 Apr 2023 at 08:40, Marvin Häuser wrote: > > > > On 17. Apr 2023, at 23:18, Ard Biesheuvel wrote: > > A

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-19 Thread Ard Biesheuvel
On Wed, 19 Apr 2023 at 19:45, Marvin Häuser wrote: > > > On 19. Apr 2023, at 19:40, Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 19:14, Marvin Häuser wrote: > > > Hi all, > > While testing Ard's suggestion for V3, I noticed I got a broken FD where &g

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-19 Thread Ard Biesheuvel
On Wed, 19 Apr 2023 at 20:25, Marvin Häuser wrote: > > > On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: > > Your branch seems to be missing 16e0969ef775b898ac700f3261d76030b8ab9ef0 > > "ArmVirtPkg/ArmVirtQemu: Use PEI flavor of ArmMmuLib for all PEIMs" > >

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-19 Thread Ard Biesheuvel
On Wed, 19 Apr 2023 at 20:32, Marvin Häuser wrote: > > > On 19. Apr 2023, at 20:26, Ard Biesheuvel wrote: > > On Wed, 19 Apr 2023 at 20:25, Marvin Häuser wrote: > > > > On 19. Apr 2023, at 20:03, Ard Biesheuvel wrote: > > Your branch seems to be missing 16e0969

Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()

2023-04-19 Thread Ard Biesheuvel
On Wed, 19 Apr 2023 at 22:10, Marvin Häuser wrote: > > > > On 19. Apr 2023, at 21:48, Ard Biesheuvel wrote: > > > > The issue is likely caused by > > > > -Wl,--defsym=PECOFF_HEADER_SIZE=0 > > > > Why are you setting that? It breaks the ELF to P

Re: [edk2-devel] [PATCH v3 2/2] ArmPkg/ArmMmuLib: Fix ArmReplaceLiveTranslationEntry() alignment

2023-04-20 Thread Ard Biesheuvel
d of the function before checking the total occupied size. This > ensures crossing a 0x200 boundary will cause a compilation error. > > Reviewed-by: Leif Lindholm > Signed-off-by: Marvin Häuser > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc

Re: [edk2-devel] [PATCH v5 02/10] MdePkg: don't set visibility to hidden

2023-04-21 Thread Ard Biesheuvel
On Fri, 21 Apr 2023 at 08:49, Gerd Hoffmann wrote: > > On Fri, Apr 21, 2023 at 06:01:11AM +, Marvin Häuser wrote: > > > > > On 21. Apr 2023, at 06:45, Gerd Hoffmann wrote: > > > > > > Not needed any more on modern toolchains, they are better > > > in not creating a GOT without this trick. >

Re: [edk2-devel] [PATCH 1/1] ArmPkg/PlatformBootManagerLib: Add path to boot UEFI Shell over UiApp

2023-04-21 Thread Ard Biesheuvel
On Tue, 7 Feb 2023 at 10:07, wrote: > > From: Pierre Gondois > > The UEFI Shell is a non-active boot option, at the opposite of UiApp. > If no valid boot option is found, UiApp is selected. UiApp requires a > human interaction. When installing a new EDKII image in CIs or when > scripting is requi

Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck

2023-04-24 Thread Ard Biesheuvel
On Sun, 16 Apr 2023 at 07:21, Ni, Ray wrote: > > Mike, > > MdeModule belongs to the common-package category. > > I agree that the common-package should not depend on a specific arch. > > MdeModule depending on UefiCpu because DxeIpl needs to prepare an arch > specific environment for DXE phase. >

Re: [edk2-devel] [Patch V3 0/8] Create page table by CpuPageTableLib in DxeIpl

2023-04-24 Thread Ard Biesheuvel
On Mon, 24 Apr 2023 at 12:06, duntan wrote: > > In V3 patch set: > 1. Add a new patch 'MdePkg: Move CpuPageTableLib defination to MdePkg' to > Move CpuPageTableLib defination from UefiCpuPkg to MdePkg. >So that MdeModulePkg doesn't need to depend on UefiCpuPkg. As I replied to the other patc

Re: [edk2-devel] [Patch V3 0/8] Create page table by CpuPageTableLib in DxeIpl

2023-04-24 Thread Ard Biesheuvel
-Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Monday, April 24, 2023 10:24 AM > > To: devel@edk2.groups.io; Tan, Dun > > Subject: Re: [edk2-devel] [Patch V3 0/8] Create page table by > > CpuPageTableLib in Dxe

Re: [edk2-devel] [Patch V3 0/8] Create page table by CpuPageTableLib in DxeIpl

2023-04-25 Thread Ard Biesheuvel
On Tue, 25 Apr 2023 at 03:45, Ni, Ray wrote: > > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Tuesday, April 25, 2023 2:07 AM > > To: Kinney, Michael D > > Cc: devel@edk2.groups.io; Tan, D

Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-04-27 Thread Ard Biesheuvel
uilt images can be loaded before d6457b309. > > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > Cc: Michael Kubacki > --- > MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/BasePeCoffLib/B

Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-04-28 Thread Ard Biesheuvel
On Fri, 28 Apr 2023 at 07:02, gaoliming via groups.io wrote: > > Ard: > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Ard > > Biesheuvel > > 发送时间: 2023年4月27日 22:47 > > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > > 抄送: Michael Kub

Re: [edk2-devel] [PATCH v3 4/5] UefiCpuPkg/ResetVector: Modify Page Table in ResetVector

2023-05-01 Thread Ard Biesheuvel
On Fri, 28 Apr 2023 at 08:43, Zhiguang Liu wrote: > > In ResetVector, if create page table, its highest address is fixed > because after page table, code layout is fixed(4K for normal code, > and another 4K only contains reset vector code). > Today's implementation organizes the page table as foll

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

2023-05-01 Thread Ard Biesheuvel
ng to inflate its size substantially. Also, including EFI_MEMORY_RP only makes sense if we implement a way to apply it, which ArmCpuDxe currently does not provide. > PR: https://github.com/tianocore/edk2/pull/4311 > Personal branch: > https://github.com/os-d/edk2/tree/osde/sync_aarch6

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

2023-05-01 Thread Ard Biesheuvel
On Mon, 1 May 2023 at 19:49, Michael D Kinney wrote: > > Hi, > > These UEFI Memory Map, GCD, and Page Table interactions can be complex and I > agree there are some UEFI/PI spec clarifications that may help. > > Ray hosts a TianoCore design meeting when needed. Do you think a meeting with > an op

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Fix the link to the Stuart documentation in PlatformCI

2023-05-03 Thread Ard Biesheuvel
Signed-off-by: Rebecca Cran Acked-by: Ard Biesheuvel Thanks for the fix - feel free to merge it directly. > --- > OvmfPkg/PlatformCI/ReadMe.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/PlatformCI/ReadMe.md b/OvmfPkg/PlatformCI/ReadMe.m

Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 12:13, Gerd Hoffmann wrote: > > Ping. > I'll pick these up - thanks for the reminder. > On Fri, Apr 14, 2023 at 10:33:21AM +0200, Oliver Steffen wrote: > > ArmVirtXen.dsc allows setting the firmware version > > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionStr

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg/PlatformBootManagerLib: Add path to boot UEFI Shell over UiApp

2023-05-04 Thread Ard Biesheuvel
On Tue, 25 Apr 2023 at 13:27, wrote: > > From: Pierre Gondois > > The UEFI Shell is a non-active boot option, at the opposite of UiApp. > If no valid boot option is found, UiApp is selected. UiApp requires a > human interaction. When installing a new EDKII image in CIs or when > scripting is requ

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: replace SECURE_BOOT_FEATURE_ENABLED with PcdSecureBootSupported

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 12:09, Gerd Hoffmann wrote: > > Ping. > Queued up now - thanks. > On Fri, Apr 21, 2023 at 08:55:44AM +0200, Gerd Hoffmann wrote: > > Drop the '-D SECURE_BOOT_FEATURE_ENABLED' compile time option, > > use a new FeaturePcd instead. > > > > Signed-off-by: Gerd Hoffmann > > --

Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: add virtio serial driver

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 15:12, Gerd Hoffmann wrote: > > v2: > - implement driver stop code paths. > - misc fixes here and there. > - rebase to latest master. > > Gerd Hoffmann (4): > OvmfPkg: add IndustryStandard/VirtioSerial.h > OvmfPkg/VirtioSerialDxe: add driver > OvmfPkg/VirtioSerialDxe

Re: [edk2-devel] [PATCH 0/3] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-04 Thread Ard Biesheuvel
nagerLib, which in turn allows to remove > PlatformBootManagerLibGrub. > > Gerd Hoffmann (3): > OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware > OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub > OvmfPkg: drop PlatformBootManagerLibGrub > Ac

Re: [edk2-devel] [PATCH] MdePkg BasePeCoffLib: Ignore the debug entry read error after it is found

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 09:49, gaoliming via groups.io wrote: > > Ard: > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Ard > > Biesheuvel > > 发送时间: 2023年4月28日 17:21 > > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > > 抄送: Michael Kub

[edk2-devel] [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories

2023-05-04 Thread Ard Biesheuvel
ry is consistent with the NB10 payload: if we should expect additional directory entries where we observe the NB10 payload, the size field is clearly wrong, and we can break from the loop. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4425 Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BasePeCo

Re: [edk2-devel] [RFC PATCH v1 00/30] Support for Arm CCA guest firmware

2023-05-04 Thread Ard Biesheuvel
On Thu, 4 May 2023 at 17:13, Jean-Philippe Brucker wrote: > > Hello, > > On Tue, Apr 25, 2023 at 05:03:58PM +0100, Sami Mujawar wrote: > > We are happy to announce an early RFC version of the Arm Confidential > > Compute Architecture (CCA) support for the Kvmtool guest firmware. > > The intention

Re: [edk2-devel] [PATCH] MdePkg/BasePeCoffLib: Deal with broken debug directories

2023-05-05 Thread Ard Biesheuvel
On Fri, 5 May 2023 at 03:56, Michael Kubacki wrote: > > Acked-by: Michael Kubacki > Merged as #4340 Thanks all > On 5/4/2023 10:47 AM, Ard Biesheuvel wrote: > > Older versions of GenFw put the wrong value in the debug directory size > > field in the PE/COFF header

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

2023-05-05 Thread Ard Biesheuvel
On Sat, 6 May 2023 at 01:27, Michael Brown wrote: > > On 05/05/2023 19:56, Laszlo Ersek wrote: > > I don't like the patch. For two reasons: > > > > (1) It papers over the actual issue. The problem should be fixed where > > it is, if possible. > > Agreed, but (as you have shown in > https://bugzill

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

2023-05-09 Thread Ard Biesheuvel
liver Smith-Denny > > Sent: Monday, May 8, 2023 7:03 PM > > To: Ni, Ray ; Kinney, Michael D > > ; Ard Biesheuvel ; > > devel@edk2.groups.io > > Cc: Leif Lindholm ; Ard Biesheuvel > > ; Sami Mujawar ; > > Michael Kubacki ; Sean Brogan > > > > S

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/NestedInterruptTplLib: replace ASSERT() with a warning logged.

2023-05-09 Thread Ard Biesheuvel
On Mon, 8 May 2023 at 08:46, Laszlo Ersek wrote: > > On 5/6/23 01:57, Ard Biesheuvel wrote: > > On Sat, 6 May 2023 at 01:27, Michael Brown wrote: > >> > >> On 05/05/2023 19:56, Laszlo Ersek wrote: > >>> I don't like the patch. For two reasons: >

Re: [edk2-devel] [PATCH v2 0/2] OvmfPkg: Relax assertion that interrupts do not occur at TPL_HIGH_LEVEL

2023-05-09 Thread Ard Biesheuvel
>> > >> Relax the assertion that the interrupted TPL is below TPL_HIGH_LEVEL > >> to an error message, to allow UEFI applications such as these versions > >> of the Microsoft Windows bootloader to continue to function. > >> > >> Ref: https://bugzi

Re: [edk2-devel][edk2-platforms][PATCH 0/2] Support for PCIe Auto Bifurcation feature

2023-05-09 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 07:59, Nhi Pham wrote: > > Thanks Minh for this series. It looks good to me. > > Reviewed-by: Nhi Pham > > Hi Leif, Ard - Could you please help merge this series? > Pushed as 7ac91ec277db..c91f8862ae87 Thanks all > > On 5/5/2023 9:49 AM, Minh Nguyen wrote: > > These pat

Re: [edk2-devel] [PATCH v2 0/2] OvmfPkg: Relax assertion that interrupts do not occur at TPL_HIGH_LEVEL

2023-05-09 Thread Ard Biesheuvel
On Tue, 9 May 2023 at 23:49, Ard Biesheuvel wrote: > > (cc Liming) > > On Tue, 9 May 2023 at 16:23, Michael Brown wrote: > > > > On 09/05/2023 14:31, Laszlo Ersek wrote: > > > On 5/9/23 14:09, Michael Brown wrote: > > >> At TPL_HIGH_LEVEL,

Re: [edk2-devel] [PATCH edk2-platforms 0/4] Remove usage of OvmfPkg/SataControllerDxe

2023-05-09 Thread Ard Biesheuvel
xe. > > The two drivers were forked from the same code and are mostly > code-and-functionality > equivalent. > > This patchset should *not* rely on the edk2 patchset, and should be merged > before edk2's > (as to not break platforms). > > Cc: Isaac Oram > C

Re: [edk2-devel] [PATCH v2 00/12] OvmfPkg: Replace the OVMF-specific SataControllerDxe with the generic one

2023-05-09 Thread Ard Biesheuvel
Laszlo as the author of the original SataControllerDxe patches) > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc :Jordan Justen > Cc: Gerd Hoffmann > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Min Xu > Cc: Tom Lendacky > Cc: Michael Roth > Cc: Rebecca Cran &

Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-10 Thread Ard Biesheuvel
(cc Liming) I'd like to merge this series before the stable tag - any objections? On Fri, 5 May 2023 at 07:28, Gerd Hoffmann wrote: > > An attempt to reduce code duplication a bit. PlatformBootManagerLibGrub > is an (outdated) copy of PlatformBootManagerLib with some policy > changes. Add a PC

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioSerialDxe: fix RELEASE build error

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote: > > EventNames is used to pretty-print debug log messages. > Add #ifdef to only include it in debug builds. > Fixes a clang build failure. > > Reported-by: Rebecca Cran > Signed-off-by: Gerd Hoffmann Queued up as #4381 - thanks. > --- > Ovmf

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioSerialDxe: fix RELEASE build error

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 09:39, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote: > > > > EventNames is used to pretty-print debug log messages. > > Add #ifdef to only include it in debug builds. > > Fixes a clang build failure. >

Re: [edk2-devel] Side effects of enabling PML5 in EFI

2023-05-10 Thread Ard Biesheuvel
On Tue, 9 May 2023 at 19:24, Pedro Falcato wrote: > > Hi all, > > (+CC people vaguely related to the EFI spec, the PML5 implementation > and kernel EFI boot code) > > As a result of the latest 5-level paging patches, I've been looking > into how tiano supports PML5. > This raised a question: Doesn

Re: [edk2-devel] [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path in tools_def.template

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote: > > Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to > override the default of 'echo'. > > Signed-off-by: Rebecca Cran This appears to break the AArch64 CLANGDWARF build. https://ci.linaro.org/job/leg-virt-tianocore-edk2-up

Re: [edk2-devel] [RFC PATCH v1 01/30] ArmVirtPkg: kvmtool: Add Emulated Runtime variable support

2023-05-10 Thread Ard Biesheuvel
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar wrote: > > Although Kvmtool supports a CFI flash interface, it is currently > implemented using file backed support on the Host. This scenario > requires the VMM to be within the trust boundary. > > In Confidential Compute Architecture the VMM is outside

Re: [edk2-devel] [RFC PATCH v1 05/30] ArmPkg & ArmVirtPkg: Make PcdMonitorConduitHvc a dynamic PCD

2023-05-10 Thread Ard Biesheuvel
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar wrote: > > The monitor call conduit is fixed for a platform firmware in > most scenarios. For a normal virtual machine guest firmware, > the default conduit is HVC. However, for Arm CCA the Realm > code must use SMC as the conduit. > > To have a common co

Re: [edk2-devel] [RFC PATCH v1 25/30] ArmVirtPkg: Add ArmCcaDxe for early DXE phase initialisation

2023-05-10 Thread Ard Biesheuvel
On Tue, 25 Apr 2023 at 18:05, Sami Mujawar wrote: > > Add ArmCcaDxe for early DXE phase initialisation like setting > up the monitor call conduit for Realm code > > The Realm code should use SMC as the conduit for monitor calls. > Therefore, set the PcdMonitorConduitHvc to FALSE if the code is > r

Re: [edk2-devel] [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path in tools_def.template

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 14:09, Rebecca Cran wrote: > > On 5/10/23 05:03, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote: > >> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to > >> override the default of

Re: [edk2-devel] 回复: [PATCH v2 0/4] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 09:41, gaoliming via groups.io wrote: > > Ard: > Seemly, this patch set passed code review before the soft feature freeze. > So, I am OK to merge it for this stable tag. > Thanks Gerd, Could you run this through the CI please? I am getting errors. https://github.com/t

Re: [edk2-devel] [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote: > > This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00. > > While GCC uses objcopy for the OBJCOPY command, it's not needed for the > CLANGDWARF toolchain and can be left as echo. > Are you sure you want to change this for IA32 and X86 a

Re: [edk2-devel] 回复: [PATCH v2 0/4] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 14:33, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 09:41, gaoliming via groups.io > wrote: > > > > Ard: > > Seemly, this patch set passed code review before the soft feature freeze. > > So, I am OK to merge it for this stable tag. &

Re: [edk2-devel] [edk2-stable202305 PATCH 1/1] BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 14:46, Rebecca Cran wrote: > > On 5/10/23 06:37, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote: > >> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00. > >> > >> While GCC uses objcopy for the O

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioSerialDxe: fix RELEASE build error

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 11:18, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 09:39, Ard Biesheuvel wrote: > > > > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote: > > > > > > EventNames is used to pretty-print debug log messages. > > >

[edk2-devel] [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang

2023-05-10 Thread Ard Biesheuvel
than tiptoe around it in the code base. This fixes the RELEASE build for OVMF, which triggers this issue in the newly added VirtioSerialDxe driver. Cc: Rebecca Cran Cc: Gerd Hoffmann Cc: Liming Gao Signed-off-by: Ard Biesheuvel --- Reproducer: https://godbolt.org/z/zx6qqjKrK BaseTools

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioSerialDxe: fix RELEASE build error

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 15:54, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 11:18, Ard Biesheuvel wrote: > > > > On Wed, 10 May 2023 at 09:39, Ard Biesheuvel wrote: > > > > > > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote: > > > > >

Re: [edk2-devel] 回复: [PATCH v2 0/4] OvmfPkg: remove PlatformBootManagerLibGrub

2023-05-10 Thread Ard Biesheuvel
On Wed, 10 May 2023 at 14:43, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 14:33, Ard Biesheuvel wrote: > > > > On Wed, 10 May 2023 at 09:41, gaoliming via groups.io > > wrote: > > > > > > Ard: > > > Seemly, this patch set passed code rev

Re: [edk2-devel] [PATCH 1/1] Platform/SbsaQemu: read platform version

2023-05-10 Thread Ard Biesheuvel
HI Marcin, On Wed, 10 May 2023 at 17:08, Marcin Juszkiewicz wrote: > > Qemu has versioning for sbsa-ref platform. TF-A reads it from provided > DeviceTree and provides as SMC. > > This change adds reading platform version into EDK2. > > Signed-off-by: Marcin Juszkiewicz > --- > Platform/Qemu/Sb

Re: [edk2-devel] JunoPkg ARM build breakage: "Error: bad instruction `aarch64_bti(c)'"

2023-05-10 Thread Ard Biesheuvel
Hi Rebecca, On Wed, 10 May 2023 at 18:23, Rebecca Cran wrote: > > I ran my script that tries to build all Arm platforms in edk2-platforms > (with the exception of known broken ones) with the GCC5/GCC toolchain, > and noticed a new breakage since I last ran it a few months ago. > > Building JunoPk

Re: [edk2-devel] JunoPkg ARM build breakage: "Error: bad instruction `aarch64_bti(c)'"

2023-05-10 Thread Ard Biesheuvel
on is always false >if (EFI_ERROR (Status)) { >^ > /home/bcran/src/uefi/edk2-platforms/Platform/ARM/Library/ArmShellCmdRunAxf/RunAxf.c:136:39: > note: initialize the variable 'FileSize' to silence this warning >UINTN Fi

[edk2-devel] [PATCH] BaseTools/tools_def: Drop ref to undefined CLANGDWARF_ARM_PREFIX

2023-05-10 Thread Ard Biesheuvel
was what was intended. Cc: Rebecca Cran Cc: Liming Gao Fixes: ecbc394365f50f3c ("BaseTools: Set CLANGDWARF RC path ...") Signed-off-by: Ard Biesheuvel --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.t

Re: [edk2-devel] [PATCH v5 2/3] OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib

2023-05-11 Thread Ard Biesheuvel
On Thu, 11 May 2023 at 15:16, Corvin Köhne wrote: > > On Thu, 2023-05-11 at 07:04 -0600, Rebecca Cran wrote: > > Could you cc me on _all_ of the patches in a series please? > > > > I seem to have been missed on this one, and only cc'd on 3/3. > > > > > > Sry, I've updated my cc list. So, you'll be

Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang

2023-05-11 Thread Ard Biesheuvel
Liming: I'd like to merge this one for the stable tag - any objections? On Thu, 11 May 2023 at 06:55, Gerd Hoffmann wrote: > > On Wed, May 10, 2023 at 04:50:08PM +0200, Ard Biesheuvel wrote: > > The warnings Clang emits when enabling -Wunneeded-internal-declaration > >

Re: [edk2-devel] 回复: [PATCH] BaseTools/tools_def: Drop ref to undefined CLANGDWARF_ARM_PREFIX

2023-05-11 Thread Ard Biesheuvel
On Fri, 12 May 2023 at 03:43, gaoliming via groups.io wrote: > > Ard: > This change is good to me. Reviewed-by: Liming Gao > > > Will it be merged for this stable tag? > Yes I will merge it today. Thanks, > > -邮件原件----- > > 发件人: Ard Biesheuvel &

Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect

2023-05-17 Thread Ard Biesheuvel
tyReg() debug log to print 64 bit capability instead of 32 > > bit > > pointer > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: Andrew Fish > > Signed-off-by: Giri Mudusuru Reviewed-by: Ard Biesheuve

Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Ard Biesheuvel
On Thu, 18 May 2023 at 11:10, Sami Mujawar wrote: > > The patch "f07a9df9af60 ArmVirtPkg: Enable stack guard" > enabled stack overflow detection for ArmVirtPkg. Following > this patch, running UEFI shell command 'dmpstore' resulted > in a crash indicating a stack overflow. Invoking 'dmpstore' > re

Re: [edk2-devel] [PATCH v1 5/6] ArmVirtPkg: Kvmtool: Increase primary core stack size

2023-05-18 Thread Ard Biesheuvel
On Thu, 18 May 2023 at 17:12, Sami Mujawar wrote: > > Hi Ard, > > Thank you for the feedback and for the pointers. > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 18/05/2023 12:01 pm, Ard Biesheuvel via groups.io wrote: &g

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-05-19 Thread Ard Biesheuvel
On Fri, 19 May 2023 at 18:32, Oliver Steffen wrote: > > > Hi all, > > I had another look at this and I can now reproduce the issue consistently, > with a quite minimal setup, on recent Linux kernel, Qemu, and EDK2. > It requires rebooting the guest in a tight loop. It happens in silent > and verbo

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: DefaultExceptionHandlerLib: Do Not Allocate Memory

2023-08-02 Thread Ard Biesheuvel
Unicode string needed for ConOut->OutputString. Correspondingly, > ArmVirtQemu can now output the stack dump and CPU state when hitting > an exception in memory code. > > GitHub PR: https://github.com/tianocore/edk2/pull/4703 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel &g

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: DefaultExceptionHandlerLib: Do Not Allocate Memory

2023-08-02 Thread Ard Biesheuvel
On Wed, 2 Aug 2023 at 18:21, Oliver Smith-Denny wrote: > > On 8/2/2023 9:06 AM, Ard Biesheuvel wrote: > > On Tue, 1 Aug 2023 at 00:04, Oliver Smith-Denny > > wrote: > >> > >> If gST->ConOut is available when Arm's DefaultExceptionHandler > >>

Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-03 Thread Ard Biesheuvel
e boot support, and everything appears to operate as intended. (I didn't manage to unlock my Linux root volume automatically but that appears to be broken with openssl 1.1.1 as well) So for the series Acked-by: Ard Biesheuvel Tested-by: Ard Biesheuvel Let's not sit on this too long - Tiano

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 > PR: https://github.com/tianocore/edk2/pull/4711 > > This series switches the OVMF CI jobs on Windows to a recent Qemu > version and re-enables SMP in the Qemu "Run to shell" CI jobs.

Re: [edk2-devel] [PATCH edk2-platforms v3 0/3] Platform/QemuSbsa: add GIC ITS

2023-08-03 Thread Ard Biesheuvel
On Wed, 19 Jul 2023 at 14:09, Marcin Juszkiewicz wrote: > > SBSA Reference Platform can have GIC ITS present. And when it has then > we can have complex PCI Express setup (and some other things). > > First patch adds support for GIC ITS. Address is read from TF-A via SMC > call. IORT is generated,

Re: [edk2-devel] [PATCH edk2-platforms] SbsaQemu: fix typo

2023-08-03 Thread Ard Biesheuvel
On Tue, 18 Jul 2023 at 12:22, Marcin Juszkiewicz wrote: > > From: Masahisa Kojima > > Fix typo in Readme.md > > Signed-off-by: Masahisa Kojima > Signed-off-by: Marcin Juszkiewicz > --- > Platform/Qemu/SbsaQemu/Readme.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Pushed, thanks.

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: DefaultExceptionHandlerLib: Do Not Allocate Memory

2023-08-03 Thread Ard Biesheuvel
t; not allocate memory when ConOut is available and instead use > stack memory to convert the Ascii string needed for SerialPortWrite > to the Unicode string needed for ConOut->OutputString. Correspondingly, > ArmVirtQemu can now output the stack dump and CPU state when hitting > an exc

Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

2023-08-03 Thread Ard Biesheuvel
> Is there any basis in the UEFI or PI specifications for this functionality? > On 7/26/2023 1:45 AM, Ard Biesheuvel wrote: > > On Mon, 24 Jul 2023 at 22:15, Kun Qin wrote: > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4466 > >> > >> This

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 16:37, Michael Kubacki wrote: > > For the series. > > Reviewed-by: Michael Kubacki > Thanks I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG keeps timing out for me https://github.com/tianocore/edk2/pull/4718 Might it help if we restrict SMP to a subset

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Ard Biesheuvel
ictly execute concurrently. (It will be very hard to catch/reproduce true concurrency issues in TCG anyway) Oliver, mind spinning a v2? Thanks, > > -Original Message- > > From: Ard Biesheuvel > > Sent: Thursday, August 3, 2023 9:54 AM > > To: devel@edk2.groups.

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-04 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 23:25, Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > wrote: > > > > Hi Ard, > > > > This is the email with the analysis and the flag > > setting required for SMP to work with SMM enabled for > > IA

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Ampere: Fix parameter mismatch in DEBUG_ERROR message

2023-08-06 Thread Ard Biesheuvel
On Mon, 7 Aug 2023 at 03:56, Rebecca Cran wrote: > > There's an extra format specifier in the DEBUG_ERROR message that > gets printed when the PCIe link check fails. This causes a > synchronous exception. Remove the string format specifier. > > Signed-off-by: Rebecca Cran Thanks Pushed as 4507d

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-07 Thread Ard Biesheuvel
upported + > > mQemuFwCfgDmaSupported") > > Signed-off-by: Corvin Köhne > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Cc: Rebecca Cran > > Cc: Peter Grehan > > --- > > OvmfPkg/Bh

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

2023-08-08 Thread Ard Biesheuvel
On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > > Nit: "sizeof" is normally used like a function. And this patch mixes the > two styles. > Actually, this is not unidiomatic for OVMF - sizeof takes either a type name (in which case the () are required) or an expression (in which case they are o

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

2023-08-09 Thread Ard Biesheuvel
gt; > 1.Update the X64/AArch64 UEFI GOP driver into v1.13.03. > > 2.Update the .inf version. > > 3.Modify report framebuffer base behavior. > > > > Cc: Ard Biesheuvel > > Cc: Isaac Oram > > Cc: Nate DeSimone > > Cc: Leif Lindholm > > Cc: Micha

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: HeapGuard: Don't Assume Pool Head Allocated In First Page

2023-08-09 Thread Ard Biesheuvel
ing the pool head in the first place. > > With this patch in place, ArmVirtQemu boots with GuardAlignedToTail > set to true (and when it is false, also). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4521 > Github PR: https://github.com/tianocore/edk2/pull/4731 > >

Re: [edk2-devel] Runtime Page Granularity on ARM64

2023-08-09 Thread Ard Biesheuvel
Hi, On Wed, 9 Aug 2023 at 23:35, Oliver Smith-Denny wrote: > > Hi Ard, > > I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head > Allocated In First Page) to fix HeapGuard GuardAlignedToTail behavior on > ARM64. However, this raised a question of why ARM64 sets > RUNTIME_PAGE_

<    1   2   3   4   5   6   7   8   9   10   >